Re: [zones-discuss] minor code review for 6890415 6880288 (zoneadm.c, native brand)

2010-02-22 Thread Jerry Jelinek

On 02/22/10 09:40, Frank Batschulat (Home) wrote:

May I have 2 code reviewers for the following minor changes for:

PSARC/2010/008 Remove zoneadm install sub-option -x nodataset
6880288 retire zoneadm install -x nodataset option
6890415 zoneadm install fails but returns 0

http://cr.opensolaris.org/~batschul/nodataset/


Frank,

This looks good to me.

Thanks,
Jerry
___
zones-discuss mailing list
zones-discuss@opensolaris.org


Re: [zones-discuss] minor code review for 6890415 6880288 (zoneadm.c, native brand)

2010-02-22 Thread Dan Price
On Mon 22 Feb 2010 at 10:52AM, Jerry Jelinek wrote:
 On 02/22/10 09:40, Frank Batschulat (Home) wrote:
 May I have 2 code reviewers for the following minor changes for:
 
 PSARC/2010/008 Remove zoneadm install sub-option -x nodataset
 6880288 retire zoneadm install -x nodataset option
 6890415 zoneadm install fails but returns 0
 
 http://cr.opensolaris.org/~batschul/nodataset/
 
 Frank,
 
 This looks good to me.

To me as well, although I would be tempted to call temp_err
something like cleanup_err.

-dp

-- 
Daniel Price, Solaris Kernel Engineeringhttp://blogs.sun.com/dp
___
zones-discuss mailing list
zones-discuss@opensolaris.org