Re: [zones-discuss] Need code review: 6558857 ZSD callback locking cause deadlocks

2007-09-04 Thread Erik Nordmark
Nicolas Williams wrote: > On Wed, Aug 29, 2007 at 03:47:22PM -0700, Erik Nordmark wrote: >> Comments? > > - $SRC/uts/common/sys/zone.h:483 > - $SRC/uts/common/sys/netstack.h:90 > >s/looks/locks/ > > > - $SRC/uts/common/os/zone.c:321 > >s/ZONE_EVENT_UNINITIALIZED/ZONE_EVENT_INITIALIZ

Re: [zones-discuss] Need code review: 6558857 ZSD callback locking cause deadlocks

2007-08-29 Thread Erik Nordmark
Nicolas Williams wrote: > Hmmm, someone commented (in the VSD case) that maybe we ought to have a > common object-specific key facility. Here we have fixes to two > different object-specific key facilities. I think a heads up to the RE > for CR 6588504 is in order. And maybe we should think abo

Re: [zones-discuss] Need code review: 6558857 ZSD callback locking cause deadlocks

2007-08-29 Thread Nicolas Williams
On Wed, Aug 29, 2007 at 03:47:22PM -0700, Erik Nordmark wrote: > Comments? - $SRC/uts/common/sys/zone.h:483 - $SRC/uts/common/sys/netstack.h:90 s/looks/locks/ - $SRC/uts/common/os/zone.c:321 s/ZONE_EVENT_UNINITIALIZED/ZONE_EVENT_INITIALIZED/ (i.e., s/UN//) This is just a quick g

Re: [zones-discuss] Need code review: 6558857 ZSD callback locking cause deadlocks

2007-08-29 Thread Nicolas Williams
On Wed, Aug 29, 2007 at 03:52:49PM -0700, Dan Price wrote: > On Wed 29 Aug 2007 at 03:47PM, Erik Nordmark wrote: > > > > Fixing the above CR requires changing how locking is done across the ZSD > > callbacks. The new design is to determine what callbacks are needed > > while holding the usual lo

Re: [zones-discuss] Need code review: 6558857 ZSD callback locking cause deadlocks

2007-08-29 Thread Dan Price
On Wed 29 Aug 2007 at 03:47PM, Erik Nordmark wrote: > > Fixing the above CR requires changing how locking is done across the ZSD > callbacks. The new design is to determine what callbacks are needed > while holding the usual locks, but not hold any locks across the actual > callbacks. > > This