[jira] Updated: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-11-04 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-882: - Attachment: FailureTest-882.patch Submitting a unit test that illustrates the bug and

[jira] Commented: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-11-03 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927912#action_12927912 ] Jared Cantwell commented on ZOOKEEPER-882: -- Sorry, I don't think I

[jira] Commented: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-11-03 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927904#action_12927904 ] Jared Cantwell commented on ZOOKEEPER-882: -- Sure Flavio. I have a test r

[jira] Commented: (ZOOKEEPER-897) C Client seg faults during close

2010-10-28 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925835#action_12925835 ] Jared Cantwell commented on ZOOKEEPER-897: -- I wasn't able to figure o

[jira] Commented: (ZOOKEEPER-897) C Client seg faults during close

2010-10-25 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924748#action_12924748 ] Jared Cantwell commented on ZOOKEEPER-897: -- we are using the 3.3.2 release

[jira] Commented: (ZOOKEEPER-906) Improve C client connection reliability by making it sleep between reconnect attempts as in Java Client

2010-10-21 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923431#action_12923431 ] Jared Cantwell commented on ZOOKEEPER-906: -- Some other small comments base

[jira] Commented: (ZOOKEEPER-906) Improve C client connection reliability by making it sleep between reconnect attempts as in Java Client

2010-10-20 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923146#action_12923146 ] Jared Cantwell commented on ZOOKEEPER-906: -- That's more like what I

[jira] Commented: (ZOOKEEPER-906) Improve C client connection reliability by making it sleep between reconnect attempts as in Java Client

2010-10-20 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922954#action_12922954 ] Jared Cantwell commented on ZOOKEEPER-906: -- I like this idea-- we ran int

[jira] Updated: (ZOOKEEPER-898) C Client might not cleanup correctly during close

2010-10-18 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-898: - Attachment: ZOOKEEPER-898.patch Updated patch format and spelling. > C Client mi

[jira] Updated: (ZOOKEEPER-897) C Client seg faults during close

2010-10-18 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-897: - Attachment: ZOOKEEPER-897.patch Updated patch format and spelling. > C Client

[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"

2010-10-16 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921690#action_12921690 ] Jared Cantwell commented on ZOOKEEPER-804: -- That probably failed because

[jira] Updated: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"

2010-10-15 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-804: - Attachment: ZOOKEEPER-804-1.patch Not sure what the protocol is here, but I'm

[jira] Updated: (ZOOKEEPER-881) ZooKeeperServer.loadData loads database twice

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-881: - Assignee: Jared Cantwell Status: Patch Available (was: Open

[jira] Updated: (ZOOKEEPER-881) ZooKeeperServer.loadData loads database twice

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-881: - Attachment: ZOOKEEPER-881.patch > ZooKeeperServer.loadData loads database tw

[jira] Updated: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-882: - Assignee: Jared Cantwell Status: Patch Available (was: Open) > Startup lo

[jira] Updated: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-882: - Attachment: ZOOKEEPER-882.patch Patch to incorporate recommended changes. > Star

[jira] Updated: (ZOOKEEPER-855) clientPortBindAddress should be clientPortAddress

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-855: - Status: Patch Available (was: Open) Simple patch. > clientPortBindAddress should

[jira] Updated: (ZOOKEEPER-855) clientPortBindAddress should be clientPortAddress

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-855: - Attachment: ZOOKEEPER-855.patch Documentation patch. > clientPortBindAddress sho

[jira] Created: (ZOOKEEPER-898) C Client might not cleanup correctly during close

2010-10-14 Thread Jared Cantwell (JIRA)
client Reporter: Jared Cantwell Priority: Trivial Attachments: ZOOKEEEPER-898.diff I was looking through the c-client code and noticed a situation where a counter can be incorrectly incremented and a small memory leak can occur. In zookeeper.c : add_completion(), if

[jira] Updated: (ZOOKEEPER-898) C Client might not cleanup correctly during close

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-898: - Attachment: ZOOKEEEPER-898.diff Suggested correction. > C Client might not clea

[jira] Updated: (ZOOKEEPER-897) C Client seg faults during close

2010-10-14 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-897: - Attachment: ZOOKEEEPER-897.diff Patch that only calls free_completions in

[jira] Created: (ZOOKEEPER-897) C Client seg faults during close

2010-10-14 Thread Jared Cantwell (JIRA)
C Client seg faults during close Key: ZOOKEEPER-897 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-897 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Jared

[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"

2010-10-13 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920689#action_12920689 ] Jared Cantwell commented on ZOOKEEPER-804: -- It seems like zookeeper_pro

[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"

2010-10-12 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920307#action_12920307 ] Jared Cantwell commented on ZOOKEEPER-804: -- Should the return statemen

[jira] Commented: (ZOOKEEPER-890) C client invokes watcher callbacks multiple times

2010-10-07 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919087#action_12919087 ] Jared Cantwell commented on ZOOKEEPER-890: -- I don't believe the C-cli

[jira] Updated: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-09-29 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-882: - Attachment: restore Maybe restore() should look like the attached (not a diff

[jira] Commented: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-09-29 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916150#action_12916150 ] Jared Cantwell commented on ZOOKEEPER-882: -- On second look, I agree with

[jira] Updated: (ZOOKEEPER-762) Allow dynamic addition/removal of server nodes in the client API

2010-09-29 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-762: - Attachment: 762.diff We had this same issue. I have submitted a possible patch for

[jira] Commented: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-09-29 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916122#action_12916122 ] Jared Cantwell commented on ZOOKEEPER-882: -- Maybe I am misunderstanding

[jira] Updated: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-09-28 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-882: - Attachment: 882.diff A simple patch for consideration. > Startup loads l

[jira] Created: (ZOOKEEPER-882) Startup loads last transaction from snapshot

2010-09-28 Thread Jared Cantwell (JIRA)
Reporter: Jared Cantwell Priority: Minor Attachments: 882.diff On startup, the server first loads the latest snapshot, and then loads from the log starting at the last transaction in the snapshot. It should begin from one past that last transaction in the log. I will

[jira] Updated: (ZOOKEEPER-881) ZooKeeperServer.loadData loads database twice

2010-09-28 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-881: - Summary: ZooKeeperServer.loadData loads database twice (was

[jira] Created: (ZOOKEEPER-881) ZooKeeperServer.loadData loads database twise

2010-09-28 Thread Jared Cantwell (JIRA)
Reporter: Jared Cantwell Priority: Trivial zkDb.loadDataBase() is called twice at the beginning of loadData(). It shouldn't have any negative affects, but is unnecessary. A patch should be trivial. -- This message is automatically generated by JIRA. - You can reply to

Snapshot on startup

2010-09-21 Thread Jared Cantwell
Hey all, I was looking at the code that loads the snapshots/logged transactions into the database on startup, and noticed that the FileTxnSnapLog initializes the log iterator to the last transaction committed to the snapshot (restore()). This causes the last transaction to be processed, even thou

Re: Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-27 Thread Jared Cantwell
ot;server.#:0.0.0.0[:port][:port]" in the > config file. > How will a peer know the IP address of other peers? > > -Vishal > > On Fri, Aug 27, 2010 at 10:20 AM, Jared Cantwell > wrote: > > > Thanks for the response Vishal. I agree that it should be used for both >

Re: Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-27 Thread Jared Cantwell
feature for both FLE and leader-follower communication? I > would suggest to keep this optional (add a property) since most users would > prefer to have the ability to reach the servers from all interfaces. > > -Vishal > > On Thu, Aug 26, 2010 at 1:34 PM, Jared Cantwell >wro

Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-26 Thread Jared Cantwell
Hello, My project currently has the need to specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was recently added. After reviewing the code, we can't think of a reason w

[jira] Created: (ZOOKEEPER-855) clientPortBindAddress should be clientPortAddress

2010-08-26 Thread Jared Cantwell (JIRA)
: documentation Affects Versions: 3.3.1, 3.3.0 Reporter: Jared Cantwell The server documentation states that the configuration parameter for binding to a specific ip address is clientPortBindAddress. The code believes the parameter is clientPortAddress. The documentation for 3.3.X

[jira] Updated: (ZOOKEEPER-855) clientPortBindAddress should be clientPortAddress

2010-08-26 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-855: - Priority: Trivial (was: Major) > clientPortBindAddress should be clientPortAddr