[jira] Created: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Tom White (JIRA)
Quote values in JMX ObjectNames 


 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: zookeeper-302.patch

Some characters are not allowed in ObjectName values and need quoting, see 
http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.

This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Tom White (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated ZOOKEEPER-302:


Attachment: zookeeper-302.patch

Patch to quote relevant ObjectName values.

 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-301) Util class to initialize Zookeeper with a set of user-specified bookies

2009-02-06 Thread Luca Telloli (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Luca Telloli updated ZOOKEEPER-301:
---

Attachment: ZOOKEEPER-301.patch

Patch attached 

 Util class to initialize Zookeeper with a set of user-specified bookies 
 

 Key: ZOOKEEPER-301
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-301
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Luca Telloli
Priority: Minor
 Attachments: ZOOKEEPER-301.patch


 This patch provides a class named 
 org.apache.bookkeeper.util.ZookeeperInitialization which provides basic 
 initialization for bookies onto zookeeper reading from a text file. An 
 example configuration file is provided in 
 conf/zookeeper-initialize-bookies.conf 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-303) Bin scripts don't work on Mac

2009-02-06 Thread Tom White (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated ZOOKEEPER-303:


Attachment: zookeeper-303.patch

The {{readlink}} command is used to canonicalize the start script, following 
symlinks recursively. This is a useful feature to have as it allows the scripts 
to be symlinked. I've attached a patch that detects if readlink is available. 
If it's not then you have to call the scripts directly (without symlinks) - 
which is a good compromise as it means the scripts can be used on Macs, while 
still supporting symlinks on Linux. 

Note also, as a workaround you can install GNU readlink (MacPorts: {{port 
install coreutils}}) and change {{readlink}} to {{greadlink}} in the scripts.

 Bin scripts don't work on Mac
 -

 Key: ZOOKEEPER-303
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-303
 Project: Zookeeper
  Issue Type: Bug
  Components: scripts
 Environment: Mac OS X
Reporter: Tom White
 Attachments: zookeeper-303.patch


 Macs don't support the -f option in readlink
 {noformat}
 $ bin/zkServer.sh start
 JMX enabled by default
 readlink: illegal option -- f
 usage: readlink [-n] [file ...]
 {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-303) Bin scripts don't work on Mac

2009-02-06 Thread Tom White (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated ZOOKEEPER-303:


Status: Patch Available  (was: Open)

 Bin scripts don't work on Mac
 -

 Key: ZOOKEEPER-303
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-303
 Project: Zookeeper
  Issue Type: Bug
  Components: scripts
 Environment: Mac OS X
Reporter: Tom White
 Attachments: zookeeper-303.patch


 Macs don't support the -f option in readlink
 {noformat}
 $ bin/zkServer.sh start
 JMX enabled by default
 readlink: illegal option -- f
 usage: readlink [-n] [file ...]
 {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



RE: [VOTE] Release ZooKeeper 3.1.0 (candidate 2)

2009-02-06 Thread Stu Hood
+1

-Original Message-
From: Patrick Hunt ph...@apache.org
Sent: Thursday, February 5, 2009 5:14pm
To: zookeeper-dev@hadoop.apache.org zookeeper-dev@hadoop.apache.org
Subject: [VOTE] Release ZooKeeper 3.1.0 (candidate 2)

I've created a new candidate (rc2) that fixes an issue raised by a user 
(thanks Chris!) during review:
https://issues.apache.org/jira/browse/ZOOKEEPER-293
The release notes were also updated to reflect this change.

Otw there are no other changes.

*** Please download, test and VOTE before the
*** vote closes EOD on Tuesday February 10.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-2/

Should we release this?

Patrick





[jira] Commented: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)

2009-02-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671104#action_12671104
 ] 

Hudson commented on ZOOKEEPER-291:
--

Integrated in ZooKeeper-trunk #221 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/221/])


 regression for legacy code using KeeperException.Code constants (due to 246)
 

 Key: ZOOKEEPER-291
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
 Project: Zookeeper
  Issue Type: Bug
  Components: java client
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.1.0

 Attachments: ZOOKEEPER-291.patch


 In 246 the old constants were deprecated and replace with enum. In the 
 process usage of the orig constants was broken for switch statements, cases 
 require compiletime constants.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-301) Util class to initialize Zookeeper with a set of user-specified bookies

2009-02-06 Thread Luca Telloli (JIRA)
Util class to initialize Zookeeper with a set of user-specified bookies 


 Key: ZOOKEEPER-301
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-301
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Luca Telloli
Priority: Minor


This patch provides a class named 
org.apache.bookkeeper.util.ZookeeperInitialization which provides basic 
initialization for bookies onto zookeeper reading from a text file. An example 
configuration file is provided in conf/zookeeper-initialize-bookies.conf 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-303) Bin scripts don't work on Mac

2009-02-06 Thread Tom White (JIRA)
Bin scripts don't work on Mac
-

 Key: ZOOKEEPER-303
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-303
 Project: Zookeeper
  Issue Type: Bug
  Components: scripts
 Environment: Mac OS X
Reporter: Tom White


Macs don't support the -f option in readlink

{noformat}
$ bin/zkServer.sh start
JMX enabled by default
readlink: illegal option -- f
usage: readlink [-n] [file ...]
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-302:
---

Attachment: ZOOKEEPER-302.patch

modified tom's patch a bit:

1) only quote if the addr is an ipv6 addr
2) I don't think getclientport needs to be quoted (ie values) -- otw thinks 
like the time/date stamp would also fail (removed this from my patch)
3) removed the printstacktrace calls in mbeanregistry - replaced with proper 
error handling/logging.


 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671262#action_12671262
 ] 

Patrick Hunt commented on ZOOKEEPER-302:


oops - the latest patch is ZOOKEEPER-302.patch (all caps version) be sure to 
review that one not the orig (all lower)


 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671273#action_12671273
 ] 

Benjamin Reed commented on ZOOKEEPER-302:
-

+1 looks good. i have one small suggestion: in the early part of the patch you 
log some problem when you catch an exception, would it be good to log the 
exception?

 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671278#action_12671278
 ] 

Patrick Hunt commented on ZOOKEEPER-302:


the extra log/rethrow is just there because sun messed up on 
malformedobjectnameexceptin - they don't include the name that was malformed, 
which makes debugging hard.

So -- I log then rethrow, the calling code will actually log the exception and 
then handle in some way - this log is just for context when reviewing the log.

I could have wrapped the exception with another, but I didn't want to do that 
for this patch... I think we really need to take a hard look at this 
mbeanregistry stuff anyway, it will probably go away in the end...


 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671281#action_12671281
 ] 

Mahadev konar commented on ZOOKEEPER-302:
-

+1  for the patch  passes the tests... 

 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Stu Hood (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671283#action_12671283
 ] 

Stu Hood commented on ZOOKEEPER-302:


The patch looks alright to me.

It passes our unit tests, but we start the server programmatically and we don't 
use JMX, so I don't know how much my vote counts.

 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Tom White (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671295#action_12671295
 ] 

Tom White commented on ZOOKEEPER-302:
-

+1

The patch works for me.

 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-302:
---

Fix Version/s: 3.1.0
 Assignee: Patrick Hunt

 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
Assignee: Patrick Hunt
 Fix For: 3.1.0

 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-302) Quote values in JMX ObjectNames

2009-02-06 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-302:


  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

I just committed this. Thanks tom and pat.

 Quote values in JMX ObjectNames 
 

 Key: ZOOKEEPER-302
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-302
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Tom White
Assignee: Patrick Hunt
 Fix For: 3.1.0

 Attachments: ZOOKEEPER-302.patch, zookeeper-302.patch


 Some characters are not allowed in ObjectName values and need quoting, see 
 http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
 This came up with IPv6 addresses which contain a colon character.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [VOTE] Release ZooKeeper 3.1.0 (candidate 1)

2009-02-06 Thread Patrick Hunt
Thanks Tom. A patch for 302 has been committed to SVN, I will create a 
new release candidate today.


Patrick

Tom White wrote:

After a bit of digging I think I know what's happening. I'm running in
standalone mode on a Mac with IPv6. When I try to connect to
localhost using

new ZooKeeper(localhost, 5000, this);

I get the exception I posted earlier. When I use 127.0.0.1 it works
fine. So it is an IPv6 issue (you were right!).

I can fix the error by quoting the value properties, for example:

org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=0:0:0:0:0:0:0:1%0,name3=0x11f4b7b4c34000e

Note that name2 is in quotes. See
http://java.sun.com/javase/6/docs/api/javax/management/ObjectName.html.
I've created a patch for this in
https://issues.apache.org/jira/browse/ZOOKEEPER-302.

Not sure if this is a blocker or not for 3.1.0. It probably is if IPv6
is supported. What do you think?

Thanks,
Tom

On Thu, Feb 5, 2009 at 11:42 PM, Patrick Hunt ph...@apache.org wrote:

I don't suppose you are running on an IPv6 system?

Patrick

Patrick Hunt wrote:

Hi Tom, this is unusual - what's your environment like? OS and java
version string would help to debug (zk config?). Mahadev (mac) and I
(ubuntu/redhat) both running recent versions of java6 have just tried this
and we can't reproduce it.

We use the IP address  sessionid as the name of the connection jmx bean,
so this is weird:

ip=connection.getRemoteAddress().getAddress().getHostAddress();

here's an example name I see in jconsole:

org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=Connections,name2=127.0.0.1,name3=0x11f489f8126

(btw, thank you sun for including the invalid name in the error message
;-) )

One thing I do notice is that printStackTrace is being called by our jmx
code which should not be happening - that's why you are seeing this in on
the console rather than just in the log (we log WARN then ignore the issue
btw) . I'll enter a jira for this.
https://issues.apache.org/jira/browse/ZOOKEEPER-300

Patrick

Tom White wrote:

I installed the candidate and got the following exception when
performing some basic operations. The operations succeeded - it looks
like a problem with JMX integration. Has anyone else seen this?

Thanks,
Tom

$ bin/zkServer.sh start
JMX enabled by default
-n Starting zookeeper ...
STARTED
loy:zookeeper-3.1.0 tom$
javax.management.MalformedObjectNameException: Invalid character ':'
in value part of property
   at javax.management.ObjectName.construct(ObjectName.java:602)
   at javax.management.ObjectName.init(ObjectName.java:1394)
   at
org.apache.zookeeper.jmx.MBeanRegistry.makeObjectName(MBeanRegistry.java:173)
   at
org.apache.zookeeper.jmx.MBeanRegistry.register(MBeanRegistry.java:70)
   at
org.apache.zookeeper.server.NIOServerCnxn.finishSessionInit(NIOServerCnxn.java:861)
   at
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:145)
   at
org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
   at
org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)
java.lang.IllegalArgumentException: Null object name
   at
com.sun.jmx.mbeanserver.MXBeanSupport.register(MXBeanSupport.java:138)
   at
com.sun.jmx.mbeanserver.MBeanSupport.preRegister2(MBeanSupport.java:183)
   at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:941)
   at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:917)
   at
com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:312)
   at
com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:482)
   at
org.apache.zookeeper.jmx.MBeanRegistry.register(MBeanRegistry.java:72)
   at
org.apache.zookeeper.server.NIOServerCnxn.finishSessionInit(NIOServerCnxn.java:861)
   at
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:145)
   at
org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:127)
   at
org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:75)


On Thu, Feb 5, 2009 at 8:56 PM, Stu Hood stuh...@mailtrust.com wrote:

+1

Thanks Patrick!


-Original Message-
From: Patrick Hunt ph...@apache.org
Sent: Wednesday, February 4, 2009 6:33pm
To: zookeeper-dev@hadoop.apache.org zookeeper-dev@hadoop.apache.org
Subject: [VOTE] Release ZooKeeper 3.1.0 (candidate 1)

I've created a new candidate (rc1) that fixes an issue raised by a user
(thanks Stu!) during review:
https://issues.apache.org/jira/browse/ZOOKEEPER-291
The release notes were also updated to reflect this change.

Otw there are no other changes.

*** Please download, test and VOTE before the
*** vote closes EOD on Monday February 9.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-1/

Should we release this?

Patrick







[jira] Commented: (ZOOKEEPER-303) Bin scripts don't work on Mac

2009-02-06 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671354#action_12671354
 ] 

Mahadev konar commented on ZOOKEEPER-303:
-

+1 the patch looks good. .. ZOOKEEPER-299 is a duplicate of this ... 


 Bin scripts don't work on Mac
 -

 Key: ZOOKEEPER-303
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-303
 Project: Zookeeper
  Issue Type: Bug
  Components: scripts
 Environment: Mac OS X
Reporter: Tom White
 Attachments: zookeeper-303.patch


 Macs don't support the -f option in readlink
 {noformat}
 $ bin/zkServer.sh start
 JMX enabled by default
 readlink: illegal option -- f
 usage: readlink [-n] [file ...]
 {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-304) factor out common methods from zookeeper.java

2009-02-06 Thread Mahadev konar (JIRA)
factor out common methods from zookeeper.java
-

 Key: ZOOKEEPER-304
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-304
 Project: Zookeeper
  Issue Type: Improvement
Affects Versions: 3.1.0
Reporter: Mahadev konar


we need to factor out common methods from zookeeper.java to a commons directory 
for zookeeper so that it can be used both in client and server without each of 
them depending on each other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[VOTE] Release ZooKeeper 3.1.0 (candidate 3)

2009-02-06 Thread Patrick Hunt
I've created a new candidate (rc3) that fixes an issue raised by a user 
(thanks Tom!) during review:

https://issues.apache.org/jira/browse/ZOOKEEPER-302
The release notes were also updated to reflect this change.

Otw there are no other changes.

*** Please download, test and VOTE before the
*** vote closes EOD on Wednesday February 11.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-3/

Should we release this?

Patrick