Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #79

2009-05-21 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/79/changes

Changes:

[phunt] ZOOKEEPER-411. Building zookeeper fails on RHEL 5 64 bit during 
test-cppunit

[breed] ZOOKEEPER-407. address all findbugs warnings in 
org.apache.zookeeper.server.quorum.** packages.

[breed] ZOOKEEPER-403. cleanup javac compiler warnings.

[breed] ZOOKEEPER-410. address all findbugs warnings in client/server classes.

[breed] ZOOKEEPER-292. forgot to update changes.txt

[breed] ZOOKEEPER-292. commit configure scripts (autotools) to svn for c 
projects and include in release.

[breed] ZOOKEEPER-345 the CLIs should allow addAuth to be invoked.

[breed] ZOOKEEPER-405 nullpointer exception in zookeeper java shell.

[mahadev] ZOOKEEPER-404. nightly build failed on hudson. (henry robinson and 
pat via mahadev)

--
started
Building remotely on vesta.apache.org (Ubuntu)
Updating http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk
U CHANGES.txt
U src/contrib/zkpython/build.xml
U src/contrib/rest/src/test/zkServer.sh
U src/java/test/config/findbugsExcludeFile.xml
U src/java/main/org/apache/zookeeper/ZooKeeper.java
U src/java/main/org/apache/zookeeper/ClientCnxn.java
U src/java/main/org/apache/zookeeper/ZooKeeperMain.java
U src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
U 
src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
U src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
U 
src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
U 
src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
U 
src/java/main/org/apache/zookeeper/server/quorum/AckRequestProcessor.java
U 
src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java
U src/java/main/org/apache/zookeeper/server/quorum/FollowerHandler.java
U src/java/main/org/apache/zookeeper/server/quorum/Follower.java
U 
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
U 
src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
U src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java
U src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
U src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
U src/java/main/org/apache/zookeeper/server/quorum/Leader.java
U src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
U src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
U src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
U src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java
U src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
U src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
U src/c/tests/zkServer.sh
U src/c/src/cli.c
U src/recipes/lock/src/c/tests/zkServer.sh
U build.xml
Fetching 'http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch' at -1 
into 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/test/bin'
 
At revision 777018
At revision 777018
no change for http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch 
since the previous build
[Zookeeper-Patch-vesta.apache.org] $ /bin/bash /tmp/hudson2319157540823527603.sh
/home/hudson/tools/java/latest1.6/bin/java
Buildfile: build.xml

check-for-findbugs:

findbugs.check:

java5.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-405.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Fetching external item into 'src/java/test/bin'
 [exec] Asrc/java/test/bin/test-patch.sh
 [exec] Updated external to revision 777018.
 [exec] 
 [exec] Updated to revision 777018.
 [exec] ZOOKEEPER-405 is not Patch Available.  Exiting.
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  Current
 [exec]  Dload  Upload   Total   Spent
Left  Speed
 [exec] 
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 

Hudson build is back to normal: Zookeeper-Patch-vesta.apache.org #80

2009-05-21 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/80/




[jira] Commented: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.

2009-05-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711527#action_12711527
 ] 

Hadoop QA commented on ZOOKEEPER-402:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408622/ZOOKEEPER-402.patch
  against trunk revision 776889.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/80/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/80/console

This message is automatically generated.

 zookeeper c library segfaults on data for a node in zookeeper being null.
 -

 Key: ZOOKEEPER-402
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0, 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Critical
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch


 the zookeeper c client library seg faults on data being null for a zoo node. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711621#action_12711621
 ] 

Hadoop QA commented on ZOOKEEPER-383:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408575/ZOOKEEPER-383.patch
  against trunk revision 776889.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 7 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/82/console

This message is automatically generated.

 Asynchronous version of createLedger()
 --

 Key: ZOOKEEPER-383
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Utkarsh Srivastava
Assignee: Flavio Paiva Junqueira
 Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch


 While there are async versions for read and write, there is no async version 
 for creating a ledger. This can cause applications to have to change their 
 whole thread design. 
 It should be easier and more consistent to add an async version of 
 createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #82

2009-05-21 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/82/

--
started
Building remotely on vesta.apache.org (Ubuntu)
Updating http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk
Fetching 'http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch' at -1 
into 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/test/bin'
 
At revision 777114
At revision 777114
no change for http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk since the 
previous build
no change for http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch 
since the previous build
[Zookeeper-Patch-vesta.apache.org] $ /bin/bash /tmp/hudson2886119697557213103.sh
/home/hudson/tools/java/latest1.6/bin/java
Buildfile: build.xml

check-for-findbugs:

findbugs.check:

java5.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-383.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Fetching external item into 'src/java/test/bin'
 [exec] Asrc/java/test/bin/test-patch.sh
 [exec] Updated external to revision 777114.
 [exec] 
 [exec] Updated to revision 777114.
 [exec] ZOOKEEPER-383 patch is being downloaded at Thu May 21 13:55:31 UTC 
2009 from
 [exec] 
http://issues.apache.org/jira/secure/attachment/12408575/ZOOKEEPER-383.patch
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Pre-building trunk to determine trunk number
 [exec] of release audit, javac, and Findbugs warnings.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/hudson/tools/ant/latest/bin/ant  
-Djava5.home=/home/hudson/tools/java/latest1.5 
-Dforrest.home=/home/nigel/tools/forrest/latest -DZooKeeperPatchProcess= 
releaseaudit  
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/patchprocess/trunkReleaseAuditWarnings.txt
  21
 [exec] /home/hudson/tools/ant/latest/bin/ant  -Djavac.args=-Xlint 
-Xmaxwarns 1000 -Declipse.home=/home/nigel/tools/eclipse/latest 
-Djava5.home=/home/hudson/tools/java/latest1.5 
-Dforrest.home=/home/nigel/tools/forrest/latest -DZooKeeperPatchProcess= clean 
tar  
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/patchprocess/trunkJavacWarnings.txt
  21
 [exec] /home/hudson/tools/ant/latest/bin/ant  
-Dfindbugs.home=/home/nigel/tools/findbugs/latest 
-Djava5.home=/home/hudson/tools/java/latest1.5 
-Dforrest.home=/home/nigel/tools/forrest/latest -DZooKeeperPatchProcess= 
findbugs  /dev/null 21
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Checking there are no @author tags in the patch.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] There appear to be 0 @author tags in the patch.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Checking there are new or changed tests in the patch.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] There appear to be 7 test files referenced in the patch.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Applying patch.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] patching file 
src/contrib/bookkeeper/src/java/org/apache/bookkeeper/bookie/Bookie.java
 [exec] patching file 
src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/AddCallback.java
 [exec] patching file 
src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/AsyncCallback.java
 

Build failed in Hudson: ZooKeeper-trunk #319

2009-05-21 Thread Apache Hudson Server
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/319/changes

Changes:

[phunt] ZOOKEEPER-411. Building zookeeper fails on RHEL 5 64 bit during 
test-cppunit

--
[...truncated 1334 lines...]

init-contrib:

compile:
 [echo] contrib: bookkeeper
[javac] Compiling 29 source files to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/bookkeeper/classes
 

jar:
 [echo] contrib: bookkeeper
  [jar] Building jar: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/bookkeeper/zookeeper-3.2.0-bookkeeper.jar
 

zookeeperbuildcontrib.package:
 [echo] contrib: bookkeeper
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper
 
 [copy] Copying 1 file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper
 

package:
 [copy] Copying 1 file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/test
 
 [copy] Copying 6 files to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/test
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/benchmark
 
 [copy] Copying 2 files to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/benchmark
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/src
 
 [copy] Copying 29 files to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/src
 

checkMainCompiled:

versionedjarname:

unversionedjarname:

setjarname:

check-contrib:

init:
 [echo] contrib: fatjar
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/classes
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/test
 

init-contrib:

compile:
 [echo] contrib: fatjar
[javac] Compiling 1 source file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/classes
 

jar:
 [echo] contrib: fatjar
  [jar] Building jar: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/zookeeper-3.2.0-fatjar.jar
 

zookeeperbuildcontrib.package:
 [echo] contrib: fatjar
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar
 
 [copy] Copying 1 file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar
 

package:
 [copy] Copying 1 file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/conf
 
 [copy] Copying 1 file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/conf
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/src
 
 [copy] Copying 1 file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/src
 

checkMainCompiled:

versionedjarname:

unversionedjarname:

setjarname:

check-contrib:

init:
 [echo] contrib: rest
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/classes
 
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/test
 

init-contrib:

compile:
 [echo] contrib: rest
[javac] Compiling 12 source files to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/classes
 

jar:
 [echo] contrib: rest
  [jar] Building jar: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/zookeeper-3.2.0-rest.jar
 

package:
 [echo] contrib: rest
[mkdir] Created dir: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/rest
 
 [copy] Copying 1 file to 

[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-21 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-383:
-

Status: Open  (was: Patch Available)

 Asynchronous version of createLedger()
 --

 Key: ZOOKEEPER-383
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Utkarsh Srivastava
Assignee: Flavio Paiva Junqueira
 Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
 ZOOKEEPER-383.patch


 While there are async versions for read and write, there is no async version 
 for creating a ledger. This can cause applications to have to change their 
 whole thread design. 
 It should be easier and more consistent to add an async version of 
 createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-21 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-383:
-

Attachment: ZOOKEEPER-383.patch

Apparently my last patch conflicted with the code in trunk, so I regenerated it 
and I'm resubmitting it. 

 Asynchronous version of createLedger()
 --

 Key: ZOOKEEPER-383
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Utkarsh Srivastava
Assignee: Flavio Paiva Junqueira
 Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
 ZOOKEEPER-383.patch


 While there are async versions for read and write, there is no async version 
 for creating a ledger. This can cause applications to have to change their 
 whole thread design. 
 It should be easier and more consistent to add an async version of 
 createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-21 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-383:
-

Status: Patch Available  (was: Open)

 Asynchronous version of createLedger()
 --

 Key: ZOOKEEPER-383
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Utkarsh Srivastava
Assignee: Flavio Paiva Junqueira
 Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
 ZOOKEEPER-383.patch


 While there are async versions for read and write, there is no async version 
 for creating a ledger. This can cause applications to have to change their 
 whole thread design. 
 It should be easier and more consistent to add an async version of 
 createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-402:
---

Status: Open  (was: Patch Available)

The specific changes look good, however I think we should include the following:

1) I don't see this documented in zookeeper.h api docs, please update the api 
docs for create/set/get
2) the tests should test all methods - set for example is not tested

What methods are impacted? create/get/set, that's it? Do the async versions of 
the methods
also need to be tested, or is that covered by the sync?


 zookeeper c library segfaults on data for a node in zookeeper being null.
 -

 Key: ZOOKEEPER-402
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.1, 3.1.0
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Critical
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch


 the zookeeper c client library seg faults on data being null for a zoo node. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-409) address all findbugs warnings in jute related classes

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-409:
--

Assignee: Patrick Hunt

 address all findbugs warnings in jute related classes
 -

 Key: ZOOKEEPER-409
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-409
 Project: Zookeeper
  Issue Type: Sub-task
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.2.0


 trunk/src/java/main/org/apache/jute/XmlInputArchive.java
 trunk/src/java/main/org/apache/jute/compiler/JFile.java
 trunk/src/java/main/org/apache/jute/compiler/JRecord.java
 trunk/src/java/main/org/apache/jute/compiler/CGenerator.java
 trunk/src/java/main/org/apache/jute/compiler/CppGenerator.java
 trunk/src/java/main/org/apache/jute/compiler/JavaGenerator.java
 org/apache/zookeeper/proto/AuthPacket.java
 org/apache/zookeeper/proto/ConnectRequest.java
 org/apache/zookeeper/proto/ConnectResponse.java
 org/apache/zookeeper/proto/CreateRequest.java
 org/apache/zookeeper/proto/GetChildrenResponse.java
 org/apache/zookeeper/proto/GetDataResponse.java
 org/apache/zookeeper/proto/SetDataRequest.java
 org/apache/zookeeper/proto/op_result_t.java
 org/apache/zookeeper/server/quorum/QuorumPacket.java
 org/apache/zookeeper/txn/CreateTxn.java
 org/apache/zookeeper/txn/SetDataTxn.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.

2009-05-21 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-402:


Status: Patch Available  (was: Open)

 zookeeper c library segfaults on data for a node in zookeeper being null.
 -

 Key: ZOOKEEPER-402
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.1, 3.1.0
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Critical
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, 
 ZOOKEEPER-402.patch


 the zookeeper c client library seg faults on data being null for a zoo node. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.

2009-05-21 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-402:


Attachment: ZOOKEEPER-402.patch

valid points pat... 

- added comments to zookeeper.h 
- added test for zoo_set
- also, the async apis are tested via athe sync apis.


 zookeeper c library segfaults on data for a node in zookeeper being null.
 -

 Key: ZOOKEEPER-402
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0, 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Critical
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, 
 ZOOKEEPER-402.patch


 the zookeeper c client library seg faults on data being null for a zoo node. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #83

2009-05-21 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/83/

--
started
Building remotely on vesta.apache.org (Ubuntu)
Updating http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk
Fetching 'http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch' at -1 
into 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/test/bin'
 
At revision 777203
At revision 777203
no change for http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk since the 
previous build
no change for http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch 
since the previous build
[Zookeeper-Patch-vesta.apache.org] $ /bin/bash /tmp/hudson7207709814124434935.sh
/home/hudson/tools/java/latest1.6/bin/java
Buildfile: build.xml

check-for-findbugs:

findbugs.check:

java5.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-411.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Reverted 
'src/contrib/bookkeeper/test/org/apache/bookkeeper/test/BookieReadWriteTest.java'
 [exec] Reverted 
'src/contrib/bookkeeper/src/java/org/apache/bookkeeper/proto/BookieServer.java'
 [exec] Reverted 
'src/contrib/bookkeeper/src/java/org/apache/bookkeeper/bookie/Bookie.java'
 [exec] Reverted 
'src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/BookKeeper.java'
 [exec] Reverted 
'src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java'
 [exec] Reverted 
'src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/QuorumEngine.java'
 [exec] 
 [exec] Fetching external item into 'src/java/test/bin'
 [exec] Asrc/java/test/bin/test-patch.sh
 [exec] Updated external to revision 777203.
 [exec] 
 [exec] Updated to revision 777203.
 [exec] ZOOKEEPER-411 is not Patch Available.  Exiting.
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  Current
 [exec]  Dload  Upload   Total   Spent
Left  Speed
 [exec] 
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0

BUILD SUCCESSFUL
Total time: 4 seconds
ERROR: No artifacts found that match the file pattern 
trunk/build/test/findbugs/newPatchFindbugsWarnings.html,trunk/patchprocess/*Warnings.txt.
 Configuration error?
ERROR: 'trunk/build/test/findbugs/newPatchFindbugsWarnings.html' doesn't match 
anything: 'trunk' exists but not 
'trunk/build/test/findbugs/newPatchFindbugsWarnings.html'
Recording test results
Description found: ZOOKEEPER-411



Build failed in Hudson: ZooKeeper-trunk #320

2009-05-21 Thread Apache Hudson Server
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/320/

--
[...truncated 125963 lines...]
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:653)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:897)
[junit] 2009-05-21 19:18:58,212 - INFO  
[NIOServerCxn.Factory:33221:nioservercnxn$fact...@190] - NIOServerCnxn factory 
exited run method
[junit] 2009-05-21 19:18:58,213 - INFO  [main:finalrequestproces...@268] - 
shutdown of request processor complete
[junit] 2009-05-21 19:18:58,213 - INFO  
[SyncThread:0:syncrequestproces...@118] - SyncRequestProcessor exited!
[junit] ensureOnly:[]
[junit] 2009-05-21 19:18:58,213 - INFO  
[ProcessThread:-1:preprequestproces...@109] - PrepRequestProcessor exited loop!
[junit] 2009-05-21 19:18:58,312 - INFO  [main:clientb...@316] - STARTING 
server
[junit] 2009-05-21 19:18:58,313 - INFO  [main:zookeeperser...@160] - 
Created server
[junit] 2009-05-21 19:18:58,314 - INFO  [main:files...@81] - Reading 
snapshot 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/tmp/test5747648790557940842.junit.dir/version-2/snapshot.5
 
[junit] 2009-05-21 19:18:58,316 - INFO  [main:filetxnsnap...@198] - 
Snapshotting: 6
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2009-05-21 19:18:58,318 - INFO  
[NIOServerCxn.Factory:33221:nioserverc...@646] - Processing stat command from 
/127.0.0.1:60901
[junit] 2009-05-21 19:18:58,318 - WARN  
[NIOServerCxn.Factory:33221:nioserverc...@444] - Exception causing close of 
session 0x0 due to java.io.IOException: Responded to info probe
[junit] 2009-05-21 19:18:58,319 - INFO  
[NIOServerCxn.Factory:33221:nioserverc...@777] - closing session:0x0 
NIOServerCnxn: java.nio.channels.SocketChannel[connected local=/127.0.0.1:33221 
remote=/127.0.0.1:60901]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2009-05-21 19:18:59,874 - INFO  
[main-SendThread:clientcnxn$sendthr...@821] - Attempting connection to server 
/127.0.0.1:33221
[junit] 2009-05-21 19:18:59,874 - INFO  
[main-SendThread:clientcnxn$sendthr...@737] - Priming connection to 
java.nio.channels.SocketChannel[connected local=/127.0.0.1:60902 
remote=/127.0.0.1:33221]
[junit] 2009-05-21 19:18:59,875 - INFO  
[main-SendThread:clientcnxn$sendthr...@889] - Server connection successful
[junit] 2009-05-21 19:18:59,875 - INFO  
[NIOServerCxn.Factory:33221:nioserverc...@532] - Connected to /127.0.0.1:60902 
lastZxid 6
[junit] 2009-05-21 19:18:59,875 - INFO  
[NIOServerCxn.Factory:33221:nioserverc...@906] - Finished init of 
0x121649c1c69 valid:true
[junit] 2009-05-21 19:18:59,876 - INFO  
[NIOServerCxn.Factory:33221:nioserverc...@560] - Renewing session 
0x121649c1c69
[junit] 2009-05-21 19:19:00,000 - INFO  
[SessionTracker:sessiontrackeri...@141] - SessionTrackerImpl exited loop!
[junit] 2009-05-21 19:19:10,962 - INFO  [main:zookee...@437] - Closing 
session: 0x121649c1c69
[junit] 2009-05-21 19:19:10,962 - INFO  [main:clientc...@1020] - Closing 
ClientCnxn for session: 0x121649c1c69
[junit] 2009-05-21 19:19:10,963 - INFO  
[ProcessThread:-1:preprequestproces...@363] - Processed session termination 
request for id: 0x121649c1c69
[junit] 2009-05-21 19:19:10,973 - INFO  [SyncThread:0:nioserverc...@777] - 
closing session:0x121649c1c69 NIOServerCnxn: 
java.nio.channels.SocketChannel[connected local=/127.0.0.1:33221 
remote=/127.0.0.1:60902]
[junit] 2009-05-21 19:19:10,974 - INFO  
[main-SendThread:clientcnxn$sendthr...@913] - Exception while closing send 
thread for session 0x121649c1c69 : Read error rc = -1 
java.nio.DirectByteBuffer[pos=0 lim=4 cap=4]
[junit] 2009-05-21 19:19:11,074 - INFO  [main:clientc...@1006] - 
Disconnecting ClientCnxn for session: 0x121649c1c69
[junit] 2009-05-21 19:19:11,075 - INFO  [main:zookee...@445] - Session: 
0x121649c1c69 closed
[junit] 2009-05-21 19:19:11,075 - INFO  
[main-EventThread:clientcnxn$eventthr...@473] - EventThread shut down
[junit] 2009-05-21 19:19:11,075 - INFO  [main:clientb...@332] - tearDown 
starting
[junit] 2009-05-21 19:19:11,075 - INFO  [main:clientb...@323] - STOPPING 
server
[junit] 2009-05-21 19:19:11,076 - INFO  
[NIOServerCxn.Factory:33221:nioservercnxn$fact...@190] - NIOServerCnxn factory 
exited run method
[junit] 2009-05-21 19:19:11,076 - INFO  [main:finalrequestproces...@268] - 
shutdown of request processor complete
[junit] 2009-05-21 19:19:11,076 - INFO  
[ProcessThread:-1:preprequestproces...@109] - PrepRequestProcessor exited loop!
[junit] 2009-05-21 19:19:11,076 - 

[jira] Created: (ZOOKEEPER-415) zookeeper c tests hang.

2009-05-21 Thread Mahadev konar (JIRA)
zookeeper c tests hang.
---

 Key: ZOOKEEPER-415
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-415
 Project: Zookeeper
  Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
 Fix For: 3.2.0


the c tests hang sometimes. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-415) zookeeper c tests hang.

2009-05-21 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711787#action_12711787
 ] 

Mahadev konar commented on ZOOKEEPER-415:
-

the stack traces are - 

- thread 1
{code}
0  0x003f41e075a5 in pthread_join () from /lib64/libpthread.so.0
#1  0x0044cef4 in pthread_join (t=1075841344, r=0x0) at 
zootestbuild/trunk/src/c/tests/PthreadMocks.cc:70
#2  0x004591ce in adaptor_finish (zh=0x2c0024d0) at 
zootestbuild/trunk/src/c/src/mt_adaptor.c:218
#3  0x0045066e in zookeeper_close (zh=0x2c0024d0) at 
zootestbuild/trunk/src/c/src/zookeeper.c:1870
#4  0x0044856b in ~watchCtx (this=0x7fff244a1290) at 
zootestbuild/trunk/src/c/tests/TestClient.cc:111
#5  0x00448675 in Zookeeper_simpleSystem::testWatcherAutoResetWithLocal 
(this=0x12450330) at zootestbuild/trunk/src/c/tests/TestClient.cc:671
#6  0x004403d6 in CppUnit::TestCallerZookeeper_simpleSystem::runTest 
(this=0x12450350) at /usr/local/include/cppunit/TestCaller.h:166
#7  0x2aaef2bf in CppUnit::TestCaseMethodFunctor::operator() 
(this=0x402009d0) at TestCase.cpp:32
#8  0x2aadc664 in CppUnit::DefaultProtector::protect (this=0x1244db80, 
funct...@0x402009d0, conte...@0x7fff244a1680) at DefaultProtector.cpp:15
#9  0x2aaeb049 in CppUnit::ProtectorChain::ProtectFunctor::operator() 
(this=0x402009d0) at ProtectorChain.cpp:20
#10 0x2aaeac3f in CppUnit::ProtectorChain::protect (this=0x1244d8c0, 
funct...@0x7fff244a16e0, conte...@0x7fff244a1680) at ProtectorChain.cpp:77
#11 0x2aafb964 in CppUnit::TestResult::protect (this=0x7fff244a1a00, 
funct...@0x7fff244a16e0, test=0x31f3, shortdescripti...@0x0) at 
TestResult.cpp:178
#12 0x2aaeefb4 in CppUnit::TestCase::run (this=0x12450350, 
result=0x7fff244a1a00) at TestCase.cpp:27
#13 0x2aaef869 in CppUnit::TestComposite::doRunChildTests 
(this=0x1244fb70, controller=0x7fff244a1a00) at TestComposite.cpp:64
#14 0x2aaef776 in CppUnit::TestComposite::run (this=0x1244fb70, 
result=0x7fff244a1a00) at TestComposite.cpp:23
#15 0x2aaef869 in CppUnit::TestComposite::doRunChildTests 
(this=0x1244e110, controller=0x7fff244a1a00) at TestComposite.cpp:64
#16 0x2aaef776 in CppUnit::TestComposite::run (this=0x1244e110, 
result=0x7fff244a1a00) at TestComposite.cpp:23
#17 0x2aafb8da in CppUnit::TestResult::runTest (this=0x7fff244a1a00, 
test=0x1244e0b0) at TestResult.cpp:145
#18 0x2aaff705 in CppUnit::TestRunner::run (this=0x402009d0, 
controll...@0x7fff244a1a00, testpa...@0x31f3) at TestRunner.cpp:96
#19 0x004059e1 in main (argc=1, argv=0x7fff244a1bd8) at 
zootestbuild/trunk/src/c/tests/TestDriver.cc:91
{code}

- thread 2

{code}
#0  0x003f41e0c878 in __lll_mutex_lock_wait () from /lib64/libpthread.so.0
#1  0x003f41e088a5 in _L_mutex_lock_107 () from /lib64/libpthread.so.0
#2  0x003f41e08333 in pthread_mutex_lock () from /lib64/libpthread.so.0
#3  0x0041096e in Mutex::acquire (this=0x7fff244a1280) at 
zootestbuild/trunk/src/c/tests/ThreadingUtil.cc:40
#4  0x00442121 in watchCtx::putEvent (this=0x7fff244a1260, 
e...@0x401ffea0) at zootestbuild/trunk/src/c/tests/TestClient.cc:134
#5  0x004421c3 in Zookeeper_simpleSystem::watcher (type=1, state=3, 
path=0x12459e80 /watchtest/child2, v=0x7fff244a1260)
at zootestbuild/trunk/src/c/tests/TestClient.cc:181
#6  0x00458338 in deliverWatchers (zh=0x2c0024d0, type=1, state=3, 
path=0x12459e80 /watchtest/child2, list=0x12456ad8)
at  zootestbuild/trunk/src/c/src/zk_hashtable.c:270
#7  0x0040ca9e in __wrap_deliverWatchers (zh=0x2c0024d0, type=1, 
state=3, path=0x12459e80 /watchtest/child2, list=0x12456ad8)
at zootestbuild/trunk/src/c/tests/ZKMocks.cc:218
#8  0x00450ab8 in process_completions (zh=0x2c0024d0) at 
zootestbuild/trunk/src/c/src/zookeeper.c:1407
#9  0x00458af1 in do_completion (v=value optimized out) at 
zootestbuild/trunk/src/c/src/mt_adaptor.c:332
#10 0x003f41e062e7 in start_thread () from /lib64/libpthread.so.0
#11 0x003f412ce3bd in clone () from /lib64/libc.so.6
{code}



 zookeeper c tests hang.
 ---

 Key: ZOOKEEPER-415
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-415
 Project: Zookeeper
  Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
 Fix For: 3.2.0


 the c tests hang sometimes. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-409) address all findbugs warnings in jute related classes

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-409:
---

Status: Patch Available  (was: Open)

 address all findbugs warnings in jute related classes
 -

 Key: ZOOKEEPER-409
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-409
 Project: Zookeeper
  Issue Type: Sub-task
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-409.patch


 trunk/src/java/main/org/apache/jute/XmlInputArchive.java
 trunk/src/java/main/org/apache/jute/compiler/JFile.java
 trunk/src/java/main/org/apache/jute/compiler/JRecord.java
 trunk/src/java/main/org/apache/jute/compiler/CGenerator.java
 trunk/src/java/main/org/apache/jute/compiler/CppGenerator.java
 trunk/src/java/main/org/apache/jute/compiler/JavaGenerator.java
 org/apache/zookeeper/proto/AuthPacket.java
 org/apache/zookeeper/proto/ConnectRequest.java
 org/apache/zookeeper/proto/ConnectResponse.java
 org/apache/zookeeper/proto/CreateRequest.java
 org/apache/zookeeper/proto/GetChildrenResponse.java
 org/apache/zookeeper/proto/GetDataResponse.java
 org/apache/zookeeper/proto/SetDataRequest.java
 org/apache/zookeeper/proto/op_result_t.java
 org/apache/zookeeper/server/quorum/QuorumPacket.java
 org/apache/zookeeper/txn/CreateTxn.java
 org/apache/zookeeper/txn/SetDataTxn.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-402:
---

  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

+1 looks good. thanks Mahadev
Committed revision 777265.

 zookeeper c library segfaults on data for a node in zookeeper being null.
 -

 Key: ZOOKEEPER-402
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0, 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Critical
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, 
 ZOOKEEPER-402.patch


 the zookeeper c client library seg faults on data being null for a zoo node. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-375) zoo_add_auth only retains most recent auth on re-sync

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-375:
--

Assignee: Mahadev konar

 zoo_add_auth only retains most recent auth on re-sync
 -

 Key: ZOOKEEPER-375
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.1.0, 3.1.1
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
 Fix For: 3.2.0


 zoo_add_auth doesn't maintain a list of auths - it only stores the most 
 recent auth send to the server. As a result on re-sync to the cluster it will 
 lose (not reregister) any auths prior to the most recent.
 This code should maintain a list of auths similar to the java code. Be sure 
 to free the memory in close.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-310) Coverity report on issues in C client code

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-310:
--

Assignee: Mahadev konar

 Coverity report on issues in C client code
 --

 Key: ZOOKEEPER-310
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-310
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.1.0
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Minor
 Fix For: 3.2.0


 Coverity found the following issues in the c code thatwe should look 
 at/resolve:
 1) zookeeper.c
 Event unterminated_case: This case (value 0) is not terminated by a 'break' 
 statement.
 717   case 0:
 718   errno = EHOSTDOWN;
 Event fallthrough: The above case falls through to this one.
 719   case -1:
 Event unterminated_case: This case (value 0) is not terminated by a 'break' 
 statement.
 739   case 0:
 740   errno = EHOSTDOWN;
 Event fallthrough: The above case falls through to this one.
 741   case -1:
 Event negative_return_fn: Called negative-returning function socket(2, 1, 0)
 Event var_assign: NEGATIVE return value of socket assigned to signed 
 variable zh-fd
 1099  zh-fd = socket(PF_INET, SOCK_STREAM, 0);
 Event negative_returns: Tracked variable zh-fd was passed to a negative 
 sink.
 1100  setsockopt(zh-fd, IPPROTO_TCP, TCP_NODELAY, on, 
 sizeof(int));
 Event deref_ptr: Directly dereferenced pointer cptr-buffer
 1308  cptr-buffer-curr_offset = get_buffer_len(oa);
 Event check_after_deref: Pointer cptr-buffer dereferenced before NULL check
 1309  if (!cptr-buffer) {
 cli.c
 Event returned_null: Function strchr returned NULL value (checked 4 out of 
 5 times)
 Event var_assigned: Variable ptr assigned to NULL return value from strchr
 532   char *ptr = strchr(buffer, '\n');
 Event dereference: Dereferencing NULL value ptr 
 recordio.c
 Event alloc_fn: Called allocation function malloc
 Event var_assign: Assigned variable buff to storage returned from 
 malloc(12U)
 284   struct buff_struct *buff = malloc(sizeof(struct buff_struct));
 Event leaked_storage: Variable buff goes out of scope
 At conditional (1): !(ia != NULL) taking true path 
 285   if (!ia) return 0;
 Event alloc_fn: Called allocation function malloc
 Event var_assign: Assigned variable buff to storage returned from 
 malloc(12U)
 301   struct buff_struct *buff = malloc(sizeof(struct buff_struct));
 Event leaked_storage: Variable buff goes out of scope
 At conditional (1): !(oa != NULL) taking true path
 302   if (!oa) return 0;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-274) Document options to connect Jconsole remotely

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-274:
--

Assignee: Patrick Hunt

 Document options to connect Jconsole remotely
 -

 Key: ZOOKEEPER-274
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-274
 Project: Zookeeper
  Issue Type: Improvement
  Components: jmx
Reporter: Flavio Paiva Junqueira
Assignee: Patrick Hunt
Priority: Minor
 Fix For: 3.2.0


 Here is the command I used:
 java -cp 
 .:./zookeeper-dev.jar:/usr/local/apache-log4j-1.2.15/log4j-1.2.15.jar 
 -Dlog4j.configuration=log4j_console.properties -Dcom.sun.management.jmxremote 
 -Dcom.sun.management.jmxremote.port=12122 
 -Dcom.sun.management.jmxremote.local.only=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.ssl=false 
 org.apache.zookeeper.server.quorum.QuorumPeerMain zoo.cfg
 In addition to the ones in jira 234, we also need the following to connect 
 remotely:
 -Dcom.sun.management.jmxremote.port
 -Dcom.sun.management.jmxremote.authenticate=false
 -Dcom.sun.management.jmxremote.ssl=false
 This command assumes no authentication or secure connection through ssl. To 
 use authentication, other options are necessary, such as the password file:
 -Dcom.sun.management.jmxremote.password.file
 In general, I found the following page a good source of information on this 
 topic:
 http://java.sun.com/javase/6/docs/technotes/guides/management/agent.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-192) trailing whitespace in config file can cause number format exceptions

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-192:
--

Assignee: Patrick Hunt

 trailing whitespace in config file can cause number format exceptions
 -

 Key: ZOOKEEPER-192
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-192
 Project: Zookeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Minor
 Fix For: 3.2.0


 a config file with trailing whitespace can cause number format exception
 for example a line such as
 clientPort=2181
 where 2181 is followed by a space character, will fail to parse with number 
 format excetion 2181  (notice the space).
 We need to trim whitespace when parsing numbers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (ZOOKEEPER-274) Document options to connect Jconsole remotely

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-274.


Resolution: Invalid

Closing -- the ZK JMX documention (as of 3.1) includes details on this - in 
particular it includes
sun's agent configuration document, the same link detailed in this jira.

 Document options to connect Jconsole remotely
 -

 Key: ZOOKEEPER-274
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-274
 Project: Zookeeper
  Issue Type: Improvement
  Components: jmx
Reporter: Flavio Paiva Junqueira
Assignee: Patrick Hunt
Priority: Minor
 Fix For: 3.2.0


 Here is the command I used:
 java -cp 
 .:./zookeeper-dev.jar:/usr/local/apache-log4j-1.2.15/log4j-1.2.15.jar 
 -Dlog4j.configuration=log4j_console.properties -Dcom.sun.management.jmxremote 
 -Dcom.sun.management.jmxremote.port=12122 
 -Dcom.sun.management.jmxremote.local.only=false 
 -Dcom.sun.management.jmxremote.authenticate=false 
 -Dcom.sun.management.jmxremote.ssl=false 
 org.apache.zookeeper.server.quorum.QuorumPeerMain zoo.cfg
 In addition to the ones in jira 234, we also need the following to connect 
 remotely:
 -Dcom.sun.management.jmxremote.port
 -Dcom.sun.management.jmxremote.authenticate=false
 -Dcom.sun.management.jmxremote.ssl=false
 This command assumes no authentication or secure connection through ssl. To 
 use authentication, other options are necessary, such as the password file:
 -Dcom.sun.management.jmxremote.password.file
 In general, I found the following page a good source of information on this 
 topic:
 http://java.sun.com/javase/6/docs/technotes/guides/management/agent.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-192) trailing whitespace in config file can cause number format exceptions

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-192:
---

Status: Patch Available  (was: Open)

 trailing whitespace in config file can cause number format exceptions
 -

 Key: ZOOKEEPER-192
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-192
 Project: Zookeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Minor
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-192.patch


 a config file with trailing whitespace can cause number format exception
 for example a line such as
 clientPort=2181
 where 2181 is followed by a space character, will fail to parse with number 
 format excetion 2181  (notice the space).
 We need to trim whitespace when parsing numbers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-192) trailing whitespace in config file can cause number format exceptions

2009-05-21 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-192:
---

Attachment: ZOOKEEPER-192.patch

added trim() for key/value when reading config file.

added test that verifies

 trailing whitespace in config file can cause number format exceptions
 -

 Key: ZOOKEEPER-192
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-192
 Project: Zookeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Minor
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-192.patch


 a config file with trailing whitespace can cause number format exception
 for example a line such as
 clientPort=2181
 where 2181 is followed by a space character, will fail to parse with number 
 format excetion 2181  (notice the space).
 We need to trim whitespace when parsing numbers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Hudson build is back to normal: Zookeeper-Patch-vesta.apache.org #84

2009-05-21 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/84/changes




[jira] Commented: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711869#action_12711869
 ] 

Hadoop QA commented on ZOOKEEPER-383:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408700/ZOOKEEPER-383.patch
  against trunk revision 777265.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 7 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/84/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/84/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/84/console

This message is automatically generated.

 Asynchronous version of createLedger()
 --

 Key: ZOOKEEPER-383
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Utkarsh Srivastava
Assignee: Flavio Paiva Junqueira
 Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
 ZOOKEEPER-383.patch


 While there are async versions for read and write, there is no async version 
 for creating a ledger. This can cause applications to have to change their 
 whole thread design. 
 It should be easier and more consistent to add an async version of 
 createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (ZOOKEEPER-379) cppunit tests failed during hudson patch tests

2009-05-21 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar resolved ZOOKEEPER-379.
-

   Resolution: Invalid
Fix Version/s: 3.2.0

this was just a problem with setup.

 cppunit tests failed during hudson patch tests 
 ---

 Key: ZOOKEEPER-379
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-379
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Giridharan Kesavan
Assignee: Mahadev konar
 Fix For: 3.2.0


 patch test build failed with  equality assertion failed
 link: 
 http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/Zookeeper-Patch-vesta.apache.org/44/console
 Mahadev,
 Could you take a look?
 Tnx!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-415) zookeeper c tests hang.

2009-05-21 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-415:


Attachment: ZOOKEEPER-415.patch

it turns out that we were facing a problem with the list.get() throwing an 
excpetion when the list is empty, whcih would result in lock not being released 
and the other thread waiting on the lock and never able to acquire it leading 
to tests hanging. for the soln.

- added wait for events before we ever call getEvents() 
- added assertion in getEvent that would fail if there are no elements 
available.



 zookeeper c tests hang.
 ---

 Key: ZOOKEEPER-415
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-415
 Project: Zookeeper
  Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-415.patch


 the c tests hang sometimes. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-345) the CLIs should allow addAuth to be invoked

2009-05-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711887#action_12711887
 ] 

Hudson commented on ZOOKEEPER-345:
--

Integrated in ZooKeeper-trunk #321 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])


 the CLIs should allow addAuth to be invoked
 ---

 Key: ZOOKEEPER-345
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-345
 Project: Zookeeper
  Issue Type: Improvement
  Components: c client, java client
Reporter: Patrick Hunt
Assignee: Henry Robinson
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-345.patch, ZOOKEEPER-345.patch


 Not sure about the c client but the java CLI ZooKeeperMain does not allow 
 addAuth to be called, it should have a command for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-403) cleanup javac compiler warnings

2009-05-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711886#action_12711886
 ] 

Hudson commented on ZOOKEEPER-403:
--

Integrated in ZooKeeper-trunk #321 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])


 cleanup javac compiler warnings
 ---

 Key: ZOOKEEPER-403
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-403
 Project: Zookeeper
  Issue Type: Improvement
  Components: java client, server
Reporter: Patrick Hunt
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-403.patch, ZOOKEEPER-403.patch


 Cleanup javac warnings, also turn on lint by default in ant build.xml for 
 main org.apache.zookeeper classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit

2009-05-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711889#action_12711889
 ] 

Hudson commented on ZOOKEEPER-411:
--

Integrated in ZooKeeper-trunk #321 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])


 Building zookeeper fails on RHEL 5 64 bit during test-cppunit
 -

 Key: ZOOKEEPER-411
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411
 Project: Zookeeper
  Issue Type: Bug
 Environment: RHEL5, 64bit 
Reporter: Lee Tucker
Assignee: Mahadev konar
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-411.patch, ZOOKEEPER-411.patch, 
 ZOOKEEPER-411.patch, ZOOKEEPER-411.patch


  [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion
  [exec] 
  [exec] 
 /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499:
  Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)]
  [exec] Failures !!!
  [exec] Run: 32   Failure total: 1   Failures: 1   Errors: 0
  [exec] make: *** [run-check] Error 1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.

2009-05-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711888#action_12711888
 ] 

Hudson commented on ZOOKEEPER-402:
--

Integrated in ZooKeeper-trunk #321 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])
. zookeeper c library segfaults on data for a node in zookeeper being null


 zookeeper c library segfaults on data for a node in zookeeper being null.
 -

 Key: ZOOKEEPER-402
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.0, 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Critical
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch, 
 ZOOKEEPER-402.patch


 the zookeeper c client library seg faults on data being null for a zoo node. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-405) nullpointer exception in zookeeper java shell.

2009-05-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711893#action_12711893
 ] 

Hudson commented on ZOOKEEPER-405:
--

Integrated in ZooKeeper-trunk #321 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])


 nullpointer exception in zookeeper java shell.
 --

 Key: ZOOKEEPER-405
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-405
 Project: Zookeeper
  Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-405.patch


 The java client shell does not handle null return data and throws out null 
 pointer exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages

2009-05-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711892#action_12711892
 ] 

Hudson commented on ZOOKEEPER-407:
--

Integrated in ZooKeeper-trunk #321 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])


 address all findbugs warnings in org.apache.zookeeper.server.quorum.** 
 packages
 ---

 Key: ZOOKEEPER-407
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407
 Project: Zookeeper
  Issue Type: Sub-task
  Components: server
Reporter: Patrick Hunt
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch, 
 ZOOKEEPER-407.patch


 Flavio please address the findbugs warnings in quorum and sub packages. See
 http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/
 for a list of issues or use ant's findbugs (or eclipse) to identify the 
 issues.
 In general we should try to fix these, but ignoring the warning (annotation) 
 is ok if it includes comments to effect why, also has
  to be reviewed/approved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-410) address all findbugs warnings in client/server classes

2009-05-21 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711890#action_12711890
 ] 

Hudson commented on ZOOKEEPER-410:
--

Integrated in ZooKeeper-trunk #321 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/321/])


 address all findbugs warnings in client/server classes
 --

 Key: ZOOKEEPER-410
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410
 Project: Zookeeper
  Issue Type: Sub-task
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-410.patch


 trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
 trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
 trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
 trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java
 trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
 trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
 trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #86

2009-05-21 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/86/

--
[...truncated 105339 lines...]
 [exec]  [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
  -DTHREADED -g -O2 -MT libzkmt_la-mt_adaptor.lo -MD -MP -MF 
.deps/libzkmt_la-mt_adaptor.Tpo -c 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/src/mt_adaptor.c
   -fPIC -DPIC -o .libs/libzkmt_la-mt_adaptor.o
 [exec]  [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
  -DTHREADED -g -O2 -MT libzkmt_la-mt_adaptor.lo -MD -MP -MF 
.deps/libzkmt_la-mt_adaptor.Tpo -c 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/src/mt_adaptor.c
  -o libzkmt_la-mt_adaptor.o /dev/null 21
 [exec]  [exec] mv -f .deps/libzkmt_la-mt_adaptor.Tpo 
.deps/libzkmt_la-mt_adaptor.Plo
 [exec]  [exec] /bin/bash ./libtool --tag=CC   --mode=link gcc 
-DTHREADED -g -O2   -o libzkmt.la  libzkmt_la-zookeeper.lo 
libzkmt_la-recordio.lo libzkmt_la-zookeeper.jute.lo libzkmt_la-zk_log.lo 
libzkmt_la-zk_hashtable.lo libzkmt_la-mt_adaptor.lo -lm 
 [exec]  [exec] libtool: link: ar cru .libs/libzkmt.a 
.libs/libzkmt_la-zookeeper.o .libs/libzkmt_la-recordio.o 
.libs/libzkmt_la-zookeeper.jute.o .libs/libzkmt_la-zk_log.o 
.libs/libzkmt_la-zk_hashtable.o .libs/libzkmt_la-mt_adaptor.o 
 [exec]  [exec] libtool: link: ranlib .libs/libzkmt.a
 [exec]  [exec] libtool: link: ( cd .libs  rm -f libzkmt.la  ln 
-s ../libzkmt.la libzkmt.la )
 [exec]  [exec] /bin/bash ./libtool --tag=CC   --mode=link gcc -Wall 
-Werror  -g -O2 -no-undefined -version-info 2  -o libzookeeper_mt.la -rpath 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/test-cppunit/lib
   libzkmt.la libhashtable.la -lpthread 
 [exec]  [exec] libtool: link: gcc -shared  -Wl,--whole-archive 
./.libs/libzkmt.a ./.libs/libhashtable.a -Wl,--no-whole-archive  -lm -lpthread  
  -Wl,-soname -Wl,libzookeeper_mt.so.2 -o .libs/libzookeeper_mt.so.2.0.0
 [exec]  [exec] libtool: link: (cd .libs  rm -f 
libzookeeper_mt.so.2  ln -s libzookeeper_mt.so.2.0.0 
libzookeeper_mt.so.2)
 [exec]  [exec] libtool: link: (cd .libs  rm -f 
libzookeeper_mt.so  ln -s libzookeeper_mt.so.2.0.0 libzookeeper_mt.so)
 [exec]  [exec] libtool: link: (cd .libs/libzookeeper_mt.lax/libzkmt.a 
 ar x 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/test-cppunit/./.libs/libzkmt.a;)
 
 [exec]  [exec] libtool: link: (cd 
.libs/libzookeeper_mt.lax/libhashtable.a  ar x 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/test-cppunit/./.libs/libhashtable.a;)
 
 [exec]  [exec] libtool: link: ar cru .libs/libzookeeper_mt.a   
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zk_hashtable.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zookeeper.jute.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-mt_adaptor.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zk_log.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-recordio.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zookeeper.o  
.libs/libzookeeper_mt.lax/libhashtable.a/hashtable_itr.o 
.libs/libzookeeper_mt.lax/libhashtable.a/hashtable.o 
 [exec]  [exec] libtool: link: ranlib .libs/libzookeeper_mt.a
 [exec]  [exec] libtool: link: rm -fr .libs/libzookeeper_mt.lax
 [exec]  [exec] libtool: link: ( cd .libs  rm -f 
libzookeeper_mt.la  ln -s ../libzookeeper_mt.la libzookeeper_mt.la )
 [exec]  [exec] gcc -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
   
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
   -Wall -Werror  -g -O2 -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test 
-f 'src/cli.c' || echo 

Hudson build is back to normal: Zookeeper-Patch-vesta.apache.org #87

2009-05-21 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/87/




[jira] Commented: (ZOOKEEPER-192) trailing whitespace in config file can cause number format exceptions

2009-05-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711917#action_12711917
 ] 

Hadoop QA commented on ZOOKEEPER-192:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408748/ZOOKEEPER-192.patch
  against trunk revision 777265.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 2 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/87/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/87/console

This message is automatically generated.

 trailing whitespace in config file can cause number format exceptions
 -

 Key: ZOOKEEPER-192
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-192
 Project: Zookeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Minor
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-192.patch


 a config file with trailing whitespace can cause number format exception
 for example a line such as
 clientPort=2181
 where 2181 is followed by a space character, will fail to parse with number 
 format excetion 2181  (notice the space).
 We need to trim whitespace when parsing numbers

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-415) zookeeper c tests hang.

2009-05-21 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12711923#action_12711923
 ] 

Hadoop QA commented on ZOOKEEPER-415:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408761/ZOOKEEPER-415.patch
  against trunk revision 777265.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/88/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/88/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/88/console

This message is automatically generated.

 zookeeper c tests hang.
 ---

 Key: ZOOKEEPER-415
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-415
 Project: Zookeeper
  Issue Type: Bug
Reporter: Mahadev konar
Assignee: Mahadev konar
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-415.patch


 the c tests hang sometimes. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.