Hudson build is back to normal: ZooKeeper-trunk #37
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/37/changes
[jira] Commented: (ZOOKEEPER-80) Document process for client recipe contributions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617827#action_12617827 ] Hiram Chirino commented on ZOOKEEPER-80: Hi, Here are my 2 cents for how to implement this so it co-exists nicely with ZOOKEEPER-103 For java at least, you want to group lots of small disjoint contributions into one jar. If they become more massive, it may be worth splitting it out to independent jars, but simplicities sake/maintenance needed to manage small contributions, one jar should be enough. The only tricky bit is that we also want to support implementing the recipe in other languages, so we want to also support multiple module directories. So my proposal is to have a module which would mainly hold the general documentation for the protocol which should be language agnostic: trunk/zookeeper-recipes/ trunk/zookeeper-recipes/src/docs And then we just have sub modules for the implementation of those recipes for the different languages. The java module would use maven directory layouts trunk/zookeeper-recipes/zookeeper-java-recipes trunk/zookeeper-recipes/zookeeper-java-recipes/src/main/java The c stuff would standard GNU c source layout trunk/zookeeper-recipes/zookeeper-c-recipes trunk/zookeeper-recipes/zookeeper-c-recipes/src ruby would use what every ruby folks are used to. trunk/zookeeper-recipes/zookeeper-ruby-recipes Also note that it might be better to replace 'recipes' term with 'protocols'. Document process for client recipe contributions Key: ZOOKEEPER-80 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-80 Project: Zookeeper Issue Type: Task Components: documentation Reporter: Patrick Hunt Assignee: Patrick Hunt Per Doug's suggestion I'll use a link instead of copy/paste: http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL PROTECTED] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617857#action_12617857 ] Patrick Hunt commented on ZOOKEEPER-103: I reviewed the patch itself (the patch file and the script) against the code (this was on friday 7/25). It applied cleanly and the build/test continued to function properly. I'm a bit concerned that this new structure results in a large number of toplevel (trunk) directories... just me or anyone else think this might be an issue? Reorganize the ZooKeeper source distro to follow maven conventions -- Key: ZOOKEEPER-103 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Hiram Chirino Assignee: Hiram Chirino Fix For: 3.0.0 Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617859#action_12617859 ] Hiram Chirino commented on ZOOKEEPER-103: - Generally it's just a good sign showing that stuff is decoupled. we could group things into directories but that would just deepen the directory tree and not add tremendous amount of value. Reorganize the ZooKeeper source distro to follow maven conventions -- Key: ZOOKEEPER-103 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Hiram Chirino Assignee: Hiram Chirino Fix For: 3.0.0 Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-82: -- Status: Open (was: Patch Available) I'm still unable to apply this patch, cancelling: 1) I get the following error during the patch patch -p0 /home/phunt/Desktop/ZOOKEEPER-82-b.patch patching file src/java/main/org/apache/zookeeper/ZooKeeper.java Reversed (or previously applied) patch detected! Assume -R? [n] I forced the patch, then fixed up the rejected patch issue by hand but there are still problems, 2) ObservableNIOServerCnxn is referenced by the patch file, but not in the mainline SVN nor in the patch file itself. Make the ZooKeeperServer more DI friendly - Key: ZOOKEEPER-82 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Hiram Chirino Assignee: Hiram Chirino Attachments: ZOOKEEPER-82-b.patch Proposed changes were discussed in [this mailing list thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL PROTECTED]: Basic goals are: * Decouple the current configuration system from the public API. I see stuff like ZooKeeperServer being coupled to ServerConfig a bit. * Allow the use of setter injection in addition to constructor injection. This is the most important thing needed to let spring more easily configure the objects. * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.