[jira] Updated: (ZOOKEEPER-135) Fat jar build target
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-135: --- Attachment: ZOOKEEPER-135.patch added missing changed file to diff Fat jar build target Key: ZOOKEEPER-135 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135 Project: Zookeeper Issue Type: New Feature Components: build Reporter: Benjamin Reed Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-135) Fat jar build target
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661637#action_12661637 ] Patrick Hunt commented on ZOOKEEPER-135: give it a try now, I missed a file when creating the patch (build.xml) Fat jar build target Key: ZOOKEEPER-135 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-135 Project: Zookeeper Issue Type: New Feature Components: build Reporter: Benjamin Reed Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch, ZOOKEEPER-135.patch For testing and experimentation purposes it would be nice to have everything in a self contained executable jar file that you can plop down on a machine and run. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-269) connectionloss - add more documentation to detail
connectionloss - add more documentation to detail -- Key: ZOOKEEPER-269 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-269 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.0 discussion with user, this should be better documented: -- There are basically 2 cases where you can see connectionloss: 1) you call an operation on a session that is no longer alive 2) you are disconnected from a server when there are pending async operations to that server (you made an async request which has not yet completed) Patrick Kevin Burton wrote: Can this be thrown when using multiple servers as long as 1 of them is online? Trying to figure out of I should try some type of reconnect if a single machine fails instead of failing altogether. Kevin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-231) Quotas in zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-231: Attachment: ZOOKEEPER-231.patch here is a preliminary patch for qutoa's. This is not fully complete -- lacking tests, documentation and a few minor features, which I will be adding shortly. The design is based on whats discussed above. COmments are welcome. Quotas in zookeeper --- Key: ZOOKEEPER-231 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-231 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.0.0 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.1.0 Attachments: ZOOKEEPER-231.patch creating quota's in zookeeper so that a runaway application does not bring down the zookeeper cluster. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-268) tostring on jute generated objects can cause NPE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-268: -- Assignee: Patrick Hunt tostring on jute generated objects can cause NPE Key: ZOOKEEPER-268 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-268 Project: Zookeeper Issue Type: Bug Components: java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-268.patch Jute still causing problems with tostring operations on generated code, need to review/cleanup the toCSV code From user Kevin Burton: - Creating this node with this ACL: Created /foo setAcl /foo world:anyone:w Causes the exception included below. It's an infinite loop so it's just called over and over again filling my console. I'm just doing an exists( path, true ); ... setting a watch still causes the problem. java.lang.NullPointerException at org.apache.jute.Utils.toCSVBuffer(Utils.java:234) at org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101) at org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586) at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852) java.lang.NullPointerException at org.apache.jute.Utils.toCSVBuffer(Utils.java:234) at org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101) at org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586) at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-268) tostring on jute generated objects can cause NPE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-268: --- Status: Patch Available (was: Open) tostring on jute generated objects can cause NPE Key: ZOOKEEPER-268 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-268 Project: Zookeeper Issue Type: Bug Components: java client, server Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-268.patch Jute still causing problems with tostring operations on generated code, need to review/cleanup the toCSV code From user Kevin Burton: - Creating this node with this ACL: Created /foo setAcl /foo world:anyone:w Causes the exception included below. It's an infinite loop so it's just called over and over again filling my console. I'm just doing an exists( path, true ); ... setting a watch still causes the problem. java.lang.NullPointerException at org.apache.jute.Utils.toCSVBuffer(Utils.java:234) at org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101) at org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586) at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852) java.lang.NullPointerException at org.apache.jute.Utils.toCSVBuffer(Utils.java:234) at org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101) at org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586) at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-268) tostring on jute generated objects can cause NPE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-268: --- Attachment: ZOOKEEPER-268.patch updated the jute tocsv methods to handle passed nulls. Also updated toxml at the same time new test for jute tostring test on a zk specific object that has null buffer. tostring on jute generated objects can cause NPE Key: ZOOKEEPER-268 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-268 Project: Zookeeper Issue Type: Bug Components: java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-268.patch Jute still causing problems with tostring operations on generated code, need to review/cleanup the toCSV code From user Kevin Burton: - Creating this node with this ACL: Created /foo setAcl /foo world:anyone:w Causes the exception included below. It's an infinite loop so it's just called over and over again filling my console. I'm just doing an exists( path, true ); ... setting a watch still causes the problem. java.lang.NullPointerException at org.apache.jute.Utils.toCSVBuffer(Utils.java:234) at org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101) at org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586) at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852) java.lang.NullPointerException at org.apache.jute.Utils.toCSVBuffer(Utils.java:234) at org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101) at org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230) at java.lang.String.valueOf(String.java:2827) at java.lang.StringBuilder.append(StringBuilder.java:115) at org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586) at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-264) docs should include a state transition diagram for client state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12661803#action_12661803 ] Patrick Hunt commented on ZOOKEEPER-264: In general our docs for client state are lacking, might be good to beef up this section http://hadoop.apache.org/zookeeper/docs/r3.0.1/zookeeperProgrammers.html#sc_connectingToZk including the state transition diagram and also discussion of the states and their meaning. This is even more evident to me based on the numerous questions we've been getting of late on the user lists regarding this issue. docs should include a state transition diagram for client state --- Key: ZOOKEEPER-264 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-264 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Priority: Minor Fix For: 3.1.0 we should have a state transition diagram to help users understand client state transitions. perhaps the edges could indicate what might cause such a transition? (not sure if that will work). keep in mind for the states that the java/c clients have diff names for constants (not sure how to handle). This should be added to the programmer guide in the appropriate section. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-266) KeeperState missing javadoc for values
[ https://issues.apache.org/jira/browse/ZOOKEEPER-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-266: --- Assignee: Patrick Hunt Status: Patch Available (was: Open) ZOOKEEPER-265 has the patch for this included KeeperState missing javadoc for values -- Key: ZOOKEEPER-266 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-266 Project: Zookeeper Issue Type: Bug Components: java client Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 KeeperState is missing documentation of the states. Should provide some basic details and refer users to the appropriate forrest doc for more detail (most likely prog guide). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-265) remove (deprecate) unused NoSyncConnected from KeeperState
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-265: --- Attachment: ZOOKEEPER-265.patch deprecated the unused states and also added javadoc. remove (deprecate) unused NoSyncConnected from KeeperState -- Key: ZOOKEEPER-265 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265 Project: Zookeeper Issue Type: Improvement Components: c client, java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-265.patch deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase. what about Unknown? that seems to be unused as well, deprecate it as well? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-258) docs incorrectly state max client timeout as 60 seconds (it's based on server ticktime)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-258: --- Attachment: ZOOKEEPER-258.patch Fixed the docs as stated in description. docs incorrectly state max client timeout as 60 seconds (it's based on server ticktime) --- Key: ZOOKEEPER-258 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-258 Project: Zookeeper Issue Type: Bug Components: documentation Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-258.patch The docs incorrectly state the max client timeout as 60 seconds. http://hadoop.apache.org/zookeeper/docs/r3.0.1/zookeeperProgrammers.html#ch_zkSessions the current server code has the following logic: if (sessionTimeout zk.tickTime * 2) { sessionTimeout = zk.tickTime * 2; } if (sessionTimeout zk.tickTime * 20) { sessionTimeout = zk.tickTime * 20; } So really the docs should say max is 20*tickTime -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-258) docs incorrectly state max client timeout as 60 seconds (it's based on server ticktime)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-258: --- Assignee: Patrick Hunt Status: Patch Available (was: Open) docs incorrectly state max client timeout as 60 seconds (it's based on server ticktime) --- Key: ZOOKEEPER-258 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-258 Project: Zookeeper Issue Type: Bug Components: documentation Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-258.patch The docs incorrectly state the max client timeout as 60 seconds. http://hadoop.apache.org/zookeeper/docs/r3.0.1/zookeeperProgrammers.html#ch_zkSessions the current server code has the following logic: if (sessionTimeout zk.tickTime * 2) { sessionTimeout = zk.tickTime * 2; } if (sessionTimeout zk.tickTime * 20) { sessionTimeout = zk.tickTime * 20; } So really the docs should say max is 20*tickTime -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-265) remove (deprecate) unused NoSyncConnected from KeeperState
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-265: --- Assignee: Patrick Hunt Status: Patch Available (was: Open) remove (deprecate) unused NoSyncConnected from KeeperState -- Key: ZOOKEEPER-265 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265 Project: Zookeeper Issue Type: Improvement Components: c client, java client, server Affects Versions: 3.0.1, 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.1.0 Attachments: ZOOKEEPER-265.patch deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase. what about Unknown? that seems to be unused as well, deprecate it as well? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.