Hudson build is back to normal: ZooKeeper-trunk #349
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/349/
[jira] Commented: (ZOOKEEPER-443) trace logging in watch notification not wrapped with istraceneabled - inefficient
[ https://issues.apache.org/jira/browse/ZOOKEEPER-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720615#action_12720615 ] Hudson commented on ZOOKEEPER-443: -- Integrated in ZooKeeper-trunk #349 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/349/]) trace logging in watch notification not wrapped with istraceneabled - inefficient - Key: ZOOKEEPER-443 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-443 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.2.0 Attachments: ZOOKEEPER-443.patch In org.apache.zookeeper.server.NIOServerCnxn.process(WatchedEvent) there's a trace message that's not wrapped with isTraceEnabled, this is very inefficient and should be fixed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-444) perms definition for PERMS_ALL differ in C and java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720774#action_12720774 ] Benjamin Reed commented on ZOOKEEPER-444: - +1 brilliant! perms definition for PERMS_ALL differ in C and java --- Key: ZOOKEEPER-444 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-444 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-444.patch the perms_all definition in Java is PERMS.ALL and does not include ADMIN perms but in c the PERMS_ALL def includes the ADMIN perms. We should make it consistent to include or not include the admin perms in both c and java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-444) perms definition for PERMS_ALL differ in C and java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-444: Resolution: Fixed Release Note: Changed PERMS.ALL definition in ZooDefs in java to include ADMIN. This changes the definition of OPEN_ACL_UNSAFE to have admin perms. Hadoop Flags: [Incompatible change, Reviewed] Status: Resolved (was: Patch Available) I just committed this. thanks ben for the brilliant review :). perms definition for PERMS_ALL differ in C and java --- Key: ZOOKEEPER-444 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-444 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-444.patch the perms_all definition in Java is PERMS.ALL and does not include ADMIN perms but in c the PERMS_ALL def includes the ADMIN perms. We should make it consistent to include or not include the admin perms in both c and java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-433) getacl on root znode (/) fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720781#action_12720781 ] Mahadev konar commented on ZOOKEEPER-433: - this patch needs to change with ZOOKEEPER-444 been committed. getacl on root znode (/) fails -- Key: ZOOKEEPER-433 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-433 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.1.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-433.patch, ZOOKEEPER-433.patch running a getAcl on the root znode / fails with the following: Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,072 - ERROR [CommitProcessor:3:finalrequestproces...@243] - Failed to process sessionid:0x321b16868f40003 ty pe:getACL cxid:0x3 zxid:0xfffe txntype:unknown n/a Fri Jun 5 10:21:17 2009: java.lang.NullPointerException Fri Jun 5 10:21:17 2009: at java.util.ArrayList.init(ArrayList.java:131) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.DataTree.getACL(DataTree.java:622) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:216) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,073 - ERROR [CommitProcessor:3:finalrequestproces...@250] - Dumping request buffer: 0x00012f We need to support getting/setting the root acl in particular -- not being able to control acls on this node makes multi-tenancy a non-starter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720790#action_12720790 ] Benjamin Reed commented on ZOOKEEPER-107: - oh right. you are correct. i guess it is more of a liveness/correctness issue: 1) start with A, B, C, D 2) B is down and A is the leader and proposes LEAVE C and fails where only D gets it. 3) C and D cannot get quorum since C has an older view. 4) D fails 5) A and B come back up and B is elected leader. 6) B proposes LEAVE A and C gets it before B fails. Now what happens? we cannot get quorum with just A and C since A has the old view. even if D comes up it will not elect C because it does not believe C is part of the ensemble. if they all come up either C or D can be elected leader, but if C is elected you end up with conflicting views: A thinks (B, C, D), B thinks (B, C, D), C thinks (B, C, D), and D thinks (A, B, D), so both A and D will effectively be out of the ensemble and you can't tolerate any failures. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Attachments: SimpleAddition.rtf Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-433) getacl on root znode (/) fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-433: Status: Open (was: Patch Available) getacl on root znode (/) fails -- Key: ZOOKEEPER-433 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-433 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.1.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-433.patch, ZOOKEEPER-433.patch, ZOOKEEPER-433.patch running a getAcl on the root znode / fails with the following: Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,072 - ERROR [CommitProcessor:3:finalrequestproces...@243] - Failed to process sessionid:0x321b16868f40003 ty pe:getACL cxid:0x3 zxid:0xfffe txntype:unknown n/a Fri Jun 5 10:21:17 2009: java.lang.NullPointerException Fri Jun 5 10:21:17 2009: at java.util.ArrayList.init(ArrayList.java:131) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.DataTree.getACL(DataTree.java:622) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:216) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,073 - ERROR [CommitProcessor:3:finalrequestproces...@250] - Dumping request buffer: 0x00012f We need to support getting/setting the root acl in particular -- not being able to control acls on this node makes multi-tenancy a non-starter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-433) getacl on root znode (/) fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-433: Attachment: ZOOKEEPER-433.patch this patch removes the newly added OPEN_ACL_UNSAFE_ADMIN with OPEN_ACL_UNSAFE since OPEN_ACL_UNSAFE is supposed to have admin previliges as well. getacl on root znode (/) fails -- Key: ZOOKEEPER-433 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-433 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.1.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-433.patch, ZOOKEEPER-433.patch, ZOOKEEPER-433.patch running a getAcl on the root znode / fails with the following: Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,072 - ERROR [CommitProcessor:3:finalrequestproces...@243] - Failed to process sessionid:0x321b16868f40003 ty pe:getACL cxid:0x3 zxid:0xfffe txntype:unknown n/a Fri Jun 5 10:21:17 2009: java.lang.NullPointerException Fri Jun 5 10:21:17 2009: at java.util.ArrayList.init(ArrayList.java:131) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.DataTree.getACL(DataTree.java:622) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:216) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,073 - ERROR [CommitProcessor:3:finalrequestproces...@250] - Dumping request buffer: 0x00012f We need to support getting/setting the root acl in particular -- not being able to control acls on this node makes multi-tenancy a non-starter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-433) getacl on root znode (/) fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-433: Status: Patch Available (was: Open) retrying hudson. getacl on root znode (/) fails -- Key: ZOOKEEPER-433 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-433 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.1.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-433.patch, ZOOKEEPER-433.patch, ZOOKEEPER-433.patch running a getAcl on the root znode / fails with the following: Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,072 - ERROR [CommitProcessor:3:finalrequestproces...@243] - Failed to process sessionid:0x321b16868f40003 ty pe:getACL cxid:0x3 zxid:0xfffe txntype:unknown n/a Fri Jun 5 10:21:17 2009: java.lang.NullPointerException Fri Jun 5 10:21:17 2009: at java.util.ArrayList.init(ArrayList.java:131) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.DataTree.getACL(DataTree.java:622) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:216) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,073 - ERROR [CommitProcessor:3:finalrequestproces...@250] - Dumping request buffer: 0x00012f We need to support getting/setting the root acl in particular -- not being able to control acls on this node makes multi-tenancy a non-starter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Post Summit Developer Offsite
Here are the notes from last Friday's meeting: http://wiki.apache.org/hadoop/DeveloperOffsite20090612. Thanks to everyone who contributed! Cheers, Tom On Tue, May 26, 2009 at 1:08 PM, Christophe Biscigliachristo...@cloudera.com wrote: Hadoop Developers, we'd like to let you know about a special developer offsite: http://hadoop-developer-offsite.eventbrite.com/ On the Friday after the summit, we're inviting committers from all Hadoop sub projects to get together for a day of real life camaraderie and a chance to attack some of the issues that are best solved face to face. We'll specifically focus on: * Understanding the major development challenges for the year ahead * Building consensus on the relative priorities of key upcoming features * Improving integration among sub projects * Best practices for packaging and distributing code (making life easier for the ops guys) We also realize that many developers that aren't yet committers will have valuable input, and we'd like to accommodate as many as we have room for. If you aren't a committer, but are actively involved in development, please register as an applicant, and we'll work with the committers on each project to squeeze in as many as we have room for. We know we can't accommodate everyone, but we will do our best, and will of course circulate notes from the meeting. Cheers, Christophe and the Cloudera Team -- get hadoop: cloudera.com/hadoop online training: cloudera.com/hadoop-training blog: cloudera.com/blog twitter: twitter.com/cloudera
[jira] Commented: (ZOOKEEPER-433) getacl on root znode (/) fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720852#action_12720852 ] Hadoop QA commented on ZOOKEEPER-433: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410965/ZOOKEEPER-433.patch against trunk revision 785741. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/118/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/118/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/118/console This message is automatically generated. getacl on root znode (/) fails -- Key: ZOOKEEPER-433 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-433 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.1.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-433.patch, ZOOKEEPER-433.patch, ZOOKEEPER-433.patch running a getAcl on the root znode / fails with the following: Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,072 - ERROR [CommitProcessor:3:finalrequestproces...@243] - Failed to process sessionid:0x321b16868f40003 ty pe:getACL cxid:0x3 zxid:0xfffe txntype:unknown n/a Fri Jun 5 10:21:17 2009: java.lang.NullPointerException Fri Jun 5 10:21:17 2009: at java.util.ArrayList.init(ArrayList.java:131) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.DataTree.getACL(DataTree.java:622) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:216) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,073 - ERROR [CommitProcessor:3:finalrequestproces...@250] - Dumping request buffer: 0x00012f We need to support getting/setting the root acl in particular -- not being able to control acls on this node makes multi-tenancy a non-starter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal: Zookeeper-Patch-vesta.apache.org #118
See http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/118/changes
[jira] Updated: (ZOOKEEPER-397) mainline tests conversion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Boudnik updated ZOOKEEPER-397: - Status: Patch Available (was: Open) Fixing the status to Patch Available mainline tests conversion - Key: ZOOKEEPER-397 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-397 Project: Zookeeper Issue Type: Sub-task Components: tests Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Fix For: 3.3.0 Attachments: testng-5.9-jdk15.jar, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch In this stage main set (src/java/test) of ZK tests will be converted to TestNG -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #119
See http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/119/ -- started Building remotely on vesta.apache.org (Ubuntu) Updating http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk Fetching 'http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch' at -1 into 'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/test/bin' At revision 785776 At revision 785776 no change for http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk since the previous build no change for http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch since the previous build [Zookeeper-Patch-vesta.apache.org] $ /bin/bash /tmp/hudson263861002508234677.sh /home/hudson/tools/java/latest1.6/bin/java Buildfile: build.xml check-for-findbugs: findbugs.check: java5.check: forrest.check: hudson-test-patch: [exec] [exec] [exec] == [exec] == [exec] Testing patch for ZOOKEEPER-397. [exec] == [exec] == [exec] [exec] [exec] Reverted 'src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/DataTree.java' [exec] Reverted 'src/c/tests/TestClient.cc' [exec] Reverted 'src/c/include/zookeeper.h' [exec] [exec] Fetching external item into 'src/java/test/bin' [exec] Asrc/java/test/bin/test-patch.sh [exec] Updated external to revision 785776. [exec] [exec] Updated to revision 785776. [exec] ZOOKEEPER-397 patch is being downloaded at Wed Jun 17 21:21:24 UTC 2009 from [exec] http://issues.apache.org/jira/secure/attachment/12408109/ZOOKEEPER-397.patch [exec] [exec] [exec] == [exec] == [exec] Pre-building trunk to determine trunk number [exec] of release audit, javac, and Findbugs warnings. [exec] == [exec] == [exec] [exec] [exec] /home/hudson/tools/ant/latest/bin/ant -Djava5.home=/home/hudson/tools/java/latest1.5 -Dforrest.home=/home/nigel/tools/forrest/latest -DZooKeeperPatchProcess= releaseaudit http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/patchprocess/trunkReleaseAuditWarnings.txt 21 [exec] /home/hudson/tools/ant/latest/bin/ant -Djavac.args=-Xlint -Xmaxwarns 1000 -Declipse.home=/home/nigel/tools/eclipse/latest -Djava5.home=/home/hudson/tools/java/latest1.5 -Dforrest.home=/home/nigel/tools/forrest/latest -DZooKeeperPatchProcess= clean tar http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/patchprocess/trunkJavacWarnings.txt 21 [exec] /home/hudson/tools/ant/latest/bin/ant -Dfindbugs.home=/home/nigel/tools/findbugs/latest -Djava5.home=/home/hudson/tools/java/latest1.5 -Dforrest.home=/home/nigel/tools/forrest/latest -DZooKeeperPatchProcess= findbugs /dev/null 21 [exec] [exec] [exec] == [exec] == [exec] Checking there are no @author tags in the patch. [exec] == [exec] == [exec] [exec] [exec] There appear to be 0 @author tags in the patch. [exec] [exec] [exec] == [exec] == [exec] Checking there are new or changed tests in the patch. [exec] == [exec] == [exec] [exec] [exec] There appear to be 145 test files referenced in the patch. [exec] [exec] [exec] == [exec] == [exec] Applying patch. [exec] == [exec] == [exec] [exec] [exec] patching file build.xml [exec]
[jira] Commented: (ZOOKEEPER-397) mainline tests conversion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720870#action_12720870 ] Hadoop QA commented on ZOOKEEPER-397: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408109/ZOOKEEPER-397.patch against trunk revision 785741. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 145 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/119/console This message is automatically generated. mainline tests conversion - Key: ZOOKEEPER-397 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-397 Project: Zookeeper Issue Type: Sub-task Components: tests Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Fix For: 3.3.0 Attachments: testng-5.9-jdk15.jar, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch In this stage main set (src/java/test) of ZK tests will be converted to TestNG -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Attachment: ZOOKEEPER-408.patch fixed the compilation problems and some more findbugs warnnings. Now the count should be 0 for findbugs warnings. address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #120
See http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/120/ -- [...truncated 220 lines...] [exec][delete] Deleting: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/lib/jdiff/zookeeper_3.2.0.xml [exec][delete] Deleting: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/zookeeper-dev.jar [exec][delete] Deleting directory http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/.revision [exec] [exec] clover.setup: [exec] [exec] clover.info: [exec] [exec] clover: [exec] [exec] init: [exec] [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/classes [exec] [exec] jute: [exec] [javac] Compiling 38 source files to http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/classes [exec] [javac] Note: Some input files use unchecked or unsafe operations. [exec] [javac] Note: Recompile with -Xlint:unchecked for details. [exec] [exec] compile_jute_uptodate: [exec] [exec] compile_jute: [exec] [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/generated [exec] [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated [exec] [java] ../../zookeeper.jute Parsed Successfully [exec] [java] ../../zookeeper.jute Parsed Successfully [exec] [touch] Creating http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/generated/.generated [exec] [exec] ver-gen: [exec] [javac] Compiling 1 source file to http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/classes [exec] [exec] svn-revision: [exec] [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/.revision [exec] [exec] version-info: [exec] [exec] build-generated: [exec] [javac] Compiling 44 source files to http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/classes [exec] [exec] compile-main: [exec] [javac] Compiling 105 source files to http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/classes [exec] [javac] http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java :168: disableAutoWatchReset has private access in org.apache.zookeeper.ClientCnxn [exec] [javac] if (ClientCnxn.disableAutoWatchReset [exec] [javac] ^ [exec] [javac] 1 error [exec] [exec] BUILD FAILED [exec] http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build.xml :261: Compile failed; see the compiler error output for details. [exec] [exec] Total time: 3 seconds [exec] [exec] [exec] There appear to be 0 javadoc warnings generated by the patched build. [exec] [exec] [exec] == [exec] == [exec] Determining number of patched javac warnings. [exec] == [exec] == [exec] [exec] [exec] /home/hudson/tools/ant/latest/bin/ant -Djavac.args=-Xlint -Xmaxwarns 1000 -Declipse.home=/home/nigel/tools/eclipse/latest -Djava5.home=/home/hudson/tools/java/latest1.5 -Dforrest.home=/home/nigel/tools/forrest/latest -DZooKeeperPatchProcess= clean tar http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/patchprocess/patchJavacWarnings.txt 21 [exec] There appear to be javac compiler warnings before the patch and javac compiler warnings after applying the patch. [exec] [exec] [exec] == [exec] == [exec] Determining number of patched Findbugs warnings. [exec] == [exec] == [exec] [exec] [exec] /home/hudson/tools/ant/latest/bin/ant -Dfindbugs.home=/home/nigel/tools/findbugs/latest
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720905#action_12720905 ] Hadoop QA commented on ZOOKEEPER-408: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410981/ZOOKEEPER-408.patch against trunk revision 785741. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 51 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/120/testReport/ Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/120/console This message is automatically generated. address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Attachment: ZOOKEEPER-408.patch missed out on a compilation problem. address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Open (was: Patch Available) address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720924#action_12720924 ] Hadoop QA commented on ZOOKEEPER-408: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410985/ZOOKEEPER-408.patch against trunk revision 785741. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 51 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/121/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/121/console This message is automatically generated. address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #121
See http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/121/ -- [...truncated 118000 lines...] [exec] [junit] 2009-06-17 21:57:11,316 - INFO [SyncThread:0:syncrequestproces...@134] - SyncRequestProcessor exited! [exec] [junit] ensureOnly:[] [exec] [junit] 2009-06-17 21:57:11,415 - INFO [main:clientb...@316] - STARTING server [exec] [junit] 2009-06-17 21:57:11,416 - INFO [main:zookeeperser...@159] - Created server [exec] [junit] 2009-06-17 21:57:11,417 - INFO [main:files...@81] - Reading snapshot http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/tmp/test4483727480028010616.junit.dir/version-2/snapshot.0 [exec] [junit] 2009-06-17 21:57:11,418 - INFO [main:filetxnsnap...@208] - Snapshotting: 3 [exec] [junit] 2009-06-17 21:57:11,420 - INFO [NIOServerCxn.Factory:33221:nioserverc...@690] - Processing stat command from /127.0.0.1:52306 [exec] [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [exec] [junit] 2009-06-17 21:57:11,421 - WARN [NIOServerCxn.Factory:33221:nioserverc...@488] - Exception causing close of session 0x0 due to java.io.IOException: Responded to info probe [exec] [junit] 2009-06-17 21:57:11,421 - INFO [NIOServerCxn.Factory:33221:nioserverc...@826] - closing session:0x0 NIOServerCnxn: java.nio.channels.SocketChannel[connected local=/127.0.0.1:33221 remote=/127.0.0.1:52306] [exec] [junit] expect:InMemoryDataTree [exec] [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [exec] [junit] expect:StandaloneServer_port [exec] [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [exec] [junit] 2009-06-17 21:57:12,000 - INFO [SessionTracker:sessiontrackeri...@139] - SessionTrackerImpl exited loop! [exec] [junit] 2009-06-17 21:57:12,000 - INFO [SessionTracker:sessiontrackeri...@139] - SessionTrackerImpl exited loop! [exec] [junit] 2009-06-17 21:57:12,418 - INFO [main-SendThread:clientcnxn$sendthr...@835] - Attempting connection to server /127.0.0.1:33221 [exec] [junit] 2009-06-17 21:57:12,419 - INFO [main-SendThread:clientcnxn$sendthr...@751] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:52307 remote=/127.0.0.1:33221] [exec] [junit] 2009-06-17 21:57:12,419 - INFO [main-SendThread:clientcnxn$sendthr...@903] - Server connection successful [exec] [junit] 2009-06-17 21:57:12,419 - INFO [NIOServerCxn.Factory:33221:nioserverc...@576] - Connected to /127.0.0.1:52307 lastZxid 3 [exec] [junit] 2009-06-17 21:57:12,420 - INFO [NIOServerCxn.Factory:33221:nioserverc...@957] - Finished init of 0x121f0393bbe valid:true [exec] [junit] 2009-06-17 21:57:12,420 - INFO [NIOServerCxn.Factory:33221:nioserverc...@604] - Renewing session 0x121f0393bbe [exec] [junit] 2009-06-17 21:57:46,520 - INFO [main:clientb...@323] - STOPPING server [exec] [junit] 2009-06-17 21:57:46,521 - INFO [main:nioserverc...@826] - closing session:0x121f0393bbe NIOServerCnxn: java.nio.channels.SocketChannel[connected local=/127.0.0.1:33221 remote=/127.0.0.1:52307] [exec] [junit] 2009-06-17 21:57:46,521 - WARN [main-SendThread:clientcnxn$sendthr...@933] - Exception closing session 0x121f0393bbe to sun.nio.ch.selectionkeyi...@c5122f [exec] [junit] java.io.IOException: Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [exec] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:667) [exec] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:911) [exec] [junit] 2009-06-17 21:57:46,521 - INFO [NIOServerCxn.Factory:33221:nioservercnxn$fact...@234] - NIOServerCnxn factory exited run method [exec] [junit] 2009-06-17 21:57:46,521 - INFO [main:finalrequestproces...@278] - shutdown of request processor complete [exec] [junit] 2009-06-17 21:57:46,521 - INFO [SyncThread:0:syncrequestproces...@134] - SyncRequestProcessor exited! [exec] [junit] 2009-06-17 21:57:46,521 - INFO [ProcessThread:-1:preprequestproces...@119] - PrepRequestProcessor exited loop! [exec] [junit] ensureOnly:[] [exec] [junit] 2009-06-17 21:57:46,621 - INFO [main:clientb...@316] - STARTING server [exec] [junit] 2009-06-17 21:57:46,622 - INFO [main:zookeeperser...@159] - Created server [exec] [junit] 2009-06-17 21:57:46,623 - INFO [main:files...@81] - Reading snapshot http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/tmp/test4483727480028010616.junit.dir/version-2/snapshot.3 [exec] [junit] 2009-06-17
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) retyring to see if the test failure is temporary.. address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-427) ZooKeeper server unexpectedly high CPU utilisation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Zhuravlev updated ZOOKEEPER-427: --- Attachment: zk_quorum_recv_eof.patch Hi! I think, that problem is not in nio, but in QuorumCnxManager. Manager start while-loop when channel is connected and start wait msgLength in read call. At this moment process from other side stops and read return -1 But there is no checking of read return value, so loop become infinite. Please, look at my patch, it works for my case. ZooKeeper server unexpectedly high CPU utilisation -- Key: ZOOKEEPER-427 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-427 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1 Environment: Linux: 2.6.18-92.1.18.el5 #1 SMP Wed Nov 12 09:19:49 EST 2008 x86_64 x86_64 x86_64 GNU/Linux java version 1.6.0_03 Java(TM) SE Runtime Environment (build 1.6.0_03-b05) Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_03-b05, mixed mode) Reporter: Satish Bhatti Assignee: Benjamin Reed Attachments: zk_quorum_recv_eof.patch, zoo.cfg, zookeeper-jstack.log, zookeeper.log I am running a 5 node ZooKeeper cluster and I noticed that one of them has very high CPU usage: PID USER PR NI VIRT RES SHR S %CPU %MEMTIME+ COMMAND 6883 infact 22 0 725m 41m 4188 S 95 0.5 5671:54 java It is not doing anything application-wise at this point, so I was wondering why the heck it's using up so much CPU. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Open (was: Patch Available) address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-310) Coverity report on issues in C client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-310:
Fix Version/s: (was: 3.2.0)
3.3.0
moving it to 3.3
Coverity report on issues in C client code
--
Key: ZOOKEEPER-310
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-310
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.1.0
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Minor
Fix For: 3.3.0
Coverity found the following issues in the c code thatwe should look
at/resolve:
1) zookeeper.c
Event unterminated_case: This case (value 0) is not terminated by a 'break'
statement.
717 case 0:
718 errno = EHOSTDOWN;
Event fallthrough: The above case falls through to this one.
719 case -1:
Event unterminated_case: This case (value 0) is not terminated by a 'break'
statement.
739 case 0:
740 errno = EHOSTDOWN;
Event fallthrough: The above case falls through to this one.
741 case -1:
Event negative_return_fn: Called negative-returning function socket(2, 1, 0)
Event var_assign: NEGATIVE return value of socket assigned to signed
variable zh-fd
1099 zh-fd = socket(PF_INET, SOCK_STREAM, 0);
Event negative_returns: Tracked variable zh-fd was passed to a negative
sink.
1100 setsockopt(zh-fd, IPPROTO_TCP, TCP_NODELAY, on,
sizeof(int));
Event deref_ptr: Directly dereferenced pointer cptr-buffer
1308 cptr-buffer-curr_offset = get_buffer_len(oa);
Event check_after_deref: Pointer cptr-buffer dereferenced before NULL check
1309 if (!cptr-buffer) {
cli.c
Event returned_null: Function strchr returned NULL value (checked 4 out of
5 times)
Event var_assigned: Variable ptr assigned to NULL return value from strchr
532 char *ptr = strchr(buffer, '\n');
Event dereference: Dereferencing NULL value ptr
recordio.c
Event alloc_fn: Called allocation function malloc
Event var_assign: Assigned variable buff to storage returned from
malloc(12U)
284 struct buff_struct *buff = malloc(sizeof(struct buff_struct));
Event leaked_storage: Variable buff goes out of scope
At conditional (1): !(ia != NULL) taking true path
285 if (!ia) return 0;
Event alloc_fn: Called allocation function malloc
Event var_assign: Assigned variable buff to storage returned from
malloc(12U)
301 struct buff_struct *buff = malloc(sizeof(struct buff_struct));
Event leaked_storage: Variable buff goes out of scope
At conditional (1): !(oa != NULL) taking true path
302 if (!oa) return 0;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-413) two flaws need addressing in the c tests that can cause false positive failures
[ https://issues.apache.org/jira/browse/ZOOKEEPER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-413: Fix Version/s: (was: 3.2.0) 3.3.0 moving it to 3.3 two flaws need addressing in the c tests that can cause false positive failures --- Key: ZOOKEEPER-413 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413 Project: Zookeeper Issue Type: Bug Components: c client, tests Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Minor Fix For: 3.3.0 1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server 2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to have some limit on the number of iterations (other than just the test, which may never return false), also the loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #122
See http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/122/ -- started Building remotely on vesta.apache.org (Ubuntu) Updating http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk Fetching 'http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch' at -1 into 'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/test/bin' At revision 785848 At revision 785848 no change for http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk since the previous build no change for http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch since the previous build [Zookeeper-Patch-vesta.apache.org] $ /bin/bash /tmp/hudson1789554667238858001.sh /home/hudson/tools/java/latest1.6/bin/java Buildfile: build.xml check-for-findbugs: findbugs.check: java5.check: forrest.check: hudson-test-patch: [exec] [exec] [exec] == [exec] == [exec] Testing patch for ZOOKEEPER-408. [exec] == [exec] == [exec] [exec] [exec] Reverted 'src/java/test/config/findbugsExcludeFile.xml' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/ACLTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/LETest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/InvalidSnapshotTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/FLETest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/ClientBase.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/PurgeTxnTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/ClientTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/QuorumBase.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/UpgradeTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/RecoveryTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/AsyncOpsTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/test/WatcherTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java' [exec] Reverted 'src/java/test/org/apache/zookeeper/server/CRCTest.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/ZooKeeper.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/Environment.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/ClientCnxn.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/ZooKeeperMain.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/persistence/Util.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/quorum/FollowerHandler.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/DataNode.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/DataTree.java' [exec] Reverted 'src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java' [exec] [exec] Fetching external item into 'src/java/test/bin' [exec] Asrc/java/test/bin/test-patch.sh [exec] Updated external to revision 785848. [exec] [exec] Updated to revision 785848. [exec] ZOOKEEPER-408 is not Patch Available. Exiting. [exec] % Total% Received % Xferd Average Speed TimeTime Time Current [exec] Dload Upload Total Spent Left Speed [exec] [exec] 0 00
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) address all findbugs warnings in persistence classes Key: ZOOKEEPER-408 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch trunk/src/java/main/org/apache/zookeeper/server/DataTree.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java trunk/src/java/main/org/apache/zookeeper/server/DataNode.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-433) getacl on root znode (/) fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-433: Resolution: Fixed Release Note: fixes a problem with getacl on root node / Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. thanks pat. getacl on root znode (/) fails -- Key: ZOOKEEPER-433 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-433 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.1.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Blocker Fix For: 3.2.0 Attachments: ZOOKEEPER-433.patch, ZOOKEEPER-433.patch, ZOOKEEPER-433.patch running a getAcl on the root znode / fails with the following: Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,072 - ERROR [CommitProcessor:3:finalrequestproces...@243] - Failed to process sessionid:0x321b16868f40003 ty pe:getACL cxid:0x3 zxid:0xfffe txntype:unknown n/a Fri Jun 5 10:21:17 2009: java.lang.NullPointerException Fri Jun 5 10:21:17 2009: at java.util.ArrayList.init(ArrayList.java:131) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.DataTree.getACL(DataTree.java:622) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:216) Fri Jun 5 10:21:17 2009: at org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:74) Fri Jun 5 10:21:17 2009: 2009-06-05 10:21:17,073 - ERROR [CommitProcessor:3:finalrequestproces...@250] - Dumping request buffer: 0x00012f We need to support getting/setting the root acl in particular -- not being able to control acls on this node makes multi-tenancy a non-starter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal: Zookeeper-Patch-vesta.apache.org #123
See http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/123/changes
