date:20091201

[
https://issues.apache.org/jira/browse/ZOOKEEPER-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784340#action_12784340
]

Patrick Hunt commented on ZOOKEEPER-597:

according to the latest log the commit processor thread is exiting. I notice
that we are not logging exceptions from that thread. We should include logging
the exception as part of this fix. Really we need to add to the ThreadGroup --
handle uncaught exceptions -- log them at error level

ASyncHammerTest is failing intermittently on hudson trunk
-

Attachments: ZOOKEEPER-597.patch

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-600) TODO pondering about allocation behavior in zkpython may be removed

2009-12-01 Thread Gustavo Niemeyer (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gustavo Niemeyer updated ZOOKEEPER-600:
---

Attachment: deallocate-vector.patch

The attached patch should fix this problem.  It also reuses existing code, and 
fixes a few other issues around the former problem, with return values not 
being properly checked for errors.

I'm afraid there are several instances of variables which are not checked for 
error conditions in the module, unfortunately. :-(  I'm not going to try fixing 
these in this JIRA, though.

 TODO pondering about allocation behavior in zkpython may be removed
 ---

 Key: ZOOKEEPER-600
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Gustavo Niemeyer
Assignee: Gustavo Niemeyer
Priority: Trivial
 Fix For: 3.3.0

 Attachments: deallocate-vector.patch


 I suppose the TODO below is referring to the path variable which is passed 
 in as an output variable to PyArg_ParseTuple right below.  The TODO may be 
 removed, since the code is right.  Code using PyArg_ParseTuple will borrow 
 the reference from the calling code, since there's a stack behind the call to 
 the enclosing function (pyzoo_get_children in this case) which won't go away 
 until the function returns.
 Index: src/contrib/zkpython/src/c/zookeeper.c
 ===
 --- src/contrib/zkpython/src/c/zookeeper.c(revision 885582)
 +++ src/contrib/zkpython/src/c/zookeeper.c(working copy)
 @@ -774,8 +774,6 @@
  
  static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
  {
 -  // TO DO: Does Python copy the string or the reference? If it's the former
 -  // we should free the String_vector
int zkhid;
char *path;
PyObject *watcherfn = Py_None;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-597) ASyncHammerTest is failing intermittently on hudson trunk

2009-12-01 Thread Flavio Paiva Junqueira (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784344#action_12784344
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-597:
--

It is ok to have cnxn = null in FinalRequestProcessor. For example, if a 
follower is forwarding a request, cnxn will be null for the leader. The 
problem, as Pat points out, seems to be that CommitProcessor is exiting at the 
follower that was supposed to finalize it.

Here is the stack trace from a faulty run:


{noformat}
java.nio.channels.CancelledKeyException
at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59)
at 
org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:350)
at 
org.apache.zookeeper.server.NIOServerCnxn.sendResponse(NIOServerCnxn.java:1065)
at 
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:360)
at 
org.apache.zookeeper.server.quorum.CommitProcessor.run(CommitProcessor.java:73)
{noformat}

 ASyncHammerTest is failing intermittently on hudson trunk
 -

 Key: ZOOKEEPER-597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-597
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-597.patch


 ASyncHammerTest is failing intermittently on hudson trunk. There is no clear 
 reason why this is happening, but
 it seems from the logs that a session connection to a follower is failing 
 during session establishment - the
 failure seems to be a problem either on the follower or leader. The server 
 gets the session create request, but
 it stalls in the request processor pipeline. (we see it go in, but we do not 
 see it com eout)
 unfortunately all efforts to reproduce this on non-hudson trunk have failed. 
 Even trying to reproduce by
 running on hudson host itself (manually) has failed.
 We need to instrument the client session creation code in the test to dump 
 the thread stack if the
 session creation fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-602) log all exceptions not caught by ZK threads

log all exceptions not caught by ZK threads
---

 Key: ZOOKEEPER-602
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602
 Project: Zookeeper
  Issue Type: Bug
  Components: java client, server
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0


the java code should add a ThreadGroup exception handler that logs at ERROR 
level any uncaught exceptions thrown by Thread run methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-600) TODO pondering about allocation behavior in zkpython may be removed


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784352#action_12784352
 ] 

Henry Robinson commented on ZOOKEEPER-600:
--

Patch applies fine for me and tests all pass - looks good, thanks Gustavo! I'll 
open a JIRA for the other issues. 

 TODO pondering about allocation behavior in zkpython may be removed
 ---

 Key: ZOOKEEPER-600
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Gustavo Niemeyer
Assignee: Gustavo Niemeyer
Priority: Trivial
 Fix For: 3.3.0

 Attachments: deallocate-vector.patch


 I suppose the TODO below is referring to the path variable which is passed 
 in as an output variable to PyArg_ParseTuple right below.  The TODO may be 
 removed, since the code is right.  Code using PyArg_ParseTuple will borrow 
 the reference from the calling code, since there's a stack behind the call to 
 the enclosing function (pyzoo_get_children in this case) which won't go away 
 until the function returns.
 Index: src/contrib/zkpython/src/c/zookeeper.c
 ===
 --- src/contrib/zkpython/src/c/zookeeper.c(revision 885582)
 +++ src/contrib/zkpython/src/c/zookeeper.c(working copy)
 @@ -774,8 +774,6 @@
  
  static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
  {
 -  // TO DO: Does Python copy the string or the reference? If it's the former
 -  // we should free the String_vector
int zkhid;
char *path;
PyObject *watcherfn = Py_None;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-603) zkpython should do a better job of freeing memory under error conditions

zkpython should do a better job of freeing memory under error conditions


 Key: ZOOKEEPER-603
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-603
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Henry Robinson
 Fix For: 3.2.2


The general pattern is that the construction of a collection might fail, but 
the module is not freeing the memory that it has already allocated. Exceptions 
that are raised during this process aren't always propagated back to the Python 
side either. 



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-597) ASyncHammerTest is failing intermittently on hudson trunk

2009-12-01 Thread Benjamin Reed (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-597:


Status: Patch Available  (was: Reopened)

 ASyncHammerTest is failing intermittently on hudson trunk
 -

 Key: ZOOKEEPER-597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-597
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-597.patch, ZOOKEEPER-597.patch


 ASyncHammerTest is failing intermittently on hudson trunk. There is no clear 
 reason why this is happening, but
 it seems from the logs that a session connection to a follower is failing 
 during session establishment - the
 failure seems to be a problem either on the follower or leader. The server 
 gets the session create request, but
 it stalls in the request processor pipeline. (we see it go in, but we do not 
 see it com eout)
 unfortunately all efforts to reproduce this on non-hudson trunk have failed. 
 Even trying to reproduce by
 running on hudson host itself (manually) has failed.
 We need to instrument the client session creation code in the test to dump 
 the thread stack if the
 session creation fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-597) ASyncHammerTest is failing intermittently on hudson trunk

2009-12-01 Thread Benjamin Reed (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-597:


Attachment: ZOOKEEPER-597.patch

A runtime exception was killing the CommitProcessor.

 ASyncHammerTest is failing intermittently on hudson trunk
 -

 Key: ZOOKEEPER-597
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-597
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-597.patch, ZOOKEEPER-597.patch


 ASyncHammerTest is failing intermittently on hudson trunk. There is no clear 
 reason why this is happening, but
 it seems from the logs that a session connection to a follower is failing 
 during session establishment - the
 failure seems to be a problem either on the follower or leader. The server 
 gets the session create request, but
 it stalls in the request processor pipeline. (we see it go in, but we do not 
 see it com eout)
 unfortunately all efforts to reproduce this on non-hudson trunk have failed. 
 Even trying to reproduce by
 running on hudson host itself (manually) has failed.
 We need to instrument the client session creation code in the test to dump 
 the thread stack if the
 session creation fails.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [VOTE] Release ZooKeeper 3.1.2 (candidate 0)

2009-12-01 Thread Mahadev Konar

-1 

http://issues.apache.org/jira/browse/ZOOKEEPER-597 exposes a critical bug
and should be included in the fix for both 3.2.2 and 3.1.2.

Thanks
mahadev



On 11/25/09 6:50 AM, Flavio Junqueira f...@yahoo-inc.com wrote:

 +1. Also ran ant test.
 
 -Flavio
 
 On Nov 25, 2009, at 4:17 AM, Mahadev Konar wrote:
 
 +1 .. Ran ant test.
 
 mahadev
 
 
 On 11/24/09 11:22 AM, Benjamin Reed br...@yahoo-inc.com wrote:
 
 +1
 
 Patrick Hunt wrote:
 I've created a candidate build for ZooKeeper 3.1.2. This is a bug
 fix
 release addressing just two critical issues -- see the release
 notes for
 details.
 
 *** Please download, test and VOTE before the
 *** vote closes 4pm pacific time, Friday, November 27.***
 
 http://people.apache.org/~phunt/zookeeper-3.1.2-candidate-0/
 
 Should we release this?
 
 Patrick

Re: [Fwd: [VOTE] Release ZooKeeper 3.2.2 (candidate 0)]

2009-12-01 Thread Mahadev Konar

-1 

http://issues.apache.org/jira/browse/ZOOKEEPER-597 exposes a critical bug
and should be included in the fix for both 3.2.2 and 3.1.2.

Thanks
mahadev




On 11/25/09 9:03 AM, Flavio Junqueira f...@yahoo-inc.com wrote:

 +1. I also ran ant test.
 
 -Flavio
 
 On Nov 25, 2009, at 4:17 AM, Mahadev Konar wrote:
 
 +1 for the release. Ran ant test and some smoke tests it worked fine.
 
 mahadev
 
 
 On 11/24/09 7:54 AM, stack st...@duboce.net wrote:
 
 +1 Ran it in place of zk-3.2.1 in hbase context for an upload and
 nothing
 untoward examining logs.  Took a quick gander at the doc. and nothing
 obviously amiss.
 
 St.Ack
 
 
 
 On Mon, Nov 23, 2009 at 4:53 PM, Patrick Hunt ph...@apache.org
 wrote:
 
 Hadoop PMC,
 
 Please test and vote on this release in zookeeper-dev list.
 
 Thanks,
 
 Patrick
 
 I've created a candidate build for ZooKeeper 3.2.2. This is a bug
 fix
 release addressing eleven issues (two critical) -- see the release
 notes for
 details.
 
 *** Please download, test and VOTE before the
 *** vote closes 5pm pacific time, Friday, November 27.***
 
 http://people.apache.org/~phunt/zookeeper-3.2.2-candidate-0/http://people.
 ap
 ache.org/%7Ephunt/zookeeper-3.2.2-candidate-0/
 
 Should we release this?
 
 Patrick

[jira] Commented: (ZOOKEEPER-603) zkpython should do a better job of freeing memory under error conditions


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784404#action_12784404
 ] 

Mahadev konar commented on ZOOKEEPER-603:
-

henry,
 should this be marked for 3.3? Does not look like a blocker or does it?

 zkpython should do a better job of freeing memory under error conditions
 

 Key: ZOOKEEPER-603
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-603
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Henry Robinson
 Fix For: 3.2.2


 The general pattern is that the construction of a collection might fail, but 
 the module is not freeing the memory that it has already allocated. 
 Exceptions that are raised during this process aren't always propagated back 
 to the Python side either. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-604) zk needs to prevent export of any symbol not listed in their api

2009-12-01 Thread Alex Newman (JIRA)

zk needs to prevent export of any symbol not listed in their api


 Key: ZOOKEEPER-604
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-604
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1, 3.2.0, 3.1.1, 3.1.0, 3.0.1, 3.0.0, 3.1.2, 3.2.2, 
3.3.0, 4.0.0
 Environment: linux amd64
Reporter: Alex Newman


Currently the zookeeper seems to be exporting symbols not in the api. An 
example of this seems to be the symbol hash, which interferes with me using 
memcached and zookeeper in the same program.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-604) zk needs to prevent export of any symbol not listed in their api

2009-12-01 Thread Alex Newman (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Newman updated ZOOKEEPER-604:
--

Environment: All  (was: linux amd64)

 zk needs to prevent export of any symbol not listed in their api
 

 Key: ZOOKEEPER-604
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-604
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1, 3.2.2, 
 3.3.0, 4.0.0
 Environment: All
Reporter: Alex Newman

 Currently the zookeeper seems to be exporting symbols not in the api. An 
 example of this seems to be the symbol hash, which interferes with me using 
 memcached and zookeeper in the same program.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-604) zk needs to prevent export of any symbol not listed in their api

2009-12-01 Thread Alex Newman (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784422#action_12784422
 ] 

Alex Newman commented on ZOOKEEPER-604:
---

From a developer, the symbol was named hash, but basically they should work 
with the whitelist of functions in their zookeeper.h

 zk needs to prevent export of any symbol not listed in their api
 

 Key: ZOOKEEPER-604
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-604
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1, 3.2.2, 
 3.3.0, 4.0.0
 Environment: All
Reporter: Alex Newman

 Currently the zookeeper seems to be exporting symbols not in the api. An 
 example of this seems to be the symbol hash, which interferes with me using 
 memcached and zookeeper in the same program.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-603) zkpython should do a better job of freeing memory under error conditions


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-603:
-

Fix Version/s: (was: 3.2.2)
   3.3.0

 zkpython should do a better job of freeing memory under error conditions
 

 Key: ZOOKEEPER-603
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-603
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Henry Robinson
 Fix For: 3.3.0


 The general pattern is that the construction of a collection might fail, but 
 the module is not freeing the memory that it has already allocated. 
 Exceptions that are raised during this process aren't always propagated back 
 to the Python side either. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-603) zkpython should do a better job of freeing memory under error conditions


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784431#action_12784431
 ] 

Henry Robinson commented on ZOOKEEPER-603:
--

You're right - this shouldn't block. Marked it for 3.3.

 zkpython should do a better job of freeing memory under error conditions
 

 Key: ZOOKEEPER-603
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-603
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Henry Robinson
 Fix For: 3.3.0


 The general pattern is that the construction of a collection might fail, but 
 the module is not freeing the memory that it has already allocated. 
 Exceptions that are raised during this process aren't always propagated back 
 to the Python side either. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-604) zk needs to prevent export of any symbol not listed in their api


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-604:


Fix Version/s: 3.3.0

alex,
  do you plan to upload a patch for this? 

 zk needs to prevent export of any symbol not listed in their api
 

 Key: ZOOKEEPER-604
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-604
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1, 3.2.2, 
 3.3.0, 4.0.0
 Environment: All
Reporter: Alex Newman
 Fix For: 3.3.0


 Currently the zookeeper seems to be exporting symbols not in the api. An 
 example of this seems to be the symbol hash, which interferes with me using 
 memcached and zookeeper in the same program.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-604) zk needs to prevent export of any symbol not listed in their api


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12784457#action_12784457
 ] 

Patrick Hunt commented on ZOOKEEPER-604:


Bummer -- +1 on fixing this for 3.3.0. Alex it would be great if you could 
provide a patch given you can verify and also are on the cusp of the issue.

 zk needs to prevent export of any symbol not listed in their api
 

 Key: ZOOKEEPER-604
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-604
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1, 3.2.2, 
 3.3.0, 4.0.0
 Environment: All
Reporter: Alex Newman
 Fix For: 3.3.0


 Currently the zookeeper seems to be exporting symbols not in the api. An 
 example of this seems to be the symbol hash, which interferes with me using 
 memcached and zookeeper in the same program.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-604) zk needs to prevent export of any symbol not listed in their api


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-604:
---

Priority: Critical  (was: Major)

 zk needs to prevent export of any symbol not listed in their api
 

 Key: ZOOKEEPER-604
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-604
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1, 3.2.2, 
 3.3.0, 4.0.0
 Environment: All
Reporter: Alex Newman
Priority: Critical
 Fix For: 3.3.0


 Currently the zookeeper seems to be exporting symbols not in the api. An 
 example of this seems to be the symbol hash, which interferes with me using 
 memcached and zookeeper in the same program.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-605) remove datatreebuilder classes from the codebase.

remove datatreebuilder classes from the codebase.
-

 Key: ZOOKEEPER-605
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-605
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Mahadev konar
Assignee: Mahadev konar
 Fix For: 3.3.0


the current trunk has datatreebuilder classes which adds an unnecessary layer 
of abastraction without any need for it. It just causes confusion and 
unreadable code. We should get rid of these classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-606) bin scripts don't work in cygwin (spaces in paths)

bin scripts don't work in cygwin (spaces in paths)
--

 Key: ZOOKEEPER-606
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-606
 Project: Zookeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.2.1
Reporter: Patrick Hunt
 Fix For: 3.3.0


the scripts in bin fail under cygwin due to spaces not handled properly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-606) bin scripts don't work in cygwin (spaces in paths)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-606:
---

Attachment: ZOOKEEPER-606.patch

this patch:

1) fixes the spaces
2) fixes the need for wndows java to have ; in classpath
3) fixes kill command on cygwin

 bin scripts don't work in cygwin (spaces in paths)
 --

 Key: ZOOKEEPER-606
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-606
 Project: Zookeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.2.1
Reporter: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-606.patch


 the scripts in bin fail under cygwin due to spaces not handled properly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-606) bin scripts don't work in cygwin (spaces in paths)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-606:
---

Assignee: Patrick Hunt
  Status: Patch Available  (was: Open)

Seems to work on unix as well (ubuntu), submitting.

 bin scripts don't work in cygwin (spaces in paths)
 --

 Key: ZOOKEEPER-606
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-606
 Project: Zookeeper
  Issue Type: Bug
  Components: scripts
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-606.patch


 the scripts in bin fail under cygwin due to spaces not handled properly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-458:


Status: Open  (was: Patch Available)

the tests pass for me on linux. ill try hudson again to see if the failure is 
consistent or not.

 connect_index in zookeeper handle might get out of bound.
 -

 Key: ZOOKEEPER-458
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, 
 ZOOKEEPER-458.patch, ZOOKEEPER-458.patch


 connect_index in zookeeper handle might get out of bound. the zokoeeper_init 
 method checks for index == count and sets it to zero. If the index becomes 
 greater than count, then it will go out of bounds.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-606) bin scripts don't work in cygwin (spaces in paths)