[jira] Commented: (ZOOKEEPER-747) Add C# generation to Jute

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860081#action_12860081
 ] 

Hadoop QA commented on ZOOKEEPER-747:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442635/ZOOKEEPER-747.patch
  against trunk revision 936624.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/70/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/70/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/70/console

This message is automatically generated.

> Add C# generation to Jute
> -
>
> Key: ZOOKEEPER-747
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: jute
>Reporter: Eric Hauser
>Assignee: Eric Hauser
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-747.patch
>
>
> The following patch adds a new language, C#, to the Jute code generation.  
> The code that is generated does have a dependency on a third party library, 
> Jon Skeet's MiscUtil, which is Apache licensed.  The library is necessary 
> because C# does not provide big endian support in the base class libraries.
> As none of the existing Jute code has any unit tests, I have not added tests 
> for this patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-747) Add C# generation to Jute

[Eric Hauser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Hauser updated ZOOKEEPER-747:
--

Attachment: ZOOKEEPER-747.patch

> Add C# generation to Jute
> -
>
> Key: ZOOKEEPER-747
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: jute
>Reporter: Eric Hauser
>Assignee: Eric Hauser
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-747.patch
>
>
> The following patch adds a new language, C#, to the Jute code generation.  
> The code that is generated does have a dependency on a third party library, 
> Jon Skeet's MiscUtil, which is Apache licensed.  The library is necessary 
> because C# does not provide big endian support in the base class libraries.
> As none of the existing Jute code has any unit tests, I have not added tests 
> for this patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-747) Add C# generation to Jute

[Eric Hauser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Hauser updated ZOOKEEPER-747:
--

Attachment: (was: ZOOKEEPER-747.patch)

> Add C# generation to Jute
> -
>
> Key: ZOOKEEPER-747
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: jute
>Reporter: Eric Hauser
>Assignee: Eric Hauser
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-747.patch
>
>
> The following patch adds a new language, C#, to the Jute code generation.  
> The code that is generated does have a dependency on a third party library, 
> Jon Skeet's MiscUtil, which is Apache licensed.  The library is necessary 
> because C# does not provide big endian support in the base class libraries.
> As none of the existing Jute code has any unit tests, I have not added tests 
> for this patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-747) Add C# generation to Jute

[Eric Hauser (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Hauser updated ZOOKEEPER-747:
--

Status: Patch Available  (was: Open)

Should be all set now.

> Add C# generation to Jute
> -
>
> Key: ZOOKEEPER-747
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: jute
>Reporter: Eric Hauser
>Assignee: Eric Hauser
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-747.patch
>
>
> The following patch adds a new language, C#, to the Jute code generation.  
> The code that is generated does have a dependency on a third party library, 
> Jon Skeet's MiscUtil, which is Apache licensed.  The library is necessary 
> because C# does not provide big endian support in the base class libraries.
> As none of the existing Jute code has any unit tests, I have not added tests 
> for this patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-752) address use of "recoverable" vs "revocable" in lock recipes documentation

[Patrick Hunt (JIRA)]

address use of "recoverable" vs "revocable" in lock recipes documentation
-

 Key: ZOOKEEPER-752
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-752
 Project: Zookeeper
  Issue Type: Bug
  Components: documentation
Affects Versions: 3.3.0
Reporter: Patrick Hunt
 Fix For: 3.4.0


http://hadoop.apache.org/zookeeper/docs/r3.3.0/recipes.html#sc_recoverableSharedLocks
uses the heading "recoverable" locks, but the text refers to "revocable".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-751) Recipe heading refers to 'recoverable' but should be 'revocable'

[Adam Rosien (JIRA)]

Recipe heading refers to 'recoverable' but should be 'revocable'


 Key: ZOOKEEPER-751
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-751
 Project: Zookeeper
  Issue Type: Improvement
  Components: documentation
Affects Versions: 3.3.0
Reporter: Adam Rosien
Priority: Minor


http://hadoop.apache.org/zookeeper/docs/r3.3.0/recipes.html#sc_recoverableSharedLocks
 uses the heading "recoverable" locks, but the text refers to "revocable".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-734) QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle windows path correctly

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859954#action_12859954
 ] 

Hadoop QA commented on ZOOKEEPER-734:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442606/ZOOKEEPER-734.patch
  against trunk revision 936624.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/69/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/69/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/69/console

This message is automatically generated.

> QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle 
> windows path correctly
> -
>
> Key: ZOOKEEPER-734
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-734
> Project: Zookeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.3.0
> Environment: Windows 32-bit
>Reporter: Vishal K
>Assignee: Vishal K
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-734.patch
>
>
> While runniing "ant test-core-java" QuorumPeerTestBase.java and 
> ZooKeeperServerMainTest.java fail. The problem seems to be in 
> ZookeeperserverMainTest.java:MainThread():66 and in 
> QuorumPeerBaseTest.java:MainThread:76.
> FileWriter.write() writes windows path to the conf file. Java does not like 
> windows path. Therefore, the test complains that it cannot find myid and 
> fails. 
> Solution - convert windows path to UNIX path. This worked for me on windows.  
> Diffs are attached below. Solution not tested on Linux since for some reason 
> build is failing (due to problems not related to this change).
> vmc-floorb-dhcp116-114:/opt/zksrc/zookeeper-3.3.0/src/java/test/org/apache/zookeeper/server
>  # svn diff
> Index: ZooKeeperServerMainTest.java
> ===
> --- ZooKeeperServerMainTest.java  (revision 931240)
> +++ ZooKeeperServerMainTest.java  (working copy)
> @@ -61,7 +61,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.flush();
> Index: quorum/QuorumPeerTestBase.java
> ===
> --- quorum/QuorumPeerTestBase.java(revision 931240)
> +++ quorum/QuorumPeerTestBase.java(working copy)
> @@ -73,7 +73,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("Unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.write(quorumCfgSection + "\n");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-734) QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle windows path correctly

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-734:
---

Status: Patch Available  (was: Open)

Thanks Vishal, appreciated!

Btw, once you have a patch that you think is ready, just go ahead and "submit 
patch" on the left hand side (link).
This will run the patch through the automated tests and advance the workflow 
(so the committers will review,
perhaps provide feedback if changes need to be made, then eventually commit).

Thanks!

> QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle 
> windows path correctly
> -
>
> Key: ZOOKEEPER-734
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-734
> Project: Zookeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.3.0
> Environment: Windows 32-bit
>Reporter: Vishal K
>Assignee: Vishal K
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-734.patch
>
>
> While runniing "ant test-core-java" QuorumPeerTestBase.java and 
> ZooKeeperServerMainTest.java fail. The problem seems to be in 
> ZookeeperserverMainTest.java:MainThread():66 and in 
> QuorumPeerBaseTest.java:MainThread:76.
> FileWriter.write() writes windows path to the conf file. Java does not like 
> windows path. Therefore, the test complains that it cannot find myid and 
> fails. 
> Solution - convert windows path to UNIX path. This worked for me on windows.  
> Diffs are attached below. Solution not tested on Linux since for some reason 
> build is failing (due to problems not related to this change).
> vmc-floorb-dhcp116-114:/opt/zksrc/zookeeper-3.3.0/src/java/test/org/apache/zookeeper/server
>  # svn diff
> Index: ZooKeeperServerMainTest.java
> ===
> --- ZooKeeperServerMainTest.java  (revision 931240)
> +++ ZooKeeperServerMainTest.java  (working copy)
> @@ -61,7 +61,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.flush();
> Index: quorum/QuorumPeerTestBase.java
> ===
> --- quorum/QuorumPeerTestBase.java(revision 931240)
> +++ quorum/QuorumPeerTestBase.java(working copy)
> @@ -73,7 +73,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("Unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.write(quorumCfgSection + "\n");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: .NET client

[Eric Hauser]

I have not open a JIRA ticket yet.  All of my latest code is available in my
ZK fork on Github if you want it:

http://github.com/ewhauser/zookeeper/


--
Eric Hauser
Cell: (317) 679-4766


On Thu, Apr 22, 2010 at 12:50 PM, Mahadev Konar wrote:

> Good to see this
>
> Eric, do you have an open jira for client bindings?
>
>
> Thanks
> mahadev
>
>
> On 4/21/10 8:32 PM, "Eric Hauser"  wrote:
>
> > I submitted the Jute changes back as ZOOKEEPER-747.
> >
> > Regarding contrib, I'd be happy to submit the client bindings back once I
> do
> > a bit more cleanup.
> >
> > On Mon, Apr 19, 2010 at 1:11 PM, Patrick Hunt  wrote:
> >
> >> Hi Eric, this sounds great! Please consider submitting the client
> binding
> >> back, you could start it as a contrib package (src/contrib) until things
> >> settle and you get some usage. We recently have been seeing interest in
> >> running ZK on windows servers, so having .net would be awesome.
> >> http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
> >>
> >> It would be nice to see the Jute support, btw this is a port of Hadoop's
> >> "recordio" package from a few years ago. We are actually looking to move
> to
> >> Avro at some point, I'm sure they would love to have .net support as
> well.
> >>
> >> Regards,
> >>
> >> Patrick
> >>
> >>
> >> On 04/15/2010 05:55 PM, Eric Hauser wrote:
> >>
> >>> Hi,
> >>>
> >>> I've ported the Java ZK client to .NET.  It's available for forking at
> >>> http://github.com/ewhauser/zookeeper/.  It is still in very early
> stages,
> >>> but all of the client tests that I have ported complete successfully -
> >>> both
> >>> normal calls and watches are working successfully.  Some things to keep
> in
> >>> mind:
> >>>
> >>> - It's not actively being used at the moment
> >>> - I have not had any chance to do any performance testing
> >>> - The API will definitely be changing.  I've ported watches over as is
> in
> >>> order to get everything working, but I'll be changing that to use
> events
> >>> instead to make it more .NET-like.
> >>> - There are not any asynchronous methods on the ZK client API -- async
> >>> method calls are easy to do .NET.  May add a wrapper for it at some
> point.
> >>>
> >>> If there is any interest in having any part of my work go back into
> trunk,
> >>> I'm happy to sign the ASF release.  In particular, it would be nice if
> the
> >>> C# support I added to Jute made it back into the core code base.
> >>>
> >>>
>
>

[jira] Assigned: (ZOOKEEPER-734) QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle windows path correctly

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-734:
--

Assignee: Vishal K

> QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle 
> windows path correctly
> -
>
> Key: ZOOKEEPER-734
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-734
> Project: Zookeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.3.0
> Environment: Windows 32-bit
>Reporter: Vishal K
>Assignee: Vishal K
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-734.patch
>
>
> While runniing "ant test-core-java" QuorumPeerTestBase.java and 
> ZooKeeperServerMainTest.java fail. The problem seems to be in 
> ZookeeperserverMainTest.java:MainThread():66 and in 
> QuorumPeerBaseTest.java:MainThread:76.
> FileWriter.write() writes windows path to the conf file. Java does not like 
> windows path. Therefore, the test complains that it cannot find myid and 
> fails. 
> Solution - convert windows path to UNIX path. This worked for me on windows.  
> Diffs are attached below. Solution not tested on Linux since for some reason 
> build is failing (due to problems not related to this change).
> vmc-floorb-dhcp116-114:/opt/zksrc/zookeeper-3.3.0/src/java/test/org/apache/zookeeper/server
>  # svn diff
> Index: ZooKeeperServerMainTest.java
> ===
> --- ZooKeeperServerMainTest.java  (revision 931240)
> +++ ZooKeeperServerMainTest.java  (working copy)
> @@ -61,7 +61,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.flush();
> Index: quorum/QuorumPeerTestBase.java
> ===
> --- quorum/QuorumPeerTestBase.java(revision 931240)
> +++ quorum/QuorumPeerTestBase.java(working copy)
> @@ -73,7 +73,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("Unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.write(quorumCfgSection + "\n");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859941#action_12859941
 ] 

Hadoop QA commented on ZOOKEEPER-738:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442124/semi.patch
  against trunk revision 936624.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/147/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/147/console

This message is automatically generated.

> zookeeper.jute.h fails to compile with -pedantic 
> -
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-734) QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle windows path correctly

[Vishal K (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vishal K updated ZOOKEEPER-734:
---

Attachment: ZOOKEEPER-734.patch

Request for review.

There is probably a better way to handle backlashes in Windows. I tried a use 
properties (file.separator etc), but didn't work. So finally decided to do it 
the dumb way. Replace "\\" with "/". If we done replace backslash, then java 
considers it as escape sequence and essentially the backslash gets removed.

Please, feel free to drop the patch If there is a better way to handle it.

> QuorumPeerTestBase.java and ZooKeeperServerMainTest.java do not handle 
> windows path correctly
> -
>
> Key: ZOOKEEPER-734
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-734
> Project: Zookeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.3.0
> Environment: Windows 32-bit
>Reporter: Vishal K
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-734.patch
>
>
> While runniing "ant test-core-java" QuorumPeerTestBase.java and 
> ZooKeeperServerMainTest.java fail. The problem seems to be in 
> ZookeeperserverMainTest.java:MainThread():66 and in 
> QuorumPeerBaseTest.java:MainThread:76.
> FileWriter.write() writes windows path to the conf file. Java does not like 
> windows path. Therefore, the test complains that it cannot find myid and 
> fails. 
> Solution - convert windows path to UNIX path. This worked for me on windows.  
> Diffs are attached below. Solution not tested on Linux since for some reason 
> build is failing (due to problems not related to this change).
> vmc-floorb-dhcp116-114:/opt/zksrc/zookeeper-3.3.0/src/java/test/org/apache/zookeeper/server
>  # svn diff
> Index: ZooKeeperServerMainTest.java
> ===
> --- ZooKeeperServerMainTest.java  (revision 931240)
> +++ ZooKeeperServerMainTest.java  (working copy)
> @@ -61,7 +61,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.flush();
> Index: quorum/QuorumPeerTestBase.java
> ===
> --- quorum/QuorumPeerTestBase.java(revision 931240)
> +++ quorum/QuorumPeerTestBase.java(working copy)
> @@ -73,7 +73,8 @@
>  if (!dataDir.mkdir()) {
>  throw new IOException("Unable to mkdir " + dataDir);
>  }
> -fwriter.write("dataDir=" + dataDir.toString() + "\n");
> +String data = dataDir.toString().replace('\\', '/');
> +fwriter.write("dataDir=" + data + "\n");
>  
>  fwriter.write("clientPort=" + clientPort + "\n");
>  fwriter.write(quorumCfgSection + "\n");

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859927#action_12859927
 ] 

Hadoop QA commented on ZOOKEEPER-737:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442478/ZOOKEEPER-737.patch
  against trunk revision 936624.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/68/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/68/console

This message is automatically generated.

> some 4 letter words may fail with netcat (nc)
> -
>
> Key: ZOOKEEPER-737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, 
> ZOOKEEPER-737.patch, ZOOKEEPER-737.patch
>
>
> nc closes the write channel as soon as it's sent it's information, for 
> example "echo stat|nc localhost 2181"
> in general this is fine, however the server code will close the socket as 
> soon as it receives notice that nc has
> closed it's write channel. if not all the 4 letter word result has been 
> written back to the client yet, this will cause
> some or all of the result to be lost - ie the client will not see the full 
> result. this was introduced in 3.3.0 as part
> of a change to reduce blocking of the selector by long running 4letter words.
> here's an example of the logs from the server during this
> echo -n stat | nc localhost 2181
> 2010-04-09 21:55:36,124 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - 
> Accepted socket connection from /127.0.0.1:42179
> 2010-04-09 21:55:36,124 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing 
> stat command from /127.0.0.1:42179
> 2010-04-09 21:55:36,125 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - 
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> 2010-04-09 21:55:36,125 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed 
> socket connection for client /127.0.0.1:42179 (no session established for 
> client)
> [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR 
> [Thread-15:nioserverc...@422] - Unexpected Exception: 
> java.nio.channels.CancelledKeyException
>   at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
>   at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945)
>   at java.io.BufferedWriter.flush(BufferedWriter.java:236)
>   at java.io.PrintWriter.flush(PrintWriter.java:276)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089)
> 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - 
> Thread Thread[Thread-15,5,main] died
> java.nio.channels.CancelledKeyException
>   at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
>   at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945)
>   at java.io.BufferedWriter.flush(BufferedWriter.java:236)
>   at java.io.PrintWriter

[jira] Commented: (ZOOKEEPER-746) learner outputs session id to log in dec (should be hex)

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859924#action_12859924
 ] 

Hadoop QA commented on ZOOKEEPER-746:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442513/ZOOKEEPER-746.patch
  against trunk revision 936624.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/146/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/146/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/146/console

This message is automatically generated.

> learner outputs session id to log in dec (should be hex)
> 
>
> Key: ZOOKEEPER-746
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-746
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-746.patch
>
>
> usability issue, should be in hex:
> 2010-04-21 11:31:13,827 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11354:lear...@95] - Revalidating 
> client: 83353578391797760

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in binary only jar

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-749:
---

Status: Patch Available  (was: Open)

> OSGi metadata not included in binary only jar
> -
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar 
> (zookeeper-.jar) but not in the binary only
> jar (zookeeper--bin.jar) which is eventually deployed to the maven 
> repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-738:
---

Status: Patch Available  (was: Open)

> zookeeper.jute.h fails to compile with -pedantic 
> -
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-738:
---

Status: Open  (was: Patch Available)

> zookeeper.jute.h fails to compile with -pedantic 
> -
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-746) learner outputs session id to log in dec (should be hex)

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-746:
---

Status: Patch Available  (was: Open)

> learner outputs session id to log in dec (should be hex)
> 
>
> Key: ZOOKEEPER-746
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-746
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-746.patch
>
>
> usability issue, should be in hex:
> 2010-04-21 11:31:13,827 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11354:lear...@95] - Revalidating 
> client: 83353578391797760

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-746) learner outputs session id to log in dec (should be hex)

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-746:
---

Status: Open  (was: Patch Available)

> learner outputs session id to log in dec (should be hex)
> 
>
> Key: ZOOKEEPER-746
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-746
> Project: Zookeeper
>  Issue Type: Bug
>  Components: quorum, server
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-746.patch
>
>
> usability issue, should be in hex:
> 2010-04-21 11:31:13,827 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11354:lear...@95] - Revalidating 
> client: 83353578391797760

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in binary only jar

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-749:
---

Status: Open  (was: Patch Available)

> OSGi metadata not included in binary only jar
> -
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar 
> (zookeeper-.jar) but not in the binary only
> jar (zookeeper--bin.jar) which is eventually deployed to the maven 
> repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-737:
---

Status: Patch Available  (was: Open)

> some 4 letter words may fail with netcat (nc)
> -
>
> Key: ZOOKEEPER-737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, 
> ZOOKEEPER-737.patch, ZOOKEEPER-737.patch
>
>
> nc closes the write channel as soon as it's sent it's information, for 
> example "echo stat|nc localhost 2181"
> in general this is fine, however the server code will close the socket as 
> soon as it receives notice that nc has
> closed it's write channel. if not all the 4 letter word result has been 
> written back to the client yet, this will cause
> some or all of the result to be lost - ie the client will not see the full 
> result. this was introduced in 3.3.0 as part
> of a change to reduce blocking of the selector by long running 4letter words.
> here's an example of the logs from the server during this
> echo -n stat | nc localhost 2181
> 2010-04-09 21:55:36,124 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - 
> Accepted socket connection from /127.0.0.1:42179
> 2010-04-09 21:55:36,124 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing 
> stat command from /127.0.0.1:42179
> 2010-04-09 21:55:36,125 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - 
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> 2010-04-09 21:55:36,125 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed 
> socket connection for client /127.0.0.1:42179 (no session established for 
> client)
> [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR 
> [Thread-15:nioserverc...@422] - Unexpected Exception: 
> java.nio.channels.CancelledKeyException
>   at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
>   at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945)
>   at java.io.BufferedWriter.flush(BufferedWriter.java:236)
>   at java.io.PrintWriter.flush(PrintWriter.java:276)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089)
> 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - 
> Thread Thread[Thread-15,5,main] died
> java.nio.channels.CancelledKeyException
>   at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
>   at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945)
>   at java.io.BufferedWriter.flush(BufferedWriter.java:236)
>   at java.io.PrintWriter.flush(PrintWriter.java:276)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-737) some 4 letter words may fail with netcat (nc)

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-737:
---

Status: Open  (was: Patch Available)

> some 4 letter words may fail with netcat (nc)
> -
>
> Key: ZOOKEEPER-737
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-737
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-737.patch, ZOOKEEPER-737.patch, 
> ZOOKEEPER-737.patch, ZOOKEEPER-737.patch
>
>
> nc closes the write channel as soon as it's sent it's information, for 
> example "echo stat|nc localhost 2181"
> in general this is fine, however the server code will close the socket as 
> soon as it receives notice that nc has
> closed it's write channel. if not all the 4 letter word result has been 
> written back to the client yet, this will cause
> some or all of the result to be lost - ie the client will not see the full 
> result. this was introduced in 3.3.0 as part
> of a change to reduce blocking of the selector by long running 4letter words.
> here's an example of the logs from the server during this
> echo -n stat | nc localhost 2181
> 2010-04-09 21:55:36,124 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioservercnxn$fact...@251] - 
> Accepted socket connection from /127.0.0.1:42179
> 2010-04-09 21:55:36,124 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@968] - Processing 
> stat command from /127.0.0.1:42179
> 2010-04-09 21:55:36,125 - WARN  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@606] - 
> EndOfStreamException: Unable to read additional data from client sessionid 
> 0x0, likely client has closed socket
> 2010-04-09 21:55:36,125 - INFO  
> [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:nioserverc...@1286] - Closed 
> socket connection for client /127.0.0.1:42179 (no session established for 
> client)
> [ph...@gsbl90850 zookeeper-3.3.0]$ 2010-04-09 21:55:36,126 - ERROR 
> [Thread-15:nioserverc...@422] - Unexpected Exception: 
> java.nio.channels.CancelledKeyException
>   at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
>   at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:59)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn.sendBuffer(NIOServerCnxn.java:395)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:907)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945)
>   at java.io.BufferedWriter.flush(BufferedWriter.java:236)
>   at java.io.PrintWriter.flush(PrintWriter.java:276)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089)
> 2010-04-09 21:55:36,126 - ERROR [Thread-15:nioservercnxn$factor...@82] - 
> Thread Thread[Thread-15,5,main] died
> java.nio.channels.CancelledKeyException
>   at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:55)
>   at sun.nio.ch.SelectionKeyImpl.interestOps(SelectionKeyImpl.java:64)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.wakeup(NIOServerCnxn.java:927)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.checkFlush(NIOServerCnxn.java:909)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$SendBufferWriter.flush(NIOServerCnxn.java:945)
>   at java.io.BufferedWriter.flush(BufferedWriter.java:236)
>   at java.io.PrintWriter.flush(PrintWriter.java:276)
>   at 
> org.apache.zookeeper.server.NIOServerCnxn$2.run(NIOServerCnxn.java:1089)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859912#action_12859912
 ] 

Hadoop QA commented on ZOOKEEPER-738:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442124/semi.patch
  against trunk revision 936624.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/67/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/67/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/67/console

This message is automatically generated.

> zookeeper.jute.h fails to compile with -pedantic 
> -
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-738:
--

Assignee: Jozef Hatala  (was: Patrick Hunt)

> zookeeper.jute.h fails to compile with -pedantic 
> -
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-738:
---

Status: Patch Available  (was: Open)

> zookeeper.jute.h fails to compile with -pedantic 
> -
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-749) OSGi metadata not included in binary only jar

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859904#action_12859904
 ] 

Hadoop QA commented on ZOOKEEPER-749:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12442587/ZOOKEEPER-749.patch
  against trunk revision 936624.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/66/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/66/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/66/console

This message is automatically generated.

> OSGi metadata not included in binary only jar
> -
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar 
> (zookeeper-.jar) but not in the binary only
> jar (zookeeper--bin.jar) which is eventually deployed to the maven 
> repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859894#action_12859894
 ] 

Patrick Hunt commented on ZOOKEEPER-425:


Chris thanks for the report, new jira created to address: ZOOKEEPER-749

> Add OSGi metadata to zookeeper.jar
> --
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: David Bosschaert
>Assignee: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> 
>   ZooKeeper bundle
>   This bundle contains the ZooKeeper 
> library
>   org.apache.hadoop.zookeeper
>   3.1.1
>   *
>   *;version=3.1.1
> 
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: .NET client

[Mahadev Konar]

Good to see this

Eric, do you have an open jira for client bindings?


Thanks
mahadev


On 4/21/10 8:32 PM, "Eric Hauser"  wrote:

> I submitted the Jute changes back as ZOOKEEPER-747.
> 
> Regarding contrib, I'd be happy to submit the client bindings back once I do
> a bit more cleanup.
> 
> On Mon, Apr 19, 2010 at 1:11 PM, Patrick Hunt  wrote:
> 
>> Hi Eric, this sounds great! Please consider submitting the client binding
>> back, you could start it as a contrib package (src/contrib) until things
>> settle and you get some usage. We recently have been seeing interest in
>> running ZK on windows servers, so having .net would be awesome.
>> http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
>> 
>> It would be nice to see the Jute support, btw this is a port of Hadoop's
>> "recordio" package from a few years ago. We are actually looking to move to
>> Avro at some point, I'm sure they would love to have .net support as well.
>> 
>> Regards,
>> 
>> Patrick
>> 
>> 
>> On 04/15/2010 05:55 PM, Eric Hauser wrote:
>> 
>>> Hi,
>>> 
>>> I've ported the Java ZK client to .NET.  It's available for forking at
>>> http://github.com/ewhauser/zookeeper/.  It is still in very early stages,
>>> but all of the client tests that I have ported complete successfully -
>>> both
>>> normal calls and watches are working successfully.  Some things to keep in
>>> mind:
>>> 
>>> - It's not actively being used at the moment
>>> - I have not had any chance to do any performance testing
>>> - The API will definitely be changing.  I've ported watches over as is in
>>> order to get everything working, but I'll be changing that to use events
>>> instead to make it more .NET-like.
>>> - There are not any asynchronous methods on the ZK client API -- async
>>> method calls are easy to do .NET.  May add a wrapper for it at some point.
>>> 
>>> If there is any interest in having any part of my work go back into trunk,
>>> I'm happy to sign the ASF release.  In particular, it would be nice if the
>>> C# support I added to Jute made it back into the core code base.
>>> 
>>> 

[jira] Updated: (ZOOKEEPER-750) move maven artifacts into "dist-maven" subdir of the release (package target)

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-750:
---

Fix Version/s: 3.4.0

> move maven artifacts into "dist-maven" subdir of the release (package target)
> -
>
> Key: ZOOKEEPER-750
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-750
> Project: Zookeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.1, 3.4.0
>
>
> The maven artifacts are currently (3.3.0) put into the toplevel of the 
> release. This causes confusion
> amonst new users (ie "which jar do I use?"). Also the naming of the bin jar 
> is wrong for maven (to put
> onto the maven repo it must be named without the -bin) which adds extra 
> burden for the release
> manager. Putting into a subdir fixes this and makes it explicit what's being 
> deployed to maven repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in binary only jar

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-749:
---

Status: Patch Available  (was: Open)

> OSGi metadata not included in binary only jar
> -
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar 
> (zookeeper-.jar) but not in the binary only
> jar (zookeeper--bin.jar) which is eventually deployed to the maven 
> repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-749) OSGi metadata not included in binary only jar

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-749:
---

Attachment: ZOOKEEPER-749.patch

This patch adds the osgi data to the manifest of the maven bin jar.

This patch also includes a fix for ZOOKEEPER-750, plz close that one when you 
close this.

> OSGi metadata not included in binary only jar
> -
>
> Key: ZOOKEEPER-749
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
> Project: Zookeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.3.1, 3.4.0
>
> Attachments: ZOOKEEPER-749.patch
>
>
> See this JIRA/comment for background:
> https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697
> basically the issue is that OSGi metadata is included in the legacy jar 
> (zookeeper-.jar) but not in the binary only
> jar (zookeeper--bin.jar) which is eventually deployed to the maven 
> repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-750) move maven artifacts into "dist-maven" subdir of the release (package target)

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-750:
---

   Assignee: Patrick Hunt
Description: 
The maven artifacts are currently (3.3.0) put into the toplevel of the release. 
This causes confusion
amonst new users (ie "which jar do I use?"). Also the naming of the bin jar is 
wrong for maven (to put
onto the maven repo it must be named without the -bin) which adds extra burden 
for the release
manager. Putting into a subdir fixes this and makes it explicit what's being 
deployed to maven repo.


> move maven artifacts into "dist-maven" subdir of the release (package target)
> -
>
> Key: ZOOKEEPER-750
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-750
> Project: Zookeeper
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.3.1
>
>
> The maven artifacts are currently (3.3.0) put into the toplevel of the 
> release. This causes confusion
> amonst new users (ie "which jar do I use?"). Also the naming of the bin jar 
> is wrong for maven (to put
> onto the maven repo it must be named without the -bin) which adds extra 
> burden for the release
> manager. Putting into a subdir fixes this and makes it explicit what's being 
> deployed to maven repo.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-750) move maven artifacts into "dist-maven" subdir of the release (package target)

[Patrick Hunt (JIRA)]

move maven artifacts into "dist-maven" subdir of the release (package target)
-

 Key: ZOOKEEPER-750
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-750
 Project: Zookeeper
  Issue Type: Bug
  Components: build
Affects Versions: 3.3.0
Reporter: Patrick Hunt
 Fix For: 3.3.1




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-749) OSGi metadata not included in binary only jar

[Patrick Hunt (JIRA)]

OSGi metadata not included in binary only jar
-

 Key: ZOOKEEPER-749
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-749
 Project: Zookeeper
  Issue Type: Bug
  Components: build
Affects Versions: 3.3.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.1, 3.4.0


See this JIRA/comment for background:
https://issues.apache.org/jira/browse/ZOOKEEPER-425?focusedCommentId=12859697&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12859697

basically the issue is that OSGi metadata is included in the legacy jar 
(zookeeper-.jar) but not in the binary only
jar (zookeeper--bin.jar) which is eventually deployed to the maven 
repo.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-425) Add OSGi metadata to zookeeper.jar

[Chris Custine (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859697#action_12859697
 ] 

Chris Custine commented on ZOOKEEPER-425:
-

As of 3.3.0, I see the OSGI meta data in the tar.gz download from the Apache 
mirrors, but it is not in the zookeeper-3.3.0.jar artifact that is deployed to 
the maven central repository here:  
http://repo2.maven.org/maven2/org/apache/hadoop/zookeeper/3.3.0/

> Add OSGi metadata to zookeeper.jar
> --
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: David Bosschaert
>Assignee: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi 
> bundle as well as an ordinary jar file. 
> In the CXF/DOSGi project the buildsystem does this using the 
> maven-bundle-plugin: 
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug, 
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd 
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you 
> should be able to use more or less the same instructions as were used in 
> maven:
> 
>   ZooKeeper bundle
>   This bundle contains the ZooKeeper 
> library
>   org.apache.hadoop.zookeeper
>   3.1.1
>   *
>   *;version=3.1.1
> 
> Oh and one other thing. Is it really necessary to put the source code in the 
> Jar file too? I would put that in a separate source distribution :)
> See also: 
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%3c4a2009b1.3030...@yahoo-inc.com%3e

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-721) No set for log4j dependency in the generated pom.xml

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859690#action_12859690
 ] 

Patrick Hunt commented on ZOOKEEPER-721:


I tried this in ivy.xml but it doesn't effect the generated pom file:


  
  
  
  


any ideas?

> No  set for log4j dependency in the generated pom.xml
> -
>
> Key: ZOOKEEPER-721
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-721
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.3.0
>Reporter: Paolo Castagna
>Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
>
> The generated Maven pom.xml file contains:
> {code}
> 
>   log4j
>   log4j
>   1.2.15
>   compile
> 
> {code}
> It would be better to have:
> {code}
> 
>   log4j
>   log4j
>   1.2.15
>   compile
>   
> 
>   javax.jms
>   jms
> 
> 
>   com.sun.jdmk
>   jmxtools
> 
> 
>   com.sun.jmx
>   jmxri
> 
> 
>   javax.mail
>   mail
> 
>
> 
> {code}
> This would avoid to people depending on ZooKeeper artifacts the pain to 
> exclude such "broken" dependencies by themselves.
> A similar issue is discussed in HADOOP-6629, although I am not clear on how 
> to solve fix it using Ivy.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.