[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883499#action_12883499 ] Ivan Kelly commented on ZOOKEEPER-789: -- The patch attached passes each member of Notification separatedly to printNotification. Would it not be simpler to just pass the whole Notification object to printNotification. This way if the Notification object changes internally, only printNotification needs to be changed. Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated ZOOKEEPER-789: - Attachment: ZOOKEEPER-789.patch Fixed up loggraph parsing, and changed printNotification to take the Notification object itself rather than all the little parts. Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated ZOOKEEPER-789: - Attachment: (was: ZOOKEEPER-789.patch) Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-798) Fixup loggraph for FLE changes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883536#action_12883536 ] Ivan Kelly commented on ZOOKEEPER-798: -- Changes to the loggraph log parsing to allow for flavio's changes to the FLE logging (ZOOKEEPER-789) Fixup loggraph for FLE changes -- Key: ZOOKEEPER-798 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-798 Project: Zookeeper Issue Type: Sub-task Components: contrib Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Minor Attachments: ZOOKEEPER-798.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-798) Fixup loggraph for FLE changes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated ZOOKEEPER-798: - Attachment: ZOOKEEPER-798.patch Fixup loggraph for FLE changes -- Key: ZOOKEEPER-798 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-798 Project: Zookeeper Issue Type: Sub-task Components: contrib Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Minor Attachments: ZOOKEEPER-798.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-798) Fixup loggraph for FLE changes
Fixup loggraph for FLE changes -- Key: ZOOKEEPER-798 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-798 Project: Zookeeper Issue Type: Sub-task Components: contrib Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Minor Attachments: ZOOKEEPER-798.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-798) Fixup loggraph for FLE changes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated ZOOKEEPER-798: - Status: Patch Available (was: Open) Fixup loggraph for FLE changes -- Key: ZOOKEEPER-798 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-798 Project: Zookeeper Issue Type: Sub-task Components: contrib Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Minor Attachments: ZOOKEEPER-798.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-789: - Attachment: ZOOKEEPER-789.patch It is a good suggestion. Uploading a new patch... Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-789: - Status: Open (was: Patch Available) Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-789: - Status: Patch Available (was: Open) Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-797) c client source with AI_ADDRCONFIG cannot be compiled with early glibc
[ https://issues.apache.org/jira/browse/ZOOKEEPER-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883563#action_12883563 ] Hadoop QA commented on ZOOKEEPER-797: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448273/ZOOKEEPER-797.patch against trunk revision 958096. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/89/console This message is automatically generated. c client source with AI_ADDRCONFIG cannot be compiled with early glibc -- Key: ZOOKEEPER-797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-797 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.3.1 Environment: linux 2.6.9 Reporter: Qian Ye Attachments: ZOOKEEPER-797.patch c client source with AI_ADDRCONFIG cannot be compiled with early glibc (before 2.3.3) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883567#action_12883567 ] Hadoop QA commented on ZOOKEEPER-789: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448310/ZOOKEEPER-789.patch against trunk revision 958096. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/126/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/126/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/126/console This message is automatically generated. Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883572#action_12883572 ] Flavio Paiva Junqueira commented on ZOOKEEPER-789: -- There is no need for testing here. This is just a modification to log messages. Improve FLE log messages Key: ZOOKEEPER-789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.3.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.2, 3.4.0 Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, ZOOKEEPER-789.patch Notification messages are quite important to determine what is going with leader election. The main idea of this improvement is name the fields we output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-798) Fixup loggraph for FLE changes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883591#action_12883591 ] Hadoop QA commented on ZOOKEEPER-798: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448307/ZOOKEEPER-798.patch against trunk revision 958096. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/90/console This message is automatically generated. Fixup loggraph for FLE changes -- Key: ZOOKEEPER-798 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-798 Project: Zookeeper Issue Type: Sub-task Components: contrib Reporter: Ivan Kelly Assignee: Ivan Kelly Priority: Minor Attachments: ZOOKEEPER-798.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-797) c client source with AI_ADDRCONFIG cannot be compiled with early glibc
[ https://issues.apache.org/jira/browse/ZOOKEEPER-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883603#action_12883603 ] Qian Ye commented on ZOOKEEPER-797: --- Hi guys, do I need to add any tests for this patch? c client source with AI_ADDRCONFIG cannot be compiled with early glibc -- Key: ZOOKEEPER-797 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-797 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.3.1 Environment: linux 2.6.9 Reporter: Qian Ye Attachments: ZOOKEEPER-797.patch c client source with AI_ADDRCONFIG cannot be compiled with early glibc (before 2.3.3) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-795) eventThread isn't shutdown after a connection session expired event coming
[ https://issues.apache.org/jira/browse/ZOOKEEPER-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Lord updated ZOOKEEPER-795: -- Attachment: ExpiredSessionThreadLeak.java Here is a test class that illustrates the problem using Thread#suspend and Thread#resume to simulate long GC times or other halted JVM problems. There is a simple wrapper around a ZooKeeper client handle that will connect another client in the event that its managed client receives an Expired event. The longer that the test program runs the more runaway EventThreads will be created and displayed. The only dependencies are on the ZooKeeper libraries. eventThread isn't shutdown after a connection session expired event coming Key: ZOOKEEPER-795 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-795 Project: Zookeeper Issue Type: Bug Components: java client Affects Versions: 3.3.1 Environment: ubuntu 10.04 Reporter: mathieu barcikowski Priority: Blocker Fix For: 3.3.2, 3.4.0 Attachments: ExpiredSessionThreadLeak.java Hi, I notice a problem with the eventThread located in ClientCnxn.java file. The eventThread isn't shutdown after a connection session expired event coming (i.e. never receive EventOfDeath). When a session timeout occurs and the session is marked as expired, the connexion is fully closed (socket, SendThread...) expect for the eventThread. As a result, if i create a new zookeeper object and connect through it, I got a zombi thread which will never be kill (as for the previous zookeeper object, the state is already close, calling close again don't do anything). So everytime I will create a new zookeeper connection after a expired session, I will have a one more zombi EventThread. How to reproduce : - Start a zookeeper client connection in debug mode - Pause the jvm enough time to the expired event occur - Watch for example with jvisualvm the list of threads, the sendThread is succesfully killed, but the EventThread go to wait state for a infinity of time - if you reopen a new zookeeper connection, and do again the previous steps, another EventThread will be present in infinite wait state -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-799) Add tools and recipes for monitoring as a contrib
Add tools and recipes for monitoring as a contrib - Key: ZOOKEEPER-799 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-799 Project: Zookeeper Issue Type: New Feature Components: contrib Affects Versions: 3.3.1, 3.3.0, 3.4.0 Reporter: Andrei Savu Assignee: Andrei Savu Tools and Recipes for Monitoring ZooKeeper using Cacti, Nagios or Ganglia. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-799) Add tools and recipes for monitoring as a contrib
[ https://issues.apache.org/jira/browse/ZOOKEEPER-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Savu updated ZOOKEEPER-799: -- Attachment: ZOOKEEPER-799.patch monitoring.tar.gz I've attached a patch and an archive containing all the files in the patch + some screenshots. I'm waiting for your feedback. Add tools and recipes for monitoring as a contrib - Key: ZOOKEEPER-799 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-799 Project: Zookeeper Issue Type: New Feature Components: contrib Affects Versions: 3.3.0, 3.3.1, 3.4.0 Reporter: Andrei Savu Assignee: Andrei Savu Attachments: monitoring.tar.gz, ZOOKEEPER-799.patch Tools and Recipes for Monitoring ZooKeeper using Cacti, Nagios or Ganglia. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-613) add ganglia monitoring support as contrib
[ https://issues.apache.org/jira/browse/ZOOKEEPER-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12883719#action_12883719 ] Andrei Savu commented on ZOOKEEPER-613: --- I think this JIRA should be closed because I have opened ZOOKEEPER-799 and added a patch containing monitoring scripts for multiple platforms: Cacti, Nagios and Ganglia. add ganglia monitoring support as contrib - Key: ZOOKEEPER-613 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-613 Project: Zookeeper Issue Type: Improvement Components: contrib, scripts Reporter: Patrick Hunt It would be great to add ganglia monitoring support for ZooKeeper Cluster. AFAIK this means writing a ganglia plugin that knows how to talk to ZK servers (either JMX, or the command port via 4letterwords) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE
zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE --- Key: ZOOKEEPER-800 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-800 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.3.1 Reporter: Michi Mutsuzaki Priority: Minor This happened when I called zoo_add_auth() immediately after zookeeper_init(). It took me a while to figure out that authentication actually failed since zoo_add_auth() returned ZOK. It should return ZINVALIDSTATE instead. --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
