[jira] Commented: (ZOOKEEPER-900) FLE implementation should be improved to use non-blocking sockets
[ https://issues.apache.org/jira/browse/ZOOKEEPER-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934123#action_12934123 ] Hudson commented on ZOOKEEPER-900: -- Integrated in ZooKeeper-trunk #1010 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1010/]) > FLE implementation should be improved to use non-blocking sockets > - > > Key: ZOOKEEPER-900 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-900 > Project: Zookeeper > Issue Type: Bug >Reporter: Vishal K >Assignee: Vishal K >Priority: Critical > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-900.patch, ZOOKEEPER-900.patch1, > ZOOKEEPER-900.patch2 > > > From earlier email exchanges: > 1. Blocking connects and accepts: > a) The first problem is in manager.toSend(). This invokes connectOne(), which > does a blocking connect. While testing, I changed the code so that > connectOne() starts a new thread called AsyncConnct(). AsyncConnect.run() > does a socketChannel.connect(). After starting AsyncConnect, connectOne > starts a timer. connectOne continues with normal operations if the connection > is established before the timer expires, otherwise, when the timer expires it > interrupts AsyncConnect() thread and returns. In this way, I can have an > upper bound on the amount of time we need to wait for connect to succeed. Of > course, this was a quick fix for my testing. Ideally, we should use Selector > to do non-blocking connects/accepts. I am planning to do that later once we > at least have a quick fix for the problem and consensus from others for the > real fix (this problem is big blocker for us). Note that it is OK to do > blocking IO in SenderWorker and RecvWorker threads since they block IO to the > respective ! peer. > b) The blocking IO problem is not just restricted to connectOne(), but also > in receiveConnection(). The Listener thread calls receiveConnection() for > each incoming connection request. receiveConnection does blocking IO to get > peer's info (s.read(msgBuffer)). Worse, it invokes connectOne() back to the > peer that had sent the connection request. All of this is happening from the > Listener. In short, if a peer fails after initiating a connection, the > Listener thread won't be able to accept connections from other peers, because > it would be stuck in read() or connetOne(). Also the code has an inherent > cycle. initiateConnection() and receiveConnection() will have to be very > carefully synchronized otherwise, we could run into deadlocks. This code is > going to be difficult to maintain/modify. > Also see: https://issues.apache.org/jira/browse/ZOOKEEPER-822 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934122#action_12934122 ] Hudson commented on ZOOKEEPER-926: -- Integrated in ZooKeeper-trunk #1010 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1010/]) > Fork Hadoop common's test-patch.sh and modify for Zookeeper > --- > > Key: ZOOKEEPER-926 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Nigel Daley >Assignee: Nigel Daley > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-926.patch > > > Zookeeper currently uses the test-patch.sh script from the Hadoop nightly > dir. This is now out of date. I propose we just copy the updated one in > Hadoop common and then modify for ZK. This will also help as ZK moves out of > Hadoop to it's own TLP. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non thread safe logging library
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932895#action_12932895 ] Hudson commented on ZOOKEEPER-930: -- Integrated in ZooKeeper-trunk #1005 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1005/]) ZOOKEEPER-930. Hedwig c++ client uses a non thread safe logging library > Hedwig c++ client uses a non thread safe logging library > > > Key: ZOOKEEPER-930 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930 > Project: Zookeeper > Issue Type: Bug > Components: contrib-hedwig >Affects Versions: 3.3.2 >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: ZOOKEEPER-930.patch, ZOOKEEPER-930.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-908) Remove code duplication and inconsistent naming in ClientCnxn.Packet creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931300#action_12931300 ] Hudson commented on ZOOKEEPER-908: -- Integrated in ZooKeeper-trunk #999 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/999/]) ZOOKEEPER-908. Remove code duplication and inconsistent naming in ClientCnxn.Packet creation > Remove code duplication and inconsistent naming in ClientCnxn.Packet creation > - > > Key: ZOOKEEPER-908 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-908 > Project: Zookeeper > Issue Type: Sub-task > Components: server >Reporter: Thomas Koch >Assignee: Thomas Koch >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-908.patch > > > rename record -> request (since their is a counterpart record named > "response") > rename header -> requestHeader (to distinguish from responseHeader) > remove ByteBuffer creation code from primeConnection() method and use the > duplicate code in the Packet constructor. Therefor the Bytebuffer bb > parameter could also be removed from the constructor's parameters. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-909) Extract NIO specific code from ClientCnxn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930821#action_12930821 ] Hudson commented on ZOOKEEPER-909: -- Integrated in ZooKeeper-trunk #997 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/997/]) ZOOKEEPER-909. Extract NIO specific code from ClientCnxn > Extract NIO specific code from ClientCnxn > - > > Key: ZOOKEEPER-909 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909 > Project: Zookeeper > Issue Type: Sub-task > Components: java client >Reporter: Thomas Koch >Assignee: Thomas Koch > Fix For: 3.4.0 > > Attachments: ClientCnxnSocketNetty.java, ZOOKEEPER-909.patch, > ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, > ZOOKEEPER-909.patch > > > This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus > everything Netty related. This means this patch only extract all NIO specific > code in the class ClientCnxnSocketNIO which extends ClientCnxnSocket. > I've redone this patch from current trunk step by step now and couldn't find > any logical error. I've already done a couple of successful test runs and > will continue to do so this night. > It would be nice, if we could apply this patch as soon as possible to trunk. > This allows us to continue to work on the netty integration without blocking > the ClientCnxn class. Adding Netty after this patch should be only a matter > of adding the ClientCnxnSocketNetty class with the appropriate test cases. > You could help me by reviewing the patch and by running it on whatever test > server you have available. Please send me any complete failure log you should > encounter to thomas at koch point ro. Thx! > Update: Until now, I've collected 8 successful builds in a row! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930571#action_12930571 ] Hudson commented on ZOOKEEPER-926: -- Integrated in ZooKeeper-trunk #996 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/996/]) ZOOKEEPER-926. Fork Hadoop common's test-patch.sh and modify for Zookeeper. Update allowed number of warnings. ZOOKEEPER-926. Fork Hadoop common's test-patch.sh and modify for Zookeeper. Remove unneeded params from test-patch.sh. ZOOKEEPER-926. Fork Hadoop common's test-patch.sh and modify for Zookeeper. Updated test-patch.sh and build.xml. Contributed by nigel. > Fork Hadoop common's test-patch.sh and modify for Zookeeper > --- > > Key: ZOOKEEPER-926 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Nigel Daley >Assignee: Nigel Daley > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-926.patch > > > Zookeeper currently uses the test-patch.sh script from the Hadoop nightly > dir. This is now out of date. I propose we just copy the updated one in > Hadoop common and then modify for ZK. This will also help as ZK moves out of > Hadoop to it's own TLP. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930078#action_12930078 ] Hudson commented on ZOOKEEPER-926: -- Integrated in ZooKeeper-trunk #995 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/995/]) ZOOKEEPER-926. Fork Hadoop common's test-patch.sh and modify for Zookeeper. Updated test-patch.sh. Contributed by nigel. ZOOKEEPER-926. Fork Hadoop common's test-patch.sh and modify for Zookeeper. Build commit. Contributed by nigel. ZOOKEEPER-926. Fork Hadoop common's test-patch.sh and modify for Zookeeper. Initial commit. Contributed by nigel. > Fork Hadoop common's test-patch.sh and modify for Zookeeper > --- > > Key: ZOOKEEPER-926 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Nigel Daley > Attachments: ZOOKEEPER-926.patch > > > Zookeeper currently uses the test-patch.sh script from the Hadoop nightly > dir. This is now out of date. I propose we just copy the updated one in > Hadoop common and then modify for ZK. This will also help as ZK moves out of > Hadoop to it's own TLP. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-907) Spurious "KeeperErrorCode = Session moved" messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928558#action_12928558 ] Hudson commented on ZOOKEEPER-907: -- Integrated in ZooKeeper-trunk #991 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/991/]) ZOOKEEPER-907. Spurious "KeeperErrorCode = Session moved" messages > Spurious "KeeperErrorCode = Session moved" messages > --- > > Key: ZOOKEEPER-907 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-907 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Vishal K >Assignee: Vishal K >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-907.patch, ZOOKEEPER-907.patch_v2 > > > The sync request does not set the session owner in Request. > As a result, the leader keeps printing: > 2010-07-01 10:55:36,733 - INFO [ProcessThread:-1:preprequestproces...@405] - > Got user-level KeeperException when processing sessionid:0x298d3b1fa9 > type:sync: cxid:0x6 zxid:0xfffe txntype:unknown reqpath:/ Error > Path:null Error:KeeperErrorCode = Session moved -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-884) Remove LedgerSequence references from BookKeeper documentation and comments in tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928557#action_12928557 ] Hudson commented on ZOOKEEPER-884: -- Integrated in ZooKeeper-trunk #991 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/991/]) ZOOKEEPER-884. Remove LedgerSequence references from BookKeeper documentation and comments in tests > Remove LedgerSequence references from BookKeeper documentation and comments > in tests > - > > Key: ZOOKEEPER-884 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-884 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bookkeeper >Affects Versions: 3.3.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-884.patch > > > We no longer use LedgerSequence, so we need to remove references in > documentation and comments sprinkled throughout the code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-916) Problem receiving messages from subscribed channels in c++ client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928559#action_12928559 ] Hudson commented on ZOOKEEPER-916: -- Integrated in ZooKeeper-trunk #991 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/991/]) ZOOKEEPER-916. Problem receiving messages from subscribed channels in c++ client > Problem receiving messages from subscribed channels in c++ client > -- > > Key: ZOOKEEPER-916 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-916 > Project: Zookeeper > Issue Type: Bug > Components: contrib-hedwig >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: ZOOKEEPER-916.patch > > > We see this bug with receiving messages from a subscribed channel. This > problem seems to happen with larger messages. The flow is to first read at > least 4 bytes from the socket channel. Extract the first 4 bytes to get the > message size. If we've read enough data into the buffer already, we're done > so invoke the messageReadCallbackHandler passing the channel and message > size. If not, then do an async read for at least the remaining amount of > bytes in the message from the socket channel. When done, invoke the > messageReadCallbackHandler. > The problem seems that when the second async read is done, the same > sizeReadCallbackHandler is invoked instead of the messageReadCallbackHandler. > The result is that we then try to read the first 4 bytes again from the > buffer. This will get a random message size and screw things up. I'm not > sure if it's an incorrect use of the boost asio async_read function or we're > doing the boost bind to the callback function incorrectly. > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler system:0,512 channel(0x80b7a18) > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler: size of buffer before reading message > size: 512 channel(0x80b7a18) > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler: size of incoming message 599, > currently in buffer 508 channel(0x80b7a18) > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler: Still have more data to read, 91 from > channel(0x80b7a18) > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler system:0, 91 channel(0x80b7a18) > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler: size of buffer before reading message > size: 599 channel(0x80b7a18) > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler: size of incoming message 134287360, > currently in buffer 595 channel(0x80b7a18) > 101015 15:30:40.108 DEBUG hedwig.channel.cpp - > DuplexChannel::sizeReadCallbackHandler: Still have more data to read, > 134286765 from channel(0x80b7a18) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-897) C Client seg faults during close
[ https://issues.apache.org/jira/browse/ZOOKEEPER-897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926007#action_12926007 ] Hudson commented on ZOOKEEPER-897: -- Integrated in ZooKeeper-trunk #983 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/983/]) ZOOKEEPER-897. C Client seg faults during close (jared cantwell via mahadev) > C Client seg faults during close > > > Key: ZOOKEEPER-897 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-897 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Jared Cantwell >Assignee: Jared Cantwell > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEEPER-897.diff, ZOOKEEPER-897.patch > > > We observed a crash while closing our c client. It was in the do_io() thread > that was processing as during the close() call. > #0 queue_buffer (list=0x6bd4f8, b=0x0, add_to_front=0) at src/zookeeper.c:969 > #1 0x0046234e in check_events (zh=0x6bd480, events= out>) at src/zookeeper.c:1687 > #2 0x00462d74 in zookeeper_process (zh=0x6bd480, events=2) at > src/zookeeper.c:1971 > #3 0x00469c34 in do_io (v=0x6bd480) at src/mt_adaptor.c:311 > #4 0x77bc59ca in start_thread () from /lib/libpthread.so.0 > #5 0x76f706fd in clone () from /lib/libc.so.6 > #6 0x in ?? () > We tracked down the sequence of events, and the cause is that input_buffer is > being freed from a thread other than the do_io thread that relies on it: > 1. do_io() call check_events() > 2. if(events&ZOOKEEPER_READ) branch executes > 3. if (rc > 0) branch executes > 4. if (zh->input_buffer != &zh->primer_buffer) branch executes > .in the meantime.. > 5. zookeeper_close() called > 6. if (inc_ref_counter(zh,0)!=0) branch executes > 7. cleanup_bufs() is called > 8. input_buffer is freed at the end > . back to check_events(). > 9. queue_events() is called on a NULL buffer. > I believe the patch is to only call free_completions() in zookeeper_close() > and not cleanup_bufs(). The original reason cleanup_bufs() was added was to > call any outstanding synhcronous completions, so only free_completions (which > is guarded) is needed. I will submit a patch for review with this change. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-898) C Client might not cleanup correctly during close
[ https://issues.apache.org/jira/browse/ZOOKEEPER-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926008#action_12926008 ] Hudson commented on ZOOKEEPER-898: -- Integrated in ZooKeeper-trunk #983 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/983/]) ZOOKEEPER-898. C Client might not cleanup correctly during close (jared cantwell via mahadev) > C Client might not cleanup correctly during close > - > > Key: ZOOKEEPER-898 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-898 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Jared Cantwell >Assignee: Jared Cantwell >Priority: Trivial > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEEPER-898.diff, ZOOKEEPER-898.patch > > > I was looking through the c-client code and noticed a situation where a > counter can be incorrectly incremented and a small memory leak can occur. > In zookeeper.c : add_completion(), if close_requested is true, then the > completion will not be queued. But at the end, outstanding_sync is still > incremented and free() never called on the newly allocated completion_list_t. > > I will submit for review a diff that I believe corrects this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-904) super digest is not actually acting as a full superuser
[
https://issues.apache.org/jira/browse/ZOOKEEPER-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925323#action_12925323
]
Hudson commented on ZOOKEEPER-904:
--
Integrated in ZooKeeper-trunk #981 (See
[https://hudson.apache.org/hudson/job/ZooKeeper-trunk/981/])
ZOOKEEPER-904. super digest is not actually acting as a full superuser
(Camille Fournier via mahadev)
> super digest is not actually acting as a full superuser
> ---
>
> Key: ZOOKEEPER-904
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-904
> Project: Zookeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.3.1
>Reporter: Camille Fournier
>Assignee: Camille Fournier
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-904-332.patch, ZOOKEEPER-904.patch
>
>
> The documentation states:
> New in 3.2: Enables a ZooKeeper ensemble administrator to access the znode
> hierarchy as a "super" user. In particular no ACL checking occurs for a user
> authenticated as super.
> However, if a super user does something like:
> zk.setACL("/", Ids.READ_ACL_UNSAFE, -1);
> the super user is now bound by read-only ACL. This is not what I would expect
> to see given the documentation. It can be fixed by moving the chec for the
> "super" authId in PrepRequestProcessor.checkACL to before the for(ACL a :
> acl) loop.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923814#action_12923814 ] Hudson commented on ZOOKEEPER-800: -- Integrated in ZooKeeper-trunk #976 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/976/]) ZOOKEEPER-800. zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE (michi mutsuzaki via mahadev konar) > zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE > --- > > Key: ZOOKEEPER-800 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-800 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.1 >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-800.patch > > > This happened when I called zoo_add_auth() immediately after > zookeeper_init(). It took me a while to figure out that authentication > actually failed since zoo_add_auth() returned ZOK. It should return > ZINVALIDSTATE instead. > --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923396#action_12923396 ] Hudson commented on ZOOKEEPER-794: -- Integrated in ZooKeeper-trunk #975 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/975/]) > Callbacks are not invoked when the client is closed > --- > > Key: ZOOKEEPER-794 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-794 > Project: Zookeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.3.1 >Reporter: Alexis Midon >Assignee: Alexis Midon >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-794.patch.txt, ZOOKEEPER-794.txt, > ZOOKEEPER-794_2.patch, ZOOKEEPER-794_3.patch, ZOOKEEPER-794_4.patch.txt, > ZOOKEEPER-794_5.patch.txt, ZOOKEEPER-794_5_br33.patch > > > I noticed that ZooKeeper has different behaviors when calling synchronous or > asynchronous actions on a closed ZooKeeper client. > Actually a synchronous call will throw a "session expired" exception while an > asynchronous call will do nothing. No exception, no callback invocation. > Actually, even if the EventThread receives the Packet with the session > expired err code, the packet is never processed since the thread has been > killed by the ventOfDeath. So the call back is not invoked. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923116#action_12923116 ] Hudson commented on ZOOKEEPER-804: -- Integrated in ZooKeeper-trunk #973 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/973/]) ZOOKEEPER-804. c unit tests failing due to "assertion cptr failed" (second patch) > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-804-1.patch, ZOOKEEPER-804-1.patch, > ZOOKEEPER-804.patch > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923115#action_12923115 ] Hudson commented on ZOOKEEPER-820: -- Integrated in ZooKeeper-trunk #973 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/973/]) ZOOKEEPER-820. update c unit tests to ensure "zombie" java server processes dont cause failure > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, > ZOOKEEPER-820.patch, ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-893) ZooKeeper high cpu usage when invalid requests
[
https://issues.apache.org/jira/browse/ZOOKEEPER-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922910#action_12922910
]
Hudson commented on ZOOKEEPER-893:
--
Integrated in ZooKeeper-trunk #972 (See
[https://hudson.apache.org/hudson/job/ZooKeeper-trunk/972/])
ZOOKEEPER-893. ZooKeeper high cpu usage when invalid requests
> ZooKeeper high cpu usage when invalid requests
> --
>
> Key: ZOOKEEPER-893
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-893
> Project: Zookeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.3.1
> Environment: Linux 2.6.16
> 4x Intel(R) Xeon(R) CPU X3320 @ 2.50GHz
> java version "1.6.0_17"
> Java(TM) SE Runtime Environment (build 1.6.0_17-b04)
> Java HotSpot(TM) Server VM (build 14.3-b01, mixed mode)
>Reporter: Thijs Terlouw
>Assignee: Thijs Terlouw
>Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-893-3.3.patch, ZOOKEEPER-893.patch,
> ZOOKEEPER-893.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When ZooKeeper receives certain illegally formed messages on the internal
> communication port (:4181 by default), it's possible for ZooKeeper to enter
> an infinite loop which causes 100% cpu usage. It's related to ZOOKEEPER-427,
> but that patch does not resolve all issues.
> from: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
> the two affected parts:
> ===
> int length = msgLength.getInt();
>
> if(length <= 0) {
>
> throw new IOException("Invalid packet length:" + length);
>
> }
> ===
> ===
> while (message.hasRemaining()) {
>
> temp_numbytes = channel.read(message);
>
> if(temp_numbytes < 0) {
>
> throw new IOException("Channel eof before end");
>
> }
>
> numbytes += temp_numbytes;
>
> }
> ===
> how to replicate this bug:
> perform an nmap portscan against your zookeeper server: "nmap -sV -n
> your.ip.here -p4181"
> wait for a while untill you see some messages in the logfile and then you
> will see 100% cpu usage. It does not recover from this situation. With my
> patch, it does not occur anymore
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-888) c-client / zkpython: Double free corruption on node watcher
[ https://issues.apache.org/jira/browse/ZOOKEEPER-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922909#action_12922909 ] Hudson commented on ZOOKEEPER-888: -- Integrated in ZooKeeper-trunk #972 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/972/]) ZOOKEEPER-888: c-client / zkpython: Double free corruption on node watcher (Austin Shoemaker via henryr) > c-client / zkpython: Double free corruption on node watcher > --- > > Key: ZOOKEEPER-888 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-888 > Project: Zookeeper > Issue Type: Bug > Components: c client, contrib-bindings >Affects Versions: 3.3.1 >Reporter: Lukas >Assignee: Lukas >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: resume-segfault.py, ZOOKEEPER-888-3.3.patch, > ZOOKEEPER-888.patch > > > the c-client / zkpython wrapper invokes already freed watcher callback > steps to reproduce: > 0. start a zookeper server on your machine > 1. run the attached python script > 2. suspend the zookeeper server process (e.g. using `pkill -STOP -f > org.apache.zookeeper.server.quorum.QuorumPeerMain` ) > 3. wait until the connection and the node observer fired with a session > event > 4. resume the zookeeper server process (e.g. using `pkill -CONT -f > org.apache.zookeeper.server.quorum.QuorumPeerMain` ) > -> the client tries to dispatch the node observer function again, but it was > already freed -> double free corruption -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-855) clientPortBindAddress should be clientPortAddress
[ https://issues.apache.org/jira/browse/ZOOKEEPER-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922512#action_12922512 ] Hudson commented on ZOOKEEPER-855: -- Integrated in ZooKeeper-trunk #971 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/971/]) ZOOKEEPER-855. clientPortBindAddress should be clientPortAddress (Jared Cantwell via fpj) > clientPortBindAddress should be clientPortAddress > - > > Key: ZOOKEEPER-855 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-855 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Affects Versions: 3.3.0, 3.3.1 >Reporter: Jared Cantwell >Assignee: Jared Cantwell >Priority: Trivial > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-855.patch, ZOOKEEPER-855.patch > > > The server documentation states that the configuration parameter for binding > to a specific ip address is clientPortBindAddress. The code believes the > parameter is clientPortAddress. The documentation for 3.3.X versions needs > changed to reflect the correct parameter . This parameter was added in > ZOOKEEPER-635. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-881) ZooKeeperServer.loadData loads database twice
[ https://issues.apache.org/jira/browse/ZOOKEEPER-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921306#action_12921306 ] Hudson commented on ZOOKEEPER-881: -- Integrated in ZooKeeper-trunk #967 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/967/]) ZOOKEEPER-881. ZooKeeperServer.loadData loads database twice (jared cantwell via breed) > ZooKeeperServer.loadData loads database twice > - > > Key: ZOOKEEPER-881 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-881 > Project: Zookeeper > Issue Type: Bug > Components: server >Reporter: Jared Cantwell >Assignee: Jared Cantwell >Priority: Trivial > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-881.patch > > > zkDb.loadDataBase() is called twice at the beginning of loadData(). It > shouldn't have any negative affects, but is unnecessary. A patch should be > trivial. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920160#action_12920160 ] Hudson commented on ZOOKEEPER-864: -- Integrated in ZooKeeper-trunk #964 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/964/]) ZOOKEEPER-864. Hedwig C++ client improvements > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff, ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-886) Hedwig Server stays in "disconnected" state when connection to ZK dies but gets reconnected
[ https://issues.apache.org/jira/browse/ZOOKEEPER-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920159#action_12920159 ] Hudson commented on ZOOKEEPER-886: -- Integrated in ZooKeeper-trunk #964 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/964/]) ZOOKEEPER-886. Hedwig Server stays in "disconnected" state when connection to ZK dies but gets reconnected > Hedwig Server stays in "disconnected" state when connection to ZK dies but > gets reconnected > --- > > Key: ZOOKEEPER-886 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-886 > Project: Zookeeper > Issue Type: Bug > Components: contrib-hedwig >Reporter: Erwin Tam >Assignee: Erwin Tam > Attachments: ZOOKEEPER-886.patch > > > The Hedwig Server is connected to ZooKeeper. In the ZkTopicManager, it > registers a watcher so that if it ever gets disconnected from ZK, it will > temporarily fail all incoming requests since the Hedwig server does not know > for sure if it is still the master for the topics. When the ZK client gets > reconnected, the logic currently is wrong and it does not unset the suspended > flag. Thus once it gets disconnected, it will stay in the suspended state > forever, thereby making the Hedwig server hub dead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-844) handle auth failure in java client
[
https://issues.apache.org/jira/browse/ZOOKEEPER-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918879#action_12918879
]
Hudson commented on ZOOKEEPER-844:
--
Integrated in ZooKeeper-trunk #959 (See
[https://hudson.apache.org/hudson/job/ZooKeeper-trunk/959/])
ZOOKEEPER-844. handle auth failure in java client
> handle auth failure in java client
> --
>
> Key: ZOOKEEPER-844
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-844
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.3.1
>Reporter: Camille Fournier
>Assignee: Camille Fournier
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-844.patch, ZOOKEEPER332-844
>
>
> ClientCnxn.java currently has the following code:
> if (replyHdr.getXid() == -4) {
> // -2 is the xid for AuthPacket
> // TODO: process AuthPacket here
> if (LOG.isDebugEnabled()) {
> LOG.debug("Got auth sessionid:0x"
> + Long.toHexString(sessionId));
> }
> return;
> }
> Auth failures appear to cause the server to disconnect but the client never
> gets a proper state change or notification that auth has failed, which makes
> handling this scenario very difficult as it causes the client to go into a
> loop of sending bad auth, getting disconnected, trying to reconnect, sending
> bad auth again, over and over.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-822) Leader election taking a long time to complete
[ https://issues.apache.org/jira/browse/ZOOKEEPER-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918878#action_12918878 ] Hudson commented on ZOOKEEPER-822: -- Integrated in ZooKeeper-trunk #959 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/959/]) ZOOKEEPER-822. Leader election taking a long time to complete > Leader election taking a long time to complete > --- > > Key: ZOOKEEPER-822 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-822 > Project: Zookeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.3.0 >Reporter: Vishal K >Assignee: Vishal K >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: 822.tar.gz, rhel.tar.gz, test_zookeeper_1.log, > test_zookeeper_2.log, zk_leader_election.tar.gz, zookeeper-3.4.0.tar.gz, > ZOOKEEPER-822-3.3.2.patch, ZOOKEEPER-822-3.3.2.patch, > ZOOKEEPER-822-3.3.2.patch, ZOOKEEPER-822-3.3.2.patch, ZOOKEEPER-822.patch, > ZOOKEEPER-822.patch, ZOOKEEPER-822.patch, ZOOKEEPER-822.patch, > ZOOKEEPER-822.patch, ZOOKEEPER-822.patch, ZOOKEEPER-822.patch_v1 > > > Created a 3 node cluster. > 1 Fail the ZK leader > 2. Let leader election finish. Restart the leader and let it join the > 3. Repeat > After a few rounds leader election takes anywhere 25- 60 seconds to finish. > Note- we didn't have any ZK clients and no new znodes were created. > zoo.cfg is shown below: > #Mon Jul 19 12:15:10 UTC 2010 > server.1=192.168.4.12\:2888\:3888 > server.0=192.168.4.11\:2888\:3888 > clientPort=2181 > dataDir=/var/zookeeper > syncLimit=2 > server.2=192.168.4.13\:2888\:3888 > initLimit=5 > tickTime=2000 > I have attached logs from two nodes that took a long time to form the cluster > after failing the leader. The leader was down anyways so logs from that node > shouldn't matter. > Look for "START HERE". Logs after that point should be of our interest. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918466#action_12918466 ] Hudson commented on ZOOKEEPER-804: -- Integrated in ZooKeeper-trunk #958 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/958/]) ZOOKEEPER-804. c unit tests failing due to "assertion cptr failed" (michi mutsuzaki via mahadev) > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-804.patch > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-846) zookeeper client doesn't shut down cleanly on the close call
[ https://issues.apache.org/jira/browse/ZOOKEEPER-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913497#action_12913497 ] Hudson commented on ZOOKEEPER-846: -- Integrated in ZooKeeper-trunk #944 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/944/]) ZOOKEEPER-846. zookeeper client doesn't shut down cleanly on the close call > zookeeper client doesn't shut down cleanly on the close call > > > Key: ZOOKEEPER-846 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-846 > Project: Zookeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.2.2 >Reporter: Ted Yu >Assignee: Patrick Hunt >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: rs-13.stack, ZOOKEEPER-846.patch > > > Using HBase 0.20.6 (with HBASE-2473) we encountered a situation where > Regionserver > process was shutting down and seemed to hang. > Here is the bottom of region server log: > http://pastebin.com/YYawJ4jA > zookeeper-3.2.2 is used. > Here is relevant portion from jstack - I attempted to attach jstack twice in > my email to d...@hbase.apache.org but failed: > "DestroyJavaVM" prio=10 tid=0x2aabb849c800 nid=0x6c60 waiting on > condition [0x] >java.lang.Thread.State: RUNNABLE > "regionserver/10.32.42.245:60020" prio=10 tid=0x2aabb84ce000 nid=0x6c81 > in Object.wait() [0x43755000] >java.lang.Thread.State: WAITING (on object monitor) > at java.lang.Object.wait(Native Method) > - waiting on <0x2aaab76633c0> (a > org.apache.zookeeper.ClientCnxn$Packet) > at java.lang.Object.wait(Object.java:485) > at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1099) > - locked <0x2aaab76633c0> (a > org.apache.zookeeper.ClientCnxn$Packet) > at org.apache.zookeeper.ClientCnxn.close(ClientCnxn.java:1077) > at org.apache.zookeeper.ZooKeeper.close(ZooKeeper.java:505) > - locked <0x2aaabf5e0c30> (a org.apache.zookeeper.ZooKeeper) > at > org.apache.hadoop.hbase.zookeeper.ZooKeeperWrapper.close(ZooKeeperWrapper.java:681) > at > org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:654) > at java.lang.Thread.run(Thread.java:619) > "main-EventThread" daemon prio=10 tid=0x43474000 nid=0x6c80 waiting > on condition [0x413f3000] >java.lang.Thread.State: WAITING (parking) > at sun.misc.Unsafe.park(Native Method) > - parking to wait for <0x2aaabf6e9150> (a > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) > at java.util.concurrent.locks.LockSupport.park(LockSupport.java:158) > at > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1987) > at > java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:399) > at > org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:414) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-831) BookKeeper: Throttling improved for reads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910965#action_12910965 ] Hudson commented on ZOOKEEPER-831: -- Integrated in ZooKeeper-trunk #940 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/940/]) ZOOKEEPER-831. BookKeeper: Throttling improved for reads > BookKeeper: Throttling improved for reads > - > > Key: ZOOKEEPER-831 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-831 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bookkeeper >Affects Versions: 3.3.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-831.patch, ZOOKEEPER-831.patch, > ZOOKEEPER-831.patch, ZOOKEEPER-831.patch > > > Reads and writes in BookKeeper are asymmetric: a write request writes one > entry, whereas a read request may read multiple requests. The current > implementation of throttling only counts the number of read requests instead > of counting the number of entries being read. Consequently, a few read > requests reading a large number of entries each will spawn a large number of > read-entry requests. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-792) zkpython memory leak
[ https://issues.apache.org/jira/browse/ZOOKEEPER-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909609#action_12909609 ] Hudson commented on ZOOKEEPER-792: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > zkpython memory leak > > > Key: ZOOKEEPER-792 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-792 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings >Affects Versions: 3.3.1 > Environment: vmware workstation - guest OS:Linux python:2.4.3 >Reporter: Lei Zhang >Assignee: Lei Zhang > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-792.patch, ZOOKEEPER-792.patch, > ZOOKEEPER-792.patch > > > We recently upgraded zookeeper from 3.2.1 to 3.3.1, now we are seeing less > client deadlock on session expiration, which is a definite plus! > Unfortunately we are seeing memory leak that requires our zk clients to be > restarted every half-day. Valgrind result: > ==8804== 25 (12 direct, 13 indirect) bytes in 1 blocks are definitely lost in > loss record 255 of 670 > ==8804==at 0x4021C42: calloc (vg_replace_malloc.c:418) > ==8804==by 0x5047B42: parse_acls (zookeeper.c:369) > ==8804==by 0x5047EF6: pyzoo_create (zookeeper.c:1009) > ==8804==by 0x40786CC: PyCFunction_Call (in /usr/lib/libpython2.4.so.1.0) > ==8804==by 0x40B31DC: PyEval_EvalFrame (in /usr/lib/libpython2.4.so.1.0) > ==8804==by 0x40B4485: PyEval_EvalCodeEx (in /usr/lib/libpython2.4.so.1.0) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-785) Zookeeper 3.3.1 shouldn't infinite loop if someone creates a server.0 line
[ https://issues.apache.org/jira/browse/ZOOKEEPER-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909611#action_12909611 ] Hudson commented on ZOOKEEPER-785: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > Zookeeper 3.3.1 shouldn't infinite loop if someone creates a server.0 line > --- > > Key: ZOOKEEPER-785 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-785 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.3.1 > Environment: Tested in linux with a new jvm >Reporter: Alex Newman >Assignee: Patrick Hunt > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-785.patch, ZOOKEEPER-785.patch, > ZOOKEEPER-785_2.patch, ZOOKEEPER-785_2.patch, ZOOKEEPER-785_2.patch, > ZOOKEEPER-785_2_br33.patch, ZOOKEEPER-785_2_br33.patch, > ZOOKEEPER-785_2_br33.patch > > > The following config causes an infinite loop > [zoo.cfg] > tickTime=2000 > dataDir=/var/zookeeper/ > clientPort=2181 > initLimit=10 > syncLimit=5 > server.0=localhost:2888:3888 > Output: > 2010-06-01 16:20:32,471 - INFO [main:quorumpeerm...@119] - Starting quorum > peer > 2010-06-01 16:20:32,489 - INFO [main:nioservercnxn$fact...@143] - binding to > port 0.0.0.0/0.0.0.0:2181 > 2010-06-01 16:20:32,504 - INFO [main:quorump...@818] - tickTime set to 2000 > 2010-06-01 16:20:32,504 - INFO [main:quorump...@829] - minSessionTimeout set > to -1 > 2010-06-01 16:20:32,505 - INFO [main:quorump...@840] - maxSessionTimeout set > to -1 > 2010-06-01 16:20:32,505 - INFO [main:quorump...@855] - initLimit set to 10 > 2010-06-01 16:20:32,526 - INFO [main:files...@82] - Reading snapshot > /var/zookeeper/version-2/snapshot.c > 2010-06-01 16:20:32,547 - INFO [Thread-1:quorumcnxmanager$liste...@436] - My > election bind port: 3888 > 2010-06-01 16:20:32,554 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:quorump...@620] - LOOKING > 2010-06-01 16:20:32,556 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:fastleaderelect...@649] - New election. My > id = 0, Proposed zxid = 12 > 2010-06-01 16:20:32,558 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:fastleaderelect...@689] - Notification: 0, > 12, 1, 0, LOOKING, LOOKING, 0 > 2010-06-01 16:20:32,560 - WARN > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:quorump...@623] - Unexpected exception > java.lang.NullPointerException > at > org.apache.zookeeper.server.quorum.FastLeaderElection.totalOrderPredicate(FastLeaderElection.java:496) > at > org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader(FastLeaderElection.java:709) > at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:621) > 2010-06-01 16:20:32,560 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:quorump...@620] - LOOKING > 2010-06-01 16:20:32,560 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:fastleaderelect...@649] - New election. My > id = 0, Proposed zxid = 12 > 2010-06-01 16:20:32,561 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:fastleaderelect...@689] - Notification: 0, > 12, 2, 0, LOOKING, LOOKING, 0 > 2010-06-01 16:20:32,561 - WARN > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:quorump...@623] - Unexpected exception > java.lang.NullPointerException > at > org.apache.zookeeper.server.quorum.FastLeaderElection.totalOrderPredicate(FastLeaderElection.java:496) > at > org.apache.zookeeper.server.quorum.FastLeaderElection.lookForLeader(FastLeaderElection.java:709) > at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:621) > 2010-06-01 16:20:32,561 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:quorump...@620] - LOOKING > 2010-06-01 16:20:32,562 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:fastleaderelect...@649] - New election. My > id = 0, Proposed zxid = 12 > 2010-06-01 16:20:32,562 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:fastleaderelect...@689] - Notification: 0, > 12, 3, 0, LOOKING, LOOKING, 0 > 2010-06-01 16:20:32,562 - WARN > [QuorumPeer:/0:0:0:0:0:0:0:0:2181:quorump...@623] - Unexpected exception > java.lang.NullPointerException > Things like HBase require that the zookeeper servers be listed in the > zoo.cfg. This is a bug on their part, but zookeeper shouldn't null pointer in > a loop though. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer
[
https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909613#action_12909613
]
Hudson commented on ZOOKEEPER-853:
--
Integrated in ZooKeeper-trunk #936 (See
[https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/])
> Make zookeeper.is_unrecoverable return True or False and not an integer
> ---
>
> Key: ZOOKEEPER-853
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
> Project: Zookeeper
> Issue Type: Improvement
> Components: contrib-bindings
>Reporter: Andrei Savu
>Assignee: Andrei Savu
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-853.patch, ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it
> makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an
> integer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-733) use netty to handle client connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909607#action_12909607 ] Hudson commented on ZOOKEEPER-733: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > use netty to handle client connections > -- > > Key: ZOOKEEPER-733 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Benjamin Reed >Assignee: Patrick Hunt > Fix For: 3.4.0 > > Attachments: accessive.jar, flowctl.zip, moved.zip, > QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, > ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, > ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, > ZOOKEEPER-733.patch, ZOOKEEPER-733.patch > > > we currently have our own asynchronous NIO socket engine to be able to handle > lots of clients with a single thread. over time the engine has become more > complicated. we would also like the engine to use multiple threads on > machines with lots of cores. plus, we would like to be able to support things > like SSL. if we switch to netty, we can simplify our code and get the > previously mentioned benefits. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-808) Web-based Administrative Interface
[ https://issues.apache.org/jira/browse/ZOOKEEPER-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909616#action_12909616 ] Hudson commented on ZOOKEEPER-808: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > Web-based Administrative Interface > -- > > Key: ZOOKEEPER-808 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-808 > Project: Zookeeper > Issue Type: New Feature > Components: contrib >Reporter: Andrei Savu >Assignee: Andrei Savu > Fix For: 3.4.0 > > Attachments: huebrowser.tar.gz > > > Implement a web-based administrative interface that should allow the user to > perform all the tasks that can be done using the interactive shell (zkCli.sh) > from a browser. It should also display cluster and individual server info > extracted using the 4letter word commands. > I'm going to build starting from the > http://github.com/phunt/zookeeper_dashboard implemented by Patrick Hunt. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-861) Missing the test SSL certificate used for running junit tests.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909615#action_12909615 ] Hudson commented on ZOOKEEPER-861: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > Missing the test SSL certificate used for running junit tests. > -- > > Key: ZOOKEEPER-861 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-861 > Project: Zookeeper > Issue Type: Bug > Components: contrib-hedwig >Reporter: Erwin Tam >Assignee: Erwin Tam >Priority: Minor > Fix For: 3.4.0 > > Attachments: server.p12, ZOOKEEPER-861.patch > > > The Hedwig code checked into Apache is missing a test SSL certificate file > used for running the server junit tests. We need this file otherwise the > tests that use this (e.g. TestHedwigHub) will fail. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-870) Zookeeper trunk build broken.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909614#action_12909614 ] Hudson commented on ZOOKEEPER-870: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) ZOOKEEPER-870. Zookeeper trunk build broken. > Zookeeper trunk build broken. > - > > Key: ZOOKEEPER-870 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870 > Project: Zookeeper > Issue Type: Bug >Reporter: Mahadev konar >Assignee: Mahadev konar > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-870.patch, ZOOKEEPER-870.patch > > > the zookeeper current trunk build is broken mostly due to some netty changes. > This is causing a huge backlog of PA's and other impediments to the review > process. For now I plan to disable the test and fix them as part of 3.4 later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-854) BookKeeper does not compile due to changes in the ZooKeeper code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909612#action_12909612 ] Hudson commented on ZOOKEEPER-854: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > BookKeeper does not compile due to changes in the ZooKeeper code > > > Key: ZOOKEEPER-854 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-854 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bookkeeper >Affects Versions: 3.3.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-854.patch, ZOOKEEPER-854.patch > > > BookKeeper does not compile due to changes in the NIOServerCnxn class of > ZooKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909610#action_12909610 ] Hudson commented on ZOOKEEPER-775: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > A large scale pub/sub system > > > Key: ZOOKEEPER-775 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 > Project: Zookeeper > Issue Type: New Feature > Components: contrib >Reporter: Benjamin Reed >Assignee: Benjamin Reed > Fix For: 3.4.0 > > Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, > ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, > ZOOKEEPER-775_2.patch, ZOOKEEPER-775_3.patch > > > we have developed a large scale pub/sub system based on ZooKeeper and > BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-867) ClientTest is failing on hudson - fd cleanup
[ https://issues.apache.org/jira/browse/ZOOKEEPER-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909608#action_12909608 ] Hudson commented on ZOOKEEPER-867: -- Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/]) > ClientTest is failing on hudson - fd cleanup > > > Key: ZOOKEEPER-867 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-867 > Project: Zookeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.4.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-867.patch > > > client cleanup test is failing on hudson. fd count is off. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-809) Improved REST Interface
[ https://issues.apache.org/jira/browse/ZOOKEEPER-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899369#action_12899369 ] Hudson commented on ZOOKEEPER-809: -- Integrated in ZooKeeper-trunk #907 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/907/]) ZOOKEEPER-809. Improved REST Interface > Improved REST Interface > --- > > Key: ZOOKEEPER-809 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-809 > Project: Zookeeper > Issue Type: Improvement > Components: contrib >Reporter: Andrei Savu >Assignee: Andrei Savu > Fix For: 3.4.0 > > Attachments: keys.tar.gz, SPEC.txt, SPEC.txt, ZOOKEEPER-809.patch, > ZOOKEEPER-809.patch, ZOOKEEPER-809.patch, ZOOKEEPER-809.patch, > ZOOKEEPER-809.patch, ZOOKEEPER-809.patch > > > I would like to extend the existing REST Interface to also support: > * configuration > * ephemeral znodes > * watches - PubSubHubbub > * ACLs > * basic authentication > I want to do this because when building web applications that talks directly > to ZooKeeper a REST API it's a lot easier to use (there is no protocol > mismatch) than an API that uses persistent connections. I plan to use the > improved version to build a web-based administrative interface. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-790) Last processed zxid set prematurely while establishing leadership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894000#action_12894000 ] Hudson commented on ZOOKEEPER-790: -- Integrated in ZooKeeper-trunk #890 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/890/]) ZOOKEEPER-790. Last processed zxid set prematurely while establishing leadership (flavio via mahadev) > Last processed zxid set prematurely while establishing leadership > - > > Key: ZOOKEEPER-790 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-790 > Project: Zookeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.3.1 >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-790-3.3.patch, ZOOKEEPER-790-3.3.patch, > ZOOKEEPER-790-3.3.v2.patch, ZOOKEEPER-790-follower-request-NPE.log, > ZOOKEEPER-790-test.patch, ZOOKEEPER-790.patch, ZOOKEEPER-790.patch, > ZOOKEEPER-790.patch, ZOOKEEPER-790.patch, ZOOKEEPER-790.patch, > ZOOKEEPER-790.travis.log.bz2, ZOOKEEPER-790.v2.patch, ZOOKEEPER-790.v2.patch, > ZOOKEEPER-790.v2.patch > > > The leader code is setting the last processed zxid to the first of the new > epoch even before connecting to a quorum of followers. Because the leader > code sets this value before connecting to a quorum of followers > (Leader.java:281) and the follower code throws an IOException > (Follower.java:73) if the leader epoch is smaller, we have that when the > false leader drops leadership and becomes a follower, it finds a smaller > epoch and kills itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-765) Add python example script
[ https://issues.apache.org/jira/browse/ZOOKEEPER-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893133#action_12893133 ] Hudson commented on ZOOKEEPER-765: -- Integrated in ZooKeeper-trunk #888 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/888/]) ZOOKEEPER-765. Add python example script (Travis and Andrei via mahadev) > Add python example script > - > > Key: ZOOKEEPER-765 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-765 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bindings, documentation >Reporter: Travis Crawford >Assignee: Andrei Savu >Priority: Minor > Fix For: 3.4.0 > > Attachments: zk.py, ZOOKEEPER-765.patch, ZOOKEEPER-765.patch > > > When adding some zookeeper-based functionality to a python script I had to > figure everything out without guidance, which while doable, would have been a > lot easier with an example. I extracted a skeleton program structure out with > hopes its useful to others (maybe add as an example in the source or wiki?). > This script does an aget() and sets a watch, and hopefully illustrates what's > going on, and where to plug in your application code that gets run when the > znode changes. > There are probably some bugs, which if we fix now and provide a well-reviewed > example hopefully others will not run into the same mistakes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-783) committedLog in ZKDatabase is not properly synchronized
[ https://issues.apache.org/jira/browse/ZOOKEEPER-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892746#action_12892746 ] Hudson commented on ZOOKEEPER-783: -- Integrated in ZooKeeper-trunk #887 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/887/]) ZOOKEEPER-783. committedLog in ZKDatabase is not properly synchronized (henry via mahadev) > committedLog in ZKDatabase is not properly synchronized > --- > > Key: ZOOKEEPER-783 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-783 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.3.1 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-783.patch > > > ZKDatabase.getCommittedLog() returns a reference to the LinkedList > committedLog in ZKDatabase. This is then iterated over by at least one > caller. > I have seen a bug that causes a NPE in LinkedList.clear on committedLog, > which I am pretty sure is due to the lack of synchronization. This bug has > not been apparent in normal ZK operation, but in code that I have that starts > and stops a ZK server in process repeatedly (clear() is called from > ZooKeeperServerMain.shutdown()). > It's better style to defensively copy the list in getCommittedLog, and to > synchronize on the list in ZKDatabase.clear. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-814) monitoring scripts are missing apache license headers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892747#action_12892747 ] Hudson commented on ZOOKEEPER-814: -- Integrated in ZooKeeper-trunk #887 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/887/]) ZOOKEEPER-814. monitoring scripts are missing apache license headers (andrei savu via mahadev) > monitoring scripts are missing apache license headers > - > > Key: ZOOKEEPER-814 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814 > Project: Zookeeper > Issue Type: Bug > Components: contrib >Reporter: Patrick Hunt >Assignee: Andrei Savu >Priority: Blocker > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-814.patch > > > Andrei, I just realized that src/contrib/monitoring files are missing apache > license headers. Please add them (in particular any script files like > python, see similar files in svn for examples - in some cases like README > it's not strictly necessary.) > You can run the RAT tool to verify (see build.xml or > http://incubator.apache.org/rat/) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-821) Add ZooKeeper version information to zkpython
[ https://issues.apache.org/jira/browse/ZOOKEEPER-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892745#action_12892745 ] Hudson commented on ZOOKEEPER-821: -- Integrated in ZooKeeper-trunk #887 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/887/]) ZOOKEEPER-821. Add ZooKeeper version information to zkpython (Rich Schumacher via mahadev) > Add ZooKeeper version information to zkpython > - > > Key: ZOOKEEPER-821 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-821 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bindings >Affects Versions: 3.3.1 >Reporter: Rich Schumacher >Assignee: Rich Schumacher >Priority: Trivial > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-821.patch > > > Since installing and using ZooKeeper I've built and installed no less than > four versions of the zkpython bindings. It would be really helpful if the > module had a '__version__' attribute to easily tell which version is > currently in use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-790) Last processed zxid set prematurely while establishing leadership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891559#action_12891559 ] Hudson commented on ZOOKEEPER-790: -- Integrated in ZooKeeper-trunk #884 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/884/]) ZOOKEEPER-790. Last processed zxid set prematurely while establishing leadership (fpj via breed) > Last processed zxid set prematurely while establishing leadership > - > > Key: ZOOKEEPER-790 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-790 > Project: Zookeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.3.1 >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-790-3.3.patch, ZOOKEEPER-790-3.3.patch, > ZOOKEEPER-790.patch, ZOOKEEPER-790.patch, ZOOKEEPER-790.patch, > ZOOKEEPER-790.patch, ZOOKEEPER-790.patch, ZOOKEEPER-790.travis.log.bz2 > > > The leader code is setting the last processed zxid to the first of the new > epoch even before connecting to a quorum of followers. Because the leader > code sets this value before connecting to a quorum of followers > (Leader.java:281) and the follower code throws an IOException > (Follower.java:73) if the leader epoch is smaller, we have that when the > false leader drops leadership and becomes a follower, it finds a smaller > epoch and kills itself. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-799) Add tools and recipes for monitoring as a contrib
[ https://issues.apache.org/jira/browse/ZOOKEEPER-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890525#action_12890525 ] Hudson commented on ZOOKEEPER-799: -- Integrated in ZooKeeper-trunk #881 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/881/]) > Add tools and recipes for monitoring as a contrib > - > > Key: ZOOKEEPER-799 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-799 > Project: Zookeeper > Issue Type: New Feature > Components: contrib >Reporter: Andrei Savu >Assignee: Andrei Savu > Fix For: 3.4.0 > > Attachments: monitoring.tar.gz, ZOOKEEPER-799.patch > > > Tools and Recipes for Monitoring ZooKeeper using Cacti, Nagios or Ganglia. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-712) Bookie recovery
[ https://issues.apache.org/jira/browse/ZOOKEEPER-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890524#action_12890524 ] Hudson commented on ZOOKEEPER-712: -- Integrated in ZooKeeper-trunk #881 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/881/]) > Bookie recovery > --- > > Key: ZOOKEEPER-712 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-712 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Erwin Tam > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-712.patch > > > Recover the ledger fragments of a bookie once it crashes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-719) Add throttling to BookKeeper client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890523#action_12890523 ] Hudson commented on ZOOKEEPER-719: -- Integrated in ZooKeeper-trunk #881 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/881/]) > Add throttling to BookKeeper client > --- > > Key: ZOOKEEPER-719 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-719 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bookkeeper >Affects Versions: 3.3.0 >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-719.patch, ZOOKEEPER-719.patch, > ZOOKEEPER-719.patch, ZOOKEEPER-719.patch > > > Add throttling to client to control the rate of operations to bookies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-796) zkServer.sh should support an external PIDFILE variable
[ https://issues.apache.org/jira/browse/ZOOKEEPER-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885918#action_12885918 ] Hudson commented on ZOOKEEPER-796: -- Integrated in ZooKeeper-trunk #870 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/870/]) ZOOKEEPER-796. zkServer.sh should support an external PIDFILE variable > zkServer.sh should support an external PIDFILE variable > --- > > Key: ZOOKEEPER-796 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-796 > Project: Zookeeper > Issue Type: Bug > Components: scripts >Reporter: Alex Newman >Assignee: Alex Newman > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-796.patch, ZOOKEEPER-796.patch > > > So currently the pid file has to be tied to the datadirectory when starting > zkServer.sh. It would be good to be able to break them up. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-797) c client source with AI_ADDRCONFIG cannot be compiled with early glibc
[ https://issues.apache.org/jira/browse/ZOOKEEPER-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885511#action_12885511 ] Hudson commented on ZOOKEEPER-797: -- Integrated in ZooKeeper-trunk #869 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/]) ZOOKEEPER-797 c client source with AI_ADDRCONFIG cannot be compiled with early glibc > c client source with AI_ADDRCONFIG cannot be compiled with early glibc > -- > > Key: ZOOKEEPER-797 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-797 > Project: Zookeeper > Issue Type: Improvement > Components: c client >Affects Versions: 3.3.1 > Environment: linux 2.6.9 >Reporter: Qian Ye >Assignee: Qian Ye > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-797.patch > > > c client source with AI_ADDRCONFIG cannot be compiled with early glibc > (before 2.3.3) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-798) Fixup loggraph for FLE changes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885513#action_12885513 ] Hudson commented on ZOOKEEPER-798: -- Integrated in ZooKeeper-trunk #869 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/]) ZOOKEEPER-798. Fixup loggraph for FLE changes > Fixup loggraph for FLE changes > -- > > Key: ZOOKEEPER-798 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-798 > Project: Zookeeper > Issue Type: Sub-task > Components: contrib >Reporter: Ivan Kelly >Assignee: Ivan Kelly >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-798.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-789) Improve FLE log messages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885512#action_12885512 ] Hudson commented on ZOOKEEPER-789: -- Integrated in ZooKeeper-trunk #869 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/]) ZOOKEEPER-789. Improve FLE log messages > Improve FLE log messages > > > Key: ZOOKEEPER-789 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-789 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.3.1 >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-789.patch, ZOOKEEPER-789.patch, > ZOOKEEPER-789.patch, ZOOKEEPER-789.patch > > > Notification messages are quite important to determine what is going with > leader election. The main idea of this improvement is name the fields we > output in notification log messages. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
[ https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885510#action_12885510 ] Hudson commented on ZOOKEEPER-744: -- Integrated in ZooKeeper-trunk #869 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/]) ZOOKEEPER-744. Add monitoring four-letter word > Add monitoring four-letter word > --- > > Key: ZOOKEEPER-744 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744 > Project: Zookeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.4.0 >Reporter: Travis Crawford >Assignee: Andrei Savu > Fix For: 3.4.0 > > Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, > ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch > > > Filing a feature request based on a zookeeper-user discussion. > Zookeeper should have a new four-letter word that returns key-value pairs > appropriate for importing to a monitoring system (such as Ganglia which has a > large installed base) > This command should initially export the following: > (a) Count of instances in the ensemble. > (b) Count of up-to-date instances in the ensemble. > But be designed such that in the future additional data can be added. For > example, the output could define the statistic in a comment, then print a key > "space character" value line: > """ > # Total number of instances in the ensemble > zk_ensemble_instances_total 5 > # Number of instances currently participating in the quorum. > zk_ensemble_instances_active 4 > """ > From the mailing list: > """ > Date: Mon, 19 Apr 2010 12:10:44 -0700 > From: Patrick Hunt > To: zookeeper-u...@hadoop.apache.org > Subject: Re: Recovery issue - how to debug? > On 04/19/2010 11:55 AM, Travis Crawford wrote: > > It would be a lot easier from the operations perspective if the leader > > explicitly published some health stats: > > > > (a) Count of instances in the ensemble. > > (b) Count of up-to-date instances in the ensemble. > > > > This would greatly simplify monitoring& alerting - when an instance > > falls behind one could configure their monitoring system to let > > someone know and take a look at the logs. > That's a great idea. Please enter a JIRA for this - a new 4 letter word > and JMX support. It would also be a great starter project for someone > interested in becoming more familiar with the server code. > Patrick > """ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-778) ability to add a watch on a setData or create call
[ https://issues.apache.org/jira/browse/ZOOKEEPER-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884625#action_12884625 ] Hudson commented on ZOOKEEPER-778: -- Integrated in ZooKeeper-trunk #864 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/864/]) > ability to add a watch on a setData or create call > -- > > Key: ZOOKEEPER-778 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-778 > Project: Zookeeper > Issue Type: Improvement > Components: c client, java client, server >Reporter: Woody Anderson >Priority: Minor > > It is often desirable to set a watch when creating a node or setting data on > a node. Currently, you have to add a watch after the create/set with another > api call, which incurs extra cost, and a window of unobserved state change. > This would "seem" to be an easy addition to the server/client libs, but i'm > not sure if there are reasons this was never proposed or developed. > I currently am most concerned with a data watch in these two scenarios, but i > would imagine other users might be interested in registering a children watch > immediately upon creation. > This change would require adding new method signatures in the clients for > create and setData which took watchers. And some changes to the protocol, as > the SetDataRequest and CreateRequest objects would need watch flags. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-773) Log visualisation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877392#action_12877392 ] Hudson commented on ZOOKEEPER-773: -- Integrated in ZooKeeper-trunk #839 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/839/]) ZOOKEEPER-773. Log visualisation > Log visualisation > - > > Key: ZOOKEEPER-773 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-773 > Project: Zookeeper > Issue Type: Improvement > Components: contrib >Reporter: Ivan Kelly >Assignee: Ivan Kelly >Priority: Minor > Fix For: 3.4.0 > > Attachments: test5.logs.tgz, ZOOKEEPER-773.binaries.tgz, > ZOOKEEPER-773.diff > > > Zkgraph is a log viewer for zookeeper. It can handle transaction logs and > message logs. There are currently two view. > > a) Server view > The server view shows the interactions between the different servers in > an ensemble. The X axis represents time. > * Exceptions show up as red dots. Hovering your mouse over them will > give you more details of the exception > * The colour of the line represents the election state of the server. > - orange means LOOKING for leader > - dark green means the server is the leader > - light green means the server is following a leader > - yellow means there isn't enough information to determine the state > of the server. > * The gray arrows denote election messages between servers. Pink dashed > arrows are messages that were sent but never delivered. >b) Session view > The session view shows the lifetime of sessions on a server. Use the > time filter to narrow down the view. Any more than about 2000 events will > take a long time to view in your browser. > The Y axis represents time in this case. Each line is a session. The > black dots represent events on the session. You can click on the black dots > for more details of the event. > 2 - Compiling & Running > Run "ant jar" in src/contrib/zkgraph/. This will download all dependencies > and compile all the zkgraph code. > Once compilation has finished, you can run it the the zkgraph.sh script in > src/contrib/zkgraph/bin. This will start and embedded web server on you > machine. Navigate to http://localhost:8182/graph/main.html. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-772) zkpython segfaults when watcher from async get children is invoked.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874195#action_12874195 ] Hudson commented on ZOOKEEPER-772: -- Integrated in ZooKeeper-trunk #831 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/]) > zkpython segfaults when watcher from async get children is invoked. > --- > > Key: ZOOKEEPER-772 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-772 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings > Environment: ubuntu lucid (10.04) / zk trunk >Reporter: Kapil Thangavelu >Assignee: Henry Robinson > Fix For: 3.4.0 > > Attachments: asyncgetchildren.py, zkpython-testasyncgetchildren.diff, > ZOOKEEPER-772.patch, ZOOKEEPER-772.patch > > > When utilizing the zkpython async get children api with a watch, i > consistently get segfaults when the watcher is invoked to process events. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members
[ https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874192#action_12874192 ] Hudson commented on ZOOKEEPER-769: -- Integrated in ZooKeeper-trunk #831 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/]) > Leader can treat observers as quorum members > > > Key: ZOOKEEPER-769 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.0 > Environment: Ubuntu Karmic x64 >Reporter: Sergey Doroshenko >Assignee: Sergey Doroshenko > Fix For: 3.4.0 > > Attachments: follower.log, leader.log, observer.log, warning.patch, > zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch > > > In short: it seems leader can treat observers as quorum members. > Steps to repro: > 1. Server configuration: 3 voters, 2 observers (attached). > 2. Bring up 2 voters and one observer. It's enough for quorum. > 3. Shut down the one from the quorum who is the follower. > As I understand, expected result is that leader will start a new election > round so that to regain quorum. > But the real situation is that it just says goodbye to that follower, and is > still operable. (When I'm shutting down 3rd one -- observer -- leader starts > trying to regain a quorum). > (Expectedly, if on step 3 we shut down the leader, not the follower, > remaining follower starta new leader election, as it should be). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-774) Recipes tests are slightly outdated: they do not compile against JUnit 4.8
[ https://issues.apache.org/jira/browse/ZOOKEEPER-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874196#action_12874196 ] Hudson commented on ZOOKEEPER-774: -- Integrated in ZooKeeper-trunk #831 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/]) > Recipes tests are slightly outdated: they do not compile against JUnit 4.8 > -- > > Key: ZOOKEEPER-774 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-774 > Project: Zookeeper > Issue Type: Bug > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sergey Doroshenko >Assignee: Sergey Doroshenko >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-774.patch > > > As title -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-464) Need procedure to garbage collect ledgers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874194#action_12874194 ] Hudson commented on ZOOKEEPER-464: -- Integrated in ZooKeeper-trunk #831 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/]) > Need procedure to garbage collect ledgers > - > > Key: ZOOKEEPER-464 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-464 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Erwin Tam > Fix For: 3.4.0 > > Attachments: zookeeper-464-log.txt, ZOOKEEPER-464.patch, > ZOOKEEPER-464.patch, ZOOKEEPER-464.patch, ZOOKEEPER-464.patch > > > An application using BookKeeper is likely to use a large number of ledgers > over time. Such an application might not need all ledgers created over time > and might want to delete some of these ledgers to free up some space on > bookies. The idea of this jira is to implement a procedure that enables an > application to garbage-collect unwanted ledgers. > To garbage-collect a ledger, we need to delete the ledger metadata on > ZooKeeper, and delete the ledger data on corresponding bookies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874191#action_12874191 ] Hudson commented on ZOOKEEPER-636: -- Integrated in ZooKeeper-trunk #831 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/]) > configure.ac has instructions which override the contents of CFLAGS and > CXXFLAGS. > - > > Key: ZOOKEEPER-636 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 > Project: Zookeeper > Issue Type: Improvement > Components: build, c client >Affects Versions: 3.2.1 >Reporter: Maxim P. Dementiev >Assignee: Maxim P. Dementiev > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-636.patch > > > The information mustn't be overridden. > The template like «CFLAGS="$CFLAGS -some-option"» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-729) Recursively delete a znode - zkCli.sh rmr /node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857268#action_12857268 ] Hudson commented on ZOOKEEPER-729: -- Integrated in ZooKeeper-trunk #794 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/794/]) ZOOKEEPER-729. Java client API to recursively delete a subtree. (Kay Kay via henry) > Recursively delete a znode - zkCli.sh rmr /node > > > Key: ZOOKEEPER-729 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-729 > Project: Zookeeper > Issue Type: New Feature > Components: java client >Reporter: Kay Kay >Assignee: Kay Kay > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, > ZOOKEEPER-729.patch, ZOOKEEPER-729.patch, ZOOKEEPER-729.patch > > > Recursively delete a given znode in zookeeper, from the command-line. > New operation "rmr" added to zkclient. > $ ./zkCli.sh rmr /node -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-3) syncLimit has slightly different comments in the class header, and > inline with the variable.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855396#action_12855396 ] Hudson commented on ZOOKEEPER-3: Integrated in Cassandra #402 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/402/]) r/m contrib/mutex/lib/zookeeper-3.2.2.jar > syncLimit has slightly different comments in the class header, and > inline > with the variable. > --- > > Key: ZOOKEEPER-3 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3 > Project: Zookeeper > Issue Type: Bug > Components: quorum >Reporter: Benjamin Reed >Assignee: Mahadev konar >Priority: Trivial > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-3.patch > > > syncLimit as documented in QuorumPeer is documented twice with two different > aspects of in each instance. It should be better documented and unified. > (Probably remove the second instance.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-724) Improve junit test integration - log harness information
[ https://issues.apache.org/jira/browse/ZOOKEEPER-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852961#action_12852961 ] Hudson commented on ZOOKEEPER-724: -- Integrated in ZooKeeper-trunk #777 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/777/]) > Improve junit test integration - log harness information > > > Key: ZOOKEEPER-724 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-724 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-724.patch > > > Currently we have ad-hoc logging (log4j) of setup/teardown and test > start/end. Without this information it's often difficult to determine > what's going on (major milestones) in the logs relative to the tests > performed. > In junit 4.x "@Rule" annotations have been added that allow this to be done > much more easily. This patch will add this. > In particular we can access the test name easily during setup/teardown and > the test itself. Additionally we can log more information on > success/failure of each test. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-717) add a preferred list to the instancemanager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847812#action_12847812 ] Hudson commented on ZOOKEEPER-717: -- Integrated in ZooKeeper-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/763/]) . add a preferred list to the instancemanager (breed via mahadev) > add a preferred list to the instancemanager > --- > > Key: ZOOKEEPER-717 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-717 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Benjamin Reed >Assignee: Benjamin Reed > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-717.patch > > > it would be nice to be able to list the preferred containers to assign tasks > to when using instance containers. right now assignments are made in hashmap > order which is more or less psuedo-random. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-718) the fatjar is missing libraries
[ https://issues.apache.org/jira/browse/ZOOKEEPER-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847813#action_12847813 ] Hudson commented on ZOOKEEPER-718: -- Integrated in ZooKeeper-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/763/]) . the fatjar is missing libraries (ben via mahadev) > the fatjar is missing libraries > --- > > Key: ZOOKEEPER-718 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-718 > Project: Zookeeper > Issue Type: Bug >Reporter: Benjamin Reed >Assignee: Benjamin Reed > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-718.patch > > > when we moved to ivy, we didn't update the fatjar build.xml to grab libraries > out of the new location that ivy uses for downloaded libraries. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-710) permanent ZSESSIONMOVED error after client app reconnects to zookeeper cluster
[ https://issues.apache.org/jira/browse/ZOOKEEPER-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847815#action_12847815 ] Hudson commented on ZOOKEEPER-710: -- Integrated in ZooKeeper-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/763/]) . Forgot to run ant docs > permanent ZSESSIONMOVED error after client app reconnects to zookeeper cluster > -- > > Key: ZOOKEEPER-710 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-710 > Project: Zookeeper > Issue Type: Bug > Components: server >Affects Versions: 3.2.2 > Environment: debian lenny; ia64; xen virtualization >Reporter: Lukasz Osipiuk >Assignee: Patrick Hunt >Priority: Blocker > Fix For: 3.2.3, 3.3.0 > > Attachments: app1.log.2010-03-16.gz, app2.log.2010-03-16.gz, > ZOOKEEPER-710_3.2.patch, ZOOKEEPER-710_3.3.patch, > zookeeper-node1.log.2010-03-16.gz, zookeeper-node2.log.2010-03-16.gz, > zookeeper-node3.log.2010-03-16.gz > > > Originally problem was described on Users mailing list starting with this > [post|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/201003.mbox/<3b910d891003160743k38e2e7c9y830b182d88396...@mail.gmail.com>]. > Below I restate it in more organized form. > We occasionally (few times a day) observe that our client application > disconnects from Zookeeper cluster. > Application is written in C++ and we are using libzookeeper_mt library. In > version 3.2.2. > The disconnects we are observing are probably related to some problems with > our network infrastructure - we are observing periods with great packet loss > between machines in our DC. > Sometimes after client application (i.e. zookeeper library) reconnects to > zookeeper cluster we are observing that all subsequent requests return > ZSESSIONMOVED error. Restarting client app helps - we always pass 0 as > clientid to zookeeper_init function so old session is not reused. > On 16-03-2010 we observed few occurences of problem. Example ones: > - 22:08; client IP 10.1.112.60 (app1); sessionID 0x22767e1c963 > - 14:21; client IP 10.1.112.61 (app2); sessionID 0x324dcc1ba580085 > I attach logs of cluster and application nodes (only stuff concerining > zookeeper): > - [^zookeeper-node1.log.2010-03-16.gz] - logs of zookeepr cluster node 1 > 10.1.112.62 > - [^zookeeper-node2.log.2010-03-16.gz] - logs of zookeepr cluster node 2 > 10.1.112.63 > - [^zookeeper-node3.log.2010-03-16.gz] - logs of zookeepr cluster node 3 > 10.1.112.64 > - [^app1.log.2010-03-16.gz] - application logs of app1 10.1.112.60 > - [^app2.log.2010-03-16.gz] - application logs of app2 10.1.112.61 > I also made some analysis of case at 22:08: > - Network glitch which resulted in problem occurred at about 22:08. > - From what I see since 17:48 node2 was the leader and it did not > change later yesterday. > - Client was connected to node2 since 17:50 > - At around 22:09 client tried to connect to every node (1,2,3). > Connections to node1 and node3 were closed > with exception "Exception causing close of session 0x22767e1c963 > due to java.io.IOException: Read error". > Connection to node2 stood alive. > - All subsequent operations were refused with ZSESSIONMOVED error. > Error visible both on client and on server side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-436) Bookies should auto register to ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847814#action_12847814 ] Hudson commented on ZOOKEEPER-436: -- Integrated in ZooKeeper-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/763/]) > Bookies should auto register to ZooKeeper > - > > Key: ZOOKEEPER-436 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-436 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Benjamin Reed >Assignee: Erwin Tam > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-436.patch, ZOOKEEPER-436.patch, > ZOOKEEPER-436.patch > > > currently bookies have to be manually added to ZooKeeper to be used in a > BookKeeper service. we should be able to just start up a bookkie, point it at > ZooKeeper, and have it get auto integrated in. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-708) zkpython failing due to undefined symbol deallocate_String_vector
[ https://issues.apache.org/jira/browse/ZOOKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846844#action_12846844 ] Hudson commented on ZOOKEEPER-708: -- Integrated in ZooKeeper-trunk #761 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/761/]) . zkpython failing due to undefined symbol deallocate_String_vector > zkpython failing due to undefined symbol deallocate_String_vector > - > > Key: ZOOKEEPER-708 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-708 > Project: Zookeeper > Issue Type: Bug > Components: c client, contrib-bindings >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-708.patch, ZOOKEEPER-708.patch, > ZOOKEEPER-708.patch > > > ant test in zkpython is failing. I think this is due to mahadev's changes to > remove unnecessary exports from the client lib. > [exec] ImportError: > /home/phunt/dev/workspace/gitzk/build/contrib/zkpython/lib.linux-x86_64-2.6/zookeeper.so: > undefined symbol: deallocate_String_vector > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-709) bookkeeper build failing with missing factory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846845#action_12846845 ] Hudson commented on ZOOKEEPER-709: -- Integrated in ZooKeeper-trunk #761 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/761/]) . bookkeeper build failing with missing factory > bookkeeper build failing with missing factory > - > > Key: ZOOKEEPER-709 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-709 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bookkeeper >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Blocker > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-709.patch > > > ant test in bookkeeper results in > compile-test: > [javac] Compiling 10 source files to > /home/phunt/dev/workspace/gitzk/build/contrib/bookkeeper/test > [javac] > /home/phunt/dev/workspace/gitzk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/BaseTestCase.java:91: > cannot find symbol > [javac] symbol : constructor Factory(java.lang.Integer) > [javac] location: class org.apache.zookeeper.server.NIOServerCnxn.Factory > [javac] serverFactory = new > NIOServerCnxn.Factory(ZooKeeperDefaultPort); > [javac] ^ > [javac] 1 error > Flavio can you take a look at this one? (patch) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-591) The C Client cannot exit properly in some situation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846624#action_12846624
]
Hudson commented on ZOOKEEPER-591:
--
Integrated in ZooKeeper-trunk #755 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/755/])
. The C Client cannot exit properly in some situation
> The C Client cannot exit properly in some situation
> ---
>
> Key: ZOOKEEPER-591
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-591
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.2.1
> Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr
> 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Qian Ye
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-591.patch, ZOOKEEPER-591.patch,
> ZOOKEEPER-591.patch, ZOOKEEPER-591.patch, ZOOKEEPER-591_1.patch,
> ZOOKEEPER-591_1.patch, ZOOKEEPER-591_1.patch, ZOOKEEPER-591_2.patch, zootest.c
>
>
> The following code produce a situation, where the C Client can not exit
> properly,
> #include "include/zookeeper.h"
> void default_zoo_watcher(zhandle_t *zzh, int type, int state, const char
> *path, void* context){
> int zrc = 0;
> struct String_vector str_vec = {0, NULL};
> printf("in the default_zoo_watcher\n");
> zrc = zoo_wget_children(zzh, "/mytest", default_zoo_watcher, NULL,
> &str_vec);
> printf("zoo_wget_children, error: %d\n", zrc);
> return;
> }
> int main()
> {
> int zrc = 0;
> int buff_len = 10;
> char buff[10] = "hello";
> char path[512];
> struct Stat stat;
> struct String_vector str_vec = {0, NULL};
> zhandle_t *zh = zookeeper_init("10.81.20.62:2181", NULL, 3, 0, 0, 0);
> zrc = zoo_create(zh, "/mytest", buff, 10, &ZOO_OPEN_ACL_UNSAFE, 0, path,
> 512);
> printf("zoo_create, error: %d\n", zrc);
> zrc = zoo_wget_children(zh, "/mytest", default_zoo_watcher, NULL,
> &str_vec);
> printf("zoo_wget_children, error: %d\n", zrc);
> zrc = zoo_create(zh, "/mytest/test1", buff, 10, &ZOO_OPEN_ACL_UNSAFE, 0,
> path, 512);
> printf("zoo_create, error: %d\n", zrc);
> zrc = zoo_wget_children(zh, "/mytest", default_zoo_watcher, NULL,
> &str_vec);
> printf("zoo_wget_children, error: %d\n", zrc);
> zrc = zoo_delete(zh, "/mytest/test1", -1);
> printf("zoo_delete, error: %d\n", zrc);
> zookeeper_close(zh);
> return 0;
> }
> running this code can cause the program hang at zookeeper_close(zh);(line
> 38). using gdb to attach the process, I found that the main thread is waiting
> for do_completion thread to finish,
> (gdb) bt
> #0 0x00302b806ffb in pthread_join () from /lib64/tls/libpthread.so.0
> #1 0x0040de3b in adaptor_finish (zh=0x515b60) at src/mt_adaptor.c:219
> #2 0x004060ba in zookeeper_close (zh=0x515b60) at
> src/zookeeper.c:2100
> #3 0x0040220b in main ()
> and the thread which handle the zoo_wget_children(in the default_zoo_watcher)
> is waiting for sc->cond.
> (gdb) thread 2
> [Switching to thread 2 (Thread 1094719840 (LWP 25093))]#0 0x00302b8089aa
> in pthread_cond_wait@@GLIBC_2.3.2 ()
>from /lib64/tls/libpthread.so.0
> (gdb) bt
> #0 0x00302b8089aa in pthread_cond_wait@@GLIBC_2.3.2 () from
> /lib64/tls/libpthread.so.0
> #1 0x0040d88b in wait_sync_completion (sc=0x5167f0) at
> src/mt_adaptor.c:82
> #2 0x004082c9 in zoo_wget_children (zh=0x515b60, path=0x40ebc0
> "/mytest", watcher=0x401fd8 , watcherCtx=Variable
> "watcherCtx" is not available.)
> at src/zookeeper.c:2884
> #3 0x00402037 in default_zoo_watcher ()
> #4 0x0040d664 in deliverWatchers (zh=0x515b60, type=4, state=3,
> path=0x515100 "/mytest", list=0x5177d8) at src/zk_hashtable.c:274
> #5 0x00403861 in process_completions (zh=0x515b60) at
> src/zookeeper.c:1631
> #6 0x0040e1b5 in do_completion (v=Variable "v" is not available.) at
> src/mt_adaptor.c:333
> #7 0x00302b80610a in start_thread () from /lib64/tls/libpthread.so.0
> #8 0x00302afc6003 in clone () from /lib64/tls/libc.so.6
> #9 0x in ?? ()
> here, a deadlock presents.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-591) The C Client cannot exit properly in some situation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846376#action_12846376
]
Hudson commented on ZOOKEEPER-591:
--
Integrated in ZooKeeper-trunk #754 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/754/])
. The C Client cannot exit properly in some situation (mahadev)
> The C Client cannot exit properly in some situation
> ---
>
> Key: ZOOKEEPER-591
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-591
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.2.1
> Environment: Linux db-passport-test05.vm 2.6.9_5-4-0-5 #1 SMP Tue Apr
> 14 15:56:24 CST 2009 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Qian Ye
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-591.patch, ZOOKEEPER-591.patch,
> ZOOKEEPER-591.patch, ZOOKEEPER-591.patch, ZOOKEEPER-591_1.patch,
> ZOOKEEPER-591_1.patch, ZOOKEEPER-591_1.patch, zootest.c
>
>
> The following code produce a situation, where the C Client can not exit
> properly,
> #include "include/zookeeper.h"
> void default_zoo_watcher(zhandle_t *zzh, int type, int state, const char
> *path, void* context){
> int zrc = 0;
> struct String_vector str_vec = {0, NULL};
> printf("in the default_zoo_watcher\n");
> zrc = zoo_wget_children(zzh, "/mytest", default_zoo_watcher, NULL,
> &str_vec);
> printf("zoo_wget_children, error: %d\n", zrc);
> return;
> }
> int main()
> {
> int zrc = 0;
> int buff_len = 10;
> char buff[10] = "hello";
> char path[512];
> struct Stat stat;
> struct String_vector str_vec = {0, NULL};
> zhandle_t *zh = zookeeper_init("10.81.20.62:2181", NULL, 3, 0, 0, 0);
> zrc = zoo_create(zh, "/mytest", buff, 10, &ZOO_OPEN_ACL_UNSAFE, 0, path,
> 512);
> printf("zoo_create, error: %d\n", zrc);
> zrc = zoo_wget_children(zh, "/mytest", default_zoo_watcher, NULL,
> &str_vec);
> printf("zoo_wget_children, error: %d\n", zrc);
> zrc = zoo_create(zh, "/mytest/test1", buff, 10, &ZOO_OPEN_ACL_UNSAFE, 0,
> path, 512);
> printf("zoo_create, error: %d\n", zrc);
> zrc = zoo_wget_children(zh, "/mytest", default_zoo_watcher, NULL,
> &str_vec);
> printf("zoo_wget_children, error: %d\n", zrc);
> zrc = zoo_delete(zh, "/mytest/test1", -1);
> printf("zoo_delete, error: %d\n", zrc);
> zookeeper_close(zh);
> return 0;
> }
> running this code can cause the program hang at zookeeper_close(zh);(line
> 38). using gdb to attach the process, I found that the main thread is waiting
> for do_completion thread to finish,
> (gdb) bt
> #0 0x00302b806ffb in pthread_join () from /lib64/tls/libpthread.so.0
> #1 0x0040de3b in adaptor_finish (zh=0x515b60) at src/mt_adaptor.c:219
> #2 0x004060ba in zookeeper_close (zh=0x515b60) at
> src/zookeeper.c:2100
> #3 0x0040220b in main ()
> and the thread which handle the zoo_wget_children(in the default_zoo_watcher)
> is waiting for sc->cond.
> (gdb) thread 2
> [Switching to thread 2 (Thread 1094719840 (LWP 25093))]#0 0x00302b8089aa
> in pthread_cond_wait@@GLIBC_2.3.2 ()
>from /lib64/tls/libpthread.so.0
> (gdb) bt
> #0 0x00302b8089aa in pthread_cond_wait@@GLIBC_2.3.2 () from
> /lib64/tls/libpthread.so.0
> #1 0x0040d88b in wait_sync_completion (sc=0x5167f0) at
> src/mt_adaptor.c:82
> #2 0x004082c9 in zoo_wget_children (zh=0x515b60, path=0x40ebc0
> "/mytest", watcher=0x401fd8 , watcherCtx=Variable
> "watcherCtx" is not available.)
> at src/zookeeper.c:2884
> #3 0x00402037 in default_zoo_watcher ()
> #4 0x0040d664 in deliverWatchers (zh=0x515b60, type=4, state=3,
> path=0x515100 "/mytest", list=0x5177d8) at src/zk_hashtable.c:274
> #5 0x00403861 in process_completions (zh=0x515b60) at
> src/zookeeper.c:1631
> #6 0x0040e1b5 in do_completion (v=Variable "v" is not available.) at
> src/mt_adaptor.c:333
> #7 0x00302b80610a in start_thread () from /lib64/tls/libpthread.so.0
> #8 0x00302afc6003 in clone () from /lib64/tls/libc.so.6
> #9 0x in ?? ()
> here, a deadlock presents.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-624) The C Client cause core dump when receive error data from Zookeeper Server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846239#action_12846239
]
Hudson commented on ZOOKEEPER-624:
--
Integrated in ZooKeeper-trunk #752 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/752/])
. The C Client cause core dump when receive error data from Zookeeper
Server (mahadev)
> The C Client cause core dump when receive error data from Zookeeper Server
> --
>
> Key: ZOOKEEPER-624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-624
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.2.0
> Environment: Linux 2.6.9 x86_64
>Reporter: Qian Ye
>Assignee: Mahadev konar
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-624.patch, ZOOKEEPER-624.patch
>
>
> I encountered a problem today that the Zookeeper C Client (version 3.2.0)
> core dump when reconnected and did some operations on the zookeeper server
> which just restarted. The gdb infomation is like:
> (gdb) bt
> #0 0x00302af71900 in memcpy () from /lib64/tls/libc.so.6
> #1 0x0047bfe4 in ia_deserialize_string (ia=Variable "ia" is not
> available.) at src/recordio.c:270
> #2 0x0047ed20 in deserialize_CreateResponse (in=0x9cd870,
> tag=0x50a74e "reply", v=0x409ffe70) at generated/zookeeper.jute.c:679
> #3 0x0047a1d0 in zookeeper_process (zh=0x9c8c70, events=Variable
> "events" is not available.) at src/zookeeper.c:1895
> #4 0x004815e6 in do_io (v=Variable "v" is not available.) at
> src/mt_adaptor.c:310
> #5 0x00302b80610a in start_thread () from /lib64/tls/libpthread.so.0
> #6 0x00302afc6003 in clone () from /lib64/tls/libc.so.6
> #7 0x in ?? ()
> (gdb) f 1
> #1 0x0047bfe4 in ia_deserialize_string (ia=Variable "ia" is not
> available.) at src/recordio.c:270
> 270 in src/recordio.c
> (gdb) info locals
> priv = (struct buff_struct *) 0x9cd8d0
> len = -1
> rc = Variable "rc" is not available.
> According to the source code,
> int ia_deserialize_string(struct iarchive *ia, const char *name, char **s)
> {
> struct buff_struct *priv = ia->priv;
> int32_t len;
> int rc = ia_deserialize_int(ia, "len", &len);
> if (rc < 0)
> return rc;
> if ((priv->len - priv->off) < len) {
> return -E2BIG;
> }
> *s = malloc(len+1);
> if (!*s) {
> return -ENOMEM;
> }
> memcpy(*s, priv->buffer+priv->off, len);
> (*s)[len] = '\0';
> priv->off += len;
> return 0;
> }
> the variable len is set by ia_deserialize_int, and the returned len doesn't
> been checked, so the client segment fault when trying to memcpy -1 byte data.
> In the source file recordio.c, there are many functions which don't check the
> returned len. They all might cause segment fault in some kind of situations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-586) c client does not compile under cygwin
[ https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846212#action_12846212 ] Hudson commented on ZOOKEEPER-586: -- Integrated in ZooKeeper-trunk #749 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/749/]) . c client does not compile under cygwin > c client does not compile under cygwin > -- > > Key: ZOOKEEPER-586 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, > ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, > ZOOKEEPER-586.patch > > > the c client fails to compile under cygwin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846190#action_12846190 ] Hudson commented on ZOOKEEPER-121: -- Integrated in ZooKeeper-trunk #746 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/746/]) . SyncRequestProcessor is not closing log stream during shutdown > SyncRequestProcessor is not closing log stream during shutdown > -- > > Key: ZOOKEEPER-121 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 > Project: Zookeeper > Issue Type: Bug > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, > ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121_3.patch, > ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch, ZOOKEEPER-121_4.patch > > > The SyncRequestProcessor is not closing log stream during shutdown. > See FIXMEs with this ID in ClientBase.java -- I've commented out the > assertion for the time being (checking for logs being deleted), as part of > this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846140#action_12846140 ] Hudson commented on ZOOKEEPER-121: -- Integrated in ZooKeeper-trunk #744 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/744/]) . SyncRequestProcessor is not closing log stream during shutdown (3rd attempt) > SyncRequestProcessor is not closing log stream during shutdown > -- > > Key: ZOOKEEPER-121 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 > Project: Zookeeper > Issue Type: Bug > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, > ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, ZOOKEEPER-121_3.patch, > ZOOKEEPER-121_3.patch, ZOOKEEPER-121_3.patch > > > The SyncRequestProcessor is not closing log stream during shutdown. > See FIXMEs with this ID in ClientBase.java -- I've commented out the > assertion for the time being (checking for logs being deleted), as part of > this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845594#action_12845594 ] Hudson commented on ZOOKEEPER-698: -- Integrated in ZooKeeper-trunk #738 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/]) > intermittent JMX test failures due to not verifying QuorumPeer shutdown > > > Key: ZOOKEEPER-698 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698 > Project: Zookeeper > Issue Type: Bug > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-698.patch > > > in some cases the tests are failing with JMX errors. From the logs I can see > that QP was shutdown, however it did not exit it's thread until some time > much later. This is causing interference with subsequent tests, causing the > test to fail. > I have a patch that attempts to verify that the QP was shutdown (by joining > the thread). It turns out that tests based on QuorumBase do this check (join) > however some of the other tests do not. I believe this will address the issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-604) zk needs to prevent export of any symbol not listed in their api
[ https://issues.apache.org/jira/browse/ZOOKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845593#action_12845593 ] Hudson commented on ZOOKEEPER-604: -- Integrated in ZooKeeper-trunk #738 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/]) > zk needs to prevent export of any symbol not listed in their api > > > Key: ZOOKEEPER-604 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-604 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.2.0, 3.2.1, 3.2.2, > 3.3.0, 4.0.0 > Environment: All >Reporter: Alex Newman >Assignee: Mahadev konar >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-604.patch > > > Currently the zookeeper seems to be exporting symbols not in the api. An > example of this seems to be the symbol hash, which interferes with me using > memcached and zookeeper in the same program. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845596#action_12845596 ] Hudson commented on ZOOKEEPER-121: -- Integrated in ZooKeeper-trunk #738 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/]) > SyncRequestProcessor is not closing log stream during shutdown > -- > > Key: ZOOKEEPER-121 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121 > Project: Zookeeper > Issue Type: Bug > Components: server >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Blocker > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, > ZOOKEEPER-121.patch, ZOOKEEPER-121.patch > > > The SyncRequestProcessor is not closing log stream during shutdown. > See FIXMEs with this ID in ClientBase.java -- I've commented out the > assertion for the time being (checking for logs being deleted), as part of > this fix re-enable these asserts and also verify tests on a Windows system. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-601) allow configuration of session timeout min/max bounds
[ https://issues.apache.org/jira/browse/ZOOKEEPER-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845595#action_12845595 ] Hudson commented on ZOOKEEPER-601: -- Integrated in ZooKeeper-trunk #738 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/738/]) > allow configuration of session timeout min/max bounds > - > > Key: ZOOKEEPER-601 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-601 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-601.patch, ZOOKEEPER-601.patch > > > ZK servers currently enforce a min/max boundary on client session timeout > relative to the ticktime setting, detailed here: > http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#ch_zkSessions > In general there are good reasons for this however in some cases, in > particular with HBase region servers, we have seen a need to allow this bound > to be set differently (higher). The Sun jvm can GC pause for very long times > (in some cases we've seen 4 minutes even with the "realtime" gc. > It would be good to allow this bound to be set via configuration parameters. > Note: 4letterword and JMX integration would be needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-511) bad error handling in FollowerHandler.sendPackets
[ https://issues.apache.org/jira/browse/ZOOKEEPER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844451#action_12844451 ] Hudson commented on ZOOKEEPER-511: -- Integrated in ZooKeeper-trunk #733 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/733/]) . bad error handling in FollowerHandle.sendPackets (mahadev via flavio) > bad error handling in FollowerHandler.sendPackets > - > > Key: ZOOKEEPER-511 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-511 > Project: Zookeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.2.0 >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-511.patch > > > in FollowerHandler if sendPackets gets an ioexception on writeRecord the send > thread will exit, however the > socket isn't necessarily closed. > 2009-08-19 15:28:46,869 - WARN [Sender-/127.0.0.1:58179:followerhand...@131] > - Unexpected exception > at > org.apache.zookeeper.server.quorum.FollowerHandler.sendPackets(FollowerHandler.java:128) > at > org.apache.zookeeper.server.quorum.FollowerHandler.access$0(FollowerHandler.java:107) > at > org.apache.zookeeper.server.quorum.FollowerHandler$1.run(FollowerHandler.java:325) > This results in the follower taking a very long time to recover and rejoin > the quorum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-693) TestObserver stuck in tight notification loop in FLE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844055#action_12844055 ] Hudson commented on ZOOKEEPER-693: -- Integrated in ZooKeeper-trunk #732 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/732/]) . TestObserver stuck in tight notification loop in FLE > TestObserver stuck in tight notification loop in FLE > > > Key: ZOOKEEPER-693 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-693 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Henry Robinson >Assignee: Flavio Paiva Junqueira >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-693.patch, ZOOKEEPER-693.patch > > > See > http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/77/testReport/junit/org.apache.zookeeper.test/ObserverTest/testObserver/ > [exec] [junit] 2010-03-04 00:23:37,803 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:11229:fastleaderelect...@683] - Notification > time out: 3200 > [exec] [junit] 2010-03-04 00:23:37,804 - INFO > [QuorumPeer:/0:0:0:0:0:0:0:0:11229:fastleaderelect...@689] - Notification: 2, > 0, 2, 3, LOOKING, LOOKING, 1 > ad infinitum. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-696) NPE in the hudson logs, seems nioservercnxn closed twice
[ https://issues.apache.org/jira/browse/ZOOKEEPER-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844057#action_12844057 ] Hudson commented on ZOOKEEPER-696: -- Integrated in ZooKeeper-trunk #732 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/732/]) . NPE in the hudson logs, seems nioservercnxn closed twice (phunt via mahadev) > NPE in the hudson logs, seems nioservercnxn closed twice > > > Key: ZOOKEEPER-696 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-696 > Project: Zookeeper > Issue Type: Bug > Components: server >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Blocker > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-696.patch > > > seeing the following on the console for > http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/729/ > looks like the cnxn is closed twice? (the second time 'sock' is null). > perhaps it's due to client closing and sending session term, then closing > socket, server sees the read return -1, so closes cnxn, then sees the session > close request (which was queued)? > [junit] 2010-03-10 03:15:53,205 - INFO [main:nioserverc...@1232] - > Closed socket connection for client /127.0.0.1:41285 which had sessionid > 0x127461233fc > [junit] 2010-03-10 03:15:53,206 - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:nioservercnxn$fact...@269] - > Ignoring unexpected runtime exception > [junit] java.lang.NullPointerException > [junit] at > org.apache.zookeeper.server.NIOServerCnxn.close(NIOServerCnxn.java:1232) > [junit] at > org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:594) > [junit] at > org.apache.zookeeper.server.NIOServerCnxn$Factory.run(NIOServerCnxn.java:259) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-692) upgrade junit to latest version (4.8.1)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844054#action_12844054 ] Hudson commented on ZOOKEEPER-692: -- Integrated in ZooKeeper-trunk #732 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/732/]) . upgrade junit to latest version (4.8.1) (phunt via mahadev) > upgrade junit to latest version (4.8.1) > --- > > Key: ZOOKEEPER-692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-692 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Minor > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-692.patch > > > upgrade junit to 4.8.1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-677) c client doesn't allow ipv6 numeric connect string
[ https://issues.apache.org/jira/browse/ZOOKEEPER-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844056#action_12844056 ] Hudson commented on ZOOKEEPER-677: -- Integrated in ZooKeeper-trunk #732 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/732/]) . c client doesn't allow ipv6 numeric connect string > c client doesn't allow ipv6 numeric connect string > -- > > Key: ZOOKEEPER-677 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-677 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.2.2 >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-677.patch, ZOOKEEPER-677.patch, > ZOOKEEPER-677.patch, ZOOKEEPER-677.patch, ZOOKEEPER-677.patch > > > The c client doesn't handle ipv6 numeric addresses as they are colon : > delmited. After splitting the host/port on : we look for the port as the > second entry in the array rather than the last entry in the array. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-684) Race in LENonTerminateTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843398#action_12843398 ] Hudson commented on ZOOKEEPER-684: -- Integrated in ZooKeeper-trunk #726 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/726/]) . Race in LENonTerminateTest > Race in LENonTerminateTest > -- > > Key: ZOOKEEPER-684 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-684 > Project: Zookeeper > Issue Type: Bug > Components: leaderElection, server >Reporter: Flavio Paiva Junqueira >Assignee: Henry Robinson >Priority: Critical > Fix For: 3.3.0 > > Attachments: zookeeper-684-test-failure.rtf, ZOOKEEPER-684.patch, > ZOOKEEPER-684.patch, ZOOKEEPER-684.patch > > > testNonTermination failed during a Hudson run for ZOOKEEPER-59. After > inspecting the output, it looks like server is electing 2 as a leader and > leaving. Given that 2 is just a mock server, server 0 remains alone in leader > election. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-691) Interface changed for NIOServer.Factory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843397#action_12843397 ] Hudson commented on ZOOKEEPER-691: -- Integrated in ZooKeeper-trunk #726 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/726/]) > Interface changed for NIOServer.Factory > --- > > Key: ZOOKEEPER-691 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-691 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bookkeeper >Reporter: Benjamin Reed >Assignee: Benjamin Reed > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-691.patch > > > BookKeeper starts a ZooKeeper server and needs to create an > NIOServer.Factory, but the constructor changed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-688) explain session expiration better in the docs & faq
[ https://issues.apache.org/jira/browse/ZOOKEEPER-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842242#action_12842242 ] Hudson commented on ZOOKEEPER-688: -- Integrated in ZooKeeper-trunk #716 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/716/]) . explain session expiration better in the docs & faq (phunt via mahadev) > explain session expiration better in the docs & faq > --- > > Key: ZOOKEEPER-688 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-688 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-688.patch, ZOOKEEPER-688.patch > > > We are not clear enough (and the diagram we do have seems misleading) on > _when_ session expirations are generated. In particular the fact that you > only get expirations when the client is connected to the cluster, not when > disconnected. > we need to detail: > 1) when do you get expiration > 2) what is the sequence of events that the watcher sees, from disco state, to > getting the expiration (say the expiration happens when the client is disco, > what do you see in the watcher while you are getting reconnected) > 3) we need to give some examples of how to test this. We should be explicit > that "pulling the network cable" on the client will not show expiration since > the cliient will not be reconnected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-622) Test for pending watches in send_set_watches should be moved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842243#action_12842243
]
Hudson commented on ZOOKEEPER-622:
--
Integrated in ZooKeeper-trunk #716 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/716/])
. Test for pending watches in send_set_watches should be moved (ben and
steven via mahadev)
> Test for pending watches in send_set_watches should be moved
>
>
> Key: ZOOKEEPER-622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-622
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
>Reporter: Steven Cheng
>Assignee: Benjamin Reed
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-622.patch, ZOOKEEPER-622.patch,
> ZOOKEEPER-622.patch, ZOOKEEPER-622.patch
>
>
> Valgrind found:
> {quote}
> ==2357== Conditional jump or move depends on uninitialised value(s)
> ==2357==at 0x807FDCA: check_events (zookeeper.c:1180)
> ==2357==by 0x808043A: zookeeper_process (zookeeper.c:1775)
> ==2357==by 0x806A21B: Zookeeper_close::testCloseConnected1()
> (TestZookeeperClose.cc:161)
> ==2357==by 0x806C6BF: CppUnit::TestCaller::runTest()
> (TestCaller.h:166)
> {quote}
> zookeeper.c:1180 was the first if in send_set_watches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841813#action_12841813
]
Hudson commented on ZOOKEEPER-640:
--
Integrated in ZooKeeper-trunk #715 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/715/])
. make build.xml more configurable to ease packaging for linux distros
(phunt via mahadev)
> make build.xml more configurable to ease packaging for linux distros
>
>
> Key: ZOOKEEPER-640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Thomas Koch
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-640.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
> excluding contrib/rest from the build without patching the upstream tarball.
> Could you please add some properties to your build.xml that allow me to
> (de)select contribs? In the example below I can easily override the
> properties:
>
>
>
>
> dir="."
>includes="${contribfilesetincludes}"
>excludes="${contribfilesetexcludes}"
>/>
>
>
>
>
>
> Could you please also add a line to project.classpath:
>
>
> For Debian I may not compile based on the jar files in lib but must use the
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-687) LENonterminatetest fails on some machines.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841814#action_12841814
]
Hudson commented on ZOOKEEPER-687:
--
Integrated in ZooKeeper-trunk #715 (See
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/715/])
. LENonterminatetest fails on some machines. (mahadev)
> LENonterminatetest fails on some machines.
> --
>
> Key: ZOOKEEPER-687
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-687
> Project: Zookeeper
> Issue Type: Bug
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-687.patch, ZOOKEEPER-687.patch
>
>
> LENonterminateTest fails with the following error:
> {noformat}
> 2010-03-04 20:26:32,347 - INFO [Thread-0:leaderelect...@155] - Server
> address: 0.0.0.0/0.0.0.0:11223
> 2010-03-04 20:26:32,348 - WARN [Thread-0:leaderelect...@195] - Ignoring
> exception while looking for leader
> java.io.IOException: Network is unreachable
> at java.net.PlainDatagramSocketImpl.send(Native Method)
> at java.net.DatagramSocket.send(DatagramSocket.java:612)
> at
> org.apache.zookeeper.server.quorum.LeaderElection.lookForLeader(LeaderElection.java:169)
> at
> org.apache.zookeeper.test.LENonTerminateTest$LEThread.run(LENonTerminateTest.java:83)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-681) Minor doc issue re unset maxClientCnxns
[ https://issues.apache.org/jira/browse/ZOOKEEPER-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841811#action_12841811 ] Hudson commented on ZOOKEEPER-681: -- Integrated in ZooKeeper-trunk #715 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/715/]) . Minor doc issue re unset maxClientCnxns (phunt via mahadev) > Minor doc issue re unset maxClientCnxns > --- > > Key: ZOOKEEPER-681 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-681 > Project: Zookeeper > Issue Type: Bug > Components: documentation >Affects Versions: 3.2.2 >Reporter: Vegard B. Havdal >Assignee: Patrick Hunt >Priority: Blocker > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-681.patch > > > Just a small issue, the doc says that "Setting this to 0 or omitting it > entirely removes the limit on concurrent connections.", but we ran without > this setting, and saw: WARN > [NIOServerCxn.Factory:2181:nioservercnxn$fact...@226] - Too many connections > from /10.76.251.190 - max is 10 > Bug in doc possibly? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841812#action_12841812 ] Hudson commented on ZOOKEEPER-579: -- Integrated in ZooKeeper-trunk #715 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/715/]) . zkpython needs more test coverage for ACL code paths (henry via mahadev) > zkpython needs more test coverage for ACL code paths > > > Key: ZOOKEEPER-579 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bindings >Affects Versions: 3.2.1 >Reporter: Henry Robinson >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: zookeeper-579.patch, zookeeper-579.patch > > > zkpython's tests don't do a good enough job of exercising the ACL code paths. > A few new tests that confirm that setACL and friends are working correctly > are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-485) need ops documentation that details supervision of ZK server processes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838330#action_12838330 ] Hudson commented on ZOOKEEPER-485: -- Integrated in ZooKeeper-trunk #706 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/706/]) . Need ops documentation that details supervision of ZK server processes. (phunt via mahadev) > need ops documentation that details supervision of ZK server processes > -- > > Key: ZOOKEEPER-485 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-485 > Project: Zookeeper > Issue Type: Bug > Components: documentation, server >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-485.patch > > > We need ops documentation detailing what to do if the ZK server VM fails - by > fail I mean the jvm process > exits/dies/crashes/etc... > In general a supervisor process should be used to start/stop/restart/etc... > the ZK server vm. > Something like daemontools http://cr.yp.to/daemontools.html could be used, or > more simply a wrapper script > should monitor the status of the pid and restart if the jvm fails. It's up to > the operator, if this is not done > automatically then it will have to be done manually, by operator restarting > the ZK server jvm > The inherent behavior of ZK wrt to failures - ie that it automatically > recovers as long as quorum is maintained - > fits into this nicely. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-669) watchedevent tostring should clearly output the state/type/path
[ https://issues.apache.org/jira/browse/ZOOKEEPER-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837741#action_12837741 ] Hudson commented on ZOOKEEPER-669: -- Integrated in ZooKeeper-trunk #705 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/705/]) . watchedevent tostring should clearly output the state/type/path (phunt via mahadev) > watchedevent tostring should clearly output the state/type/path > --- > > Key: ZOOKEEPER-669 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-669 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.1.2, 3.2.2 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Critical > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-669.patch > > > the current tostring method is broken -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-569) Failure of elected leader can lead to never-ending leader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836356#action_12836356 ] Hudson commented on ZOOKEEPER-569: -- Integrated in ZooKeeper-trunk #703 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/703/]) . Failure of elected leader can lead to never-ending leader election (henry via flavio) > Failure of elected leader can lead to never-ending leader election > -- > > Key: ZOOKEEPER-569 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-569 > Project: Zookeeper > Issue Type: Bug >Reporter: Henry Robinson >Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: zookeeper-569.patch, ZOOKEEPER-569.patch, > zookeeper-569.patch, zookeeper-569.patch, zookeeper-569.patch, > zookeeper-569.patch > > > It is possible for basic LeaderElection to enter a situation where it never > terminates. > As an example, consider a three node cluster A, B and C. > 1. In the first round, A votes for A, B votes for B and C votes for C > 2. Since C > B > A, all nodes resolve to vote for C in the second round as > there is no first round winner > 3. A, B vote for C, but C fails. > 4. C is not elected because neither A nor B hear from it, and so votes for it > are discarded > 5. A and B never reset their votes, despite not hearing from C, so continue > to vote for it ad infinitum. > Step 5 is the bug. If A and B reset their votes to themselves in the case > where the heard-from vote set is empty, leader election will continue. > I do not know if this affects running ZK clusters, as it is possible that the > out-of-band failure detection protocols may cause leader election to be > restarted anyhow, but I've certainly seen this in tests. > I have a trivial patch which fixes it, but it needs a test (and tests for > race conditions are hard to write!) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-524) DBSizeTest is not really testing anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836149#action_12836149 ] Hudson commented on ZOOKEEPER-524: -- Integrated in ZooKeeper-trunk #702 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/702/]) . DBSizeTest is not really testing anything > DBSizeTest is not really testing anything > - > > Key: ZOOKEEPER-524 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524 > Project: Zookeeper > Issue Type: Bug > Components: server, tests >Reporter: Patrick Hunt >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.3.0 > > > DBSizeTest looks like it should be testing latency, but it doesn't seem to do > it (assert is commented out). > We need to decide if this test should be fixed, or just dropped. > Also note: this test takes 40seconds on my system. Way too long. Perhaps > async create operations should be used > to populate the database. I also noticed that data size has a big impact on > overall test time (1k vs 5 bytes is something > like a 2x time diff for time to run the test). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-668) Close method in LedgerInputStream doesn't do anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836049#action_12836049 ] Hudson commented on ZOOKEEPER-668: -- Integrated in ZooKeeper-trunk #701 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/]) > Close method in LedgerInputStream doesn't do anything > - > > Key: ZOOKEEPER-668 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-668 > Project: Zookeeper > Issue Type: Bug >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-668.patch, ZOOKEEPER-668.patch > > > I think we should remove the close call in LedgerInputStream. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-673) Fix observer documentation regarding leader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836048#action_12836048 ] Hudson commented on ZOOKEEPER-673: -- Integrated in ZooKeeper-trunk #701 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/]) > Fix observer documentation regarding leader election > > > Key: ZOOKEEPER-673 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-673 > Project: Zookeeper > Issue Type: Bug >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-673.patch > > > We just need to remove the first two paragraphs of Section 2. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-665) Add BookKeeper streaming documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836050#action_12836050 ] Hudson commented on ZOOKEEPER-665: -- Integrated in ZooKeeper-trunk #701 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/]) > Add BookKeeper streaming documentation > --- > > Key: ZOOKEEPER-665 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-665 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-665.patch, ZOOKEEPER-665.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-672) typo nits across documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836045#action_12836045 ] Hudson commented on ZOOKEEPER-672: -- Integrated in ZooKeeper-trunk #701 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/701/]) > typo nits across documentation > --- > > Key: ZOOKEEPER-672 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-672 > Project: Zookeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.2.2 >Reporter: Kay Kay >Assignee: Kay Kay > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-672.patch > > > some typo nits across the documentation. relevant forrest.xml files fixed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
