[jira] Commented: (ZOOKEEPER-930) Hedwig c++ client uses a non thread safe logging library
[ https://issues.apache.org/jira/browse/ZOOKEEPER-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932205#action_12932205 ] Michi Mutsuzaki commented on ZOOKEEPER-930: --- +1. Thank you Ivan for the quick patch! --Michi > Hedwig c++ client uses a non thread safe logging library > > > Key: ZOOKEEPER-930 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-930 > Project: Zookeeper > Issue Type: Bug > Components: contrib-hedwig >Affects Versions: 3.3.2 >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Attachments: ZOOKEEPER-930.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping support
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930397#action_12930397 ] Michi Mutsuzaki commented on ZOOKEEPER-920: --- I think it's better if you add a test to src/c/tests/TestClient.cc. Thanks! --Michi > L7 (application layer) ping support > --- > > Key: ZOOKEEPER-920 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920 > Project: Zookeeper > Issue Type: New Feature > Components: c client >Affects Versions: 3.3.1 >Reporter: Chang Song >Assignee: Chang Song >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-920.patch > > > Zookeeper is used in applications where fault tolerance is important. Its > client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay > connected. However healthy heartbeat does not always means that the > application that uses Zookeeper client is in good health, it only means that > ZK client thread is in good health. > This I needed something that can tagged onto Zookeeper ping that represents > L7 (application) health as well. > I have modified C client source to support this in minimal way. I am new to > Zookeeper, so please code review this code. I am actually using this code in > our in-house solution. > https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece > Thank you very much. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping support
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929974#action_12929974 ] Michi Mutsuzaki commented on ZOOKEEPER-920: --- Hi Chang, Thank you for the patch. Here are my comments: - Could you document the return value of app_ping_fn? Something like "\return 0 on successful ping. non-zero on error" should be enough. - Do you have a unit test for this? - It might be better if send_ping returns something other than ZOPERATIONTIMEOUT in case of client ping failure. That way it's easier to tell whether it's client ping that failed. Thanks! Michi > L7 (application layer) ping support > --- > > Key: ZOOKEEPER-920 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920 > Project: Zookeeper > Issue Type: New Feature > Components: c client >Affects Versions: 3.3.1 >Reporter: Chang Song >Assignee: Chang Song >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-920.patch > > > Zookeeper is used in applications where fault tolerance is important. Its > client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay > connected. However healthy heartbeat does not always means that the > application that uses Zookeeper client is in good health, it only means that > ZK client thread is in good health. > This I needed something that can tagged onto Zookeeper ping that represents > L7 (application) health as well. > I have modified C client source to support this in minimal way. I am new to > Zookeeper, so please code review this code. I am actually using this code in > our in-house solution. > https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece > Thank you very much. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922382#action_12922382 ] Michi Mutsuzaki commented on ZOOKEEPER-794: --- ZOOKEEPER-794_5_br33.patch worked. --Michi > Callbacks are not invoked when the client is closed > --- > > Key: ZOOKEEPER-794 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-794 > Project: Zookeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.3.1 >Reporter: Alexis Midon >Assignee: Alexis Midon >Priority: Blocker > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-794.patch.txt, ZOOKEEPER-794.txt, > ZOOKEEPER-794_2.patch, ZOOKEEPER-794_3.patch, ZOOKEEPER-794_4.patch.txt, > ZOOKEEPER-794_5.patch.txt, ZOOKEEPER-794_5_br33.patch > > > I noticed that ZooKeeper has different behaviors when calling synchronous or > asynchronous actions on a closed ZooKeeper client. > Actually a synchronous call will throw a "session expired" exception while an > asynchronous call will do nothing. No exception, no callback invocation. > Actually, even if the EventThread receives the Packet with the session > expired err code, the packet is never processed since the thread has been > killed by the ventOfDeath. So the call back is not invoked. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921939#action_12921939
]
Michi Mutsuzaki commented on ZOOKEEPER-794:
---
ZOOKEEPER-794_5.patch.txt doesn't compile. I'm getting these errors:
[javac]
branch-3.3/src/java/test/org/apache/zookeeper/test/SessionTest.java:201: cannot
find symbol
[javac] symbol : variable Assert
[javac] location: class org.apache.zookeeper.test.SessionTest
[javac] Assert.fail("Should have received a SessionExpiredException");
[javac] ^
[javac]
branch-3.3/src/java/test/org/apache/zookeeper/test/SessionTest.java:217: cannot
find symbol
[javac] symbol : variable Assert
[javac] location: class org.apache.zookeeper.test.SessionTest
[javac] Assert.assertEquals(KeeperException.Code.SESSIONEXPIRED.toString(),
cb.toString());
[javac] ^
We need to either:
a. import org.junit.Assert, or
b. Use fail/assertEquals instead of Assert.fail/Assert.assertEquals.
--Michi
> Callbacks are not invoked when the client is closed
> ---
>
> Key: ZOOKEEPER-794
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-794
> Project: Zookeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.3.1
>Reporter: Alexis Midon
>Assignee: Alexis Midon
>Priority: Blocker
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-794.patch.txt, ZOOKEEPER-794.txt,
> ZOOKEEPER-794_2.patch, ZOOKEEPER-794_3.patch, ZOOKEEPER-794_4.patch.txt,
> ZOOKEEPER-794_5.patch.txt
>
>
> I noticed that ZooKeeper has different behaviors when calling synchronous or
> asynchronous actions on a closed ZooKeeper client.
> Actually a synchronous call will throw a "session expired" exception while an
> asynchronous call will do nothing. No exception, no callback invocation.
> Actually, even if the EventThread receives the Packet with the session
> expired err code, the packet is never processed since the thread has been
> killed by the ventOfDeath. So the call back is not invoked.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-820: -- Status: Patch Available (was: Open) > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, > ZOOKEEPER-820.patch, ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-820: -- Attachment: ZOOKEEPER-820.patch Uses which to check if lsof command is present. If it is, use it to see if there is a process listening on port 22181 and kill it. --Michi > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, > ZOOKEEPER-820.patch, ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921923#action_12921923 ] Michi Mutsuzaki commented on ZOOKEEPER-804: --- +1. > I can open a new bug and submit a patch that way if its preferred. No worry, it's not a big deal since this is a one line change. Thanks again, Jared! --Michi > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-804-1.patch, ZOOKEEPER-804.patch > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921583#action_12921583 ] Michi Mutsuzaki commented on ZOOKEEPER-804: --- The patch looks good, but I can't seem to apply it. Has anybody seen this error? $ cd branch-3.3 $ patch -p0 < ZOOKEEPER-804.patch patching file src/c/src/zookeeper.c Hunk #1 FAILED at 1947. 1 out of 1 hunk FAILED -- saving rejects to file src/c/src/zookeeper.c.rej --Michi > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-804-1.patch, ZOOKEEPER-804.patch > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921558#action_12921558 ] Michi Mutsuzaki commented on ZOOKEEPER-804: --- Jared, thank you for volunteering to fix this. I haven't had a chance to take care of it. --Michi > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-804-1.patch, ZOOKEEPER-804.patch > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-820: -- Attachment: ZOOKEEPER-820.patch Reverted back to use pid file instead of lsof. > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch, > ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915918#action_12915918 ] Michi Mutsuzaki commented on ZOOKEEPER-820: --- Cygwin doesn't have lsof. Most of the time, 'zombie' process is caused by the invalid return code checking (it keeps starting the server process in a loop for 2 minutes). I think it's ok to use pid file to keep track of the server process. I'll submit a new patch. --Michi > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-804: -- Status: Patch Available (was: Open) > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-804.patch > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-804: -- Attachment: ZOOKEEPER-804.patch This patch modifies zookeeper_process() function. After dequeue_completion() is called, it checks if zookeeper_close has been called. If it has been called, it returns ZINVALIDSTATE. --Michi > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-804.patch > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906982#action_12906982 ] Michi Mutsuzaki commented on ZOOKEEPER-864: --- +1. The latest patch compiles cleanly with no warnings. Cool! I'm using gcc 3.4.6. $ /usr/bin/g++ --version g++ (GCC) 3.4.6 20060404 (Red Hat 3.4.6-9) --Michi > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-861) Missing the test SSL certificate used for running junit tests.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906910#action_12906910 ] Michi Mutsuzaki commented on ZOOKEEPER-861: --- +1. This fixed all the unit test failures. --Michi > Missing the test SSL certificate used for running junit tests. > -- > > Key: ZOOKEEPER-861 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-861 > Project: Zookeeper > Issue Type: Bug > Components: contrib-hedwig >Reporter: Erwin Tam >Assignee: Erwin Tam >Priority: Minor > Fix For: 3.4.0 > > Attachments: server.p12, ZOOKEEPER-861.patch > > > The Hedwig code checked into Apache is missing a test SSL certificate file > used for running the server junit tests. We need this file otherwise the > tests that use this (e.g. TestHedwigHub) will fail. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-864: -- Attachment: warnings.txt > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906231#action_12906231 ] Michi Mutsuzaki commented on ZOOKEEPER-864: --- Here are my comments: - After applying the patch, I was able to compile cpp client. - I still see some compilation warnings. I'll attach the output. Thanks! --Michi > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-861) Missing the test SSL certificate used for running junit tests.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906230#action_12906230 ] Michi Mutsuzaki commented on ZOOKEEPER-861: --- - I copied server.p12 in src/contrib/hedwig/server/src/main/resources/, and that fixed all the unit test failures. - ZOOKEEPER-861.patch doesn't apply. What is this patch supposed to do? --Michi > Missing the test SSL certificate used for running junit tests. > -- > > Key: ZOOKEEPER-861 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-861 > Project: Zookeeper > Issue Type: Bug > Components: contrib-hedwig >Reporter: Erwin Tam >Assignee: Erwin Tam >Priority: Minor > Fix For: 3.4.0 > > Attachments: server.p12, ZOOKEEPER-861.patch > > > The Hedwig code checked into Apache is missing a test SSL certificate file > used for running the server junit tests. We need this file otherwise the > tests that use this (e.g. TestHedwigHub) will fail. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906077#action_12906077 ] Michi Mutsuzaki commented on ZOOKEEPER-864: --- Thanks for the patch, Ivan! What do we need to do before we can check in this patch? --Michi > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki reassigned ZOOKEEPER-804: - Assignee: Michi Mutsuzaki (was: Mahadev konar) > c unit tests failing due to "assertion cptr failed" > --- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to "assertion cptr failed"
[
https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903260#action_12903260
]
Michi Mutsuzaki commented on ZOOKEEPER-804:
---
I haven't been able to reproduce it, but it looks like we shouldn't
assert(cptr) if zookeeper_close has been called (zookeeper.c line 1950). Can we
do something like:
completion_list_t *cptr = dequeue_completion(&zh->sent_requests);
if (zh->close_requested == 1) {
// zookeeper_close has been called. No need to assert cptr. Just free it if
it's not NULL
if (cptr) {
destroy_completion_entry(cptr);
}
// some more cleanup?
return ZINVALIDSTATE;
}
// zookeeper_close hadn't been called when we called dequeue_completion. cptr
must not be NULL.
assert(cptr);
--Michi
> c unit tests failing due to "assertion cptr failed"
> ---
>
> Key: ZOOKEEPER-804
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.4.0
> Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel)
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Critical
> Fix For: 3.3.2, 3.4.0
>
>
> I'm seeing this frequently:
> [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK
> [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK
> [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK
> [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started :
> elapsed 25687 : OK
> [exec] zktest-mt:
> /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952:
> zookeeper_process: Assertion `cptr' failed.
> [exec] make: *** [run-check] Aborted
> [exec] Zookeeper_simpleSystem::testHangingClient
> Mahadev can you take a look?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-820: -- Attachment: ZOOKEEPER-820-1.patch One more change. I like to change the sleep time to from 5 seconds 1 second. Most of the time, 1 second is enough for the server to start up (at least on my box). --Michi > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820-1.patch, ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-820: -- Status: Patch Available (was: Open) > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-820: -- Attachment: ZOOKEEPER-820.patch This patch is for branch-3.3. I changed 2 things. 1. Instead of using a file to keep track of pid, use lsof to check if a process is using port 22181. 2. Fixed invalid return code checking. This was causing the unit test to go into a loop for 2 minutes in certain cases. --Michi > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-820.patch > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902014#action_12902014 ] Michi Mutsuzaki commented on ZOOKEEPER-820: --- What's the 'correct' way to stop zookeeper server process? Right now the c unit test does kill -9. Is there a way to do clean shutdown? --Michi > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899724#action_12899724 ] Michi Mutsuzaki commented on ZOOKEEPER-775: --- ## scripts/ directory - Some scripts under ./scripts don't have the executable bit set. - I prefer not to use file extension (analyze instead of analyze.py). We might decide to use some other language later on. ## doc/ directory - Add instruction to set up local maven repository in build.txt: $ mkdir -p $HOME/.m2/repository $ export M2_REPO=$HOME/.m2/repository - Add instruction to install protobuf in build.txt. wget http://protobuf.googlecode.com/files/protobuf-2.3.0.tar.gz tar xfvz protobuf-2.3.0.tar.gz cd protobuf-2.3.0 ./configure ; make ; sudo make install cd java mvn install ## client directory - I couldn't compile cpp client. we should use a compile time flag to check whether tr1 is available, and if not, fall back to boost. This page describes how to do that: http://www.codesynthesis.com/~boris/blog/2010/05/24/smart-pointers-in-boost-tr1-cxx-x0/ If this is too much hassle, maybe we can just use boost instead of tr1 for now. - Should the c++ client follow the same naming convention as java for file names (publisherimpl.h vs PublisherImpl.h)? > A large scale pub/sub system > > > Key: ZOOKEEPER-775 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-775 > Project: Zookeeper > Issue Type: New Feature > Components: contrib >Reporter: Benjamin Reed >Assignee: Benjamin Reed > Fix For: 3.4.0 > > Attachments: libs.zip, libs_2.zip, ZOOKEEPER-775.patch, > ZOOKEEPER-775.patch, ZOOKEEPER-775.patch, ZOOKEEPER-775_2.patch, > ZOOKEEPER-775_3.patch > > > we have developed a large scale pub/sub system based on ZooKeeper and > BookKeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-820) update c unit tests to ensure "zombie" java server processes don't cause failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki reassigned ZOOKEEPER-820: - Assignee: Michi Mutsuzaki > update c unit tests to ensure "zombie" java server processes don't cause > failure > > > Key: ZOOKEEPER-820 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-820 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.3.1 >Reporter: Patrick Hunt >Assignee: Michi Mutsuzaki >Priority: Critical > Fix For: 3.3.2, 3.4.0 > > > When the c unit tests are run sometimes the server doesn't shutdown at the > end of the test, this causes subsequent tests (hudson esp) to fail. > 1) we should try harder to make the server shut down at the end of the test, > I suspect this is related to test failing/cleanup > 2) before the tests are run we should see if the old server is still running > and try to shut it down -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-800: -- Status: Patch Available (was: In Progress) > zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE > --- > > Key: ZOOKEEPER-800 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-800 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.1 >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-800.patch > > > This happened when I called zoo_add_auth() immediately after > zookeeper_init(). It took me a while to figure out that authentication > actually failed since zoo_add_auth() returned ZOK. It should return > ZINVALIDSTATE instead. > --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Work started: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on ZOOKEEPER-800 started by Michi Mutsuzaki. > zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE > --- > > Key: ZOOKEEPER-800 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-800 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.1 >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-800.patch > > > This happened when I called zoo_add_auth() immediately after > zookeeper_init(). It took me a while to figure out that authentication > actually failed since zoo_add_auth() returned ZOK. It should return > ZINVALIDSTATE instead. > --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-800: -- Attachment: ZOOKEEPER-800.patch I modified zoo_add_auth() in branch-3.3. It returns ZINVALIDSTATE if the connection is in ZOO_CLOSED_STATE state. --Michi > zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE > --- > > Key: ZOOKEEPER-800 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-800 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.1 >Reporter: Michi Mutsuzaki >Assignee: Michi Mutsuzaki >Priority: Minor > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEPER-800.patch > > > This happened when I called zoo_add_auth() immediately after > zookeeper_init(). It took me a while to figure out that authentication > actually failed since zoo_add_auth() returned ZOK. It should return > ZINVALIDSTATE instead. > --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896090#action_12896090 ] Michi Mutsuzaki commented on ZOOKEEPER-800: --- Talked with Mahadev. I'm taking this bug (but don't know how to change assignee in Jira). --Michi > zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE > --- > > Key: ZOOKEEPER-800 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-800 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.1 >Reporter: Michi Mutsuzaki >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.3.2, 3.4.0 > > > This happened when I called zoo_add_auth() immediately after > zookeeper_init(). It took me a while to figure out that authentication > actually failed since zoo_add_auth() returned ZOK. It should return > ZINVALIDSTATE instead. > --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-826) cli.c should not call zoo_add_auth immediately after zookeeper_init()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890615#action_12890615 ] Michi Mutsuzaki commented on ZOOKEEPER-826: --- It's related to this ticket: https://issues.apache.org/jira/browse/ZOOKEEPER-800 Inside zoo_add_auth() function, send_last_auth_info() gets called if the handle is in ZOO_CONNECTED_STATE or ZOO_ASSOCIATING_STATE. However, it doesn't get called if it's in ZOO_CLOSED_STATE, which is usually the case right after zookeeper_init() returns. --Michi > cli.c should not call zoo_add_auth immediately after zookeeper_init() > -- > > Key: ZOOKEEPER-826 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-826 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.1 >Reporter: Michi Mutsuzaki >Priority: Minor > > In cli.c, zoo_add_auth() gets called right after zookeeper_init(). Instead, > zoo_add_auth() should be called in the callback after the connection is > established. > --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-826) cli.c should not call zoo_add_auth immediately after zookeeper_init()
cli.c should not call zoo_add_auth immediately after zookeeper_init() -- Key: ZOOKEEPER-826 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-826 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.3.1 Reporter: Michi Mutsuzaki Priority: Minor In cli.c, zoo_add_auth() gets called right after zookeeper_init(). Instead, zoo_add_auth() should be called in the callback after the connection is established. --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-800) zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE
zoo_add_auth returns ZOK if zookeeper handle is in ZOO_CLOSED_STATE --- Key: ZOOKEEPER-800 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-800 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.3.1 Reporter: Michi Mutsuzaki Priority: Minor This happened when I called zoo_add_auth() immediately after zookeeper_init(). It took me a while to figure out that authentication actually failed since zoo_add_auth() returned ZOK. It should return ZINVALIDSTATE instead. --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-495) c client logs an invalid error when zookeeper_init is called with chroot
[ https://issues.apache.org/jira/browse/ZOOKEEPER-495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-495: -- Attachment: chroot.log chroot.cc Here is a simple program to reproduce the issue and corresponding log. --Michi > c client logs an invalid error when zookeeper_init is called with chroot > > > Key: ZOOKEEPER-495 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-495 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.2.0 >Reporter: Michi Mutsuzaki >Priority: Minor > Attachments: chroot.cc, chroot.log > > > The C client logs this error message when zookeeper_init is called with > chroot. > 2009-08-03 18:14:29,130:6624(0x5e66e950):zoo_er...@sub_string@730: server > path does not include chroot path /chroot > I'll attach a simple program to reproduce this. > Thanks! > --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-495) c client logs an invalid error when zookeeper_init is called with chroot
c client logs an invalid error when zookeeper_init is called with chroot Key: ZOOKEEPER-495 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-495 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.2.0 Reporter: Michi Mutsuzaki Priority: Minor The C client logs this error message when zookeeper_init is called with chroot. 2009-08-03 18:14:29,130:6624(0x5e66e950):zoo_er...@sub_string@730: server path does not include chroot path /chroot I'll attach a simple program to reproduce this. Thanks! --Michi -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-494) zookeeper should install include headers in /usr/local/include/zookeeper
zookeeper should install include headers in /usr/local/include/zookeeper Key: ZOOKEEPER-494 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-494 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.2.0 Reporter: Michi Mutsuzaki Priority: Trivial Hello, Currently all the c client header files get installed under /usr/local/include/c-client-src . Ideally they should get installed in /usr/local/include/zookeeper . -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
