[jira] Commented: (ZOOKEEPER-217) Errors in config file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648654#action_12648654 ] Flavio Paiva Junqueira commented on ZOOKEEPER-217: -- +1 looks good, mahadev. > Errors in config file > - > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > Attachments: ZOOKEEPER-217.patch, ZOOKEEPER-217.patch > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-217) Errors in config file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646693#action_12646693 ] Flavio Paiva Junqueira commented on ZOOKEEPER-217: -- Instead of a boolean, we should throw an exception that propagates all the way back to main and exit there. > Errors in config file > - > > Key: ZOOKEEPER-217 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-217 > Project: Zookeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.0.0 >Reporter: Flavio Paiva Junqueira >Priority: Minor > Fix For: 3.0.1, 3.1.0 > > > Discussing 209 with Ben today, we thought that it would be better to have the > parse method of QuorumPeerConfig returning a boolean that indicates whether > the configuration is good or not, and let the caller decide whether to exit > or not. Currently we execute a System.exit() on QuorumPeerConfig.parse when > we have a critical configuration error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
