[jira] Commented: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844997#action_12844997 ] Benjamin Reed commented on ZOOKEEPER-698: - ignore that last comment, it was posted to the wrong issue! intermittent JMX test failures due to not verifying QuorumPeer shutdown Key: ZOOKEEPER-698 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Attachments: ZOOKEEPER-698.patch in some cases the tests are failing with JMX errors. From the logs I can see that QP was shutdown, however it did not exit it's thread until some time much later. This is causing interference with subsequent tests, causing the test to fail. I have a patch that attempts to verify that the QP was shutdown (by joining the thread). It turns out that tests based on QuorumBase do this check (join) however some of the other tests do not. I believe this will address the issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown
[ https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844740#action_12844740 ] Hadoop QA commented on ZOOKEEPER-698: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438649/ZOOKEEPER-698.patch against trunk revision 922442. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 45 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/19/console This message is automatically generated. intermittent JMX test failures due to not verifying QuorumPeer shutdown Key: ZOOKEEPER-698 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Attachments: ZOOKEEPER-698.patch in some cases the tests are failing with JMX errors. From the logs I can see that QP was shutdown, however it did not exit it's thread until some time much later. This is causing interference with subsequent tests, causing the test to fail. I have a patch that attempts to verify that the QP was shutdown (by joining the thread). It turns out that tests based on QuorumBase do this check (join) however some of the other tests do not. I believe this will address the issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
