[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-07-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12885510#action_12885510
 ] 

Hudson commented on ZOOKEEPER-744:
--

Integrated in ZooKeeper-trunk #869 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/869/])
ZOOKEEPER-744. Add monitoring four-letter word


 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Andrei Savu
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, 
 ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-07-05 Thread Andrei Savu (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12885296#action_12885296
 ] 

Andrei Savu commented on ZOOKEEPER-744:
---

Thanks for reviewing.




 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Andrei Savu
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, 
 ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12882736#action_12882736
 ] 

Hadoop QA commented on ZOOKEEPER-744:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch
  against trunk revision 958096.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/121/console

This message is automatically generated.

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Andrei Savu
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, 
 ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12882759#action_12882759
 ] 

Hadoop QA commented on ZOOKEEPER-744:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch
  against trunk revision 958096.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/console

This message is automatically generated.

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Andrei Savu
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, 
 ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-14 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12878793#action_12878793
 ] 

Hadoop QA commented on ZOOKEEPER-744:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12447082/ZOOKEEPER-744.patch
  against trunk revision 953041.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 16 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/116/console

This message is automatically generated.

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, 
 ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-06 Thread Savu Andrei (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12876091#action_12876091
 ] 

Savu Andrei commented on ZOOKEEPER-744:
---

@Patrick I have fixed 1-5. I will resubmit the patch after writing some tests 
to ensure that the node watch count works as expected (I'm having some problems 
with this part). Right now all tests are passing.

6. I believe the leader does not record the time of the last election. I will 
look more into this and change the code as needed.

Should I also add JVM memory stats?


 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-03 Thread Savu Andrei (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12875021#action_12875021
 ] 

Savu Andrei commented on ZOOKEEPER-744:
---

Thanks for reviewing. I will resubmit the patch today.




-- 
Savu Andrei

Website: http://www.andreisavu.ro/



 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-01 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874111#action_12874111
 ] 

Patrick Hunt commented on ZOOKEEPER-744:


Andrei, are you are still working on this or should I review for commit?

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-01 Thread Savu Andrei (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874148#action_12874148
 ] 

Savu Andrei commented on ZOOKEEPER-744:
---

You can review the patch for commit. Right know I'm writing monitoring scripts 
for Nagios, Cacti and Ganglia (in this order). The script for nagios is almost 
ready. Thanks. 

-original message-
Subject: [jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word
From: Patrick Hunt (JIRA) j...@apache.org
Date: 01/06/2010 19:07


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874111#action_12874111
 ] 

Patrick Hunt commented on ZOOKEEPER-744:


Andrei, are you are still working on this or should I review for commit?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.





 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-06-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874198#action_12874198
 ] 

Hadoop QA commented on ZOOKEEPER-744:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12445822/ZOOKEEPER-744.patch
  against trunk revision 947063.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 8 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/112/console

This message is automatically generated.

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Fix For: 3.4.0

 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-05-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872176#action_12872176
 ] 

Hadoop QA commented on ZOOKEEPER-744:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12445586/ZOOKEEPER-744.patch
  against trunk revision 947063.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 8 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/109/console

This message is automatically generated.

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-05-27 Thread Travis Crawford (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872284#action_12872284
 ] 

Travis Crawford commented on ZOOKEEPER-744:
---

@savu - Sometimes the right thing is publishing everything, sometimes not. In 
this case I'll have some filtering/formatting in the zk2ganglia script.

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Affects Versions: 3.4.0
Reporter: Travis Crawford
Assignee: Savu Andrei
 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-05-25 Thread Travis Crawford (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871479#action_12871479
 ] 

Travis Crawford commented on ZOOKEEPER-744:
---

Looks awesome! One nit -- many monitoring systems do not interpret strings so 
it may be appropriate to export everything as numbers. For example, consider a 
script that loops through these values poking them into Ganglia (or other 
timeseries database). The script would need special-cased to handle leader. 
Later, as more values are added the import script would need updated with the 
new strings. Doing everything as numbers ensures new values would just work 
without updating other systems.

With that in mind, perhaps:

zk_server_state 1 (instead of: leader)
zk_build_timestamp unix_timestamp (instead of build string)

 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Reporter: Travis Crawford
 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-744) Add monitoring four-letter word

2010-05-24 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870707#action_12870707
 ] 

Patrick Hunt commented on ZOOKEEPER-744:


Looks good so far. You should update the forrest docs as part of this change, 
you should detail the format at least (and expectation that order is not 
maintained, etc...), that this is compatible with java properties format, the 
content may change (keys added) over time, etc... That way a user will better 
understand how to integrate and have a reasonable expectation of b/w 
compatibliity, implementers will also have insight into how they can change 
this command over time. We didn't do a good job with this for the other 
commands, but since this is new and intended for integration into third party 
tools (vs a human always looking at the results) it's a good idea to add. You 
should add this command to the Tests as well.


 Add monitoring four-letter word
 ---

 Key: ZOOKEEPER-744
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
 Project: Zookeeper
  Issue Type: New Feature
  Components: server
Reporter: Travis Crawford
 Attachments: zk-ganglia.png, ZOOKEEPER-744.patch


 Filing a feature request based on a zookeeper-user discussion.
 Zookeeper should have a new four-letter word that returns key-value pairs 
 appropriate for importing to a monitoring system (such as Ganglia which has a 
 large installed base)
 This command should initially export the following:
 (a) Count of instances in the ensemble.
 (b) Count of up-to-date instances in the ensemble.
 But be designed such that in the future additional data can be added. For 
 example, the output could define the statistic in a comment, then print a key 
 space character value line:
 
 # Total number of instances in the ensemble
 zk_ensemble_instances_total 5
 # Number of instances currently participating in the quorum.
 zk_ensemble_instances_active 4
 
 From the mailing list:
 
 Date: Mon, 19 Apr 2010 12:10:44 -0700
 From: Patrick Hunt ph...@apache.org
 To: zookeeper-u...@hadoop.apache.org
 Subject: Re: Recovery issue - how to debug?
 On 04/19/2010 11:55 AM, Travis Crawford wrote:
  It would be a lot easier from the operations perspective if the leader
  explicitly published some health stats:
 
  (a) Count of instances in the ensemble.
  (b) Count of up-to-date instances in the ensemble.
 
  This would greatly simplify monitoring  alerting - when an instance
  falls behind one could configure their monitoring system to let
  someone know and take a look at the logs.
 That's a great idea. Please enter a JIRA for this - a new 4 letter word 
 and JMX support. It would also be a great starter project for someone 
 interested in becoming more familiar with the server code.
 Patrick
 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.