[jira] Commented: (ZOOKEEPER-902) Fix findbug issue in trunk "Malicious code vulnerability"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933020#action_12933020 ] Patrick Hunt commented on ZOOKEEPER-902: Sounds good. Let's clear out 900 then we can adjust the OK setting back to 0 (as part of this jira) once 900 is committed. > Fix findbug issue in trunk "Malicious code vulnerability" > - > > Key: ZOOKEEPER-902 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-902 > Project: Zookeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.4.0 >Reporter: Patrick Hunt >Priority: Minor > Fix For: 3.4.0 > > > https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE > Malicious code vulnerability Warnings > Code Warning > MSorg.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final > but should be -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-902) Fix findbug issue in trunk "Malicious code vulnerability"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932989#action_12932989 ] Flavio Junqueira commented on ZOOKEEPER-902: Agreed, I've seen that 900 didn't include it. I'd rather let Pat take care of wrapping up this issue... > Fix findbug issue in trunk "Malicious code vulnerability" > - > > Key: ZOOKEEPER-902 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-902 > Project: Zookeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.4.0 >Reporter: Patrick Hunt >Priority: Minor > Fix For: 3.4.0 > > > https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE > Malicious code vulnerability Warnings > Code Warning > MSorg.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final > but should be -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-902) Fix findbug issue in trunk "Malicious code vulnerability"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932987#action_12932987 ] Vishal K commented on ZOOKEEPER-902: fyi, I had not included test-patch.properties file in my diff. > Fix findbug issue in trunk "Malicious code vulnerability" > - > > Key: ZOOKEEPER-902 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-902 > Project: Zookeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.4.0 >Reporter: Patrick Hunt >Priority: Minor > Fix For: 3.4.0 > > > https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE > Malicious code vulnerability Warnings > Code Warning > MSorg.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final > but should be -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-902) Fix findbug issue in trunk "Malicious code vulnerability"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930236#action_12930236 ] Nigel Daley commented on ZOOKEEPER-902: --- The patch for this issue should also update src/java/test/bin/test-patch.properties to set OK_FINDBUGS_WARNINGS=0 > Fix findbug issue in trunk "Malicious code vulnerability" > - > > Key: ZOOKEEPER-902 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-902 > Project: Zookeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.4.0 >Reporter: Patrick Hunt >Priority: Minor > Fix For: 3.4.0 > > > https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE > Malicious code vulnerability Warnings > Code Warning > MSorg.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final > but should be -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-902) Fix findbug issue in trunk "Malicious code vulnerability"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930222#action_12930222 ] Patrick Hunt commented on ZOOKEEPER-902: The patch queue now has a setting: (10:28:53 AM) nigelcdn: There's a new file in src/java/test/bin/test-patch.properties in which is defined the acceptable number of warnings (10:29:03 AM) nigelcdn: use it very judiciously ;-) after this issue is fixed we should adjust that file back to 0. > Fix findbug issue in trunk "Malicious code vulnerability" > - > > Key: ZOOKEEPER-902 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-902 > Project: Zookeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.4.0 >Reporter: Patrick Hunt >Priority: Minor > Fix For: 3.4.0 > > > https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE > Malicious code vulnerability Warnings > Code Warning > MSorg.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final > but should be -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
