[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-507:


  Resolution: Fixed
Release Note: bookkeeper code rewrite with optimization on disk write 
scheduling and scheduling of ledger writes on the client side.
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

I just committed this. thanks utkarsh, ben and flavio.

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Fix For: 3.3.0
>
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-23 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-507:


Attachment: ZOOKEEPER-507.patch

two extremely small fixes to make the tests patch:

1) The syncThread was not being killed in the shutdown() method of Bookie
2) We need to add pending ops before calling connect() in 
PerChannelBookieConnection because in linux with local host the connect will 
return immediately.

we really need to commit this thing. the patch has become extremely unwieldy!

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Fix For: 3.3.0
>
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-21 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-507:


Fix Version/s: 3.3.0

lets try and get this in 3.3.

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Fix For: 3.3.0
>
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Attachment: ZOOKEEPER-507.patch

Fixed warnings, added 2 missing license headers

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Status: Patch Available  (was: Open)

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Attachment: (was: ZOOKEEPER-507.patch)

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Attachment: (was: ZOOKEEPER-507.patch)

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-507:
-

Status: Open  (was: Patch Available)

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Attachment: ZOOKEEPER-507.patch

Included all the new classes. Had forgot to svn add them earlier.

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Status: Patch Available  (was: Open)

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-19 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-507:
-

Status: Open  (was: Patch Available)

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-17 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Attachment: ZOOKEEPER-507.patch

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2010-01-17 Thread Utkarsh Srivastava (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Utkarsh Srivastava updated ZOOKEEPER-507:
-

Status: Patch Available  (was: Open)

Added documentation to user-facing classes. Made all the remaining 
non-user-facing classes package public.

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2009-12-28 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-507:
-

Attachment: ZOOKEEPER-507.patch

BookieFailureTest is failing consistently now, after I re-introduced the tests 
to check the failure of each bookie. These tests are redundant, but they should 
help to pinpoint problems that arise when the position of the bookie in the 
ensemble matters. A disadvantage of re-introducing the tests is that they 
increase the total time needed to run the tests.

About the test failure, it seems that the test hangs when we error out add 
keys, but I'm not completely sure. I need to look more deeply into the problem.

I have also wrote and modified javadoc blocks for some of the client package 
classes. 

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch, ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-507) BookKeeper client re-write

2009-12-28 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-507:
-

Summary: BookKeeper client re-write  (was: Improve error handling of 
BookKeeper client)

> BookKeeper client re-write
> --
>
> Key: ZOOKEEPER-507
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Utkarsh Srivastava
> Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, 
> ZOOKEEPER-507.patch
>
>
> Error handling is far from ideal currently in the BookKeeper client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.