[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-586:


Status: Open  (was: Patch Available)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-586:


Attachment: ZOOKEEPER-586.patch

refreshed to work with trunk and cygwin 1.7. (we should check that it still 
compiles under earlier cygwin versions.)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-586:


Status: Patch Available  (was: Open)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-586:


Status: Open  (was: Patch Available)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-586:


Status: Patch Available  (was: Open)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-586:
---

Status: Open  (was: Patch Available)

I'm seeing two issues on cygwin 15:

 src/zookeeper.c: In function `send_set_watches':
src/zookeeper.c:1286: warning: passing arg 2 of `collect_keys' from incompatible
 pointer type
src/zookeeper.c:1287: warning: passing arg 2 of `collect_keys' from incompatible
 pointer type
src/zookeeper.c:1288: warning: passing arg 2 of `collect_keys' from incompatible
 pointer type
make: *** [zookeeper.lo] Error 1

if you cast the second args to (int*) it fixes the issue.

The second problem is:
 ./libtool: eval: line 1005: syntax error near unexpected token `|'
./libtool: eval: line 1005: `/usr/bin/nm -B   ./.libs/libzkst.a ./.libs/libhasht
able.a |  | /usr/bin/sed -e '/^[BCDGRS][ ]/s/.*[ ]\([^ ]*\)/\1 DATA/;s/^.*[ ]__n
m__\([^ ]*\)[ ][^ ]*/\1 DATA/;/^I[ ]/d;/^[AITW][ ]/s/.* //' | sort | uniq  .lib

notice the | | btw the nm and sed calls, what's supposed to be here?


 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-586:


Attachment: ZOOKEEPER-586.patch

made to work with 1.5

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-586:


Status: Patch Available  (was: Open)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-586:


Hadoop Flags: [Reviewed]

+1 great job pat.

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-11 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-586:


Status: Open  (was: Patch Available)

trying hudson to run with most current trunk!

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-11 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-586:


Status: Patch Available  (was: Open)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-11 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-586:


Status: Open  (was: Patch Available)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-11 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-586:


Status: Patch Available  (was: Open)

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-03-11 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-586:


Attachment: ZOOKEEPER-586.patch

uploading a patch that applies to trunk.

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch, ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-02-19 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-586:
---

Attachment: ZOOKEEPER-586.patch

Updated patch to latest code - fixed problem with pid variable.

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2010-02-19 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-586:
---

Status: Patch Available  (was: Open)

I'm submitting this so that we can get it into the code base. With this latest 
patch the client compiles under cygwin (1.5) however not all the tests run. I 
also tested the patch on ubuntu and it worked fine. I think we should commit as 
it allows the code to compile under cygwin, we can fix the cygwin tests later 
(also the issue of the new cygwin version, and what we will support going fwd).

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch, ZOOKEEPER-586.patch, 
 ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-586) c client does not compile under cygwin

2009-11-20 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-586:
---

Attachment: ZOOKEEPER-586.patch

c client compiles with this patch but the tests fail

 c client does not compile under cygwin
 --

 Key: ZOOKEEPER-586
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-586
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.2.1
Reporter: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-586.patch


 the c client fails to compile under cygwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.