[jira] Updated: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown

2010-03-13 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-698:


Attachment: ZOOKEEPER-121.patch

attaching the patch that corresponds to my comment

 intermittent JMX test failures due to not verifying QuorumPeer shutdown 
 

 Key: ZOOKEEPER-698
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-698.patch


 in some cases the tests are failing with JMX errors. From the logs I can see 
 that QP was shutdown, however it did not exit it's thread until some time 
 much later. This is causing interference with subsequent tests, causing the 
 test to fail.
 I have a patch that attempts to verify that the QP was shutdown (by joining 
 the thread). It turns out that tests based on QuorumBase do this check (join) 
 however some of the other tests do not. I believe this will address the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown

2010-03-13 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-698:


Attachment: (was: ZOOKEEPER-121.patch)

 intermittent JMX test failures due to not verifying QuorumPeer shutdown 
 

 Key: ZOOKEEPER-698
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-698.patch


 in some cases the tests are failing with JMX errors. From the logs I can see 
 that QP was shutdown, however it did not exit it's thread until some time 
 much later. This is causing interference with subsequent tests, causing the 
 test to fail.
 I have a patch that attempts to verify that the QP was shutdown (by joining 
 the thread). It turns out that tests based on QuorumBase do this check (join) 
 however some of the other tests do not. I believe this will address the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown

2010-03-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-698:
---

Status: Patch Available  (was: Open)

 intermittent JMX test failures due to not verifying QuorumPeer shutdown 
 

 Key: ZOOKEEPER-698
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-698.patch


 in some cases the tests are failing with JMX errors. From the logs I can see 
 that QP was shutdown, however it did not exit it's thread until some time 
 much later. This is causing interference with subsequent tests, causing the 
 test to fail.
 I have a patch that attempts to verify that the QP was shutdown (by joining 
 the thread). It turns out that tests based on QuorumBase do this check (join) 
 however some of the other tests do not. I believe this will address the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown

2010-03-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-698:
---

Attachment: ZOOKEEPER-698.patch

This patch addresses the problem of verifying that the QPs were actually shut 
down. Passes my tests and should address this problem.

 intermittent JMX test failures due to not verifying QuorumPeer shutdown 
 

 Key: ZOOKEEPER-698
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-698.patch


 in some cases the tests are failing with JMX errors. From the logs I can see 
 that QP was shutdown, however it did not exit it's thread until some time 
 much later. This is causing interference with subsequent tests, causing the 
 test to fail.
 I have a patch that attempts to verify that the QP was shutdown (by joining 
 the thread). It turns out that tests based on QuorumBase do this check (join) 
 however some of the other tests do not. I believe this will address the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-698) intermittent JMX test failures due to not verifying QuorumPeer shutdown

2010-03-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-698:


Hadoop Flags: [Reviewed]

+1 looks good pat. nice cleanup.

 intermittent JMX test failures due to not verifying QuorumPeer shutdown 
 

 Key: ZOOKEEPER-698
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-698
 Project: Zookeeper
  Issue Type: Bug
  Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-698.patch


 in some cases the tests are failing with JMX errors. From the logs I can see 
 that QP was shutdown, however it did not exit it's thread until some time 
 much later. This is causing interference with subsequent tests, causing the 
 test to fail.
 I have a patch that attempts to verify that the QP was shutdown (by joining 
 the thread). It turns out that tests based on QuorumBase do this check (join) 
 however some of the other tests do not. I believe this will address the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.