Will Do.
On Fri, Jul 18, 2008 at 1:40 PM, Benjamin Reed [EMAIL PROTECTED] wrote:
This sounds great. I would suggest opening a Jira to work out the
proposal and track the patch.
ben
Hiram Chirino wrote:
Yep, I've looked that the test cases. In short to make that public API
more DI
+1 :)
I'm a fellow ActiveMQ hacker too and would love to see ZK included
with ActiveMQ. Dependency Injection can really help keep your code
simple but leaving it flexible so it can be used in many different
ways.
Here's some links on DI
http://martinfowler.com/articles/injection.html
Yep, I've looked that the test cases. In short to make that public API
more DI friendly, we should:
* Decouple the current configuration system from the public API. I
see stuff like ZooKeeperServer being coupled to ServerConfig a bit.
* Allow the use of setter injection in addition to
Yeah mainly.
Ideally only your main class deals with configuration parsing and it
constructs all the zk server objects using the public api which is DI
friendly.
For example, I think we should move the main() method out of the
ZooKeeperServer class.
On Fri, Jul 18, 2008 at 1:11 PM, Benjamin
This sounds great. I would suggest opening a Jira to work out the
proposal and track the patch.
ben
Hiram Chirino wrote:
Yep, I've looked that the test cases. In short to make that public API
more DI friendly, we should:
* Decouple the current configuration system from the public API. I
