[
https://issues.apache.org/jira/browse/ZOOKEEPER-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755313#action_12755313
]
Mahadev konar commented on ZOOKEEPER-516:
-----------------------------------------
the patch looks good... I have a few comments/questions -
- why did we add this?
{code}
+ <sysproperty key="zookeeper.DigestAuthenticationProvider.superDigest"
+ value="super:D/InIHSb7yEEbrWz8b9l71RjZJU=" />
{code}
- and this change, is this a fix for python tests?
{code}
+
library_dirs=["/usr/local/lib","../../../build/test/test-cppunit/.libs"])
{code}
- and I am not sure if I understand what the following code is doing
{code}
+
+ OperatingSystemMXBean osMbean =
+ ManagementFactory.getOperatingSystemMXBean();
+ if (osMbean != null && osMbean instanceof UnixOperatingSystemMXBean) {
+ UnixOperatingSystemMXBean unixos =
+ (UnixOperatingSystemMXBean)osMbean;
+ LOG.info("Initial fdcount is: "
+ + unixos.getOpenFileDescriptorCount());
+ }
{code}
can you please explain?
> add support for 10 minute test ie "pre-commit" test
> ---------------------------------------------------
>
> Key: ZOOKEEPER-516
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-516
> Project: Zookeeper
> Issue Type: Task
> Components: tests
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-516.patch
>
>
> Our unit tests are now taking > 10 minutes (20 actually). We need to set
> things up such that we have a < 10 minute "pre commit" build, and a longer
> running test of tests (unbounded for all intents/purposes). Mainly this
> requires us to categorize our tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
