[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system

2010-08-11 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897194#action_12897194 ] Ivan Kelly commented on ZOOKEEPER-775: -- I've removed ltmain.sh from the svn repo.

High WTF count in ZooKeeper client code

2010-08-11 Thread Thomas Koch
Hi, I started yesterday to work on my idea of an alternative ZooKeeper client interface.[1] Instead of methods on a ZooKeeper class, a user should instantiate an Operation (Create, Delete, ...) and forward it to an Executor which handles session loss errors and alikes. By doing that, I got

Re: High WTF count in ZooKeeper client code

2010-08-11 Thread Mahadev Konar
HI Thomas, I read through the list of issues you posted, most of them seem reasonable to fix. The one's you have mentioned below might take quite a bit of time to fix and again a lot of testing! (just a warning :)). It would be great if you'd want to clean this up for 3.4. Please go ahead and

[jira] Created: (ZOOKEEPER-835) Refactoring Zookeeper Client Code

2010-08-11 Thread Patrick Datko (JIRA)
Refactoring Zookeeper Client Code - Key: ZOOKEEPER-835 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-835 Project: Zookeeper Issue Type: Improvement Components: java client Affects

[jira] Created: (ZOOKEEPER-836) hostlist as string

2010-08-11 Thread Patrick Datko (JIRA)
hostlist as string -- Key: ZOOKEEPER-836 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836 Project: Zookeeper Issue Type: Sub-task Components: java client Affects Versions: 3.3.1 Reporter:

[jira] Updated: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper

2010-08-11 Thread Patrick Datko (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Datko updated ZOOKEEPER-837: Tags: cyclic dependency Affects Version/s: 3.3.1 Description:

Re: High WTF count in ZooKeeper client code

2010-08-11 Thread Mahadev Konar
Also, I am assuming you have backwards compatability in mind when you suggest these changes right? The interfaces of zookeeper client should not be changing as part of this, though the recursive delete hasn't been introduced yet (its only available in 3.4, so we can move it out into a helper

[jira] Created: (ZOOKEEPER-838) Chroot is an attribute of ClientCnxn

2010-08-11 Thread Patrick Datko (JIRA)
Chroot is an attribute of ClientCnxn Key: ZOOKEEPER-838 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-838 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Datko -- This

[jira] Updated: (ZOOKEEPER-838) Chroot is an attribute of ClientCnxn

2010-08-11 Thread Patrick Datko (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Datko updated ZOOKEEPER-838: Tags: chroot Description: It would be better to have one process that uses

[jira] Created: (ZOOKEEPER-839) deleteRecursive does not belong to the other methods

2010-08-11 Thread Patrick Datko (JIRA)
deleteRecursive does not belong to the other methods Key: ZOOKEEPER-839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-839 Project: Zookeeper Issue Type: Sub-task

[jira] Created: (ZOOKEEPER-840) massive code duplication in zookeeper class

2010-08-11 Thread Patrick Datko (JIRA)
massive code duplication in zookeeper class --- Key: ZOOKEEPER-840 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-840 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Datko

[jira] Updated: (ZOOKEEPER-839) deleteRecursive does not belong to the other methods

2010-08-11 Thread Patrick Datko (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Datko updated ZOOKEEPER-839: Tags: atomic operations Affects Version/s: 3.3.1 Description:

[jira] Created: (ZOOKEEPER-841) stat is returned by parameter

2010-08-11 Thread Patrick Datko (JIRA)
stat is returned by parameter - Key: ZOOKEEPER-841 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-841 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Datko -- This message is

[jira] Updated: (ZOOKEEPER-840) massive code duplication in zookeeper class

2010-08-11 Thread Patrick Datko (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Datko updated ZOOKEEPER-840: Tags: code duplication Description: Each operation calls validatePath,

[jira] Updated: (ZOOKEEPER-841) stat is returned by parameter

2010-08-11 Thread Patrick Datko (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Datko updated ZOOKEEPER-841: Affects Version/s: 3.3.1 Description: Since one can return only one value in

Re: High WTF count in ZooKeeper client code

2010-08-11 Thread Thomas Koch
Hallo Mahadev, thank you for your nice answer. Yes, we'll of cause preserve compatibility. Otherwise there is no chance to get accepted. I assume the following things must keep their interfaces: ZooKeeper (It'll call the new interface in the background), ASyncCallback, Watcher We may want to

[jira] Assigned: (ZOOKEEPER-835) Refactoring Zookeeper Client Code

2010-08-11 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch reassigned ZOOKEEPER-835: - Assignee: Thomas Koch Refactoring Zookeeper Client Code

[jira] Created: (ZOOKEEPER-842) stat calls static method on org.apache.zookeeper.server.DataTree

2010-08-11 Thread Patrick Datko (JIRA)
stat calls static method on org.apache.zookeeper.server.DataTree Key: ZOOKEEPER-842 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-842 Project: Zookeeper Issue Type:

[jira] Updated: (ZOOKEEPER-842) stat calls static method on org.apache.zookeeper.server.DataTree

2010-08-11 Thread Patrick Datko (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Datko updated ZOOKEEPER-842: Tags: DataTree, protobuffer Affects Version/s: 3.3.1

[jira] Created: (ZOOKEEPER-843) Session class?

2010-08-11 Thread Patrick Datko (JIRA)
Session class? -- Key: ZOOKEEPER-843 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-843 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Datko -- This message is automatically generated by JIRA. -

[jira] Updated: (ZOOKEEPER-843) Session class?

2010-08-11 Thread Patrick Datko (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Datko updated ZOOKEEPER-843: Tags: session, session class, refactored class Affects Version/s: 3.3.1

[jira] Commented: (ZOOKEEPER-304) factor out common methods from zookeeper.java

2010-08-11 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897316#action_12897316 ] Thomas Koch commented on ZOOKEEPER-304: --- Could you please list the common methods

Re: High WTF count in ZooKeeper client code

2010-08-11 Thread Patrick Hunt
wrt defining interface stability we should adopt something like hadoop is now doing: https://issues.apache.org/jira/browse/HADOOP-5073 Mahadev, do you know if this is documented somewhere? final documentation, rather than the running commentary thats on this jira? We could adopt something

Re: High WTF count in ZooKeeper client code

2010-08-11 Thread Patrick Hunt
Hi Thomas, thanks for the reports, esp the JIRAs. One you missed (and aptly numbered) that's a pet peeve of mine is this one: https://issues.apache.org/jira/browse/ZOOKEEPER-666 I think part of what you are seeing is that the C api matured more quickly, and directly influenced the development

[jira] Commented: (ZOOKEEPER-784) server-side functionality for read-only mode

2010-08-11 Thread Henry Robinson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897338#action_12897338 ] Henry Robinson commented on ZOOKEEPER-784: -- Spectacular job, Sergey. I've taken

[jira] Commented: (ZOOKEEPER-795) eventThread isn't shutdown after a connection session expired event coming

2010-08-11 Thread Mahadev konar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897366#action_12897366 ] Mahadev konar commented on ZOOKEEPER-795: - ben, pinging again, can you provide a

[jira] Updated: (ZOOKEEPER-772) zkpython segfaults when watcher from async get children is invoked.

2010-08-11 Thread Mahadev konar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-772: Status: Resolved (was: Patch Available) Resolution: Fixed Luckily the 3.4

[jira] Commented: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper

2010-08-11 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897411#action_12897411 ] Thomas Koch commented on ZOOKEEPER-837: --- I've managed to make ClientCnxn

[jira] Assigned: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper

2010-08-11 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch reassigned ZOOKEEPER-837: - Assignee: Thomas Koch cyclic dependency ClientCnxn, ZooKeeper

Re: High WTF count in ZooKeeper client code

2010-08-11 Thread Maarten Koopmans
Off note: I have a Scala wrapper on the Java client (sync only) that has these functions: - treeAsList(path: String) - processTree(path: String,f: (String - Unit)) This implements recursive delete as a processTree(path,delete_), but also a recursive copy and move if need be. Just my two

[jira] Updated: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper

2010-08-11 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-837: -- Attachment: ZOOKEEPER-837.patch cyclic dependency ClientCnxn, ZooKeeper

[jira] Updated: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper

2010-08-11 Thread Thomas Koch (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-837: -- Status: Patch Available (was: Open) first try without testing. Would like to hear your

[jira] Updated: (ZOOKEEPER-839) deleteRecursive does not belong to the other methods

2010-08-11 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-839: --- Fix Version/s: 3.4.0 Priority: Blocker (was: Major) Component/s: java

[jira] Updated: (ZOOKEEPER-823) update ZooKeeper java client to optionally use Netty for connections

2010-08-11 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-823: --- Status: Patch Available (was: Open) update ZooKeeper java client to optionally use

Re: High WTF count in ZooKeeper client code

2010-08-11 Thread Patrick Hunt
Thomas, I see some patches already, which is great, however there's a big/complicated refactoring that's pending here: https://issues.apache.org/jira/browse/ZOOKEEPER-823 and to some extent here: https://issues.apache.org/jira/browse/ZOOKEEPER-733 and refactorings in this code prior to

[jira] Commented: (ZOOKEEPER-837) cyclic dependency ClientCnxn, ZooKeeper

2010-08-11 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897440#action_12897440 ] Patrick Hunt commented on ZOOKEEPER-837: Seems reasonable, notice that

[jira] Commented: (ZOOKEEPER-775) A large scale pub/sub system

2010-08-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12897581#action_12897581 ] Benjamin Reed commented on ZOOKEEPER-775: - i believe the NOTICE file is