[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Alexandre Hardy (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921244#action_12921244 ] Alexandre Hardy commented on ZOOKEEPER-885: --- {quote} Hi Alexandre, When you

[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Alexandre Hardy (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921251#action_12921251 ] Alexandre Hardy commented on ZOOKEEPER-885: --- Hi Patrick, {quote} 1) you are

[jira] Updated: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Alexandre Hardy (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Hardy updated ZOOKEEPER-885: -- Attachment: benchmark.csv Here are some results with different settings of

[jira] Commented: (ZOOKEEPER-893) ZooKeeper high cpu usage when invalid requests

2010-10-15 Thread Thijs Terlouw (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921286#action_12921286 ] Thijs Terlouw commented on ZOOKEEPER-893: - I'll try to write a test case, but

[jira] Commented: (ZOOKEEPER-881) ZooKeeperServer.loadData loads database twice

2010-10-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921306#action_12921306 ] Hudson commented on ZOOKEEPER-881: -- Integrated in ZooKeeper-trunk #967 (See

[jira] Created: (ZOOKEEPER-899) Update Netty version in trunk to 3.2.2

2010-10-15 Thread Thomas Koch (JIRA)
Update Netty version in trunk to 3.2.2 -- Key: ZOOKEEPER-899 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-899 Project: Zookeeper Issue Type: Task Reporter: Thomas Koch The patch for

Re: Branch hudson job created for ZOOKEEPER-823

2010-10-15 Thread Thomas Koch
Patrick Hunt: I created a branch in SVN and a new Hudson job to track the ZOOKEEPER-823 patch. Getting this one done has been tough, Thomas has been working on it but we are seeing intermittent failures. lmk if you have any questions. Hi Patrick, thank you for the branch. Is there a way, how

[jira] Commented: (ZOOKEEPER-851) ZK lets any node to become an observer

2010-10-15 Thread Vishal K (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921340#action_12921340 ] Vishal K commented on ZOOKEEPER-851: Hi Henry , Any comments? Thanks. -Vishal ZK

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Thomas Koch
Hi Benjamin, thank you for your response. Please find some comments inline. Benjamin Reed: code quality is important, and there are things we should keep in mind, but in general i really don't like the idea of risking code breakage because of a gratuitous code cleanup. we should be watching

[jira] Commented: (ZOOKEEPER-445) Potential bug in leader code

2010-10-15 Thread Vishal K (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921360#action_12921360 ] Vishal K commented on ZOOKEEPER-445: Is this a bug? If not, we should just close

[jira] Created: (ZOOKEEPER-900) FLE implementation should be improved to use non-blocking sockets

2010-10-15 Thread Vishal K (JIRA)
FLE implementation should be improved to use non-blocking sockets - Key: ZOOKEEPER-900 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-900 Project: Zookeeper Issue Type:

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Vishal K
Hi, I would like to add my few cents here. I would suggest to stay away from code cleanup unless it is absolutely necessary. I would also like to extend this discussion to understand the amount of testing/QA to be performed before a release. How do we currently qualify a release? Recently, we

[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921412#action_12921412 ] Benjamin Reed commented on ZOOKEEPER-885: - we are having problems reproducing

[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Dave Wright (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921459#action_12921459 ] Dave Wright commented on ZOOKEEPER-885: --- I don't think the cause of this is much

[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921467#action_12921467 ] Flavio Junqueira commented on ZOOKEEPER-885: I'm not sure it is that simple,

[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921471#action_12921471 ] Patrick Hunt commented on ZOOKEEPER-885: re what Dave just mentioned (fsync

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Mahadev Konar
Well said Vishal. I really like the points you put forth!!! Agree on all the points, but again, all the point you mention require commitment from folks like you. Its a pretty hard task to test all the corner cases of ZooKeeper. I'd expect everyone to pitch in for testing a release. We should

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Patrick Hunt
Recently, we have ran into issues in ZK that I believe should have caught by some basic testing before the release Vishal, can you be more specific, point out specific JIRAs that you entered would be very valuable. Don't worry about hurting our feelings or anything, without this type of feedback

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Patrick Hunt
Recently, we have ran into issues in ZK that I believe should have caught by some basic testing before the release Vishal, can you be more specific, point out specific JIRAs that you entered would be very valuable. Don't worry about hurting our feelings or anything, without this type of feedback

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Benjamin Reed
i think we have a very different perspective on the quality issue: I didn't want to say it that clear, but especially the new Netty code, both on client and server side is IMHO an example of new code in very bad shape. The client code patch even changes the FindBugs configuration to exclude

[jira] Updated: (ZOOKEEPER-804) c unit tests failing due to assertion cptr failed

2010-10-15 Thread Jared Cantwell (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jared Cantwell updated ZOOKEEPER-804: - Attachment: ZOOKEEPER-804-1.patch Not sure what the protocol is here, but I'm gonna

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Vishal K
Hi Mahadev, Yes this will require effort from the community. In a related note how many of the contributors do you think are dedicated (either partially or fully to ZK development/testing)? This will help to in understanding how much effort will be required for tasks and how we can prioritize

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Vishal K
Hi Patrick, On Fri, Oct 15, 2010 at 2:22 PM, Patrick Hunt ph...@apache.org wrote: Recently, we have ran into issues in ZK that I believe should have caught by some basic testing before the release Vishal, can you be more specific, point out specific JIRAs that you entered would be very

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Henry Robinson
I broadly agree with Ben - all meaningful code changes carry a risk of destabilization (otherwise software development would be very easy) so we should guard against improving cleanliness only for its own sake. At the point where bad code gets in the way of fixing bugs or adding features, I think

[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Dave Wright (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921528#action_12921528 ] Dave Wright commented on ZOOKEEPER-885: --- Has it been verified that ZK is doing no

[jira] Commented: (ZOOKEEPER-885) Zookeeper drops connections under moderate IO load

2010-10-15 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921557#action_12921557 ] Flavio Junqueira commented on ZOOKEEPER-885: I've been running it and there

[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to assertion cptr failed

2010-10-15 Thread Michi Mutsuzaki (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921558#action_12921558 ] Michi Mutsuzaki commented on ZOOKEEPER-804: --- Jared, thank you for volunteering

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Patrick Hunt
On Fri, Oct 15, 2010 at 12:11 PM, Henry Robinson he...@cloudera.com wrote: The netty patch is a good test case for this approach. If we feel that reworking the structure of the existing server cnxn code will make it significantly easier to add a second implementation that adheres to the same

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Patrick Hunt
On Fri, Oct 15, 2010 at 12:11 PM, Henry Robinson he...@cloudera.com wrote: The netty patch is a good test case for this approach. If we feel that reworking the structure of the existing server cnxn code will make it significantly easier to add a second implementation that adheres to the same

[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to assertion cptr failed

2010-10-15 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921573#action_12921573 ] Patrick Hunt commented on ZOOKEEPER-804: Thanks Jared, I missed your question on

[jira] Updated: (ZOOKEEPER-804) c unit tests failing due to assertion cptr failed

2010-10-15 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-804: --- Status: Patch Available (was: Reopened) c unit tests failing due to assertion cptr

[jira] Commented: (ZOOKEEPER-804) c unit tests failing due to assertion cptr failed

2010-10-15 Thread Michi Mutsuzaki (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921583#action_12921583 ] Michi Mutsuzaki commented on ZOOKEEPER-804: --- The patch looks good, but I can't

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Benjamin Reed
actually, the other way of doing the netty patch (since i'm scared of merges) would be to do a refactor cleanup patch with an eye toward netty, and then another patch to actually add netty. that would have been nice because the first patch would allow us to more easily make sure that NIO