Re: An interest in increasing the DI'ness of ZooKeeper?

2008-07-18 Thread Benjamin Reed
This sounds great. I would suggest opening a Jira to work out the proposal and track the patch. ben Hiram Chirino wrote: Yep, I've looked that the test cases. In short to make that public API more DI friendly, we should: * Decouple the current configuration system from the public API. I

Re: Recipe contrib -- was Re: [PATCH] a simple Leader Election or exclusive Write Lock protocol/policy

2008-07-18 Thread Benjamin Reed
Some initial implementations of a recipe may only be in C, so it would be nice to have a standard way of finding the recipe that wasn't dependent on the language that implements the recipe. ben James Strachan wrote: 2008/7/17 Benjamin Reed [EMAIL PROTECTED]: Excellent proposal. The only

Re: when should a SessionExpiredException occur?

2008-07-23 Thread Benjamin Reed
SessionExpiredExceptions should be extremely rare. Basically they should only happen if a machine goes down (of course that would mean no exception would actually get generated since the client is dead :) or a network partition occurs. Having said that we seem to have a bug that cause

RE: [VOTE] Release ZooKeeper 3.1.0 (candidate 3)

2009-02-09 Thread Benjamin Reed
+1 From: Stu Hood [stuh...@mailtrust.com] Sent: Monday, February 09, 2009 9:11 AM To: zookeeper-dev@hadoop.apache.org Subject: RE: [VOTE] Release ZooKeeper 3.1.0 (candidate 3) +1 Looks good here. -Original Message- From: Patrick Hunt

RE: setACL semantics

2009-02-10 Thread Benjamin Reed
Manos, in your scenario the getData will not succeed. the acl will be checked in the FinalRequestProcessor after the setAcl has passed through the final request processor. execution only happens in the final request processor and always happens in order. the only way a getData will succeed

RE: Preventing SessionExpired events

2009-04-08 Thread Benjamin Reed
I'm curious about your session scenario. If your servers can hang for X seconds without a problem and Y is your session timeout, why would you set Y X? In your case if you set your session timeout to 5 secs for example, but your server can hang for 20 seconds doing GC, your clients cannot

RE: [VOTE] Release ZooKeeper 3.2.1 (candidate 0)

2009-09-02 Thread Benjamin Reed
+1 looks good. ben From: Patrick Hunt [ph...@apache.org] Sent: Friday, August 28, 2009 11:21 AM To: zookeeper-dev@hadoop.apache.org Subject: [VOTE] Release ZooKeeper 3.2.1 (candidate 0) I've created a candidate build for ZooKeeper 3.2.1. This is a bug fix

Re: C formatting conventions

2009-10-23 Thread Benjamin Reed
i think we follow linux coding conventions. i think i wrote most of the code using the linux emacs style. ben Steve Cheng wrote: Hi, What are the C formatting conventions for ZooKeeper? Couldn't find anything on the HowToContribute page. Thank you, Steven

Re: [VOTE] Release ZooKeeper 3.1.2 (candidate 0)

2009-11-24 Thread Benjamin Reed
+1 Patrick Hunt wrote: I've created a candidate build for ZooKeeper 3.1.2. This is a bug fix release addressing just two critical issues -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 4pm pacific time, Friday, November 27.***

Re: [VOTE] Release ZooKeeper 3.2.2 (candidate 0)

2009-11-24 Thread Benjamin Reed
+1 Patrick Hunt wrote: I've created a candidate build for ZooKeeper 3.2.2. This is a bug fix release addressing eleven issues (two critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 5pm pacific time, Friday, November 27.***

Re: Build failed in Hudson: ZooKeeper-trunk #576

2009-12-04 Thread Benjamin Reed
Check it out, the default uncaught exception handler helped! look at this problem: 2009-12-04 09:30:47,333 - ERROR [QuorumPeer with myid:1 and clientPort:11221:quorumpeertestbase$mainthr...@92] - unexpected exception in run java.lang.NullPointerException at

Re: Build failed in Hudson: ZooKeeper-trunk #576

2009-12-04 Thread Benjamin Reed
good find! i think we can fix this problem by doing Selector.open().close() in QuorumBase or perhaps as a static block in NIOServerCnxn.Factory. ben Flavio Junqueira wrote: Is this the problem? http://bugs.sun.com/view_bug.do?bug_id=6427854 -Flavio On Dec 4, 2009, at 5:49 PM, Benjamin

Re: [VOTE] Release ZooKeeper 3.1.2 (candidate 1)

2009-12-09 Thread Benjamin Reed
+1 Flavio Junqueira wrote: +1, I've also run ant test and some manual tests. -Flavio On Dec 9, 2009, at 8:12 AM, Mahadev Konar wrote: +1 I ran ant test and smoke tests. Thanks mahadev On 12/8/09 2:30 PM, Patrick Hunt ph...@apache.org wrote: I've created a second candidate build

Re: [VOTE] Release ZooKeeper 3.2.2 (candidate 1)

2009-12-09 Thread Benjamin Reed
+1 Flavio Junqueira wrote: +1, I've also run ant test and some separate tests. -Flavio On Dec 9, 2009, at 8:10 AM, Mahadev Konar wrote: +1 I ran ant test and some smoke tests. thanks mahadev On 12/8/09 2:32 PM, Patrick Hunt ph...@apache.org wrote: I've created a second candidate

Re: A very strange scenario, may due to some bug on the server side

2009-12-15 Thread Benjamin Reed
does se/diserver_tc/diserver_tc67 appear on all three servers? ben Qian Ye wrote: Hi guys: I find a very strange scenario today, I'm not sure how it happen, I just found it like this. Maybe you can give me some information about it, my Zookeeper Server is version 3.2.1. My Zookeeper

Re: 3.3.0 release planning

2009-12-16 Thread Benjamin Reed
March 10th sounds good to me. ben Patrick Hunt wrote: Now that the fix releases are out we should look at nailing down a date for 3.3.0, once we define a date we can triage the JIRA list and pare it down to what we think we can/should accomplish in the timeframe we have. December is mostly

Re: A deficiency? You can only add children to persistent nodes

2010-03-23 Thread Benjamin Reed
in some sense the children will own the parent. the nice thing about it is that it isn't tied to any particular session, so we don't have to worry about weird cases like owners going away or switching ownership. ben On 03/23/2010 03:04 AM, Dominic Williams wrote: Hi, would work nicely. Who

Re: [VOTE] Release ZooKeeper 3.3.0 (candidate 0)

2010-03-23 Thread Benjamin Reed
+1 ran some load tests and everything looks good. no measurable change in performance from last release. On 03/19/2010 12:43 PM, Patrick Hunt wrote: I have created a candidate build for ZooKeeper 3.3.0. Over 180 JIRAs are addressed in this release. *** Please download, test and VOTE before

Re: How to ensure transaction create-and-update

2010-03-30 Thread Benjamin Reed
Sinfonia is pretty cool, but the commit mechanism is not simple and the ordering guarantees are different. i think we can do it simpler in zookeeper. basically, we would just need to be able to list a set of operations in a single zxid rather than just one operation. in some sense we do do

Re: [VOTE] Release ZooKeeper 3.3.1 (candidate 0)

2010-05-12 Thread Benjamin Reed
+1, things check out for me too. ben On 05/11/2010 11:19 PM, Henry Robinson wrote: +1, Java tests pass for me, as do Python ones. Henry On 11 May 2010 22:32, Patrick Huntph...@apache.org wrote: +1, tests pass for me, also verified that nc/zktop worked properly on a real cluster

Re: enhance zookeeper lock function in cocurrent condition

2010-06-03 Thread Benjamin Reed
if i understand your situation correctly, you have a lock that may have more than 100,000 processes contending for a lock. since this can cause a problem for getChildren, you want to have a way to get the server to do it for you without returning everything. the isFirst method would return

Re: Fwd: RE: WORKSHOP ORGANIZER ZooKeeper

2010-06-09 Thread Benjamin Reed
i will be there. i would be glad to do a talk on bookkeeper/hedwig. ben On 06/09/2010 11:10 AM, Patrick Hunt wrote: Fellow contributors, Yahoo is hosting a contributor workshop the day after the Hadoop Summit. The purpose of the workshops is to collectively discuss challenges, concerns and

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-14 Thread Benjamin Reed
+1 ben On 10/14/2010 11:47 AM, Henry Robinson wrote: +1, I agree that we've addressed most outstanding concerns, we're ready for TLP. Henry On 14 October 2010 13:29, Mahadev Konarmaha...@yahoo-inc.com wrote: +1 for moving to TLP. Thanks for starting the vote Pat. mahadev On 10/13/10

Re: What's the QA strategy of ZooKeeper?

2010-10-14 Thread Benjamin Reed
code quality is important, and there are things we should keep in mind, but in general i really don't like the idea of risking code breakage because of a gratuitous code cleanup. we should be watching out for these things when patches get submitted or when new things go in. i think this is

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Benjamin Reed
i think we have a very different perspective on the quality issue: I didn't want to say it that clear, but especially the new Netty code, both on client and server side is IMHO an example of new code in very bad shape. The client code patch even changes the FindBugs configuration to exclude

Re: What's the QA strategy of ZooKeeper?

2010-10-15 Thread Benjamin Reed
actually, the other way of doing the netty patch (since i'm scared of merges) would be to do a refactor cleanup patch with an eye toward netty, and then another patch to actually add netty. that would have been nice because the first patch would allow us to more easily make sure that NIO

Re: Restarting discussion on ZooKeeper as a TLP

2010-10-21 Thread Benjamin Reed
: * Patrick Hunt ph...@apache.org * Flavio Junqueira f...@apache.org * Mahadev Konarmaha...@apache.org * Benjamin Reedbr...@apache.org * Henry Robinson he...@apache.org NOW, THEREFORE, BE IT FURTHER RESOLVED

Re: What's the magic behind lenBuffer and incomingBuffer?

2010-10-21 Thread Benjamin Reed
look in readLength(). incomingBuffer is set to a newly allocated ByteBuffer. ben On 10/21/2010 07:52 AM, Thomas Koch wrote: Hi, inside ClientCnxn.SendThread we have final ByteBuffer lenBuffer = ByteBuffer.allocateDirect(4); ByteBuffer incomingBuffer = lenBuffer; So

Re: [VOTE] ZooKeeper as TLP?

2010-10-25 Thread Benjamin Reed
+1 On 10/22/2010 02:42 PM, Patrick Hunt wrote: Please vote as to whether you think ZooKeeper should become a top-level Apache project, as discussed previously on this list. I've included below a draft board resolution. Do folks support sending this request on to the Hadoop PMC? Patrick

Re: What happens to a follower if leader hangs?

2010-11-10 Thread Benjamin Reed
have you been able to make this happen? the behavior you are suggesting is exactly what should be happening. When we sync with the leader we set the socket timeout: sock.setSoTimeout(self.tickTime * self.syncLimit); if the leader hangs, we should get a timeout and disconnect from the leader.

[jira] Commented: (ZOOKEEPER-16) Need to do path validation

2008-06-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12605385#action_12605385 ] Benjamin Reed commented on ZOOKEEPER-16: The following characters cannot be used

[jira] Created: (ZOOKEEPER-46) Clients should check the latencies to the various servers and try to connect to the servers with the lowest latencies first

2008-06-17 Thread Benjamin Reed (JIRA)
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-46 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed When ZooKeeper clients and servers are on the same LAN or in the same data center it really doesn't matter which ZooKeeper server

[jira] Created: (ZOOKEEPER-49) SetACL does not work

2008-06-20 Thread Benjamin Reed (JIRA)
SetACL does not work Key: ZOOKEEPER-49 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-49 Project: Zookeeper Issue Type: Bug Components: server Reporter: Benjamin Reed As reported by Shane

[jira] Updated: (ZOOKEEPER-48) AUTH_ID not handled correctly when no auth ids are present

2008-06-20 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-48: --- Attachment: acl_3.patch Since the fix for this issue overlaps with ZOOKEEPER-49 and since

[jira] Resolved: (ZOOKEEPER-47) io thread still around after a EXPIRED_SESSION or AUTH_FAILED event is received

2008-06-27 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-47?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-47. Resolution: Invalid io thread still around after a EXPIRED_SESSION or AUTH_FAILED event

[jira] Commented: (ZOOKEEPER-38) headers (version+) in log/snap files

2008-07-17 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614540#action_12614540 ] Benjamin Reed commented on ZOOKEEPER-38: I really like how you pulled the code

[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-23 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616139#action_12616139 ] Benjamin Reed commented on ZOOKEEPER-83: I completely agreed with the goals you

[jira] Commented: (ZOOKEEPER-58) Race condition on ClientCnxn.java

2008-07-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616998#action_12616998 ] Benjamin Reed commented on ZOOKEEPER-58: +1 Race condition on ClientCnxn.java

[jira] Commented: (ZOOKEEPER-97) The code generators should support an optional output directory

2008-07-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617000#action_12617000 ] Benjamin Reed commented on ZOOKEEPER-97: One thing to keep in mind

[jira] Updated: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions

2008-07-28 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-103: Status: Open (was: Patch Available) The hierachy implemented by this patch conflicts

[jira] Assigned: (ZOOKEEPER-32) CRCs for ZooKeeper data

2008-07-28 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed reassigned ZOOKEEPER-32: -- Assignee: Mahadev konar (was: Benjamin Reed) CRCs for ZooKeeper data

[jira] Assigned: (ZOOKEEPER-38) headers (version+) in log/snap files

2008-07-28 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed reassigned ZOOKEEPER-38: -- Assignee: Mahadev konar (was: Benjamin Reed) Mahadev is simplifying the patch

[jira] Commented: (ZOOKEEPER-104) KeptSet: a distributed data stucture backed by the children of a ZooKeeper node

2008-07-30 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12618399#action_12618399 ] Benjamin Reed commented on ZOOKEEPER-104: - InterruptedException is something we

[jira] Commented: (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2008-08-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619035#action_12619035 ] Benjamin Reed commented on ZOOKEEPER-107: - +1 I like the idea. You can currently

[jira] Updated: (ZOOKEEPER-63) Race condition in client close() operation

2008-08-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-63: --- Attachment: patch_ZOOKEEPER-63.patch I've fixed the patch to not duplicate the logic

[jira] Updated: (ZOOKEEPER-63) Race condition in client close() operation

2008-08-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-63: --- Status: Patch Available (was: Open) Race condition in client close() operation

[jira] Commented: (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2008-08-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619109#action_12619109 ] Benjamin Reed commented on ZOOKEEPER-107: - I think there are two issues here: 1

[jira] Commented: (ZOOKEEPER-44) DataTree does not use natural sort for getChildren

2008-08-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619163#action_12619163 ] Benjamin Reed commented on ZOOKEEPER-44: +1 Fantastic job Jakob! This looks great

[jira] Updated: (ZOOKEEPER-44) DataTree does not use natural sort for getChildren

2008-08-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-44: --- Hadoop Flags: [Reviewed] DataTree does not use natural sort for getChildren

[jira] Commented: (ZOOKEEPER-84) provide a mechanism to reconnect a ZooKeeper if a client receives a SessionExpiredException

2008-08-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619604#action_12619604 ] Benjamin Reed commented on ZOOKEEPER-84: I've documented why Facade is a bad idea

[jira] Resolved: (ZOOKEEPER-49) SetACL does not work

2008-08-05 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-49. Resolution: Fixed The patch for the dependent issue fixed this issue as well. SetACL

[jira] Commented: (ZOOKEEPER-91) provide an option for the WriteLock to also watch the locks own znode, so that if someone else deletes it then it is equivalent to calling WriteLock.unlock()

2008-08-05 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619882#action_12619882 ] Benjamin Reed commented on ZOOKEEPER-91: +1 provide an option for the WriteLock

[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions

2008-08-05 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12620013#action_12620013 ] Benjamin Reed commented on ZOOKEEPER-103: - I think we need to postpone

[jira] Commented: (ZOOKEEPER-113) ZooKeeper.java should be interface not concrete class.

2008-08-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12621497#action_12621497 ] Benjamin Reed commented on ZOOKEEPER-113: - I don't think moving to an interface

[jira] Updated: (ZOOKEEPER-122) NPE in jute's Utils.toCSVString

2008-08-19 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-122: Hadoop Flags: [Reviewed] NPE in jute's Utils.toCSVString

[jira] Created: (ZOOKEEPER-131) Old leader election can elect a dead leader over and over again

2008-09-02 Thread Benjamin Reed (JIRA)
Components: leaderElection Reporter: Benjamin Reed I think there is a race condition that is probably easy to get into with the old leader election and a large number of servers: 1) Leader dies 2) Followers start looking for a new leader before all Followers have abandoned

[jira] Commented: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.

2008-09-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12628352#action_12628352 ] Benjamin Reed commented on ZOOKEEPER-112: - +1 I do have some nits: I don't

[jira] Commented: (ZOOKEEPER-133) hudson tests failing intermittently

2008-09-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12628361#action_12628361 ] Benjamin Reed commented on ZOOKEEPER-133: - I'm thrown

[jira] Commented: (ZOOKEEPER-134) findbugs cleanup

2008-09-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12628362#action_12628362 ] Benjamin Reed commented on ZOOKEEPER-134: - +1 ready to commit findbugs cleanup

[jira] Updated: (ZOOKEEPER-135) Fat jar build target

2008-09-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-135: Attachment: ZOOKEEPER-135.patch This patch modifies the build file to create

[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

2008-09-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-134: Hadoop Flags: [Reviewed] findbugs cleanup Key

[jira] Updated: (ZOOKEEPER-134) findbugs cleanup

2008-09-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-134: Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision

[jira] Updated: (ZOOKEEPER-133) hudson tests failing intermittently

2008-09-05 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-133: Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision

[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.

2008-09-05 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-112: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: (was: log_ZOOKEEPER-136.txt) sync causes hang in all followers

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: (was: testfails_ZOOKEEPER-136.patch) sync causes hang in all followers

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Status: Patch Available (was: Open) sync causes hang in all followers of quorum

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: ZOOKEEPER-136.patch This patch includes the tests that Pat wrote

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: ZOOKEEPER-136.patch Added missing SyncTest. sync causes hang in all

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Status: Patch Available (was: Open) sync causes hang in all followers of quorum

[jira] Updated: (ZOOKEEPER-135) Fat jar build target

2008-09-14 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-135: Attachment: (was: ZOOKEEPER-135.patch) Fat jar build target

[jira] Updated: (ZOOKEEPER-131) Old leader election can elect a dead leader over and over again

2008-09-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-131: Status: Patch Available (was: Open) Old leader election can elect a dead leader over

[jira] Updated: (ZOOKEEPER-131) Old leader election can elect a dead leader over and over again

2008-09-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-131: Attachment: ZOOKEEPER-131.patch This patch adds a test case that reproduces the problem

[jira] Updated: (ZOOKEEPER-137) client watcher objects can lose events

2008-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-137: Hadoop Flags: [Reviewed] +1 Looks good client watcher objects can lose events

[jira] Updated: (ZOOKEEPER-117) threading issues in Leader election

2008-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-117: Hadoop Flags: [Reviewed] +1 Looks good threading issues in Leader election

[jira] Commented: (ZOOKEEPER-38) headers (version+) in log/snap files

2008-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12634267#action_12634267 ] Benjamin Reed commented on ZOOKEEPER-38: This looks great Mahadev. Just small

[jira] Updated: (ZOOKEEPER-117) threading issues in Leader election

2008-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-117: Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision

[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files

2008-10-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-38: --- Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change]) +1 Looks good

[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files

2008-10-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-38: --- Resolution: Fixed Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed

[jira] Updated: (ZOOKEEPER-127) Use of non-standard election ports in config breaks services

2008-10-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-127: Hadoop Flags: [Reviewed] +1 looks good Use of non-standard election ports in config

[jira] Updated: (ZOOKEEPER-127) Use of non-standard election ports in config breaks services

2008-10-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-127: Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-10-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: ZOOKEEPER-136.patch Fixed the comments suggested by Flavio. Updated

[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-10-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Status: Patch Available (was: Open) sync causes hang in all followers of quorum

[jira] Updated: (ZOOKEEPER-154) reliability graph diagram in overview doc needs context

2008-10-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-154: Hadoop Flags: [Reviewed] +1 I'm not much of a proof reader, but It looks good to me

[jira] Updated: (ZOOKEEPER-156) update programmer guide with acl details from old wiki page

2008-10-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-156: Hadoop Flags: [Reviewed] +1 The first sentence of the ACL section refers to ACL

[jira] Updated: (ZOOKEEPER-157) Peer can't find existing leader

2008-10-04 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-157: Hadoop Flags: [Reviewed] +1 looks good. Peer can't find existing leader

[jira] Updated: (ZOOKEEPER-159) Cover two corner cases of leader election

2008-10-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-159: Hadoop Flags: [Reviewed] +1 Looks good Cover two corner cases of leader election

[jira] Updated: (ZOOKEEPER-178) FLE test.

2008-10-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-178: Hadoop Flags: [Reviewed] +1 Looks good! FLE test. - Key

[jira] Updated: (ZOOKEEPER-33) Better ACL management

2008-10-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-33: --- Status: Open (was: Patch Available) -1 Sorry Mahadev, two small issues (one is super

[jira] Updated: (ZOOKEEPER-33) Better ACL management

2008-10-14 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-33: --- Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change]) +1 Great job

[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest

2008-10-14 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-185: Hadoop Flags: [Reviewed] +1 Looks good. My only suggestion would be to rename deadCount

[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch

2008-10-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Attachment: ZOOKEEPER-43.patch This has the server side and the Java client implementation

[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch

2008-10-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Status: Patch Available (was: Open) Server side of the auto reset watches patch

[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-5: -- Status: Open (was: Patch Available) -1 SnapshotUpgradeV1 should be UpgradeSnapshotV1 since

[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch

2008-10-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Attachment: (was: ZOOKEEPER-43.patch) Server side of the auto reset watches patch

[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch

2008-10-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Status: Patch Available (was: Open) Server side of the auto reset watches patch

[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch

2008-10-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Attachment: ZOOKEEPER-43.patch Resynced with trunk. Added tests for local watch objects

[jira] Updated: (ZOOKEEPER-23) Auto reset of watches on reconnect

2008-10-20 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-23: --- Attachment: ZOOKEEPER-23.patch This is the C client for the auto reset of watches

[jira] Updated: (ZOOKEEPER-23) Auto reset of watches on reconnect

2008-10-21 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-23: --- Attachment: (was: ZOOKEEPER-23.patch) Auto reset of watches on reconnect

[jira] Updated: (ZOOKEEPER-23) Auto reset of watches on reconnect

2008-10-21 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-23: --- Attachment: ZOOKEEPER-23.patch In addition to the previous changes I've updated the docs

  1   2   3   4   5   6   7   >