[jira] Commented: (ZOOKEEPER-129) Thrift proxy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627109#action_12627109 ] Patrick Hunt commented on ZOOKEEPER-129: +1 on Mahadev's comments (unit tests should live within this contrib module's subdir(s) somewhere) Having a readme that details how to build/simpleexample would be nice for ppl not already experienced with thrift. also: 1) *.java/.xml/.thrift files need apache source license headers 2) libthrift.jar needs to be renamed to specify the version 3) libthrift.jar also needs an accompanying libthrift-###.LICENSE.txt file ( see src/java/lib for examples with junit/log4j) > Thrift proxy > > > Key: ZOOKEEPER-129 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-129 > Project: Zookeeper > Issue Type: New Feature >Reporter: Chris Smith >Priority: Trivial > Attachments: thriftkeeper.patch > > > This is a basic server that acts as a proxy between a thrift interface and > ZooKeeper. It doesn't support watches, and I'm not entirely convinced the > session handling makes sense, but it works for basic operations like > creating, listing and deleting nodes. The patch puts the code and (basic) > build file under src/contrib/thrift; the build file requires the thrift > compiler to be in the path, and the thrift and zookeeper libraries in the lib > dir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-129) Thrift proxy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627058#action_12627058 ] Mahadev konar commented on ZOOKEEPER-129: - chris, would you be willing to provide a complete interface that supports watches? I think it would be good to have this as a part of contrib. If you do decide on creating a complete interface, then two important things that you would need to do is 1) documentation in forrest on how it works and setup. 2) unit tests to test the interface. > Thrift proxy > > > Key: ZOOKEEPER-129 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-129 > Project: Zookeeper > Issue Type: New Feature >Reporter: Chris Smith >Priority: Trivial > Attachments: thriftkeeper.patch > > > This is a basic server that acts as a proxy between a thrift interface and > ZooKeeper. It doesn't support watches, and I'm not entirely convinced the > session handling makes sense, but it works for basic operations like > creating, listing and deleting nodes. The patch puts the code and (basic) > build file under src/contrib/thrift; the build file requires the thrift > compiler to be in the path, and the thrift and zookeeper libraries in the lib > dir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
