[jira] Commented: (ZOOKEEPER-347) zkfuse uses non-standard String
[ https://issues.apache.org/jira/browse/ZOOKEEPER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12697490#action_12697490 ] Hudson commented on ZOOKEEPER-347: -- Integrated in ZooKeeper-trunk #276 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/276/]) . zkfuse uses non-standard String. (patrick hunt via mahadev) zkfuse uses non-standard String --- Key: ZOOKEEPER-347 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-347 Project: Zookeeper Issue Type: Bug Components: contrib-zkfuse Affects Versions: 3.1.0 Environment: gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7) Reporter: Nitay Joffe Assignee: Patrick Hunt Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-347.patch I'm getting an error compiling zkfuse: g++ -DHAVE_CONFIG_H -I. -I.. -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/include -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/generated -I../include -I/usr/include -D_FILE_OFFSET_BITS=64 -D_REENTRANT -g -O2 -MT zkfuse.o -MD -MP -MF .deps/zkfuse.Tpo -c -o zkfuse.o zkfuse.cc zkfuse.cc: In function 'int main(int, char**)': zkfuse.cc:4282: error: 'String' does not name a type zkfuse.cc:4283: error: 'file' was not declared in this scope make[2]: *** [zkfuse.o] Error 1 make[2]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse' make: *** [all] Error 2 4279 /** 4280 * Initialize log4cxx 4281 */ 4282 const String file(log4cxx.properties); 4283 PropertyConfigurator::configureAndWatch( file, 5000 ); 4284 LOG_INFO(LOG, Starting zkfuse); String is not standard, we should change it to std::string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-347) zkfuse uses non-standard String
[ https://issues.apache.org/jira/browse/ZOOKEEPER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696925#action_12696925 ] Hadoop QA commented on ZOOKEEPER-347: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404895/ZOOKEEPER-347.patch against trunk revision 762602. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/20/console This message is automatically generated. zkfuse uses non-standard String --- Key: ZOOKEEPER-347 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-347 Project: Zookeeper Issue Type: Bug Components: contrib-zkfuse Affects Versions: 3.1.0 Environment: gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7) Reporter: Nitay Joffe Assignee: Patrick Hunt Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-347.patch I'm getting an error compiling zkfuse: g++ -DHAVE_CONFIG_H -I. -I.. -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/include -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/generated -I../include -I/usr/include -D_FILE_OFFSET_BITS=64 -D_REENTRANT -g -O2 -MT zkfuse.o -MD -MP -MF .deps/zkfuse.Tpo -c -o zkfuse.o zkfuse.cc zkfuse.cc: In function 'int main(int, char**)': zkfuse.cc:4282: error: 'String' does not name a type zkfuse.cc:4283: error: 'file' was not declared in this scope make[2]: *** [zkfuse.o] Error 1 make[2]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse' make: *** [all] Error 2 4279 /** 4280 * Initialize log4cxx 4281 */ 4282 const String file(log4cxx.properties); 4283 PropertyConfigurator::configureAndWatch( file, 5000 ); 4284 LOG_INFO(LOG, Starting zkfuse); String is not standard, we should change it to std::string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-347) zkfuse uses non-standard String
[ https://issues.apache.org/jira/browse/ZOOKEEPER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12697080#action_12697080 ] Patrick Hunt commented on ZOOKEEPER-347: this fixes a C code gcc compiler warning, existing tests otw cover. Please review/commit this. zkfuse uses non-standard String --- Key: ZOOKEEPER-347 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-347 Project: Zookeeper Issue Type: Bug Components: contrib-zkfuse Affects Versions: 3.1.0 Environment: gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7) Reporter: Nitay Joffe Assignee: Patrick Hunt Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-347.patch I'm getting an error compiling zkfuse: g++ -DHAVE_CONFIG_H -I. -I.. -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/include -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/generated -I../include -I/usr/include -D_FILE_OFFSET_BITS=64 -D_REENTRANT -g -O2 -MT zkfuse.o -MD -MP -MF .deps/zkfuse.Tpo -c -o zkfuse.o zkfuse.cc zkfuse.cc: In function 'int main(int, char**)': zkfuse.cc:4282: error: 'String' does not name a type zkfuse.cc:4283: error: 'file' was not declared in this scope make[2]: *** [zkfuse.o] Error 1 make[2]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse' make: *** [all] Error 2 4279 /** 4280 * Initialize log4cxx 4281 */ 4282 const String file(log4cxx.properties); 4283 PropertyConfigurator::configureAndWatch( file, 5000 ); 4284 LOG_INFO(LOG, Starting zkfuse); String is not standard, we should change it to std::string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
