[jira] Commented: (ZOOKEEPER-413) two flaws need addressing in the c tests that can cause false positive failures
[ https://issues.apache.org/jira/browse/ZOOKEEPER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805471#action_12805471 ] Hudson commented on ZOOKEEPER-413: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) two flaws need addressing in the c tests that can cause false positive failures --- Key: ZOOKEEPER-413 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413 Project: Zookeeper Issue Type: Bug Components: c client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-413.patch 1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server 2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to have some limit on the number of iterations (other than just the test, which may never return false), also the loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-413) two flaws need addressing in the c tests that can cause false positive failures
[ https://issues.apache.org/jira/browse/ZOOKEEPER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804808#action_12804808 ] Hadoop QA commented on ZOOKEEPER-413: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431380/ZOOKEEPER-413.patch against trunk revision 902694. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/59/console This message is automatically generated. two flaws need addressing in the c tests that can cause false positive failures --- Key: ZOOKEEPER-413 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413 Project: Zookeeper Issue Type: Bug Components: c client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-413.patch 1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server 2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to have some limit on the number of iterations (other than just the test, which may never return false), also the loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-413) two flaws need addressing in the c tests that can cause false positive failures
[ https://issues.apache.org/jira/browse/ZOOKEEPER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12800944#action_12800944 ] Patrick Hunt commented on ZOOKEEPER-413: item 1) is already addressed - we start a single server for all c tests (new in 3.3.0), the script for starting the server now waits for the server to start (up to some max time of course). 2) is still important to fix though two flaws need addressing in the c tests that can cause false positive failures --- Key: ZOOKEEPER-413 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413 Project: Zookeeper Issue Type: Bug Components: c client, tests Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Minor Fix For: 3.3.0 1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server 2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to have some limit on the number of iterations (other than just the test, which may never return false), also the loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.