[jira] Commented: (ZOOKEEPER-444) perms definition for PERMS_ALL differ in C and java

2009-06-18 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721181#action_12721181
 ] 

Hudson commented on ZOOKEEPER-444:
--

Integrated in ZooKeeper-trunk #350 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/350/])
. perms definition for PERMS_ALL differ in C and java (mahadev)


 perms definition for PERMS_ALL differ in C and java
 ---

 Key: ZOOKEEPER-444
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-444
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Blocker
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-444.patch


 the perms_all definition in Java is PERMS.ALL and does not include ADMIN 
 perms but in c the PERMS_ALL def includes the ADMIN perms. We should make it 
 consistent to include or not include the admin perms in both c and java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-444) perms definition for PERMS_ALL differ in C and java

2009-06-17 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720774#action_12720774
 ] 

Benjamin Reed commented on ZOOKEEPER-444:
-

+1 brilliant!

 perms definition for PERMS_ALL differ in C and java
 ---

 Key: ZOOKEEPER-444
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-444
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Blocker
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-444.patch


 the perms_all definition in Java is PERMS.ALL and does not include ADMIN 
 perms but in c the PERMS_ALL def includes the ADMIN perms. We should make it 
 consistent to include or not include the admin perms in both c and java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-444) perms definition for PERMS_ALL differ in C and java

2009-06-16 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720503#action_12720503
 ] 

Hadoop QA commented on ZOOKEEPER-444:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12410884/ZOOKEEPER-444.patch
  against trunk revision 785019.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/117/console

This message is automatically generated.

 perms definition for PERMS_ALL differ in C and java
 ---

 Key: ZOOKEEPER-444
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-444
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.1.1
Reporter: Mahadev konar
Assignee: Mahadev konar
Priority: Blocker
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-444.patch


 the perms_all definition in Java is PERMS.ALL and does not include ADMIN 
 perms but in c the PERMS_ALL def includes the ADMIN perms. We should make it 
 consistent to include or not include the admin perms in both c and java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.