[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802085#action_12802085 ] Steven Cheng commented on ZOOKEEPER-458: Couldn't figure out where it's happening and I don't get quite the same error. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801229#action_12801229 ] Steven Cheng commented on ZOOKEEPER-458: Hi Mahadev, haven't been able to look at it until now, I'll take a look and update on what I find. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12800948#action_12800948 ] Mahadev konar commented on ZOOKEEPER-458: - steve, sorry was out on vacation. Did you get a chacne to take a look at it? did you find something? connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789391#action_12789391 ] Patrick Hunt commented on ZOOKEEPER-458: Have you tried running with valgrind? connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1277#action_1277
]
Mahadev konar commented on ZOOKEEPER-458:
-
it still fails in the same place and with the same back trace:
{quote}
0 0x2adc6886c225 in free () from /lib/libc.so.6
#1 0x004053fb in __gnu_cxx::new_allocatorstd::string::deallocate
(this=0x7fff42e84c88, __p=0x3e7) at
/usr/include/c++/4.3/ext/new_allocator.h:98
#2 0x00405855 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_deallocate_node (this=0x7fff42e84c88,
__p=0x3e7) at /usr/include/c++/4.3/bits/stl_deque.h:454
#3 0x00405886 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_destroy_nodes (this=0x7fff42e84c88,
__nstart=0x1854368, __nfinish=0x1854370)
at /usr/include/c++/4.3/bits/stl_deque.h:557
#4 0x0040592b in ~_Deque_base (this=0x7fff42e84c88) at
/usr/include/c++/4.3/bits/stl_deque.h:480
#5 0x004059a8 in ~deque (this=0x7fff42e84c88) at
/usr/include/c++/4.3/bits/stl_deque.h:776
#6 0x004059fa in ~Message (this=0x7fff42e84c80) at
/usr/include/cppunit/Message.h:39
#7 0x004351bc in Zookeeper_simpleSystem::testConnectIndex1
(this=0x184fde0) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:846
#8 0x00431cc6 in CppUnit::TestCallerZookeeper_simpleSystem::runTest
(this=0x1850040) at /usr/include/cppunit/TestCaller.h:166
#9 0x0045bb6a in CppUnit::TestCaseMethodFunctor::operator() ()
#10 0x00466d54 in CppUnit::DefaultProtector::protect ()
#11 0x004685cf in CppUnit::ProtectorChain::protect ()
#12 0x00463622 in CppUnit::TestResult::protect ()
#13 0x0045b92a in CppUnit::TestCase::run ()
#14 0x00469173 in CppUnit::TestComposite::doRunChildTests ()
#15 0x00469096 in CppUnit::TestComposite::run ()
#16 0x00469173 in CppUnit::TestComposite::doRunChildTests ()
#17 0x00469096 in CppUnit::TestComposite::run ()
#18 0x00462e7a in CppUnit::TestResult::runTest ()
#19 0x004653d2 in CppUnit::TestRunner::run ()
#20 0x004047ea in main (argc=1, argv=0x7fff42e85918) at
/homes/mahadev/zookeeper-trunk/src/c/tests/TestDriver.cc:152
{quote}
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789055#action_12789055 ] Steven Cheng commented on ZOOKEEPER-458: I'm out of ideas for now, can't find anything obvious Mahadev, I will think about it some more. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789070#action_12789070
]
Mahadev konar commented on ZOOKEEPER-458:
-
I tried increasing the timer on waitForConnected to 20 seconds on so and it
seems to pass the tests 4-5 times in a row. So does look like a race condition
somewhere.
{code}
bool waitForConnected(zhandle_t *zh) {
-time_t expires = time(0) + 10;
+time_t expires = time(0) + 20;
while(!connected time(0) expires) {
yield(zh, 1);
{code}
But all the other tests work with a timeout of 10 seconds, so I am really
suspicious of the timer being the problem.
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789148#action_12789148 ] Steven Cheng commented on ZOOKEEPER-458: Hmm.. I tried with a lower timeout on my computer and couldn't get the failure. I'll look around the timer stuff. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788538#action_12788538
]
Mahadev konar commented on ZOOKEEPER-458:
-
I tried running the new patch on the hudson machine. I get a core dump but this
time there is no trace of zookeeper internal calls. This looks very fishy!
{quote}
#0 0x2ab7e7ead225 in free () from /lib/libc.so.6
#1 0x004053fb in __gnu_cxx::new_allocatorstd::string::deallocate
(this=0x7fffc3845648, __p=0x3e7) at
/usr/include/c++/4.3/ext/new_allocator.h:98
#2 0x00405855 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_deallocate_node (this=0x7fffc3845648,
__p=0x3e7) at /usr/include/c++/4.3/bits/stl_deque.h:454
#3 0x00405886 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_destroy_nodes (this=0x7fffc3845648,
__nstart=0x13d3368, __nfinish=0x13d3370) at
/usr/include/c++/4.3/bits/stl_deque.h:557
#4 0x0040592b in ~_Deque_base (this=0x7fffc3845648) at
/usr/include/c++/4.3/bits/stl_deque.h:480
#5 0x004059a8 in ~deque (this=0x7fffc3845648) at
/usr/include/c++/4.3/bits/stl_deque.h:776
#6 0x004059fa in ~Message (this=0x7fffc3845640) at
/usr/include/cppunit/Message.h:39
#7 0x004351bc in Zookeeper_simpleSystem::testConnectIndex1
(this=0x13cede0) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:846
#8 0x00431cc6 in CppUnit::TestCallerZookeeper_simpleSystem::runTest
(this=0x13cf040) at /usr/include/cppunit/TestCaller.h:166
#9 0x0045bb4a in CppUnit::TestCaseMethodFunctor::operator() ()
#10 0x00466d34 in CppUnit::DefaultProtector::protect ()
#11 0x004685af in CppUnit::ProtectorChain::protect ()
#12 0x00463602 in CppUnit::TestResult::protect ()
#13 0x0045b90a in CppUnit::TestCase::run ()
#14 0x00469153 in CppUnit::TestComposite::doRunChildTests ()
#15 0x00469076 in CppUnit::TestComposite::run ()
#16 0x00469153 in CppUnit::TestComposite::doRunChildTests ()
#17 0x00469076 in CppUnit::TestComposite::run ()
#18 0x00462e5a in CppUnit::TestResult::runTest ()
#19 0x004653b2 in CppUnit::TestRunner::run ()
#20 0x004047ea in main (argc=1, argv=0x7fffc38462d8) at
/homes/mahadev/zookeeper-trunk/src/c/tests/TestDriver.cc:152
{quote}
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12787952#action_12787952 ] Hadoop QA commented on ZOOKEEPER-458: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426121/ZOOKEEPER-458.patch against trunk revision 888216. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/20/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/20/console This message is automatically generated. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782513#action_12782513 ] Steven Cheng commented on ZOOKEEPER-458: Now I'm wondering how the old patch passed? Strange. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782525#action_12782525 ] Hadoop QA commented on ZOOKEEPER-458: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426121/ZOOKEEPER-458.patch against trunk revision 882744. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/76/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/76/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/76/console This message is automatically generated. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782535#action_12782535 ] Mahadev konar commented on ZOOKEEPER-458: - the old patch didnt run the cppunit tests since it had already failed at the java tests. the patch you just uploaded failed at the testConnectConnectIndex1 (segfaulted). you can take a look at http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/76/console are the cppunit tests passing for you? connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782633#action_12782633 ] Steven Cheng commented on ZOOKEEPER-458: These ones are passing for me, and still pass after svn update. Can't tell where it segfaults, it should have connected to the server if the zoo_exists returns ZOK? connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782702#action_12782702 ] Steven Cheng commented on ZOOKEEPER-458: Any debugging help you can give would be great Mahadev. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782275#action_12782275 ] Mahadev konar commented on ZOOKEEPER-458: - +1... good to see the tests. the test failure with hudson is a known issue. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782299#action_12782299 ] Mahadev konar commented on ZOOKEEPER-458: - steven, I tried running the ccpunit tests with your patch and it core dumps at testOperationConnectionLoss1 (the test you added) connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12781087#action_12781087 ] Hadoop QA commented on ZOOKEEPER-458: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425744/ZOOKEEPER-458.patch against trunk revision 882744. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/72/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/72/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/72/console This message is automatically generated. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779809#action_12779809 ] Mahadev konar commented on ZOOKEEPER-458: - +1 the patch looks good ... steven, would it be possible to add tests to it? connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779815#action_12779815 ] Steven Cheng commented on ZOOKEEPER-458: I think so... I would need to force handle_error to get called to bump up connect_index. Any tips on the best way to do this? Looks like handle_error gets called from either a socket error or if there's an auth fail. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
