[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777879#action_12777879
]
Hudson commented on ZOOKEEPER-472:
--
Integrated in ZooKeeper-trunk #536 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777245#action_12777245
]
Mahadev konar commented on ZOOKEEPER-472:
-
+1 .. the patch looks good. one minor
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777286#action_12777286
]
Erik Holstad commented on ZOOKEEPER-472:
@Mahadev
I totally agree that it is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12777292#action_12777292
]
Mahadev konar commented on ZOOKEEPER-472:
-
no worries erik!
Making DataNode
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776510#action_12776510
]
Hadoop QA commented on ZOOKEEPER-472:
-
-1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776549#action_12776549
]
Erik Holstad commented on ZOOKEEPER-472:
Not really sure what to do about the no
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776572#action_12776572
]
Patrick Hunt commented on ZOOKEEPER-472:
In general we should have tests but I'm
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776580#action_12776580
]
Erik Holstad commented on ZOOKEEPER-472:
Sounds good to me.
Making DataNode
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12776582#action_12776582
]
Hadoop QA commented on ZOOKEEPER-472:
-
-1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766595#action_12766595
]
Erik Holstad commented on ZOOKEEPER-472:
@ Patrik, sorry for not doing this
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766611#action_12766611
]
Mahadev konar commented on ZOOKEEPER-472:
-
erik,
I just tried compiling the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766626#action_12766626
]
Erik Holstad commented on ZOOKEEPER-472:
@ Mahadev, yeah that was my bad. Not
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766637#action_12766637
]
Mahadev konar commented on ZOOKEEPER-472:
-
erik, there are apache header changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12766655#action_12766655
]
Erik Holstad commented on ZOOKEEPER-472:
@ Mahadev, no reason for it, just a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12765676#action_12765676
]
Patrick Hunt commented on ZOOKEEPER-472:
Hi, what's the status on this JIRA? I'd
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12765697#action_12765697
]
Patrick Hunt commented on ZOOKEEPER-472:
No yelling here, maybe a stern talking
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12765709#action_12765709
]
Erik Holstad commented on ZOOKEEPER-472:
@ Patrik , well good thing you cannot
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12765765#action_12765765
]
Patrick Hunt commented on ZOOKEEPER-472:
thanks for the pointer - I fixed the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12765770#action_12765770
]
Patrick Hunt commented on ZOOKEEPER-472:
Hi Erik, I tried patching the current
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753929#action_12753929
]
Erik Holstad commented on ZOOKEEPER-472:
Did some more coding today and created
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12753939#action_12753939
]
Mahadev konar commented on ZOOKEEPER-472:
-
I htought the jira was just about not
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12754001#action_12754001
]
Erik Holstad commented on ZOOKEEPER-472:
@Mahadev
Yes the Jira was originally
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12741689#action_12741689
]
Erik Holstad commented on ZOOKEEPER-472:
After the HBase meeting this weekend we
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731595#action_12731595
]
Benjamin Reed commented on ZOOKEEPER-472:
-
i think we should expand this to not
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731605#action_12731605
]
Patrick Hunt commented on ZOOKEEPER-472:
good point ben, +1
good catch Erik,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731225#action_12731225
]
Patrick Hunt commented on ZOOKEEPER-472:
Sounds good - as long as we can make
26 matches
Mail list logo