Mahadev konar commented on ZOOKEEPER-473:
the patch looks good... this should finally get the tests running on my mac (it
used to fail because of the bind exceptions, mac isnt that good at releasing
ports). I had 2 comments -
- I think we should still keep the systemoutput/log in the same file and let
hudson have the output as a huge file, the only reason being that it allows the
system otuputs to match with the logging using log4j. I would be useful to see
all the logging and sys output/ error in a single file for a given test. what
do you think?
- also, another check does @Test tags work with javac 1.5? I am not sure if we
still want to support 1.5.
cleanup junit tests to eliminate false positives due to socket reuse and
failure to close client
Issue Type: Improvement
Affects Versions: 3.2.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.3.0
The junit tests will occasionally fail on hudson due to a few problems:
1) socket in use - sometimes the code/testcode will fail to close a socket,
either that or tcp wait
kicks in and the kernel holds onto the socket, either way subsequent tests
that use this same
port will fail
2) sometimes the tests fail to close clients, this results in clients
attempting to re-connect to
the server started as part of a subsequent test (the timeout is very long).
this causes a few
problems, typically extra load on the server or more likely unusual changes
to the server that the
next test(s) don't expect. also causes problems when trying to debug the test
as the old clients
spew messages into the log.
we see this on hudson, occasionally failures. We also saw this when working
on ZOOKEEPER-397, the testng
port. testng does not support fork mode for running the tests. as a result
all the tests (all) run in a single
vm instance, start to finish. so this problem is exacerbated significantly in
that case. this patch only
fixes the problem in junit btw, it does not move to testng
This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.