[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805475#action_12805475 ] Hudson commented on ZOOKEEPER-507: -- Integrated in ZooKeeper-trunk #680 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/680/]) . BookKeeper client re-write (Utkarsh and ben via mahadev) BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Fix For: 3.3.0 Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805265#action_12805265 ] Mahadev konar commented on ZOOKEEPER-507: - +1 ... ill go ahead and commit this. please make sure you add more java docs and forrest docs for bookkeeper. BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Fix For: 3.3.0 Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804608#action_12804608 ] Utkarsh Srivastava commented on ZOOKEEPER-507: -- Oh, you mean the connect callback gets called in the same thread? If so, yes I can see why that would not work. BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Fix For: 3.3.0 Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804298#action_12804298 ] Utkarsh Srivastava commented on ZOOKEEPER-507: -- Ben, could you explain the change in PerChannelBookieClient.java. As far as I could tell, you exchanged the order of - initiating a connect, and - adding operation to pendingops But since these are done under a lock, and the connect callback grabs the same lock, switching this order is immaterial. It shouldn't have fixed anything. BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Fix For: 3.3.0 Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803544#action_12803544 ] Mahadev konar commented on ZOOKEEPER-507: - utkarsh and ben, can you folks please update the jira saying - what changes have been made - the basic design change - what classes have been added and what is there purpose (better javadoc would help here) - what user facing changes have been made - are there forrest docs added for the user interface? - also i took a cursory look, it seems some (very few) of the classes do not have any javadoc or very minimal. It would be really helpful for future and current development if javadoc is added to these classes BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Fix For: 3.3.0 Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1280#action_1280 ] Flavio Paiva Junqueira commented on ZOOKEEPER-507: -- Utkarsh, This patch is broken. There is missing code, which you can actually see from the file size (compare to the previous patches). Could you upload a new complete patch? BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802379#action_12802379 ] Hadoop QA commented on ZOOKEEPER-507: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430774/ZOOKEEPER-507.patch against trunk revision 899383. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 211 release audit warnings (more than the trunk's current 207 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/109/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/109/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/109/console This message is automatically generated. BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802389#action_12802389 ] Flavio Paiva Junqueira commented on ZOOKEEPER-507: -- The following two classes are missing the license headers: # BaseTestCase.java # SyncCounter.java BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801644#action_12801644 ] Hadoop QA commented on ZOOKEEPER-507: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12430595/ZOOKEEPER-507.patch against trunk revision 899383. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/107/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/107/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/107/console This message is automatically generated. BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-507) BookKeeper client re-write
[ https://issues.apache.org/jira/browse/ZOOKEEPER-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12795351#action_12795351 ] Benjamin Reed commented on ZOOKEEPER-507: - it turns out that the BookieFailureTest was failing due to a bug in netty. it appears to have been fixed at the end of september (see http://viewvc.jboss.org/cgi-bin/viewvc.cgi/netty/trunk/src/main/java/org/jboss/netty/channel/socket/nio/NioWorker.java?view=log) . the fix is in 3.1.5. Running with netty 3.1.5 allows all the tests to pass. BookKeeper client re-write -- Key: ZOOKEEPER-507 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-507 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Utkarsh Srivastava Attachments: BookieFailureTest-log-507.rtf, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch, ZOOKEEPER-507.patch Error handling is far from ideal currently in the BookKeeper client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
