[jira] Commented: (ZOOKEEPER-601) allow configuration of session timeout min/max bounds

2010-03-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12844347#action_12844347
 ] 

Hadoop QA commented on ZOOKEEPER-601:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438573/ZOOKEEPER-601.patch
  against trunk revision 921853.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/16/console

This message is automatically generated.

 allow configuration of session timeout min/max bounds
 -

 Key: ZOOKEEPER-601
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-601
 Project: Zookeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-601.patch, ZOOKEEPER-601.patch


 ZK servers currently enforce a min/max boundary on client session timeout 
 relative to the ticktime setting, detailed here:
 http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#ch_zkSessions
 In general there are good reasons for this however in some cases, in 
 particular with HBase region servers, we have seen a need to allow this bound 
 to be set differently (higher). The Sun jvm can GC pause for very long times 
 (in some cases we've seen 4 minutes even with the realtime gc.
 It would be good to allow this bound to be set via configuration parameters. 
 Note: 4letterword and JMX integration would be needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-601) allow configuration of session timeout min/max bounds

2010-03-08 Thread Henry Robinson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12842916#action_12842916
 ] 

Henry Robinson commented on ZOOKEEPER-601:
--

Patch looks great to me - appreciate the refactor of the *Server classes as 
well. 

Tests pass, 'conf' works and JMX works correctly.

+1

 allow configuration of session timeout min/max bounds
 -

 Key: ZOOKEEPER-601
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-601
 Project: Zookeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.3.0

 Attachments: ZOOKEEPER-601.patch


 ZK servers currently enforce a min/max boundary on client session timeout 
 relative to the ticktime setting, detailed here:
 http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#ch_zkSessions
 In general there are good reasons for this however in some cases, in 
 particular with HBase region servers, we have seen a need to allow this bound 
 to be set differently (higher). The Sun jvm can GC pause for very long times 
 (in some cases we've seen 4 minutes even with the realtime gc.
 It would be good to allow this bound to be set via configuration parameters. 
 Note: 4letterword and JMX integration would be needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.