[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804823#action_12804823
]
Mahadev konar commented on ZOOKEEPER-612:
-
+1 the patch looks good.
Make
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804054#action_12804054
]
Hadoop QA commented on ZOOKEEPER-612:
-
+1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803419#action_12803419
]
Hadoop QA commented on ZOOKEEPER-612:
-
-1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12802374#action_12802374
]
Hadoop QA commented on ZOOKEEPER-612:
-
-1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801347#action_12801347
]
Qian Ye commented on ZOOKEEPER-612:
---
Is that because I didn't make the patch based on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801624#action_12801624
]
Mahadev konar commented on ZOOKEEPER-612:
-
sorry, I meant Qian :)
Make
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12801623#action_12801623
]
Mahadev konar commented on ZOOKEEPER-612:
-
steven,
yes you are right. you will
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12800961#action_12800961
]
Hadoop QA commented on ZOOKEEPER-612:
-
-1 overall. Here are the results of testing
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12797214#action_12797214
]
Patrick Hunt commented on ZOOKEEPER-612:
@qian in that case I suggest you ifdef
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796785#action_12796785
]
Benjamin Reed commented on ZOOKEEPER-612:
-
this looks good except for one piece
[
https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12796835#action_12796835
]
Patrick Hunt commented on ZOOKEEPER-612:
Qian thanks for the patch, in future
11 matches
Mail list logo