[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-06-01 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12874192#action_12874192
 ] 

Hudson commented on ZOOKEEPER-769:
--

Integrated in ZooKeeper-trunk #831 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/831/])


 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-21 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870024#action_12870024
 ] 

Patrick Hunt commented on ZOOKEEPER-769:


Hudson seems to be having problems these days, 2 of the machines (h7/h8) have 
been offline all week, and h1 seems to be having issues as well. I think the 
failure is unrelated. ff to commit.

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869756#action_12869756
 ] 

Hadoop QA commented on ZOOKEEPER-769:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444866/ZOOKEEPER-769.patch
  against trunk revision 946074.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/98/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/98/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/98/console

This message is automatically generated.

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869755#action_12869755
 ] 

Hadoop QA commented on ZOOKEEPER-769:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444866/ZOOKEEPER-769.patch
  against trunk revision 944515.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/97/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/97/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/97/console

This message is automatically generated.

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-20 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869766#action_12869766
 ] 

Hadoop QA commented on ZOOKEEPER-769:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444866/ZOOKEEPER-769.patch
  against trunk revision 946074.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/99/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/99/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/99/console

This message is automatically generated.

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-20 Thread Henry Robinson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869822#action_12869822
 ] 

Henry Robinson commented on ZOOKEEPER-769:
--

Failures do not look related to this patch (although I could be mistaken). 
ZkDatabaseCorruptionTest is the most recent broken test - passes fine for me 
locally?

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-19 Thread Sergey Doroshenko (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869118#action_12869118
 ] 

Sergey Doroshenko commented on ZOOKEEPER-769:
-

Yes, changes look good.

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-18 Thread Sergey Doroshenko (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868777#action_12868777
 ] 

Sergey Doroshenko commented on ZOOKEEPER-769:
-

So, since tests pass, should this be committed? Or should something be updated?

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-18 Thread Henry Robinson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868780#action_12868780
 ] 

Henry Robinson commented on ZOOKEEPER-769:
--

Sergey - sorry for the delay. It's on me to review this patch, and then I'll 
commit it.

Thanks for your patience!

Henry

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-07 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865234#action_12865234
 ] 

Patrick Hunt commented on ZOOKEEPER-769:


Hi Sergey, thanks for the patch, see this page for details on contributing:
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute

git is fine, but you need to use the --no-prefix option when doing the diff, 
otw the patch will fail with the automated verification of the patch.

also, in future it's good to name the patch after the jira ie 
ZOOKEEPER-769.patch, it helps reviewers and makes easier to keep track of many 
patches.

Regards.

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-07 Thread Henry Robinson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865240#action_12865240
 ] 

Henry Robinson commented on ZOOKEEPER-769:
--

Sergey - 

Great, thanks for making this patch! ISTR there was some reason why we didn't 
infer peerType from the servers list, but I can't remember what it was...

As for your patch, a few small comments:

1. Use --no-prefix and just attach the output of git-diff (no mail headers etc) 
- Hudson is rather picky about the patch formats it can apply
2. It would be great to include a test that reads a configuration and checks 
that the behaviour is correct
3. If the peerTypes don't match up, should we default to the server list (on 
the assumption that that will be consistent across all servers)?
4. Once you've added the patch, click 'submit patch' to start Hudson moving.

cheers,
Henry

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12865331#action_12865331
 ] 

Hadoop QA commented on ZOOKEEPER-769:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444000/ZOOKEEPER-769.patch
  against trunk revision 941521.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/87/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/87/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/87/console

This message is automatically generated.

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
Assignee: Sergey Doroshenko
 Fix For: 3.4.0

 Attachments: follower.log, leader.log, observer.log, warning.patch, 
 zoo1.cfg, ZOOKEEPER-769.patch


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-06 Thread Henry Robinson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864878#action_12864878
 ] 

Henry Robinson commented on ZOOKEEPER-769:
--

Hi Sergey - 

Can you attach the logs from (at least) the leader node to this ticket? I'd 
like to figure this one out asap.

cheers,
Henry

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
 Fix For: 3.3.0

 Attachments: zoo1.cfg


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-06 Thread Henry Robinson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864953#action_12864953
 ] 

Henry Robinson commented on ZOOKEEPER-769:
--

Sergey - 

In the cfg files for nodes 3 and 5, did you include the following line? 

peerType=observer

See http://hadoop.apache.org/zookeeper/docs/r3.3.0/zookeeperObservers.html for 
details. The observer log contains this line:

2010-05-06 22:46:00,876 - INFO  
[QuorumPeer:/0:0:0:0:0:0:0:0:2183:quorump...@642] - FOLLOWING

which is a big red flag because observers should never adopt the FOLLOWING 
state. 

If I don't have that line I can reproduce your issue. If I add it, the 
observers work as expected. Can you check your cfg files?

cheers,
Henry

 Leader can treat observers as quorum members
 

 Key: ZOOKEEPER-769
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.3.0
 Environment: Ubuntu Karmic x64
Reporter: Sergey Doroshenko
 Fix For: 3.3.0

 Attachments: follower.log, leader.log, observer.log, zoo1.cfg


 In short: it seems leader can treat observers as quorum members.
 Steps to repro:
 1. Server configuration: 3 voters, 2 observers (attached).
 2. Bring up 2 voters and one observer. It's enough for quorum.
 3. Shut down the one from the quorum who is the follower.
 As I understand, expected result is that leader will start a new election 
 round so that to regain quorum.
 But the real situation is that it just says goodbye to that follower, and is 
 still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
 trying to regain a quorum).
 (Expectedly, if on step 3 we shut down the leader, not the follower, 
 remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.