[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-08-02 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12619239#action_12619239
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


I've created a maven plugin that can be used to verify integrity of downloaded 
dependencies.  This should cross out the biggest concern that the hadoop folks 
had with maven.  The plugin can be found here:

https://svn.apache.org/repos/asf/servicemix/maven-plugins/checksum-maven-plugin/trunk

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino

 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-28 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617505#action_12617505
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


FYI: The maven folks are working on the security issue:
http://docs.codehaus.org/display/MAVEN/Repository+Security


 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino

 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-25 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617070#action_12617070
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


Re-opened as a new issue ZOOKEEPER-103
it reduces the scope of the patch to just be implementing the maven directory 
conventions.

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino

 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-25 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617081#action_12617081
 ] 

Mahadev konar commented on ZOOKEEPER-83:


are we going to close this one then ?

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino

 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-25 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12617085#action_12617085
 ] 

Patrick Hunt commented on ZOOKEEPER-83:
---

Some additional background: similar request on hadoop core with list of pro/con 
HADOOP-3302

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino

 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-24 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616575#action_12616575
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


BTW there are lots of CI tools used at the ASF which DO support maven.  But hey 
if you like Hudson that's cool.

Can we at least merge the patch in so that the maven directory convention is 
preserved and then we can delete the maven build files if you like.  The ant 
build can work with that structure just fine.  If we do that then I can provide 
folks who are interested in a maven build the pom files that just overlay onto 
the project do they can use maven to build it.

So we both win.  ZooKeeper only has 1 build system ant.  Maven users also win 
cause they can get some optional poms from me to build the project with.  What 
do you think?

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-24 Thread james strachan (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616580#action_12616580
 ] 

james strachan commented on ZOOKEEPER-83:
-

Hudson does support Maven and Ant natively

http://hudson.gotdns.com/wiki/display/HUDSON/Plugins#Plugins-Buildtools


 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-24 Thread Nigel Daley (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616583#action_12616583
 ] 

Nigel Daley commented on ZOOKEEPER-83:
--

+1 for staying with Ant and creating maven artifacts.

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-23 Thread james strachan (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615954#action_12615954
 ] 

james strachan commented on ZOOKEEPER-83:
-

Note its pretty trivial to maintain an Ant build as well as a Maven build if 
folks really have an aversion to Maven. There's really no reason at all to 
disallow a maven build from being created; they can both happily coexist - and 
its also a pretty trivial bit of work - not some huge bit of RD thats gonna 
slow down development on other things. Also note that a non committer has 
already contributed the patch already for you - so no more work is required 
other than committing it :)

Its worth remembering that pretty much all popular Java software at Apache is 
now released into a Maven repository...
http://people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/

so if folks stick with Ant and refuse to allow a maven build to coexist with 
the Ant build, someone should volunteer to figure out how to hack the Ant build 
to release ZooKeeper into the Apache maven repository - otherwise its pretty 
hard for folks who do use maven to reuse your code (and see from the repo how 
many Apache projects we're talking about not being able to easily reuse 
ZooKeeper).

i.e. as part of the move to the ASF and being a good Apache citizen, I'd 
recommend hugely that as a minimum ZooKeeper releases its jars into the Apache 
Maven repository like most other projects do.

The easiest way to do this is just to reuse a Maven build to do releases (there 
doesn't yet seem to be anything in the Ant build to do actual signed releases 
or deploy builds anywhere) - and let folks who prefer Ant to stick to that for 
day to day development.

The easier it is to reuse a project, the more likely it'll get used and the 
more likely you'll get contributions; at least thats my experience at Apache. 
That doesn't mean you have to force your Ant-loving developers to switch build 
tools!

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-23 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616020#action_12616020
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


James is right.

An ant build could easily co-exist with the maven one if folks feel that 
adverse to maven.

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-23 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616139#action_12616139
 ] 

Benjamin Reed commented on ZOOKEEPER-83:


I completely agreed with the goals you are expressing. Having ZooKeeper in the 
Maven repository is a good thing all the way around.

The problem I have is supporting two different build tools. Granted we have a 
patch now, but going forward we would have to maintain (meaning fixing the 
build scripts and running the tests) both. I think that one build tool makes 
everyones life sane (er).

I'm not familiar with most projects, but Hadoop (who we are a subproject of) 
doesn't use Maven. I talked to Owen about Hadoop using Maven and he mentioned 
they were looking at Ivy. I also see that there are Maven ant tasks from the 
Maven project that we can use. It seems to me that least disruptive way to get 
into the Maven repository is to use either the ant tasks or Ivy.

Do you guys have an opinion on either of those two routes?

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-23 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12616200#action_12616200
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


Hi folks.. 

To make the maven re-org super simple to apply I created a temp private branch 
so that the changes can easily be merged into trunk.
This branch also has an updated ant build which works with the new maven 
directory structure.

To merge the changes back into trunk, just run the follow in a clean trunk 
checkout:

[code}
svn merge -r 679094:679134 
https://svn.apache.org/repos/asf/activemq/sandbox/zookeeper
{code}

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread james strachan (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615546#action_12615546
 ] 

james strachan commented on ZOOKEEPER-83:
-

I just took a look at the patch; basically the maven conventions are to put 
source in ${module-name}/src/main/java and tests in 
${module-name}/src/test/java and resources in src/main/resources etc.

Plus it looks like hiram's split the project into multiple maven modules. (e.g. 
so that the Java 6 JMX code is a separate module so that the core of zookeeper 
can be used on Java 5 - which is a good thing IMHO - plus separating the jute 
stuff so it can be used in development time to generate code etc). Its also 
easy to generate an uber-jar if folks want later on.

This patch looks good to me - assuming folks are happy to go the maven route 
(which many other apache projects do btw - it certainly makes it much easier 
for zookeeper to be reused by other maven projects).

If this patch gets applied I'll happily volunteer to refactor my 
recipes/protocols patch to create a zookeeper-protocols module to create a 
separate jar for higher level stuff

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Flavio Paiva Junqueira (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615617#action_12615617
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-83:
-

I remember we had a discussion right when we moved ZooKeeper to sourceforge 
about moving to maven, and we ended up agreeing not to do it. I'm happy to 
retake the discussion, but as I don't fully understand all the implications of 
moving to maven, it would be useful to me to understand what we gain and what 
we lose by doing it. 

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615619#action_12615619
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


Besides the re-organization of the directory structures, I added a couple 
Mojo.java files for to create the maven plugins for the source code generation 
bits.  And I modified the jute and version gen stuff so that you can specify an 
output directory.

Also several files got deleted like all the jar files in the lib dir, and the 
checked in javacc generated files since maven is now running javacc to generate 
them from the .jj file.

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615620#action_12615620
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


James, I think you missed it but, the build dues include a module to create a 
uber-jar, look at the zookeeper-all module.  This creates a jar with all the 
runtime dependencies needed to run a zookeeper server (yes this includes log4j).


 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615764#action_12615764
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


Flavio,

maven provides a much more standardize build process than ant.  Any maven java 
project has the same directory structure and build/release procedure.  
Therefore new contributors who are familiar with maven will be more comfortable 
contributing to ZooKeeper because of it.

It handles lots of the wonky ASF relase rules like:
* GPG sighing
* staging release artifacts to get voted on. 
* building binary distros with api docs
* building source distros
* including and verifying LICENSE and NOTICE files are in all jars
* It can run the rat tool for you to verify that all source files have the 
right headers on them

It encourages folks to use your project
* It deploys your jar artifacts to a centralized maven repository where other 
projects can automatically pull your libs into their builds.
* the maven repo is a sort of eco system, where if your artifacts are available 
in it, folks are more willing to use your stuff, and they in turn pubish 
artifacts the depend on ZooKeeper which in turn might get used by someone else 
who transitively gets ZooKeeper
* It encourages good release patterns like including the version number in the 
jar.  Nice to have so that when folks use your jars it is obvious what version 
they are using.

It encourages good modularization/decoupling:
* It's easy to add additional jars to the project and then add dependencies 
between them.  This encourage folks to decouple their code properly.
* Once you have a nicely modular project, it easy for folks to add additional 
optional modules for new features.  For example I could see folks wanting a 
zookeeper-spring module.

Plus it does lots of useful things like:
* generate IDE project files so that they don't need to be manually maintained.
* it can enforce checkstyle rules if desired
* Runs findbugs and cobertura 
* It can creates  great set of cross indexed html docs about the build 
including 

Plus since it's declarative in a nature, folks can use other maven plugins 
against the build (without changing the build files) to access additional 
interesting features.

Maven in general is more higher level concept than ANT.  It brings power and 
flexibility to the table.  Plus it's the direction most new java projects are 
taking these days.

So I think the question really is why keep ANT?

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615793#action_12615793
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


Sure.. maven is not yet impervious to having it's repository hacked.  But does 
it actually happen? No.

But then again any repository can get hacked.. even the one we deploy our 
distributions to.  Yes we sign the releases, but how often do folks actually 
validate against it?  So in most systems that kind of attack will happen.

Is that the only issue?

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Doug Cutting (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615799#action_12615799
 ] 

Doug Cutting commented on ZOOKEEPER-83:
---

 Is that the only issue?

I think its fundamentally a cultural issue.  We have developers here who are 
familiar with Ant and have developed processes around Ant and are not 
frustrated with Ant and see no need to switch to a different build system.  
It's a bit like git versus svn: git may be better, but not enough folks yet 
feel that svn is a significant bottleneck, perhaps through ignorance.  I still 
use Emacs, despite folks telling me I should use an IDE.

If the majority of Zookeeper's community want to switch to Maven, I would 
certainly not oppose it.


 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615802#action_12615802
 ] 

Mahadev konar commented on ZOOKEEPER-83:


i agree with Doug on this. We never felt a need for maven since our code base 
is not huge and we are all familiar with ant and we havent had any problems 
with ant yet.

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615827#action_12615827
 ] 

Benjamin Reed commented on ZOOKEEPER-83:


I think it might be good to separate out the issues here. Two of them I see 
are: 1) Use Maven instead of ANT to build because Maven is so much better. 2) 
Make it so that ZooKeeper can be added to a Maven repository.

I'm not really convinced about 1), but 2) seems like a cool thing. I believe 
there is a way to use ANT to create Maven modules for the repository right?

 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-22 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615882#action_12615882
 ] 

Patrick Hunt commented on ZOOKEEPER-83:
---

Regardless of whether this is a good idea or not we should consider whether 
it's a good idea _right now_. We are currently working towards 4 goals (in 
order or priority):

1) support/expand our user  contributor base
2) complete migration to ASF
3) 3.0 version of ZooKeeper
and just added recently
4) recipe implementation (which is a good thing IMO and also supports 1 above)

Given the current build system is functioning fine I personally think we should 
post-pone decisions like this and continue to work towards the goals listed 
above. There's more than enough work to go around w/o creating new.

ps:

I've added Roadmap and ProjectSuggestions pages to the ZooKeeper wiki. Pretty 
bare right now but I can tell you that tests (refactoring our current 
client/server test infrastructure in particular - see ZOOKEEPER-61) and 
documentation need alot of work. Don't hesitate to contact me or any of the 
other committers if you'd like to take on an existing Jira issue slated for 3.0 
or would like to be assigned something.



 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-21 Thread Hiram Chirino (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615494#action_12615494
 ] 

Hiram Chirino commented on ZOOKEEPER-83:


I just attached a mavenized version of ZooKeeper based on rev 677371

I would have provided a patch, but due to the directory re-organizations, it 
would be too hard to produce and apply.  So attached is a full source distro, 
please evaluate and comment.  Hopefully if folks like it, it can be used as a 
guide.

For folks who are new to maven, here is a quick guide:

to build: mvn install
to clean mvn clean
to clean build: mvn clean install

to skip tests during a build: mvn install -Dtest=false 
to create eclipse project files: mvn eclipse:eclipse
to create intelij projects files: mvn idea:idea



 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper

2008-07-21 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615507#action_12615507
 ] 

Mahadev konar commented on ZOOKEEPER-83:


hiram, can you list an overall set of changes you had to make to make the src 
tree maven compatible. It would help with people who do not want to download 
the tgz to see what the changes are. 


 Switch to using maven to build ZooKeeper
 

 Key: ZOOKEEPER-83
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
 Project: Zookeeper
  Issue Type: Improvement
  Components: build
Reporter: Hiram Chirino
Assignee: Hiram Chirino
 Attachments: zookeeper-mavened.tgz


 Maven is a great too for building java projects at the ASF.  It helps 
 standardize the build a bit since it's a convention oriented.
 It's dependency auto downloading would remove the need to store the 
 dependencies in svn, and it will handle many of the suggested ASF policies 
 like gpg signing of the releases and such.
 The ZooKeeper build is almost vanilla except for the jute compiler bits.  
 Things that would need to change are:
  * re-organize the source tree a little so that it uses the maven directory 
 conventions
  * seperate the jute bits out into seperate modules so that a maven plugin 
 can be with it
  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.