[jira] Commented: (ZOOKEEPER-898) C Client might not cleanup correctly during close
[ https://issues.apache.org/jira/browse/ZOOKEEPER-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926008#action_12926008 ] Hudson commented on ZOOKEEPER-898: -- Integrated in ZooKeeper-trunk #983 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/983/]) ZOOKEEPER-898. C Client might not cleanup correctly during close (jared cantwell via mahadev) > C Client might not cleanup correctly during close > - > > Key: ZOOKEEPER-898 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-898 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Jared Cantwell >Assignee: Jared Cantwell >Priority: Trivial > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEEPER-898.diff, ZOOKEEPER-898.patch > > > I was looking through the c-client code and noticed a situation where a > counter can be incorrectly incremented and a small memory leak can occur. > In zookeeper.c : add_completion(), if close_requested is true, then the > completion will not be queued. But at the end, outstanding_sync is still > incremented and free() never called on the newly allocated completion_list_t. > > I will submit for review a diff that I believe corrects this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-898) C Client might not cleanup correctly during close
[ https://issues.apache.org/jira/browse/ZOOKEEPER-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925909#action_12925909 ] Mahadev konar commented on ZOOKEEPER-898: - +1, good catch jared. I just committed this to 3.3 and trunk. thanks! > C Client might not cleanup correctly during close > - > > Key: ZOOKEEPER-898 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-898 > Project: Zookeeper > Issue Type: Bug > Components: c client >Reporter: Jared Cantwell >Assignee: Jared Cantwell >Priority: Trivial > Fix For: 3.3.2, 3.4.0 > > Attachments: ZOOKEEEPER-898.diff, ZOOKEEPER-898.patch > > > I was looking through the c-client code and noticed a situation where a > counter can be incorrectly incremented and a small memory leak can occur. > In zookeeper.c : add_completion(), if close_requested is true, then the > completion will not be queued. But at the end, outstanding_sync is still > incremented and free() never called on the newly allocated completion_list_t. > > I will submit for review a diff that I believe corrects this issue. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
