[jira] Updated: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-291: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. THnaks pat. > regression for legacy code using KeeperException.Code constants (due to 246) > > > Key: ZOOKEEPER-291 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.1.0 > > Attachments: ZOOKEEPER-291.patch > > > In 246 the old constants were deprecated and replace with enum. In the > process usage of the orig constants was broken for switch statements, cases > require compiletime constants. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-291: --- Status: Patch Available (was: Open) Please review and commit this patch - it needs to be committed to both the trunk and also the 3.1 branch. At the same time be sure to edit the CHANGES.txt (again both main/branch) to specify that 246 was an incompatible change (this one is just a bug). I will ensure this is in the release notes for 3.1 release. > regression for legacy code using KeeperException.Code constants (due to 246) > > > Key: ZOOKEEPER-291 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.1.0 > > Attachments: ZOOKEEPER-291.patch > > > In 246 the old constants were deprecated and replace with enum. In the > process usage of the orig constants was broken for switch statements, cases > require compiletime constants. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-291: --- Attachment: ZOOKEEPER-291.patch I added tests (that failed w/o the changes) to verify that legacy code will work ok using the deprecated constants in switch case statements. Also added tests to make sure the new enums work too :-) > regression for legacy code using KeeperException.Code constants (due to 246) > > > Key: ZOOKEEPER-291 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.1.0 > > Attachments: ZOOKEEPER-291.patch > > > In 246 the old constants were deprecated and replace with enum. In the > process usage of the orig constants was broken for switch statements, cases > require compiletime constants. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
