[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-337:
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks pat.
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch,
> ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Status: Patch Available (was: Open)
resubmitting - "already bound address" issue in one of the tests (false
positive) that I hadn't touched.
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch,
> ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Status: Open (was: Patch Available)
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch,
> ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Attachment: ZOOKEEPER-337.patch
Fixed findbugs warning.
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch,
> ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Status: Patch Available (was: Open)
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch,
> ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Status: Open (was: Patch Available)
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch,
> ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Status: Patch Available (was: Open)
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Attachment: ZOOKEEPER-337.patch
fixed merge conflict for latest svn
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch, ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-337:
Status: Open (was: Patch Available)
this patch no longer applies cleanly to trunk. Can you upload a new patch pat?
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Status: Patch Available (was: Open)
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-337) improve logging in leader election lookForLeader method when address resolution fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-337:
---
Attachment: ZOOKEEPER-337.patch
The logging now includes the bad address.
Added a test to verify that it's logged/handled correctly.
Also fixed some tests that were using lower connection timeouts than they
should be. Updated to use the default for tests.
I also fixed a problem with JMX during leadership changes.
> improve logging in leader election lookForLeader method when address
> resolution fails
> -
>
> Key: ZOOKEEPER-337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-337
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-337.patch
>
>
> leader election has the following code:
> requestPacket.setSocketAddress(server.addr);
> LOG.info("Server address: " + server.addr);
> this should be switched to have the info log first, set sock addr second.
> The reason for this is that if the setSocketAddress fails sun is not printing
> the address used. As a result it's verfy difficult to debug this issue.
> If we log the server address first, then if the setsockaddr fails we'll see
> both the address of the server and the exception detail (right now we just
> see the exception detail which does not include the invlaid address in
> invalidaddressexception).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
