[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-43: --- Resolution: Fixed Hadoop Flags: [Incompatible change, Reviewed] (was: [Incompatible change]) Status: Resolved (was: Patch Available) I fixed the comments and committed the patch. Thanks Ben. > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, > ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Hadoop Flags: [Incompatible change] Status: Patch Available (was: Open) > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, > ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-43: -- Attachment: ZOOKEEPER-43.patch Another update to the patch - I realized that the watches needed to be cleared on client if autoreset is disabled. Also updated the watcher test to validate this case. > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, > ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-43: -- Status: Open (was: Patch Available) In general I'm ok with this patch but I see the following issues which need to be addressed: 1) update this jira with some detail on why/how of the changes, include potential impact on new/legacy code 2) update the forrest documentation to reflect this change programmers guide, specifically watches section (general info and the option to turn off) does/should this cause changes to the example code in the docs? 3) update the release notes to document this change (releasenotes.xml) specifically call out impact on client code also document the zookeeper.disableAutoWatchReset environment variable which allows users to disable autoreset of watches w/in the client application (server will still support) > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, > ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-43: -- Attachment: ZOOKEEPER-43.patch I've updated the patch to support an option to turn off autoreset of watches (just in case the client doesn't wish to use or has some issue, ie legacy code has unforseen incompatibility). /** This controls whether automatic watch resetting is enabled. * Clients automatically reset watches during session reconnect, this * option allows the client to turn off this behavior by setting * the environment variable "zookeeper.disableAutoWatchReset" to "true" */ by default autoreset of watches is turned on in the client, this allows turning it off. > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, > ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-43: -- Attachment: ZOOKEEPER-43.patch I found an additional problem with copyStat in DataTree was not copying pzxid - I added the copy and also updated the tests to check for this. Tests now pass. > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, > ZOOKEEPER-43.patch, ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-43: -- Attachment: ZOOKEEPER-43.patch this updated patch fixes the command line client to output the new stat information > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch, > ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-43: -- Attachment: ZOOKEEPER-43.patch I updated the patch to fix: 1) compilation failure in jmx 2) fixed javadoc of deleteNode 3) removed tabs introduced to .jute file > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch, ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Attachment: ZOOKEEPER-43.patch Resynced with trunk. Added tests for local watch objects and global watch objects. > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Status: Patch Available (was: Open) > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Attachment: (was: ZOOKEEPER-43.patch) > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-43: -- Status: Open (was: Patch Available) can you update the patch to the latest svn, patch is failing. > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Status: Patch Available (was: Open) > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-43) Server side of the auto reset watches patch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-43: --- Attachment: ZOOKEEPER-43.patch This has the server side and the Java client implementation. It also has testcases to cover both. > Server side of the auto reset watches patch > --- > > Key: ZOOKEEPER-43 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-43 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-43.patch > > > Moved from SourceForge to Apache. > http://sourceforge.net/tracker/index.php?func=detail&aid=1975262&group_id=209147&atid=1008546 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
