[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-08-03 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Status: Patch Available  (was: Open)

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-08-03 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Status: Open  (was: Patch Available)

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-08-03 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-480:


Status: Open  (was: Patch Available)

flavio, the patch does not apply any more after ZOOKEEPER-481 commit. can you 
please update the patch?

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-08-03 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Attachment: ZOOKEEPER-480.patch

Regenerated patch to apply to trunk. Will be posting a new patch for 3.2 trunk 
shortly.

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-08-03 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Attachment: ZOOKEEPER-480-3.2branch.patch

Patch for 3.2 branch.

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, 
 ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-31 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Attachment: ZOOKEEPER-480-3.2branch.patch

Uploading the 3.2 version of the patch.

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-31 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Status: Open  (was: Patch Available)

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-31 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Attachment: ZOOKEEPER-480.patch

Small modification to port assignment in the test, re-running to make sure that 
still passes all tests.

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480-3.2branch.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-30 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Attachment: ZOOKEEPER-480.patch

Added the comment Ben suggested. Thanks, Ben.

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch, 
 ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-27 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-480:
---

Status: Patch Available  (was: Open)

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-22 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-480:
---

Affects Version/s: 3.2.0
Fix Version/s: 3.3.0

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.1, 3.3.0

 Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-21 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Status: Patch Available  (was: Open)

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
 Fix For: 3.2.1

 Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-21 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Attachment: ZOOKEEPER-480.patch

* Adds a case to leader election to recover from a lost message when one single 
follower elects a leader, but the leader missed the new vote from the follower. 
This is not a really critical case because in practice the servers would just 
move to a new round of leader election, and the likelihood that this keeps 
happening forever is small;
* It adds a unit test that basically mocks a server to force a particular 
sequence and interleaving of messages;
* It makes some methods and variables public in QuorumCnxManager to enable the 
unit test to access them directly.


 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
 Fix For: 3.2.1

 Attachments: ZOOKEEPER-480.patch, ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-480) FLE should perform leader check when node is not leading and add vote of follower

2009-07-20 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-480:
-

Attachment: ZOOKEEPER-480.patch

 FLE should perform leader check when node is not leading and add vote of 
 follower
 -

 Key: ZOOKEEPER-480
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-480
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
 Fix For: 3.2.1

 Attachments: ZOOKEEPER-480.patch


 As a server may join leader election while others have already elected a 
 leader, it is necessary that a server handles some special cases of leader 
 election when notifications are from servers that are either LEADING or 
 FOLLOWING. In such special cases, we check if we have received a message from 
 the leader to declare a leader elected. This check does not consider the case 
 that the process performing the check might be a recently elected leader, and 
 consequently the check fails.
 This patch also adds a new case, which corresponds to adding a vote to 
 recvset when the notification is from a process LEADING or FOLLOWING. This 
 fixes the case raised in ZOOKEEPER-475.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.