[jira] Updated: (ZOOKEEPER-645) Bug in WriteLock recipe implementation?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-645: Fix Version/s: (was: 3.3.0) 3.4.0 not a blocker. moving it to 3.4. Bug in WriteLock recipe implementation? --- Key: ZOOKEEPER-645 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-645 Project: Zookeeper Issue Type: Bug Components: recipes Affects Versions: 3.2.2 Environment: 3.2.2 java 1.6.0_12 Reporter: Jaakko Laine Assignee: Mahadev konar Priority: Minor Fix For: 3.4.0 Attachments: 645-fix-findPrefixInChildren.patch Not sure, but there seem to be two issues in the example WriteLock: (1) ZNodeName is sorted according to session ID first, and then according to znode sequence number. This might cause starvation as lower session IDs always get priority. WriteLock is not thread-safe in the first place, so having session ID involved in compare operation does not seem to make sense. (2) if findPrefixInChildren finds previous ID, it should add dir in front of the ID -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-645) Bug in WriteLock recipe implementation?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-645: --- Component/s: recipes Fix Version/s: 3.3.0 Assignee: Jaakko Laine Mahadev can you review this one? Bug in WriteLock recipe implementation? --- Key: ZOOKEEPER-645 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-645 Project: Zookeeper Issue Type: Bug Components: recipes Affects Versions: 3.2.2 Environment: 3.2.2 java 1.6.0_12 Reporter: Jaakko Laine Assignee: Jaakko Laine Priority: Minor Fix For: 3.3.0 Attachments: 645-fix-findPrefixInChildren.patch Not sure, but there seem to be two issues in the example WriteLock: (1) ZNodeName is sorted according to session ID first, and then according to znode sequence number. This might cause starvation as lower session IDs always get priority. WriteLock is not thread-safe in the first place, so having session ID involved in compare operation does not seem to make sense. (2) if findPrefixInChildren finds previous ID, it should add dir in front of the ID -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-645) Bug in WriteLock recipe implementation?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-645: Status: Patch Available (was: Open) Bug in WriteLock recipe implementation? --- Key: ZOOKEEPER-645 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-645 Project: Zookeeper Issue Type: Bug Components: recipes Affects Versions: 3.2.2 Environment: 3.2.2 java 1.6.0_12 Reporter: Jaakko Laine Assignee: Jaakko Laine Priority: Minor Fix For: 3.3.0 Attachments: 645-fix-findPrefixInChildren.patch Not sure, but there seem to be two issues in the example WriteLock: (1) ZNodeName is sorted according to session ID first, and then according to znode sequence number. This might cause starvation as lower session IDs always get priority. WriteLock is not thread-safe in the first place, so having session ID involved in compare operation does not seem to make sense. (2) if findPrefixInChildren finds previous ID, it should add dir in front of the ID -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-645) Bug in WriteLock recipe implementation?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-645: --- Status: Open (was: Patch Available) We should add tests to this to verify the change. Bug in WriteLock recipe implementation? --- Key: ZOOKEEPER-645 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-645 Project: Zookeeper Issue Type: Bug Components: recipes Affects Versions: 3.2.2 Environment: 3.2.2 java 1.6.0_12 Reporter: Jaakko Laine Assignee: Jaakko Laine Priority: Minor Fix For: 3.3.0 Attachments: 645-fix-findPrefixInChildren.patch Not sure, but there seem to be two issues in the example WriteLock: (1) ZNodeName is sorted according to session ID first, and then according to znode sequence number. This might cause starvation as lower session IDs always get priority. WriteLock is not thread-safe in the first place, so having session ID involved in compare operation does not seem to make sense. (2) if findPrefixInChildren finds previous ID, it should add dir in front of the ID -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-645) Bug in WriteLock recipe implementation?
[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jaakko Laine updated ZOOKEEPER-645: --- Attachment: 645-fix-findPrefixInChildren.patch Attached patch addresses issue 2 above. Bug in WriteLock recipe implementation? --- Key: ZOOKEEPER-645 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-645 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.2 Environment: 3.2.2 java 1.6.0_12 Reporter: Jaakko Laine Priority: Minor Attachments: 645-fix-findPrefixInChildren.patch Not sure, but there seem to be two issues in the example WriteLock: (1) ZNodeName is sorted according to session ID first, and then according to znode sequence number. This might cause starvation as lower session IDs always get priority. WriteLock is not thread-safe in the first place, so having session ID involved in compare operation does not seem to make sense. (2) if findPrefixInChildren finds previous ID, it should add dir in front of the ID -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
