[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-758:
Assignee: Kapil Thangavelu
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
>Assignee: Kapil Thangavelu
> Fix For: 3.3.1, 3.4.0
>
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
> ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Resolved (was: Patch Available)
Fix Version/s: 3.3.1
3.4.0
Resolution: Fixed
I just committed this. Thanks Kapil!
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
> Fix For: 3.3.1, 3.4.0
>
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
> ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Open (was: Patch Available)
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
> ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Patch Available (was: Open)
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
> ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Attachment: ZOOKEEPER-758.patch
forgot --no-prefix.
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
> ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Status: Patch Available (was: Open)
Hadoop Flags: [Reviewed]
I have reviewed this, and it looks good. Thanks Kapil!
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-758:
-
Attachment: ZOOKEEPER-758.patch
Kapil -
Thanks for the patch! Unfortunately it didn't apply cleanly against trunk
because I think you had added 'test_acl_validity' to acl_test.py which was not
included in the diff.
I'm attaching a patch that applies cleanly to trunk - no code changes from your
patch.
Thanks,
Henry
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-758) zkpython segfaults on invalid acl with missing key
[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kapil Thangavelu updated ZOOKEEPER-758:
---
Attachment: invalid-acl-fix-and-test.diff
patch for zkpython to verify acl keys in dict, and tests.
> zkpython segfaults on invalid acl with missing key
> --
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
>Reporter: Kapil Thangavelu
> Attachments: invalid-acl-fix-and-test.diff
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
