[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-21 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-769:
-

Status: Resolved  (was: Patch Available)
Resolution: Fixed

I just committed this - thanks Sergey!

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-20 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-769:
-

  Status: Patch Available  (was: Open)
Hadoop Flags: [Reviewed]

hudson? hello?

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-20 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-769:
-

Status: Open  (was: Patch Available)

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-18 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-769:
-

Status: Patch Available  (was: Open)

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-18 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-769:
-

Attachment: ZOOKEEPER-769.patch

I made a few small changes to your patch to make the logic a little easier to 
follow. Take a look and let me know if you think this is ok, otherwise I'll 
commit the patch tomorrow. Thanks!

Henry

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-18 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-769:
-

Status: Open  (was: Patch Available)

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-07 Thread Sergey Doroshenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-769:


Status: Patch Available  (was: Reopened)

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-07 Thread Sergey Doroshenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-769:


Attachment: ZOOKEEPER-769.patch

New patch, formatted with --no-prefix.

In case of inconsistency peerType is set to one from the servers list.
Added test.

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg, ZOOKEEPER-769.patch
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-07 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-769:
---

 Assignee: Sergey Doroshenko
Fix Version/s: 3.4.0
   (was: 3.3.0)

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-07 Thread Sergey Doroshenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-769:


Attachment: warning.patch

Simple patch as per my suggestion above. 
(In git format. LMK if it's not acceptable.)

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
> Fix For: 3.3.0
>
> Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-06 Thread Sergey Doroshenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-769:


Attachment: follower.log
leader.log
observer.log

Logs

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
> Fix For: 3.3.0
>
> Attachments: follower.log, leader.log, observer.log, zoo1.cfg
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-769) Leader can treat observers as quorum members

2010-05-06 Thread Sergey Doroshenko (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-769:


Attachment: zoo1.cfg

> Leader can treat observers as quorum members
> 
>
> Key: ZOOKEEPER-769
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
> Project: Zookeeper
>  Issue Type: Bug
>Affects Versions: 3.3.0
> Environment: Ubuntu Karmic x64
>Reporter: Sergey Doroshenko
> Fix For: 3.3.0
>
> Attachments: zoo1.cfg
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.