Re: Concurrent primitives library - shared lock
Thanks Lin. Thanks mahadev On 11/18/10 2:00 AM, "Lin Chia-Hung" wrote: Hi According to the mail (http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/201005.mbox/%3c4bfd646c.2040...@apache.org%3e) I create a jira (ZOOKEEPER-935) with a patch attached, containing shared lock feature. Please let me know if any issue in terms of this. Thanks, Chiahung
[jira] Updated: (ZOOKEEPER-935) Concurrent primitives library - shared lock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-935: --- Fix Version/s: 3.4.0 Assignee: ChiaHung Lin Thanks for the patch! Slating for 3.4.0. > Concurrent primitives library - shared lock > --- > > Key: ZOOKEEPER-935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-935 > Project: Zookeeper > Issue Type: Improvement > Components: recipes > Environment: Debian squeeze > JDK 1.6.x > zookeeper trunk >Reporter: ChiaHung Lin >Assignee: ChiaHung Lin >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-935.patch > > > I create this jira to add sharedock function. The function follows recipes at > http://hadoop.apache.org/zookeeper/docs/r3.1.2/recipes.html#Shared+Locks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-935) Concurrent primitives library - shared lock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933382#action_12933382 ] Hadoop QA commented on ZOOKEEPER-935: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459903/ZOOKEEPER-935.patch against trunk revision 1036071. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/35//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/35//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/35//console This message is automatically generated. > Concurrent primitives library - shared lock > --- > > Key: ZOOKEEPER-935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-935 > Project: Zookeeper > Issue Type: Improvement > Components: recipes > Environment: Debian squeeze > JDK 1.6.x > zookeeper trunk >Reporter: ChiaHung Lin >Priority: Minor > Attachments: ZOOKEEPER-935.patch > > > I create this jira to add sharedock function. The function follows recipes at > http://hadoop.apache.org/zookeeper/docs/r3.1.2/recipes.html#Shared+Locks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Concurrent primitives library - shared lock
Hi According to the mail (http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/201005.mbox/%3c4bfd646c.2040...@apache.org%3e) I create a jira (ZOOKEEPER-935) with a patch attached, containing shared lock feature. Please let me know if any issue in terms of this. Thanks, Chiahung
[jira] Updated: (ZOOKEEPER-935) Concurrent primitives library - shared lock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaHung Lin updated ZOOKEEPER-935: --- Status: Patch Available (was: Open) According to the previous discussion (http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/201005.mbox/%3c4bfd646c.2040...@apache.org%3e), the patch containing sharedlock is created for concurrent primitive library (http://wiki.apache.org/hadoop/ZooKeeper/SoC2010Ideas#Concurrent_Primitives_Library). There is an issue I would like to discuss: - sharelock source code indeed follows the way that WriteLock works, and its default lock covers the WriteLock behaviour. These seems to me can be refactor to e.g. use sharedlock only; however, I am not sure if this would semantic correct. I expect this patch may need more refinement before accepted; so I appreciate any advice and suggestion. Thanks. > Concurrent primitives library - shared lock > --- > > Key: ZOOKEEPER-935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-935 > Project: Zookeeper > Issue Type: Improvement > Components: recipes > Environment: Debian squeeze > JDK 1.6.x > zookeeper trunk >Reporter: ChiaHung Lin >Priority: Minor > Attachments: ZOOKEEPER-935.patch > > > I create this jira to add sharedock function. The function follows recipes at > http://hadoop.apache.org/zookeeper/docs/r3.1.2/recipes.html#Shared+Locks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-935) Concurrent primitives library - shared lock
[ https://issues.apache.org/jira/browse/ZOOKEEPER-935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChiaHung Lin updated ZOOKEEPER-935: --- Attachment: ZOOKEEPER-935.patch > Concurrent primitives library - shared lock > --- > > Key: ZOOKEEPER-935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-935 > Project: Zookeeper > Issue Type: Improvement > Components: recipes > Environment: Debian squeeze > JDK 1.6.x > zookeeper trunk >Reporter: ChiaHung Lin >Priority: Minor > Attachments: ZOOKEEPER-935.patch > > > I create this jira to add sharedock function. The function follows recipes at > http://hadoop.apache.org/zookeeper/docs/r3.1.2/recipes.html#Shared+Locks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-935) Concurrent primitives library - shared lock
Concurrent primitives library - shared lock --- Key: ZOOKEEPER-935 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-935 Project: Zookeeper Issue Type: Improvement Components: recipes Environment: Debian squeeze JDK 1.6.x zookeeper trunk Reporter: ChiaHung Lin Priority: Minor I create this jira to add sharedock function. The function follows recipes at http://hadoop.apache.org/zookeeper/docs/r3.1.2/recipes.html#Shared+Locks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
