Re: Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-27 Thread Vishal K
Hi Jared, I was referring to InetSocketAddress(port) (or InetSocketAddress(port, null)), which uses a wild-card IP address. If you decide to make this optional, couldn't you can use Java property to select which InetSocketAddress() constructor to use? As mentioned earlier, I agree that keeping it

Re: Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-27 Thread Jared Cantwell
Hi Vishal, Each server uses a different configuration file, so config files for different servers can be different. If you were in a situation where you would _want_ to bind to the wildcard interface, then you would need different configuration files anyway. For example Assume Server 1 has

Re: Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-27 Thread Vishal K
Hi Jared, If we keep this optional, then the servers would not need to bind to any specific interface. We will just use the current implementation (InetSocketAddress(port) with wildcard IP). You are right, keeping it optional does not buy us much. However, I did not understand your solution of usi

Re: Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-27 Thread Jared Cantwell
Thanks for the response Vishal. I agree that it should be used for both FLE and normal communication (both server ports). I believe the diff I sent incorporates that thinking, although I may not have been clear. I considered that it be optional, but cases where you would want it to bind on all i

Re: Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-27 Thread Vishal K
Hi Jared, I like the idea of allowing communication with ZK on only the IP addresses specified in the config file. This is useful when you are having a host with multiple IP address and/or when you want to have traffic isolation. In our setup, we will use this feature for traffic isolation. We hav

Proposed: Leader communication should listen on specified IP, not wildcard address

2010-08-26 Thread Jared Cantwell
Hello, My project currently has the need to specify the local address that is used for leader communication (and not use the default of listening on all interfaces). This is similar to the clientPortAddress parameter that was recently added. After reviewing the code, we can't think of a reason w