Re: Recipe contrib -- was Re: [PATCH] a simple Leader Election or exclusive Write Lock protocol/policy
It should be pretty easy to link together the various recipe's from the site/wiki and where possible share the recipe documentation across languages 2008/7/18 Benjamin Reed [EMAIL PROTECTED]: Some initial implementations of a recipe may only be in C, so it would be nice to have a standard way of finding the recipe that wasn't dependent on the language that implements the recipe. ben James Strachan wrote: 2008/7/17 Benjamin Reed [EMAIL PROTECTED]: Excellent proposal. The only thing I would add is that there should be an english description of the recipe in subversion. That way if someone wanted to do a compatible binding they can do it. If the recipe is on the wiki it would be hard to keep it in sync, so it is important that it is in subversion. My preference would be that the doc would be in the same contrib subdirectory as the source for ease of maintenance. Good idea. How about for Java recipe's we include the documentation as HTML with the javadoc so we can link to it easily and so that the recipe is kept with the code versioned nicely (so as the recipe/algorithm changes we version it with the source code etc) -- James --- http://macstrac.blogspot.com/ Open Source Integration http://open.iona.com
Re: Recipe contrib -- was Re: [PATCH] a simple Leader Election or exclusive Write Lock protocol/policy
Some initial implementations of a recipe may only be in C, so it would be nice to have a standard way of finding the recipe that wasn't dependent on the language that implements the recipe. ben James Strachan wrote: 2008/7/17 Benjamin Reed [EMAIL PROTECTED]: Excellent proposal. The only thing I would add is that there should be an english description of the recipe in subversion. That way if someone wanted to do a compatible binding they can do it. If the recipe is on the wiki it would be hard to keep it in sync, so it is important that it is in subversion. My preference would be that the doc would be in the same contrib subdirectory as the source for ease of maintenance. Good idea. How about for Java recipe's we include the documentation as HTML with the javadoc so we can link to it easily and so that the recipe is kept with the code versioned nicely (so as the recipe/algorithm changes we version it with the source code etc)
Re: Recipe contrib -- was Re: [PATCH] a simple Leader Election or exclusive Write Lock protocol/policy
I was thinking all the recipe implementations are in a single jar. zookeeper-recipes.jar otw it's going to be a pain to carry around the right jars - esp if one recipe depends on another. We saw similar issue with Pig UDF contribs (originally there were multiple jars). Patrick Doug Cutting wrote: Patrick Hunt wrote: should we have separate contrib subdirs, one for each recipe or all recipes together? What about shared code, common code for implementing a recipe? Seems a little too much to separate them all at the top level, rather than separating them in packages Do you want to package them together, in a single jar, or separately, each in their own jar? A tree per jar is standard. Doug
Re: Recipe contrib -- was Re: [PATCH] a simple Leader Election or exclusive Write Lock protocol/policy
Doug Cutting wrote: Patrick Hunt wrote: my original intent was to have it as zookeeper/trunk/src/contrib/... where this directory will have not only recipes but also other contributions. +1 That's what I meant too. And since you've said you want to package these all as a single jar, then there should just be a single tree per language, right? Yes, that's right. zookeeper/trunk/src/contrib/recipes/src/java/org/apache/zookeeper/recipes/locking/ zookeeper/trunk/src/contrib/recipes/src/c++/locking/ Right. I don't see the strong connection between releases and new features. Am I missing something? I think that the issue is implied connotation of contrib. We were thinking of contrib as interesting stuff that users might want to re-use/share but not core to zookeeper, we'll carry it around so that users know where to find it, if it gets broken and no one fixes it it won't hold up the release If I understand correctly you are saying there is no middle ground. Patrick
Re: Recipe contrib -- was Re: [PATCH] a simple Leader Election or exclusive Write Lock protocol/policy
Patrick Hunt wrote: We were thinking of contrib as interesting stuff that users might want to re-use/share but not core to zookeeper, we'll carry it around so that users know where to find it, if it gets broken and no one fixes it it won't hold up the release That's a fine policy for contrib, roughly what Lucene, Hadoop etc. have. The QA, documentation, etc. requirements for contrib are frequently lower. The IP requirements however are equal, since Apache's distributing the code. Doug