What happens to a follower if leader hangs?

2010-11-10 Thread Vishal Kher
Hi, In Follower.followLeader() after syncing with the leader, the follower does: while (self.isRunning()) { readPacket(qp); processPacket(qp); } It looks like it relies on socket timeout expiry to figure out if the

Re: What happens to a follower if leader hangs?

2010-11-10 Thread Mahadev Konar
Hi Vishal, There are periodic pings sent from the leader to the followers. Take a look at Leader.java: syncedSet.add(self.getId()); synchronized (learners) { for (LearnerHandler f : learners) { if (f.synced()) {

Re: What happens to a follower if leader hangs?

2010-11-10 Thread Vishal Kher
Yes, thats what I was planning to do. At the follower, start FLE if the follower does not receive a ping for (syncLimit * tickTime). On Wed, Nov 10, 2010 at 2:48 PM, Mahadev Konar maha...@yahoo-inc.comwrote: Hi Vishal, There are periodic pings sent from the leader to the followers. Take a

Re: What happens to a follower if leader hangs?

2010-11-10 Thread Patrick Hunt
I'd go 3.3.3 and 3.4.0. Any of this (incl the other issues Vishal/others have been finding recently) point to some particular set of testing we might add to find problems like this? What are we missing? Once 3.3.2 is out and immediate tlp issues are addressed I'm going to start pushing for 3.4

Re: What happens to a follower if leader hangs?

2010-11-10 Thread Benjamin Reed
have you been able to make this happen? the behavior you are suggesting is exactly what should be happening. When we sync with the leader we set the socket timeout: sock.setSoTimeout(self.tickTime * self.syncLimit); if the leader hangs, we should get a timeout and disconnect from the leader.