build.xml from 3.3.1 distribution has version=3.3.2-dev

2010-09-17 Thread Dave Wright
Ended up chasing our tail for a while today because the ant build.xml
in the 3.3.1 distribution on the website has version is actually
3.3.2-dev. Any particular reason for that? The jar included in the
distribution is obviously labeled correctly, and the version number in
its manifest is 3.3.1, so it appears that the build.xml was modified
and bundled up for distribution after the binary was built. Not sure
if it's worth fixing in the distribution, but thought I'd at least
mention it.

-Dave Wright


Re: build.xml from 3.3.1 distribution has version=3.3.2-dev

2010-09-17 Thread Patrick Hunt
Hi Dave, while it may appear that way, it's not the case. When building a
release we run the following command:

ant -Dversion=3.3.1 ...

which overrides any setting in build.xml. This is documented in our release
process (we pretty much follow what hadoop does, although some of the maven
repo details are a bit different)
http://wiki.apache.org/hadoop/ZooKeeper/HowToRelease

Patrick

On Fri, Sep 17, 2010 at 8:55 AM, Dave Wright wrig...@gmail.com wrote:

 Ended up chasing our tail for a while today because the ant build.xml
 in the 3.3.1 distribution on the website has version is actually
 3.3.2-dev. Any particular reason for that? The jar included in the
 distribution is obviously labeled correctly, and the version number in
 its manifest is 3.3.1, so it appears that the build.xml was modified
 and bundled up for distribution after the binary was built. Not sure
 if it's worth fixing in the distribution, but thought I'd at least
 mention it.

 -Dave Wright